rjmccall accepted this revision.
rjmccall added a comment.
This revision is now accepted and ready to land.
I wonder if that was originally just an oversight that got turned into official
policy. Anyway, if it's the policy, it's what we have to do; LGTM.
Have you checked whether we do the right
NoQ added inline comments.
Comment at: lib/StaticAnalyzer/Core/RangeConstraintManager.cpp:265-276
+ const llvm::APSInt &from = i->From(), &to = i->To();
+ const llvm::APSInt &newFrom = (to.isMinSignedValue() ?
+ BV.getMaxValue(to) :
+
As the title says,thanks.___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
NoQ added a comment.
LGTM! Minor nitpicking in comments.
Currently there's no such problem, but as `GetRange` becomes more complicated,
we'll really miss the possibility of saying something like "if there's a range
for negated symbol, `return GetRange(the negated symbol)`", so that all other
s
This revision was not accepted when it landed; it landed in state "Needs
Review".
This revision was automatically updated to reflect the committed changes.
Closed by commit rL331098: [ItaniumMangle] Undeduced auto type shouldn't
be substitutable. (authored by epilk, committed by ).
Herald added a
This revision was not accepted when it landed; it landed in state "Needs
Review".
This revision was automatically updated to reflect the committed changes.
Closed by commit rC331098: [ItaniumMangle] Undeduced auto type shouldn't
be substitutable. (authored by epilk, committed by ).
Changed prior
Author: epilk
Date: Fri Apr 27 19:40:28 2018
New Revision: 331098
URL: http://llvm.org/viewvc/llvm-project?rev=331098&view=rev
Log:
[ItaniumMangle] Undeduced auto type shouldn't be substitutable.
We still support the old mangling if we're trying to be ABI-compatible with
Clang 6.0, though.
Diffe
NoQ created this revision.
NoQ added reviewers: dcoughlin, xazax.hun, a.sidorin, george.karpenkov, szepet.
Herald added subscribers: cfe-commits, rnkovacs, baloghadamsoftware.
In the provided test case the expression `(int *&)*(int *)p` is evaluated as
follows:
1. Take an lvalue `p` of type `cha
Hello everyone,
Below are some buildbot numbers for the last week of 4/15/2018 - 4/21/2018.
Please see the same data in attached csv files:
The longest time each builder was red during the week;
"Status change ratio" by active builder (percent of builds that changed the
builder status from greed
Hello everyone,
Below are some buildbot numbers for the week of 4/8/2018 - 4/14/2018.
Please see the same data in attached csv files:
The longest time each builder was red during the week;
"Status change ratio" by active builder (percent of builds that changed the
builder status from greed to re
On Fri, Apr 27, 2018 at 5:13 PM Richard Smith wrote:
> On 27 April 2018 at 17:09, Chandler Carruth via cfe-commits <
> cfe-commits@lists.llvm.org> wrote:
>
>> On Fri, Apr 27, 2018 at 4:36 PM Richard Smith via cfe-commits <
>> cfe-commits@lists.llvm.org> wrote:
>>
>>> On 27 April 2018 at 16:07, Sa
rsmith added inline comments.
Comment at: test/Analysis/asm.cpp:9
+ ref = 1;
+ __asm__("" : "=r"((int)global)); // don't crash on rvalue output operand
+ clang_analyzer_eval(global == 1); // expected-warning{{UNKNOWN}}
Ugh, do we really need to support this n
rsmith added a comment.
In https://reviews.llvm.org/D46190#1081773, @rsmith wrote:
> No, absolutely not. This would be insanely expensive, and marks entirely
> unrelated things "used".
My apologies, reading this again it comes off a lot harsher than I'd intended.
Repository:
rC Clang
http
On 27 April 2018 at 17:09, Chandler Carruth via cfe-commits <
cfe-commits@lists.llvm.org> wrote:
> On Fri, Apr 27, 2018 at 4:36 PM Richard Smith via cfe-commits <
> cfe-commits@lists.llvm.org> wrote:
>
>> On 27 April 2018 at 16:07, Sanjay Patel via cfe-commits <
>> cfe-commits@lists.llvm.org> wrot
On Fri, Apr 27, 2018 at 4:36 PM Richard Smith via cfe-commits <
cfe-commits@lists.llvm.org> wrote:
> On 27 April 2018 at 16:07, Sanjay Patel via cfe-commits <
> cfe-commits@lists.llvm.org> wrote:
>
>> Missing dash corrected at r331057. I can improve the doc wording, but
>> let's settle on the flag
NoQ accepted this revision.
NoQ added a comment.
This revision is now accepted and ready to land.
Looks great, thanks!
I think the overall plan for any taint work would be to remove it from the
program state API and move getters/setters into its own translation unit (like
dynamic type propagati
NoQ accepted this revision.
NoQ added a subscriber: rsmith.
NoQ added a comment.
Woohoo LGTM.
Heads up to @rsmith because we're about to break the CFG again, and also yay
we've found another use case for rewriting AST in our CFG.
Repository:
rC Clang
https://reviews.llvm.org/D45416
_
NoQ added inline comments.
Comment at: lib/StaticAnalyzer/Checkers/CStringChecker.cpp:106
+bool isAppending,
+bool canOverlap = false) const;
The fact that the regular `strcpy`/`strcat` isn't checked for overlaps
rsmith added inline comments.
Comment at: lib/AST/DeclBase.cpp:285
+Decl::ModuleOwnershipKind Decl::getModuleOwnershipKindForChildOf(DeclContext
*DC) {
+ // Ignore namespaces because they're visible by default.
+ while (DC && DC->isNamespace())
"because they'r
Author: dergachev
Date: Fri Apr 27 16:50:55 2018
New Revision: 331096
URL: http://llvm.org/viewvc/llvm-project?rev=331096&view=rev
Log:
[analyzer] CStringChecker: Add support for BSD strlcpy() and strlcat().
Patch by David Carlier!
Differential Revision: https://reviews.llvm.org/D45177
Modified
This revision was automatically updated to reflect the committed changes.
Closed by commit rC331096: [analyzer] CStringChecker: Add support for BSD
strlcpy() and strlcat(). (authored by dergachev, committed by ).
Changed prior to commit:
https://reviews.llvm.org/D45177?vs=140667&id=144421#toc
rsmith added inline comments.
Comment at: include/clang/AST/DeclBase.h:2055-2075
+template<>
+struct GraphTraits {
+ using NodeRef = const ::clang::Decl *;
+ using ChildIteratorType = ::clang::DeclContext::decl_iterator;
+
+ static NodeRef getEntryNode(const ::clang::DeclConte
rsmith added inline comments.
Comment at: lib/Sema/SemaDecl.cpp:16135
+for (Module *ImportedModule : Mod->Imports)
+ VisibleModules.setVisible(ImportedModule, ModuleLoc);
+ }
For completeness, you should also call
`getModuleLoader().makeModuleVisible(M
On 27 April 2018 at 16:07, Sanjay Patel via cfe-commits <
cfe-commits@lists.llvm.org> wrote:
> Missing dash corrected at r331057. I can improve the doc wording, but
> let's settle on the flag name first, and I'll try to get it all fixed up in
> one shot.
>
> So far we have these candidates:
> 1. -
tra updated this revision to Diff 144419.
tra added a subscriber: arsenm.
tra added a comment.
Do not use subtarget feature to control codegen of short pointers.
Instead we need to add a field to TargetOptions which is the only way to pass
this info to NVPTXTargetInfo constructor where we calcula
rsmith accepted this revision.
rsmith added inline comments.
This revision is now accepted and ready to land.
Comment at: lib/Serialization/ASTReaderDecl.cpp:2568-2570
// ODR-based merging is only performed in C++. In C, identically-named things
// in different translation
rsmith accepted this revision.
rsmith added a comment.
This revision is now accepted and ready to land.
This looks right to me.
Repository:
rCXXA libc++abi
https://reviews.llvm.org/D46056
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
ht
Missing dash corrected at r331057. I can improve the doc wording, but let's
settle on the flag name first, and I'll try to get it all fixed up in one
shot.
So far we have these candidates:
1. -ffp-cast-overflow-workaround
2. -fstrict-fp-trunc-semantics
3. -fstrict-fp-cast-overflow
I don't have a
rsmith requested changes to this revision.
rsmith added a comment.
This revision now requires changes to proceed.
No, absolutely not. This would be insanely expensive, and marks entirely
unrelated things "used".
The right thing to do here is to consistently track both the named declaration
(the
rsmith updated this revision to Diff 144415.
rsmith added a comment.
Added release notes.
Repository:
rC Clang
https://reviews.llvm.org/D46218
Files:
docs/ReleaseNotes.rst
lib/AST/RecordLayoutBuilder.cpp
test/CodeGenCXX/alignment.cpp
test/SemaCXX/class-layout.cpp
Index: test/SemaCXX
rsmith created this revision.
rsmith added a reviewer: rjmccall.
Clang incorrectly applies the packed attribute to base classes. Per GCC's
documentation and as can be observed from its behavior, packed only applies to
members, not base classes.
This change is conditioned behind `-fclang-abi-com
On 27 April 2018 at 09:21, Sanjay Patel via cfe-commits <
cfe-commits@lists.llvm.org> wrote:
> Author: spatel
> Date: Fri Apr 27 09:21:22 2018
> New Revision: 331056
>
> URL: http://llvm.org/viewvc/llvm-project?rev=331056&view=rev
> Log:
> [docs] add -ffp-cast-overflow-workaround to the release no
Author: rnk
Date: Fri Apr 27 15:32:21 2018
New Revision: 331093
URL: http://llvm.org/viewvc/llvm-project?rev=331093&view=rev
Log:
Fix diag-format test to not care about what cl.exe is on path
Modified:
cfe/trunk/test/Misc/diag-format.c
Modified: cfe/trunk/test/Misc/diag-format.c
URL:
http:/
Author: dergachev
Date: Fri Apr 27 15:00:51 2018
New Revision: 331089
URL: http://llvm.org/viewvc/llvm-project?rev=331089&view=rev
Log:
[analyzer] ObjCAutoreleaseWrite: Support a few more APIs and fix warning text.
API list and improved warning text composed by Devin Coughlin.
Modified:
cfe/
pfultz2 added a comment.
> Am i understanding correctly that the new -enable-alpha-checks flag doesn't
> enable alpha checks, but it only allows enabling them with a separate command?
Yes, it enables them to be selected by clang tidy.
Repository:
rCTE Clang Tools Extra
https://reviews.llvm.
pfultz2 added a comment.
> I'm curious about the use case for this, since I don't think it ever makes
> sense to run all the alpha checks at once. These checks are typically a work
> in progress (they're not finished yet) and often have false positives that
> haven't been fixed yet.
We want to
bkramer accepted this revision.
bkramer added a comment.
This revision is now accepted and ready to land.
lgtm
https://reviews.llvm.org/D46148
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe
Author: nico
Date: Fri Apr 27 13:29:57 2018
New Revision: 331077
URL: http://llvm.org/viewvc/llvm-project?rev=331077&view=rev
Log:
Revert r329698 (and r329702).
Speculative. ClangMoveTests started failing on
http://lab.llvm.org:8011/builders/clang-x64-ninja-win7/builds/9958
after this change. I c
lebedev.ri added a comment.
In https://reviews.llvm.org/D46159#1081559, @NoQ wrote:
> Am i understanding correctly that the new `-enable-alpha-checks` flag doesn't
> enable alpha checks, but it only allows enabling them with a separate command?
Yes, absolutely! Same with my followup https://re
NoQ added a comment.
Am i understanding correctly that the new `-enable-alpha-checks` flag doesn't
enable alpha checks, but it only allows enabling them with a separate command?
Also wanted to mention that developers who are interested in running analyzer
alpha checkers over a compilation datab
benhamilton created this revision.
benhamilton added reviewers: Wizard, hokein.
Herald added subscribers: cfe-commits, xazax.hun, klimek.
This adds a few common Apple first-party API prefixes as acronyms to
`objc-property-declaration`.
Here's a list showing where these come from:
http://nshipste
Author: nico
Date: Fri Apr 27 12:11:14 2018
New Revision: 331069
URL: http://llvm.org/viewvc/llvm-project?rev=331069&view=rev
Log:
s/LLVM_ON_WIN32/_WIN32/, clang
LLVM_ON_WIN32 is set exactly with MSVC and MinGW (but not Cygwin) in
HandleLLVMOptions.cmake, which is where _WIN32 defined too. Just
benhamilton added inline comments.
Comment at: clang-tools-extra/trunk/clangd/SourceCode.cpp:38
+// 0xxx is ASCII, handled above. 10xxx is a trailing byte, invalid here.
+// 1xxx is not valid UTF-8 at all. Assert because it's probably our
bug.
+assert((UTF8Length
NoQ added inline comments.
Comment at: clang-tidy/ClangTidy.cpp:373-376
// FIXME: Remove this option once clang's cfg-temporary-dtors option defaults
// to true.
AnalyzerOptions->Config["cfg-temporary-dtors"] =
Context.getOptions().AnalyzeTemporaryDtors ? "true" :
This revision was automatically updated to reflect the committed changes.
Closed by commit rC331067: [clang-format/ObjC] Use getIdentifierInfo() instead
of tok::identifier (authored by benhamilton, committed by ).
Changed prior to commit:
https://reviews.llvm.org/D46143?vs=144357&id=144377#toc
Author: benhamilton
Date: Fri Apr 27 11:51:12 2018
New Revision: 331067
URL: http://llvm.org/viewvc/llvm-project?rev=331067&view=rev
Log:
[clang-format/ObjC] Use getIdentifierInfo() instead of tok::identifier
Summary:
Previously, we checked tokens for `tok::identifier` to see if they
were identif
a.sidorin added a comment.
Hi Henry. I had a quick look at the patch, here are some remarks.
Comment at: lib/StaticAnalyzer/Checkers/CStringChecker.cpp:2092
+ // 'invalidateRegions()', which will remove the pair
+ // in CStringLength map. So calls 'InvalidateBuffer()
zinovy.nis added a comment.
Aaron, any comments for the new revision?
https://reviews.llvm.org/D45932
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
vsapsai added a comment.
It is agreed that it is untenable to support reentrancy for `std::function`
assignment operators and I'm not trying to achieve that. Here we restrict
reentrancy only to `std::function::operator=(nullptr_t)`.
@mclow.lists where should the tests go if the standard specifi
lebedev.ri added a comment.
In https://reviews.llvm.org/D46159#1081392, @dcoughlin wrote:
> In https://reviews.llvm.org/D46159#1081371, @lebedev.ri wrote:
>
> > Note that it is completely off by default, and is not listed in
> > documentation, `clang-tidy --help`,
> > so one would have to know
dcoughlin added a comment.
In https://reviews.llvm.org/D46159#1081371, @lebedev.ri wrote:
> Note that it is completely off by default, and is not listed in
> documentation, `clang-tidy --help`,
> so one would have to know of the existence of that hidden flag first, and
> only then when that fl
Author: bruno
Date: Fri Apr 27 11:01:23 2018
New Revision: 331063
URL: http://llvm.org/viewvc/llvm-project?rev=331063&view=rev
Log:
[Modules][ObjC] ASTReader should add protocols for class extensions
During deserialization clang is currently missing the merging of
protocols into the canonical int
lebedev.ri added a comment.
In https://reviews.llvm.org/D46159#1081366, @dcoughlin wrote:
> ...
Note that it is completely off by default, and is not listed in documentation,
`clang-tidy --help`,
so one would have to know of the existence of that hidden flag first, and only
then when that fla
dcoughlin added a comment.
I'm curious about the use case for this, since I don't think it ever makes
sense to run all the alpha checks at once. These checks are typically a work in
progress (they're not finished yet) and often have false positives that haven't
been fixed yet. Often they don't
Nit: The comment just repeats what the line below it says.
Does this have an observable effect? If so, should this have a test?
On Fri, Apr 27, 2018 at 12:11 PM, Nirav Dave via cfe-commits <
cfe-commits@lists.llvm.org> wrote:
> Author: niravd
> Date: Fri Apr 27 09:11:24 2018
> New Revision: 3310
rkirsling added a comment.
Guidelines page has been updated (https://trac.webkit.org/changeset/231085),
though it may take a bit for the website to update.
Repository:
rC Clang
https://reviews.llvm.org/D46024
___
cfe-commits mailing list
cfe-com
djasper accepted this revision.
djasper added a comment.
This revision is now accepted and ready to land.
Looks good, thank you.
Repository:
rC Clang
https://reviews.llvm.org/D46143
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://l
russellmcc marked an inline comment as not done.
russellmcc added a comment.
Okay; I think I've responded to all feedback at this point. Thanks for your
patience guiding me through my first contribution to this project. Let me know
what else I can do to help get this merged!
https://reviews.
spatel added a comment.
In https://reviews.llvm.org/D46135#1081193, @lebedev.ri wrote:
> (Not everyone is always using trunk snapshots)
> I'd guess it would be present for at least one release, so **I** would
> expect to see that in both the clang and llvm release notes.
Thanks - sounds right
Author: spatel
Date: Fri Apr 27 09:24:39 2018
New Revision: 331057
URL: http://llvm.org/viewvc/llvm-project?rev=331057&view=rev
Log:
[docs] more dashes
Modified:
cfe/trunk/docs/ReleaseNotes.rst
Modified: cfe/trunk/docs/ReleaseNotes.rst
URL:
http://llvm.org/viewvc/llvm-project/cfe/trunk/docs
Author: spatel
Date: Fri Apr 27 09:21:22 2018
New Revision: 331056
URL: http://llvm.org/viewvc/llvm-project?rev=331056&view=rev
Log:
[docs] add -ffp-cast-overflow-workaround to the release notes
This option was added with:
D46135
rL331041
...copying the text from UsersManual.rst for more exposure
Author: niravd
Date: Fri Apr 27 09:16:06 2018
New Revision: 331055
URL: http://llvm.org/viewvc/llvm-project?rev=331055&view=rev
Log:
[MC] Undo spurious commit added into r331052.
Modified:
cfe/trunk/tools/driver/cc1as_main.cpp
Modified: cfe/trunk/tools/driver/cc1as_main.cpp
URL:
http://llvm
Author: stuart.brady
Date: Fri Apr 27 09:11:56 2018
New Revision: 331053
URL: http://llvm.org/viewvc/llvm-project?rev=331053&view=rev
Log:
Test commit removing trailing whitespace
Modified:
cfe/trunk/lib/Sema/SemaDecl.cpp
Modified: cfe/trunk/lib/Sema/SemaDecl.cpp
URL:
http://llvm.org/viewvc
Author: niravd
Date: Fri Apr 27 09:11:24 2018
New Revision: 331052
URL: http://llvm.org/viewvc/llvm-project?rev=331052&view=rev
Log:
[MC] Provide default value for IsResolved.
Modified:
cfe/trunk/tools/driver/cc1as_main.cpp
Modified: cfe/trunk/tools/driver/cc1as_main.cpp
URL:
http://llvm.or
a.sidorin added a comment.
Hi all. I'm already here, invited by the Herald - just had no time to take a
look (will change the script to add me as a reviewer). But thank you anyway! :)
In the initial implementation
(https://raw.githubusercontent.com/haoNoQ/clang/summary-ipa-draft/lib/AST/ASTImpo
compnerd accepted this revision.
compnerd added a comment.
This revision is now accepted and ready to land.
Do you have commit access or do you need someone to commit this on your behalf?
Repository:
rC Clang
https://reviews.llvm.org/D45814
___
c
yaxunl added a comment.
Can you add a codegen test for 1.2, 2.0?
Also, I am wondering whether this is valid for OpenCL C++. Do we need special
handling for string literal?
Comment at: lib/AST/Expr.cpp:870
+ if (C.getLangOpts().OpenCL && Ty.getAddressSpace() == LangAS::Defaul
lebedev.ri added a comment.
In https://reviews.llvm.org/D46135#1081165, @spatel wrote:
> Should I add a bullet for this new flag/attribute to the clang release notes,
> the LLVM release, both? Or do we view this as temporary and not making it to
> the release?
(Not everyone is always using tr
benhamilton updated this revision to Diff 144357.
benhamilton added a comment.
Add helper canBeObjCSelectorComponent() with comments.
Repository:
rC Clang
https://reviews.llvm.org/D46143
Files:
lib/Format/TokenAnnotator.cpp
unittests/Format/FormatTestObjC.cpp
Index: unittests/Format/Fo
Author: niravd
Date: Fri Apr 27 08:45:54 2018
New Revision: 331048
URL: http://llvm.org/viewvc/llvm-project?rev=331048&view=rev
Log:
[MC] Modify MCAsmStreamer to always build MCAssembler. NFCI.
Modified:
cfe/trunk/tools/driver/cc1as_main.cpp
Modified: cfe/trunk/tools/driver/cc1as_main.cpp
UR
spatel added a comment.
Should I add a bullet for this new flag/attribute to the clang release notes,
the LLVM release, both? Or do we view this as temporary and not making it to
the release?
Repository:
rC Clang
https://reviews.llvm.org/D46135
___
lebedev.ri accepted this revision.
lebedev.ri added a comment.
This revision is now accepted and ready to land.
So i suspect the history here is: https://reviews.llvm.org/D26310 added a way
to filter-out these clang analyzer checks,
which removed these checks from being available in clang-tidy, b
abeserminji updated this revision to Diff 144344.
abeserminji marked 2 inline comments as done.
abeserminji added a comment.
Comments resolved.
https://reviews.llvm.org/D44684
Files:
include/clang/Basic/DiagnosticDriverKinds.td
lib/Driver/ToolChains/Arch/Mips.cpp
lib/Driver/ToolChains/Com
abeserminji added inline comments.
Comment at: include/clang/Basic/DiagnosticDriverKinds.td:340
+ "ignoring '%0' option as it cannot be used with "
+ "explicit use of -mabicalls and the N64 ABI">,
InGroup;
sdardis wrote:
> Use the %select{optionA|optionB|..|
CarlosAlbertoEnciso added a comment.
Note:
The patch includes the entry points to set Objective-C and OpenMP declarations,
but I do not
know anything about Objective-C or OpenMP. The functions just return without
updating any
extra 'Used' bit.
Any suggestion on how to deal with those functions
CarlosAlbertoEnciso created this revision.
CarlosAlbertoEnciso added reviewers: rsmith, erichkeane, probinson, dblaikie.
CarlosAlbertoEnciso added a project: clang.
Herald added a subscriber: aprantl.
The following submission under review
https://reviews.llvm.org/D44826
introduced an option to w
Anastasia added inline comments.
Comment at: lib/AST/Expr.cpp:870
+ if (C.getLangOpts().OpenCL && Ty.getAddressSpace() == LangAS::Default)
+Ty = C.getAddrSpaceQualType(Ty, LangAS::opencl_constant);
+
Anastasia wrote:
> bader wrote:
> > Anastasia wrote:
> > >
nik added a comment.
Trying to format the diff in the previous comment:
--- a/lib/Parse/ParseCXXInlineMethods.cpp
+++ b/lib/Parse/ParseCXXInlineMethods.cpp
@@ -102,9 +102,14 @@ NamedDecl
*Parser::ParseCXXInlineMethodDef(AccessSpecifier AS,
}
if (SkipFunctionBodies != SkipFunc
nik added a comment.
OK, to skip all function bodies in the preamble except for template functions
and functions within a template class, I've amended the previous diff with:
- a/lib/Parse/ParseCXXInlineMethods.cpp +++
b/lib/Parse/ParseCXXInlineMethods.cpp @@ -102,9 +102,14 @@ NamedDecl
*Parse
This revision was automatically updated to reflect the committed changes.
Closed by commit rC331041: [Driver, CodeGen] add options to enable/disable an
FP cast optimization (authored by spatel, committed by ).
Changed prior to commit:
https://reviews.llvm.org/D46135?vs=144226&id=144342#toc
Rep
Author: spatel
Date: Fri Apr 27 07:22:48 2018
New Revision: 331041
URL: http://llvm.org/viewvc/llvm-project?rev=331041&view=rev
Log:
[Driver, CodeGen] add options to enable/disable an FP cast optimization
As discussed in the post-commit thread for:
rL330437 (
http://lists.llvm.org/pipermail/llvm
Anastasia added inline comments.
Comment at: lib/AST/Expr.cpp:870
+ if (C.getLangOpts().OpenCL && Ty.getAddressSpace() == LangAS::Default)
+Ty = C.getAddrSpaceQualType(Ty, LangAS::opencl_constant);
+
bader wrote:
> Anastasia wrote:
> > bader wrote:
> > > As
nik added inline comments.
Comment at: lib/Parse/ParseCXXInlineMethods.cpp:104
- if (SkipFunctionBodies && (!FnD || Actions.canSkipFunctionBody(FnD)) &&
- trySkippingFunctionBody()) {
+ if (SkipFunctionBodies != SkipFunctionBodiesKind::None &&
+ (!FnD || Actions.can
This revision was automatically updated to reflect the committed changes.
Closed by commit rC331039: [ARM,AArch64] Add intrinsics for dot product
instructions (authored by olista01, committed by ).
Changed prior to commit:
https://reviews.llvm.org/D46109?vs=144081&id=144341#toc
Repository:
r
Author: olista01
Date: Fri Apr 27 07:03:32 2018
New Revision: 331039
URL: http://llvm.org/viewvc/llvm-project?rev=331039&view=rev
Log:
[ARM,AArch64] Add intrinsics for dot product instructions
The ACLE spec which describes these intrinsics hasn't been published yet, but
this is based on the final
olista01 marked an inline comment as done.
olista01 added inline comments.
Comment at: test/CodeGen/arm-neon-dot-product.c:1
+// RUN: %clang_cc1 -triple armv8-linux-gnueabihf -target-cpu cortex-a57
-target-feature +dotprod \
+// RUN: -disable-O0-optnone -emit-llvm -o - %s | opt
Author: olista01
Date: Fri Apr 27 06:56:02 2018
New Revision: 331038
URL: http://llvm.org/viewvc/llvm-project?rev=331038&view=rev
Log:
[ARM] Add __ARM_FEATURE_DOTPROD pre-defined macro
This adds a pre-defined macro to test if the compiler has support for the
v8.2-A dot rpoduct intrinsics in AArch
This revision was automatically updated to reflect the committed changes.
Closed by commit rC331038: [ARM] Add __ARM_FEATURE_DOTPROD pre-defined macro
(authored by olista01, committed by ).
Changed prior to commit:
https://reviews.llvm.org/D46108?vs=144080&id=144339#toc
Repository:
rC Clang
boga95 updated this revision to Diff 144336.
https://reviews.llvm.org/D44143
Files:
clang-tidy/cert/CERTTidyModule.cpp
clang-tidy/cert/CMakeLists.txt
clang-tidy/cert/ProperlySeededRandomGeneratorCheck.cpp
clang-tidy/cert/ProperlySeededRandomGeneratorCheck.h
docs/ReleaseNotes.rst
docs/
lebedev.ri created this revision.
lebedev.ri added reviewers: alexfh, aaron.ballman, hokein.
Herald added a subscriber: xazax.hun.
After https://reviews.llvm.org/D46159 was created by @pfultz2, and i initially
thought it was already possible, i had the need to view the call graph.
I have almost w
lebedev.ri created this revision.
lebedev.ri added reviewers: dcoughlin, alexfh, aaron.ballman, george.karpenkov,
NoQ.
Herald added subscribers: a.sidorin, szepet, xazax.hun.
I would like to be able to trigger these debug checkers from clang-tidy, as a
follow-up patch for https://reviews.llvm.or
baloghadamsoftware updated this revision to Diff 144330.
baloghadamsoftware added a comment.
Herald added a reviewer: george.karpenkov.
Rebased to Part6. Also fixed a test failing now: it is not enough to mark the
symbolic expressions as live, but if it is a SymIntExpr (it can be nothing
else, e
bader added inline comments.
Comment at: lib/AST/Expr.cpp:870
+ if (C.getLangOpts().OpenCL && Ty.getAddressSpace() == LangAS::Default)
+Ty = C.getAddrSpaceQualType(Ty, LangAS::opencl_constant);
+
Anastasia wrote:
> bader wrote:
> > As `Ty` is passed by value
lebedev.ri added a comment.
In https://reviews.llvm.org/D46159#1080939, @lebedev.ri wrote:
> Oh, hm.
> I just needed something to view the call graph.
> I have almost wrote a clang-tidy check using `analysis/CallGraph.h`, but
> then i noticed/remembered that clang static analyzer has that alre
chrib added a comment.
Hi Saleem,
Thanks for your review. I have amended the patch to avoid checking the name on
the common path.
About your second comment, I'm not sure we have to fix -print-file-name= for an
equivalent problem since in case of empty parameter, we do a concatenation with
the
chrib updated this revision to Diff 144322.
chrib added a comment.
Move the non-null name check out of GetProgramPath and add a test case.
Assume that we trust the callers to check for non null ProgramName.
Repository:
rC Clang
https://reviews.llvm.org/D45814
Files:
lib/Driver/Driver.cpp
ilya-biryukov added a comment.
the patch LG and fixes the problem of llvm namespace not showing up in
completions from the static index.
Let's add some tests and ship it!
Repository:
rCTE Clang Tools Extra
https://reviews.llvm.org/D46183
___
cfe
lebedev.ri added a comment.
Oh, hm.
I just needed something to view the call graph.
I have almost wrote a clang-tidy check using `analysis/CallGraph.h`, but then i
noticed/remembered that clang static analyzer has that already.
But `$ clang-tidy -checks=* -list-checks | grep -i analyzer | grep -i
ioeric marked 7 inline comments as done.
ioeric added a comment.
Thanks for reviewing this!
In https://reviews.llvm.org/D46180#1080822, @ilya-biryukov wrote:
> This change LG as an extraction of the helper functionality to be reused in
> clang, clang-tidy, etc.
> However, I feel there are pote
ioeric updated this revision to Diff 144319.
ioeric marked 2 inline comments as done.
ioeric added a comment.
Addressed review comments.
Repository:
rC Clang
https://reviews.llvm.org/D46180
Files:
lib/Format/Format.cpp
unittests/Format/CleanupTest.cpp
Index: unittests/Format/CleanupTest
1 - 100 of 123 matches
Mail list logo
