olista01 marked an inline comment as done. olista01 added inline comments.
================ Comment at: test/CodeGen/arm-neon-dot-product.c:1 +// RUN: %clang_cc1 -triple armv8-linux-gnueabihf -target-cpu cortex-a57 -target-feature +dotprod \ +// RUN: -disable-O0-optnone -emit-llvm -o - %s | opt -S -instcombine | FileCheck %s ---------------- efriedma wrote: > flyingforyou wrote: > > efriedma wrote: > > > flyingforyou wrote: > > > > I think proper target is cortex-a55 or cortex-a75. > > > > Do we need check routines for wrong target-cpu? > > > This is working as intended, I think: target-feature overrides target-cpu. > > dotprod is ARMv8.2's addition feature not ARMv8. Cortex-a57 only supports > > ARMv8 which couldn't have dotprod feature. Am I missing something? > Oh, sorry, misunderstood the question; yes, this might not be the most clear > "CHECK" line. I've changed this to cortex-a75 for clarity. Repository: rL LLVM https://reviews.llvm.org/D46109 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
