rsmith accepted this revision.
rsmith added inline comments.
This revision is now accepted and ready to land.


================
Comment at: lib/Serialization/ASTReaderDecl.cpp:2568-2570
   // ODR-based merging is only performed in C++. In C, identically-named things
   // in different translation units are not redeclarations (but may still have
+  // compatible types). However, clang is able to merge tag types with ODR-like
----------------
I think this comment would benefit from more rewriting, since we've basically 
decided that we do want to apply the ODR merging rule to C.


Repository:
  rC Clang

https://reviews.llvm.org/D46165



_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
  • [PATCH] D46165: [... Bruno Cardoso Lopes via Phabricator via cfe-commits
    • [PATCH] D461... Richard Smith - zygoloid via Phabricator via cfe-commits
    • [PATCH] D461... Bruno Cardoso Lopes via Phabricator via cfe-commits
    • [PATCH] D461... Bruno Cardoso Lopes via Phabricator via cfe-commits

Reply via email to