[PATCH] D43764: [clang-apply-replacements] Convert tooling::Replacements to tooling::AtomicChange for conflict resolving of changes, code cleanup, and code formatting.

jdemeule updated this revision to Diff 139889. jdemeule added a comment. Update after review (cleanup and improve comments). https://reviews.llvm.org/D43764 Files: clang-apply-replacements/include/clang-apply-replacements/Tooling/ApplyReplacements.h clang-apply-replacements/lib/Tooling/App

[PATCH] D44865: [libc++] Implement P0608R1 - A sane variant converting constructor

lichray added inline comments. Comment at: include/variant:1109 +#define _LIBCPP_VARIANT_BOOLEAN_CONVERSION(bool_type)\ +template\ EricWF wrote: > lichray wrote: > > EricWF wrote: > > > lichray

[PATCH] D44865: [libc++] Implement P0608R1 - A sane variant converting constructor

EricWF added inline comments. Comment at: include/variant:1109 +#define _LIBCPP_VARIANT_BOOLEAN_CONVERSION(bool_type)\ +template\ lichray wrote: > EricWF wrote: > > lichray wrote: > > > EricWF

r328607 - [coroutines] Fix unused warning on result of co_yield.

Author: ericwf Date: Mon Mar 26 20:33:06 2018 New Revision: 328607 URL: http://llvm.org/viewvc/llvm-project?rev=328607&view=rev Log: [coroutines] Fix unused warning on result of co_yield. This patch follows up on r328602, which fixed the spurious unused result warning for `co_await`. Modified:

[PATCH] D44913: [ObjC] Enable using C++ triviality type traits for non-trivial C structs

rjmccall accepted this revision. rjmccall added a comment. This revision is now accepted and ready to land. LGTM. Repository: rC Clang https://reviews.llvm.org/D44913 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/c

[PATCH] D44865: [libc++] Implement P0608R1 - A sane variant converting constructor

EricWF added inline comments. Comment at: include/variant:1109 +#define _LIBCPP_VARIANT_BOOLEAN_CONVERSION(bool_type)\ +template\ lichray wrote: > EricWF wrote: > > EricWF wrote: > > > I would

[PATCH] D44865: [libc++] Implement P0608R1 - A sane variant converting constructor

lichray added inline comments. Comment at: include/variant:1109 +#define _LIBCPP_VARIANT_BOOLEAN_CONVERSION(bool_type)\ +template\ lichray wrote: > EricWF wrote: > > EricWF wrote: > > > I would

[PATCH] D44865: [libc++] Implement P0608R1 - A sane variant converting constructor

lichray updated this revision to Diff 139882. lichray added a comment. Keep changes small Repository: rCXX libc++ https://reviews.llvm.org/D44865 Files: include/variant test/std/utilities/variant/variant.variant/variant.assign/T.pass.cpp test/std/utilities/variant/variant.variant/varia

[PATCH] D44865: [libc++] Implement P0608R1 - A sane variant converting constructor

lichray marked an inline comment as done. lichray added a comment. In https://reviews.llvm.org/D44865#1048880, @EricWF wrote: > Has this paper been adopted into the standard yet? No. However, it cleanly passed LEWG for recommending a DR against C++17, so I think we can apply it early, just li

[PATCH] D44915: [coroutines] Fix invalid source range in co_await call expressions.

modocache added a comment. Excellent, thank you! I think this might fix PR34982 ? Repository: rC Clang https://reviews.llvm.org/D44915 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://li

[PATCH] D44915: [coroutines] Fix invalid source range in co_await call expressions.

This revision was automatically updated to reflect the committed changes. Closed by commit rC328606: [coroutines] Fix invalid source range in co_await call expressions. (authored by EricWF, committed by ). Repository: rC Clang https://reviews.llvm.org/D44915 Files: lib/Sema/SemaCoroutine.cp

r328606 - [coroutines] Fix invalid source range in co_await call expressions.

Author: ericwf Date: Mon Mar 26 20:15:46 2018 New Revision: 328606 URL: http://llvm.org/viewvc/llvm-project?rev=328606&view=rev Log: [coroutines] Fix invalid source range in co_await call expressions. Summary: Currently an invalid source range is generated for the member call expressions of `co_

[PATCH] D44915: [coroutines] Fix invalid source range in co_await call expressions.

vsk accepted this revision. vsk added a comment. This revision is now accepted and ready to land. Thanks, LGTM. Repository: rC Clang https://reviews.llvm.org/D44915 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi

[PATCH] D44865: [libc++] Implement P0608R1 - A sane variant converting constructor

EricWF added inline comments. Comment at: include/variant:1109 +#define _LIBCPP_VARIANT_BOOLEAN_CONVERSION(bool_type)\ +template\ EricWF wrote: > I would like to see a version of this patch tha

[clang-tools-extra] r328500 - [clangd] Support incremental document syncing

Author: simark Date: Mon Mar 26 07:41:40 2018 New Revision: 328500 URL: http://llvm.org/viewvc/llvm-project?rev=328500&view=rev Log: [clangd] Support incremental document syncing Summary: This patch adds support for incremental document syncing, as described in the LSP spec. The protocol specifi

r328494 - [SemaCXX] _Pragma("clang optimize off") not affecting lambda.

Author: CarlosAlbertoEnciso Date: Mon Mar 26 06:48:03 2018 New Revision: 328494 URL: http://llvm.org/viewvc/llvm-project?rev=328494&view=rev Log: [SemaCXX] _Pragma("clang optimize off") not affecting lambda. Declaring "_Pragma("clang optimize off")" before the body of a function with a lambda lea

[PATCH] D44865: [libc++] Implement P0608R1 - A sane variant converting constructor

EricWF added a comment. Has this paper been adopted into the standard yet? Comment at: include/variant:1097 +{ +static void test(); +}; I see no need to stop using `operator()` in favor of a static function. Is there a reason? Also this would have to be `

[PATCH] D44916: [Sema] Avoid crash for category implementation without interface

smeenai created this revision. smeenai added reviewers: doug.gregor, rjmccall, rsmith. When we have a category implementation without a corresponding interface (which is an error by itself), semantic checks for property accesses will attempt to access a null interface declaration and then segfault

[PATCH] D44723: Set dso_local when clearing dllimport

espindola added a comment. ping https://reviews.llvm.org/D44723 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D44915: [coroutines] Fix invalid source range in co_await call expressions.

EricWF created this revision. EricWF added reviewers: GorNishanov, rsmith, vsk, aaron.ballman. Herald added a subscriber: modocache. Currently an invalid source range is generated for the member call expressions of `co_await`. The end location of the call expression is the `co_await` token loc,

[PATCH] D44589: [Sema] Make deprecation fix-it replace all multi-parameter ObjC method slots.

erik.pilkington accepted this revision. erik.pilkington added a comment. This revision is now accepted and ready to land. LGTM, this is a really nice feature! Comment at: clang/include/clang/Basic/SourceLocation.h:202 +/// Can be used transparently in places where SourceLocatio

r328602 - Fix unused expression warning in co_await.

Author: ericwf Date: Mon Mar 26 17:58:16 2018 New Revision: 328602 URL: http://llvm.org/viewvc/llvm-project?rev=328602&view=rev Log: Fix unused expression warning in co_await. Previously, anytime the result of the resume expression in operator co_await was unused, a warning was generated. This pa

[PATCH] D36918: [Sema] Take into account the current context when checking the accessibility of a member function pointer

rnk resigned from this revision. rnk added a comment. I don't see a new test case for the issue reduced out of Chromium. I'd recommend adding that. I have to resign because I don't know enough about deduction to stamp this... https://reviews.llvm.org/D36918 _

r328599 - Remove dead method

Author: rnk Date: Mon Mar 26 17:26:13 2018 New Revision: 328599 URL: http://llvm.org/viewvc/llvm-project?rev=328599&view=rev Log: Remove dead method Modified: cfe/trunk/include/clang/Basic/TargetCXXABI.h Modified: cfe/trunk/include/clang/Basic/TargetCXXABI.h URL: http://llvm.org/viewvc/llvm

[PATCH] D44908: [ObjC++] Make parameter passing and function return compatible with ObjC

rjmccall added a comment. I think it's reasonable to pull that into LangOpts. It would need to be in LangOpts anyway if we e.g. fixed an ABI bug in struct layout and needed a compatibility handling to preserve the old behavior. Repository: rC Clang https://reviews.llvm.org/D44908 __

r328597 - [Edit, Rewrite] Fix some Clang-tidy modernize and Include What You Use warnings; other minor fixes (NFC).

Author: eugenezelenko Date: Mon Mar 26 17:01:49 2018 New Revision: 328597 URL: http://llvm.org/viewvc/llvm-project?rev=328597&view=rev Log: [Edit, Rewrite] Fix some Clang-tidy modernize and Include What You Use warnings; other minor fixes (NFC). Modified: cfe/trunk/include/clang/Edit/Commit.

[PATCH] D43341: [clang-doc] Implement reducer portion of the frontend framework

Eugene.Zelenko added a comment. Please mention new tool in Release Notes and use //:doc:// to refer to its manual. https://reviews.llvm.org/D43341 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinf

[PATCH] D43341: [clang-doc] Implement reducer portion of the frontend framework

juliehockett updated this revision to Diff 139869. juliehockett marked 13 inline comments as done. juliehockett added a comment. Addressing comments https://reviews.llvm.org/D43341 Files: clang-doc/BitcodeReader.cpp clang-doc/BitcodeReader.h clang-doc/BitcodeWriter.cpp clang-doc/Bitcode

[PATCH] D44913: [ObjC] Enable using C++ triviality type traits for non-trivial C structs

ahatanak created this revision. ahatanak added reviewers: rjmccall, doug.gregor, rsmith. r326307 and r327870 made changes that allowed C structs to have __strong and __weak fields in ARC and be non-trivial. This patch make changes that allow using the following type traits for non-trivial C stru

[PATCH] D44912: [clang-doc] Removing -Wunused-variable warning

Eugene.Zelenko added a comment. I think it's fine to commit trivial fixes without going via review. Repository: rL LLVM https://reviews.llvm.org/D44912 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/

[PATCH] D44912: [clang-doc] Removing -Wunused-variable warning

This revision was automatically updated to reflect the committed changes. Closed by commit rL328588: [clang-doc] Removing -Wunused-variable warning (authored by juliehockett, committed by ). Herald added subscribers: llvm-commits, klimek. Changed prior to commit: https://reviews.llvm.org/D44912

[clang-tools-extra] r328588 - [clang-doc] Removing -Wunused-variable warning

Author: juliehockett Date: Mon Mar 26 15:37:31 2018 New Revision: 328588 URL: http://llvm.org/viewvc/llvm-project?rev=328588&view=rev Log: [clang-doc] Removing -Wunused-variable warning Warning was appearing in release with debug info build, this removes it. Differential Revision: https://review

[PATCH] D36918: [Sema] Take into account the current context when checking the accessibility of a member function pointer

ahatanak added a comment. ping https://reviews.llvm.org/D36918 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D44912: [clang-doc] Removing -Wunused-variable warning

lebedev.ri accepted this revision. lebedev.ri added a comment. LGTM. https://reviews.llvm.org/D44912 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Re: [PATCH] D44883: [Sema] Extend -Wself-assign with -Wself-assign-overloaded to warn on overloaded self-assignment (classes)

Historically Clang's policy on warnings was, I think, much more conservative than it seems to be today. There was a strong desire not to implement off-by-default warnings, and to have warnings with an exceptionally low false-positive rate - maybe the user-defined operator detection was either assum

[PATCH] D44883: [Sema] Extend -Wself-assign with -Wself-assign-overloaded to warn on overloaded self-assignment (classes)

dblaikie added a subscriber: lebedev.ri. dblaikie added a comment. Historically Clang's policy on warnings was, I think, much more conservative than it seems to be today. There was a strong desire not to implement off-by-default warnings, and to have warnings with an exceptionally low false-positi

[PATCH] D44912: [clang-doc] Removing -Wunused-variable warning

jakehehrlich accepted this revision. jakehehrlich added a comment. This revision is now accepted and ready to land. LGTM https://reviews.llvm.org/D44912 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/li

[PATCH] D44912: [clang-doc] Removing -Wunused-variable warning

juliehockett created this revision. juliehockett added reviewers: jakehehrlich, lebedev.ri, sammccall. juliehockett added a project: clang-tools-extra. Herald added subscribers: JDevlieghere, aprantl. Warning was appearing in release with debug info build, this removes it. https://reviews.llvm.o

[PATCH] D44883: [Sema] Extend -Wself-assign with -Wself-assign-overloaded to warn on overloaded self-assignment (classes)

lebedev.ri added a comment. In https://reviews.llvm.org/D44883#1048689, @rjmccall wrote: > I tracked Chandler down, and he doesn't remember why user-defined operators > are excluded. Ok then. Unless reviewers think it would be best to have separate diag groups for "builtin" and "user-provided

[PATCH] D42938: [Sema] Emit -Winteger-overflow for arguments in function calls, ObjC messages.

jkorous-apple accepted this revision. jkorous-apple added a comment. This revision is now accepted and ready to land. LGTM https://reviews.llvm.org/D42938 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/

[PATCH] D44883: [Sema] Extend -Wself-assign with -Wself-assign-overloaded to warn on overloaded self-assignment (classes)

rjmccall added a comment. I tracked Chandler down, and he doesn't remember why user-defined operators are excluded. Repository: rC Clang https://reviews.llvm.org/D44883 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.or

r328584 - [Frontend] Fix some Clang-tidy modernize and Include What You Use warnings; other minor fixes (NFC).

Author: eugenezelenko Date: Mon Mar 26 14:45:04 2018 New Revision: 328584 URL: http://llvm.org/viewvc/llvm-project?rev=328584&view=rev Log: [Frontend] Fix some Clang-tidy modernize and Include What You Use warnings; other minor fixes (NFC). Modified: cfe/trunk/include/clang/Frontend/Compiler

[PATCH] D44362: [clang] Change std::sort to llvm::sort in response to r327219

rnk accepted this revision. rnk added a comment. This revision is now accepted and ready to land. lgtm Repository: rC Clang https://reviews.llvm.org/D44362 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mail

[PATCH] D44908: [ObjC++] Make parameter passing and function return compatible with ObjC

ahatanak added a comment. I tried to move the code in MicrosoftCXXABI::getRecordArgABI and ItaniumCXXABI::passClassIndirect that determine whether a struct is passed indirectly to Sema::CheckCompletedCXXClass, but couldn't do so since getClangABICompat() is a method of CodeGenOpts, which Sema d

[PATCH] D44908: [ObjC++] Make parameter passing and function return compatible with ObjC

ahatanak created this revision. ahatanak added reviewers: rjmccall, doug.gregor, rsmith. r326307 and r327870 made changes that enable __strong and __weak fields to be declared in C structs. This patch changes the ObjC++ ABI so that structs with __strong or __weak pointers can be passed to or ret

[PATCH] D42787: clang-format: do not add extra indent when wrapping last parameter

chandlerc resigned from this revision. chandlerc added a comment. Since this seems not going anywhere, removing it from my review dashboard. Repository: rC Clang https://reviews.llvm.org/D42787 ___ cfe-commits mailing list cfe-commits@lists.llvm.

[PATCH] D44330: CMake option to allow enabling experimental new pass manager by default

chandlerc requested changes to this revision. chandlerc added a comment. This revision now requires changes to proceed. Just a question really. Comment at: clang/CMakeLists.txt:215 +set(ENABLE_EXPERIMENTAL_NEW_PASS_MANAGER FALSE CACHE BOOL + "Enable the experimental new pass

[PATCH] D43871: [modules] No longer include stdlib.h from mm_malloc.h.

chandlerc resigned from this revision. chandlerc added a comment. I think this is more a question for Richard... Add me back to the reviewers if there is a specific need for my input here. Repository: rC Clang https://reviews.llvm.org/D43871 ___

[PATCH] D44906: [clang-tidy] Define __clang_analyzer__ macro for clang-tidy for compatibility with clang static analyzer

zinovy.nis created this revision. zinovy.nis added a project: clang-tools-extra. Herald added subscribers: cfe-commits, a.sidorin, xazax.hun. Herald added a reviewer: george.karpenkov. This macro is widely used in many well-known projects, ex. Chromium

[PATCH] D44823: [libcxx] Improving std::vector and std::deque perfomance

lichray added inline comments. Comment at: libcxx/trunk/include/__split_buffer:201 __alloc_rr& __a = this->__alloc(); +pointer __to_be_end = this->__end_; do mclow.lists wrote: > I have been asked specifically by the optimizer folks to NOT do things

[PATCH] D44883: [Sema] Extend -Wself-assign with -Wself-assign-overloaded to warn on overloaded self-assignment (classes)

rjmccall added a comment. Is D not considered trivial there? Ugh, C++. Well, we certainly could justify treating D as a builtin operator as well, since it doesn't involve running any user code, but I don't think you're obligated to write a whole bunch of analysis just to make that work if the

[PATCH] D44295: [clang-tidy] Detects and fixes calls to grand-...parent virtual methods instead of calls to parent's virtual methods

zinovy.nis updated this revision to Diff 139834. zinovy.nis added a comment. - Updated warning message to > warning: qualified name 'A::foo' refers to a member overridden in subclass; > did you mean 'B'? [bugprone-parent-virtual-call] https://reviews.llvm.org/D44295 Files: clang-tidy/bu

[PATCH] D44449: [Parser] Fix assertion-on-invalid for unexpected typename.

vsapsai added a comment. Ping. https://reviews.llvm.org/D9 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D42938: [Sema] Emit -Winteger-overflow for arguments in function calls, ObjC messages.

vsapsai added a comment. Ping for reviewers. https://reviews.llvm.org/D42938 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D44883: [Sema] Extend -Wself-assign with -Wself-assign-overloaded to warn on overloaded self-assignment (classes)

lebedev.ri added a comment. Ok, once we understand why "field" diag is separate, and why since initial implementation it only warned for "builtin" operators, i'll work on the code further. In https://reviews.llvm.org/D44883#1048485, @rjmccall wrote: > That's an interesting question! You're ab

[PATCH] D44815: [AArch64]: Add support for parsing rN registers.

peter.smith added a comment. I think that we may have a bit of a conceptual difference with GCC here. As far as I can tell in GCC it doesn't matter if "rn", "wn", "xn" or even "bn" is used, this refers to register 0. The Operand constraint such as %w0 is used to control the substitution so the

[PATCH] D44883: [Sema] Extend -Wself-assign with -Wself-assign-overloaded to warn on overloaded self-assignment (classes)

rjmccall added a comment. In https://reviews.llvm.org/D44883#1048485, @rjmccall wrote: > In https://reviews.llvm.org/D44883#1048439, @lebedev.ri wrote: > > > In https://reviews.llvm.org/D44883#1048400, @rjmccall wrote: > > > > > Yeah, like I said, I'm just worried about the usability of having >

[PATCH] D44883: [Sema] Extend -Wself-assign with -Wself-assign-overloaded to warn on overloaded self-assignment (classes)

rjmccall added a comment. In https://reviews.llvm.org/D44883#1048439, @lebedev.ri wrote: > In https://reviews.llvm.org/D44883#1048421, @Quuxplusone wrote: > > > Two more high-level comments from me, and then I'll try to butt out. > > > > Q1. I don't understand what `field-` is doing in the name o

[PATCH] D44846: [MS] Fix late-parsed template infinite loop in eager instantiation

This revision was automatically updated to reflect the committed changes. Closed by commit rC328567: [MS] Fix late-parsed template infinite loop in eager instantiation (authored by rnk, committed by ). Changed prior to commit: https://reviews.llvm.org/D44846?vs=139663&id=139827#toc Repository:

[PATCH] D44846: [MS] Fix late-parsed template infinite loop in eager instantiation

This revision was automatically updated to reflect the committed changes. Closed by commit rL328567: [MS] Fix late-parsed template infinite loop in eager instantiation (authored by rnk, committed by ). Herald added a subscriber: llvm-commits. Changed prior to commit: https://reviews.llvm.org/D4

r328567 - [MS] Fix late-parsed template infinite loop in eager instantiation

Author: rnk Date: Mon Mar 26 11:22:47 2018 New Revision: 328567 URL: http://llvm.org/viewvc/llvm-project?rev=328567&view=rev Log: [MS] Fix late-parsed template infinite loop in eager instantiation Summary: This fixes PR33561 and PR34185. Don't store pending template instantiations for late-parse

[PATCH] D44559: [Sema] Wrong width of result of mul operation

rjmccall added a comment. In https://reviews.llvm.org/D44559#1048399, @lebedev.ri wrote: > I'm having a very hard time following this thread. In fact, i can't follow > the logic at all. > > In https://reviews.llvm.org/D44559#1041007, @rjmccall wrote: > > > ... > > This patch, however, is contra

[PATCH] D44901: [Diag] Avoid emitting a redefinition note if no location is available.

mattd created this revision. mattd added reviewers: bruno, rsmith. The "previous definition is here" note is not helpful if there is no location information. The note will reference nothing in such a case. This patch first checks to see if there is location data, and if so the note diagnostic is

Re: r328282 - [analyzer] Trust _Nonnull annotations for system framework

Yeah, I’m pretty sure this was fixed on Friday with https://reviews.llvm.org/rC328406 > On Mar 26, 2018, at 10:54 AM, Alexander Kornienko wrote: > > This checker crashes on almost each file in our codebase. No test case yet, > but here's a stack trace: > clang::Type::getTypeClass > clang::Refe

[PATCH] D44883: [Sema] Extend -Wself-assign with -Wself-assign-overloaded to warn on overloaded self-assignment (classes)

lebedev.ri added a subscriber: thakis. lebedev.ri added a comment. In https://reviews.llvm.org/D44883#1048421, @Quuxplusone wrote: > Two more high-level comments from me, and then I'll try to butt out. > > Q1. I don't understand what `field-` is doing in the name of some > diagnostics. Is there

Re: r328282 - [analyzer] Trust _Nonnull annotations for system framework

This checker crashes on almost each file in our codebase. No test case yet, but here's a stack trace: clang::Type::getTypeClass clang::ReferenceType::classof llvm::isa_impl::doit llvm::isa_impl_cl::doit llvm::isa_impl_wrap::doit llvm::isa_impl_wrap::doit llvm::isa clang::Type::getAs clang::ASTConte

[PATCH] D44883: [Sema] Extend -Wself-assign with -Wself-assign-overloaded to warn on overloaded self-assignment (classes)

Quuxplusone added a comment. Two more high-level comments from me, and then I'll try to butt out. Q1. I don't understand what `field-` is doing in the name of some diagnostics. Is there a situation where `x = x;` is "less/more of an error" just because `x` is a {data member, lambda capture, str

[PATCH] D44231: [clang-tidy] Check for sizeof that call functions

pfultz2 added a comment. > Do you need someone to submit this for you? Yes https://reviews.llvm.org/D44231 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D44883: [Sema] Extend -Wself-assign with -Wself-assign-overloaded to warn on overloaded self-assignment (classes)

rjmccall added a comment. In https://reviews.llvm.org/D44883#1048081, @lebedev.ri wrote: > In https://reviews.llvm.org/D44883#1048010, @rjmccall wrote: > > > I'm not sure you really need to put these in their own warning sub-group > > just because they're user-defined operators. That's especial

[PATCH] D44559: [Sema] Wrong width of result of mul operation

lebedev.ri added a comment. I'm having a very hard time following this thread. In fact, i can't follow the logic at all. In https://reviews.llvm.org/D44559#1041007, @rjmccall wrote: > ... > This patch, however, is contrary to the design of -Wconversion, which does > attempt to avoid warning i

[PATCH] D44559: [Sema] Wrong width of result of mul operation

rjmccall added a comment. In https://reviews.llvm.org/D44559#1048085, @avt77 wrote: > In https://reviews.llvm.org/D44559#1045758, @rjmccall wrote: > > > No, I still oppose this patch. > > > OK, we have 2 possibilities here (fmpov): > > 1. Forget about the issue and don't do anything now - it is n

[PATCH] D41648: [clang-tidy] implement cppcoreguidelines macro rules

Eugene.Zelenko added a comment. In https://reviews.llvm.org/D41648#1048312, @JonasToth wrote: > Which checks do you have in mind? bugprone-macro-*, bugprone-multiple-statement-macro. Repository: rCTE Clang Tools Extra https://reviews.llvm.org/D41648 _

[PATCH] D44852: [CodeGen] Mark fma as const for Android

pirama added a comment. Thanks for the reviews! Repository: rL LLVM https://reviews.llvm.org/D44852 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D44852: [CodeGen] Mark fma as const for Android

This revision was automatically updated to reflect the committed changes. Closed by commit rL328552: [CodeGen] Mark fma as const for Android (authored by pirama, committed by ). Repository: rL LLVM https://reviews.llvm.org/D44852 Files: cfe/trunk/lib/Sema/SemaDecl.cpp cfe/trunk/test/CodeG

r328552 - [CodeGen] Mark fma as const for Android

Author: pirama Date: Mon Mar 26 10:03:34 2018 New Revision: 328552 URL: http://llvm.org/viewvc/llvm-project?rev=328552&view=rev Log: [CodeGen] Mark fma as const for Android Summary: r318093 sets fma, fmaf, fmal as const for Gnu and MSVC. Android also does not set errno for these functions. So m

[PATCH] D44823: [libcxx] Improving std::vector and std::deque perfomance

mclow.lists requested changes to this revision. mclow.lists added a comment. This revision now requires changes to proceed. Please don't commit this. Comment at: libcxx/trunk/include/__split_buffer:201 __alloc_rr& __a = this->__alloc(); +pointer __to_be_end = this->__e

[PATCH] D44882: [clangd] Implementation of workspace/symbol request

sammccall added a comment. Very nice! I'd like to reduce the scope of the initial patch, which seems to be possible, so we can review the details but not get bogged down too much. In https://reviews.llvm.org/D44882#1048179, @malaperle wrote: > In https://reviews.llvm.org/D44882#1048043, @ilya-b

r328544 - [OPENMP] Codegen for declare target with link clause.

Author: abataev Date: Mon Mar 26 09:40:55 2018 New Revision: 328544 URL: http://llvm.org/viewvc/llvm-project?rev=328544&view=rev Log: [OPENMP] Codegen for declare target with link clause. If the link clause is used on the declare target directive, the object should be linked on target or target d

[PATCH] D44295: [clang-tidy] Detects and fixes calls to grand-...parent virtual methods instead of calls to parent's virtual methods

zinovy.nis updated this revision to Diff 139805. zinovy.nis retitled this revision from "[clang-tidy] Detect and fix calls to grand-...parent virtual methods instead of calls to parent's virtual methods" to "[clang-tidy] Detects and fixes calls to grand-...parent virtual methods instead of calls

[PATCH] D44831: [clang-format] Refine ObjC guesser to handle child lines of child lines

benhamilton updated this revision to Diff 139804. benhamilton added a comment. - Remove stray semicolon. Repository: rC Clang https://reviews.llvm.org/D44831 Files: lib/Format/Format.cpp unittests/Format/FormatTest.cpp Index: unittests/Format/FormatTest.cpp

[PATCH] D44831: [clang-format] Refine ObjC guesser to handle child lines of child lines

benhamilton updated this revision to Diff 139802. benhamilton added a comment. - Use recursion. Split lambda out into its own static method since recursion on lambdas is quite ugly until C++14 Repository: rC Clang https://reviews.llvm.org/D44831 Files: lib/Format/Format.cpp unittests/Fo

[PATCH] D41648: [clang-tidy] implement cppcoreguidelines macro rules

JonasToth added a comment. Which checks do you have in mind? Am 26.03.2018 um 18:07 schrieb Eugene Zelenko via Phabricator: > Eugene.Zelenko added inline comments. > > > Comment at: docs/clang-tidy/checks/cppcoreguidelines-macro-usage.rst:24 > + > +.. option:: CheckCapsOnly

[libunwind] r328534 - Creating release directory for release_502.

Author: tstellar Date: Mon Mar 26 09:06:38 2018 New Revision: 328534 URL: http://llvm.org/viewvc/llvm-project?rev=328534&view=rev Log: Creating release directory for release_502. Added: libunwind/tags/RELEASE_502/ ___ cfe-commits mailing list cfe-c

[libunwind] r328535 - Creating release candidate rc1 from release_502 branch

Author: tstellar Date: Mon Mar 26 09:06:40 2018 New Revision: 328535 URL: http://llvm.org/viewvc/llvm-project?rev=328535&view=rev Log: Creating release candidate rc1 from release_502 branch Added: libunwind/tags/RELEASE_502/rc1/ (props changed) - copied from r328534, libunwind/branche

[libcxxabi] r328523 - Creating release candidate rc1 from release_502 branch

Author: tstellar Date: Mon Mar 26 09:06:14 2018 New Revision: 328523 URL: http://llvm.org/viewvc/llvm-project?rev=328523&view=rev Log: Creating release candidate rc1 from release_502 branch Added: libcxxabi/tags/RELEASE_502/rc1/ - copied from r328522, libcxxabi/branches/release_50/ ___

[libcxx] r328521 - Creating release candidate rc1 from release_502 branch

Author: tstellar Date: Mon Mar 26 09:06:11 2018 New Revision: 328521 URL: http://llvm.org/viewvc/llvm-project?rev=328521&view=rev Log: Creating release candidate rc1 from release_502 branch Added: libcxx/tags/RELEASE_502/rc1/ (props changed) - copied from r328520, libcxx/branches/rele

[libcxxabi] r328522 - Creating release directory for release_502.

Author: tstellar Date: Mon Mar 26 09:06:12 2018 New Revision: 328522 URL: http://llvm.org/viewvc/llvm-project?rev=328522&view=rev Log: Creating release directory for release_502. Added: libcxxabi/tags/RELEASE_502/ ___ cfe-commits mailing list cfe-c

[libcxx] r328520 - Creating release directory for release_502.

Author: tstellar Date: Mon Mar 26 09:06:06 2018 New Revision: 328520 URL: http://llvm.org/viewvc/llvm-project?rev=328520&view=rev Log: Creating release directory for release_502. Added: libcxx/tags/RELEASE_502/ ___ cfe-commits mailing list cfe-comm

[PATCH] D41648: [clang-tidy] implement cppcoreguidelines macro rules

Eugene.Zelenko added inline comments. Comment at: docs/clang-tidy/checks/cppcoreguidelines-macro-usage.rst:24 + +.. option:: CheckCapsOnly + Will be good idea to generalize this option with other check which deal with macros. Repository: rCTE Clang Tools Ext

[PATCH] D41648: [clang-tidy] implement cppcoreguidelines macro rules

Eugene.Zelenko added inline comments. Comment at: docs/clang-tidy/checks/cppcoreguidelines-macro-usage.rst:26 + +This boolean flag disables all warnings for macros and checks only that +macro names are CAPS_ONLY. This option is meant to ease introduction of this ---

[PATCH] D42776: [Sema] Fix an assertion failure in constant expression evaluation of calls to functions with default arguments

ahatanak updated this revision to Diff 139797. ahatanak added a comment. Assign an uninitialized APValue to a temporary instead of removing it from the temporary map when the temporary's lifetime has ended. https://reviews.llvm.org/D42776 Files: include/clang/AST/APValue.h lib/AST/APValue.

[PATCH] D44893: [ASTMatchers] Add isAssignmentOperator matcher

alexfh accepted this revision. alexfh added a comment. This revision is now accepted and ready to land. LG! Repository: rC Clang https://reviews.llvm.org/D44893 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin

[PATCH] D44831: [clang-format] Refine ObjC guesser to handle child lines of child lines

benhamilton added inline comments. Comment at: lib/Format/Format.cpp:1542 }; -for (auto Line : AnnotatedLines) { - if (LineContainsObjCCode(*Line)) +llvm::DenseSet LinesToCheckSet; +LinesToCheckSet.reserve(AnnotatedLines.size()); benhamilton

[PATCH] D44295: [clang-tidy] Detects and fixes calls to grand-...parent virtual methods instead of calls to parent's virtual methods

alexfh requested changes to this revision. alexfh added inline comments. This revision now requires changes to proceed. Comment at: docs/clang-tidy/checks/bugprone-parent-virtual-call.rst:26 + int foo() override {... A::foo()...} + warning: qual

[PATCH] D44852: [CodeGen] Mark fma as const for Android

pirama updated this revision to Diff 139798. pirama added a comment. Fix comment. Repository: rC Clang https://reviews.llvm.org/D44852 Files: lib/Sema/SemaDecl.cpp test/CodeGen/math-builtins.c Index: test/CodeGen/math-builtins.c =

[PATCH] D38455: [clang-tidy] new cppcoreguidelines-narrowing-conversions check.

alexfh requested changes to this revision. alexfh added a comment. This revision now requires changes to proceed. > I agree that more data would be useful, so I'll do an analysis of flagging > all (non-ceil/floor float/double)->integral conversions. Removing from my dashboard for now. Reposito

[PATCH] D44231: [clang-tidy] Check for sizeof that call functions

alexfh accepted this revision. alexfh added a comment. LG. Do you need someone to submit this for you? Comment at: test/clang-tidy/misc-sizeof-expression.cpp:17 +enum E { E_VALUE = 0 }; + aaron.ballman wrote: > Can you add a C++11 test case using `enum class`

[libcxxabi] r328507 - [demangler] Fix a bug in r328464 found by oss-fuzz.

Author: epilk Date: Mon Mar 26 08:34:36 2018 New Revision: 328507 URL: http://llvm.org/viewvc/llvm-project?rev=328507&view=rev Log: [demangler] Fix a bug in r328464 found by oss-fuzz. Modified: libcxxabi/trunk/src/cxa_demangle.cpp Modified: libcxxabi/trunk/src/cxa_demangle.cpp URL: http://l

[PATCH] D44765: PR36643 Make clang-format support more generic TMarcos

alexfh requested changes to this revision. alexfh added a comment. This revision now requires changes to proceed. Thank you! One more comment from me and I'll leave the rest of the review to Krasimir, who has a better idea of how the configuration options should be named etc.

[PATCH] D44831: [clang-format] Refine ObjC guesser to handle child lines of child lines

benhamilton added inline comments. Comment at: lib/Format/Format.cpp:1542 }; -for (auto Line : AnnotatedLines) { - if (LineContainsObjCCode(*Line)) +llvm::DenseSet LinesToCheckSet; +LinesToCheckSet.reserve(AnnotatedLines.size()); djasper wro

  1   2   >