[PATCH] D41217: [Concepts] Concept Specialization Expressions

saar.raz updated this revision to Diff 138499. saar.raz added a comment. Applied missing clang-format. Repository: rC Clang https://reviews.llvm.org/D41217 Files: include/clang/AST/DeclTemplate.h include/clang/AST/ExprCXX.h include/clang/AST/RecursiveASTVisitor.h include/clang/Basic/

[PATCH] D43766: [clang-tidy][modernize-make-unique] Checks c++14 flag before using std::make_unique

alexfh accepted this revision. alexfh added a comment. LG. Thank you! https://reviews.llvm.org/D43766 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D41217: [Concepts] Concept Specialization Expressions

saar.raz updated this revision to Diff 138497. saar.raz added a comment. Addressed most comments. Repository: rC Clang https://reviews.llvm.org/D41217 Files: include/clang/AST/DeclTemplate.h include/clang/AST/ExprCXX.h include/clang/AST/RecursiveASTVisitor.h include/clang/Basic/Diagn

[PATCH] D43184: [WIP] [ItaniunCXXABI] Add an option for loading the type info vtable with dllimport

mstorsjo added a comment. (Accidentally pressed submit too soon) This was my conclusion at some point as well - but there's also a few issues with that approach which makes me quite hesitant: - doing fixups in the code segment requires making it writable temporarily at runtime, which is disall

[PATCH] D43184: [WIP] [ItaniunCXXABI] Add an option for loading the type info vtable with dllimport

mstorsjo added a comment. In https://reviews.llvm.org/D43184#1038129, @rnk wrote: > In https://reviews.llvm.org/D43184#1031831, @mstorsjo wrote: > > > So in case this approach as my hacky PoC does is the only feasible way > > left, I obviously need to fix it up. Any directions and suggestions on

[PATCH] D44408: Move DraftMgr from ClangdServer to ClangdLSPServer

simark updated this revision to Diff 138490. simark added a comment. Rebase on current master, addressing previous comments Repository: rCTE Clang Tools Extra https://reviews.llvm.org/D44408 Files: clangd/ClangdLSPServer.cpp clangd/ClangdLSPServer.h clangd/ClangdServer.cpp clangd/Cla

[PATCH] D43898: Preliminary refactoring in service of -Wreturn-std-move. NFC.

This revision was not accepted when it landed; it landed in state "Needs Review". This revision was automatically updated to reflect the committed changes. Closed by commit rL327598: Refactoring code around move/copy initialization. NFC. (authored by rtrieu, committed by ). Herald added a subscr

r327598 - Refactoring code around move/copy initialization. NFC.

Author: rtrieu Date: Wed Mar 14 20:00:55 2018 New Revision: 327598 URL: http://llvm.org/viewvc/llvm-project?rev=327598&view=rev Log: Refactoring code around move/copy initialization. NFC. Use an enum parameter instead of a bool for more control on how the copy elision functions work. Extract th

[PATCH] D44435: Add the module name to __cuda_module_ctor and __cuda_module_dtor for unique function names

rjmccall added inline comments. Comment at: lib/CodeGen/CGCUDANV.cpp:281 + // get name from the module to generate unique ctor name for every module + SmallString<128> ModuleName rsmith wrote: > rjmccall wrote: > > v.g.vassilev wrote: > > > rjmccall wrote: >

[PATCH] D40381: Parse concept definition

faisalv added a comment. I discussed this briefly w Hubert - and i'm planning on modifying this patch slightly so that it flows through ParseDeclSpecifier and handles attributes and other invalid decl-specifiers such as static etc. more gracefully on a concept decl. I have this partially imple

[PATCH] D44505: [MS] Always use base dtors in place of complete/vbase dtors when possible

rnk created this revision. rnk added reviewers: erichkeane, zahiraam, majnemer, rjmccall. Previously we tried too hard to uphold the fiction that destructor variants work like they do on Itanium throughout the ABI-neutral parts of clang. This lead to MS C++ ABI incompatiblities and other bugs. Now

r327593 - [CFG] Allow CallExpr's to be looked up in CFG's

Author: rtrieu Date: Wed Mar 14 17:09:26 2018 New Revision: 327593 URL: http://llvm.org/viewvc/llvm-project?rev=327593&view=rev Log: [CFG] Allow CallExpr's to be looked up in CFG's r327343 changed the handling for CallExpr in a CFG, which prevented lookups for CallExpr while other Stmt kinds stil

r327591 - [analyzer] Explicitly set an -std level for the analyzer test.

Author: george.karpenkov Date: Wed Mar 14 16:50:18 2018 New Revision: 327591 URL: http://llvm.org/viewvc/llvm-project?rev=327591&view=rev Log: [analyzer] Explicitly set an -std level for the analyzer test. Modified: cfe/trunk/test/Analysis/nonnullparamchecker-crash.cpp Modified: cfe/trunk/te

[PATCH] D44346: [clang-tidy] Add Zircon module to clang-tidy

This revision was automatically updated to reflect the committed changes. juliehockett marked 2 inline comments as done. Closed by commit rL327590: [clang-tidy] Add Zircon module to clang-tidy (authored by juliehockett, committed by ). Herald added subscribers: llvm-commits, klimek. Changed prior

[clang-tools-extra] r327590 - [clang-tidy] Add Zircon module to clang-tidy

Author: juliehockett Date: Wed Mar 14 16:47:50 2018 New Revision: 327590 URL: http://llvm.org/viewvc/llvm-project?rev=327590&view=rev Log: [clang-tidy] Add Zircon module to clang-tidy Adding a Zircon module to clang-tidy for checks specific to the Zircon kernel, and adding a checker to fuchsia-zx

[PATCH] D44435: Add the module name to __cuda_module_ctor and __cuda_module_dtor for unique function names

rsmith added inline comments. Comment at: lib/CodeGen/CGCUDANV.cpp:281 + // get name from the module to generate unique ctor name for every module + SmallString<128> ModuleName rjmccall wrote: > v.g.vassilev wrote: > > rjmccall wrote: > > > SimeonEhrig wrote:

[PATCH] D44346: [clang-tidy] Add Zircon module to clang-tidy

aaron.ballman accepted this revision. aaron.ballman added a comment. This revision is now accepted and ready to land. LGTM with some minor documentation nits. Comment at: docs/clang-tidy/checks/zircon-temporary-objects.rst:7 +Warns on construction of specific temporary objects

[PATCH] D43184: [WIP] [ItaniunCXXABI] Add an option for loading the type info vtable with dllimport

rnk added a comment. In https://reviews.llvm.org/D43184#1031831, @mstorsjo wrote: > For `__cxxabiv1::__class_type_info`, there's no declaration visible in scope > at all, and the actual contents of the vtable of this class (and the other > similar classes) doesn't seem to be defined in the ABI

[PATCH] D44346: [clang-tidy] Add Zircon module to clang-tidy

juliehockett updated this revision to Diff 138470. juliehockett added a comment. Fixing a typo sorry https://reviews.llvm.org/D44346 Files: clang-tidy/CMakeLists.txt clang-tidy/tool/CMakeLists.txt clang-tidy/tool/ClangTidyMain.cpp clang-tidy/zircon/CMakeLists.txt clang-tidy/zircon/Tem

[PATCH] D44346: [clang-tidy] Add Zircon module to clang-tidy

juliehockett updated this revision to Diff 138468. juliehockett marked 3 inline comments as done. juliehockett added a comment. Updating docs. https://reviews.llvm.org/D44346 Files: clang-tidy/CMakeLists.txt clang-tidy/tool/CMakeLists.txt clang-tidy/tool/ClangTidyMain.cpp clang-tidy/zir

[PATCH] D44346: [clang-tidy] Add Zircon module to clang-tidy

juliehockett updated this revision to Diff 138466. juliehockett marked 2 inline comments as done. juliehockett added a comment. Updating decl passed to warning string https://reviews.llvm.org/D44346 Files: clang-tidy/CMakeLists.txt clang-tidy/tool/CMakeLists.txt clang-tidy/tool/ClangTidyM

[PATCH] D44435: Add the module name to __cuda_module_ctor and __cuda_module_dtor for unique function names

rjmccall added inline comments. Comment at: lib/CodeGen/CGCUDANV.cpp:281 + // get name from the module to generate unique ctor name for every module + SmallString<128> ModuleName v.g.vassilev wrote: > rjmccall wrote: > > SimeonEhrig wrote: > > > tra wrote: >

[PATCH] D44498: Sink PrettyDeclStackTrace down to the AST library

jordan_rose created this revision. jordan_rose added reviewers: bruno, rsmith. ...and add some very basic stack trace entries for module building. This would have helped track down rdar://problem/38434694 sooner (which I can't share, sorry). Repository: rC Clang https://reviews.llvm.org/D44

[PATCH] D44445: CodeGen: Reduce LValue and CallArgList memory footprint before recommitting r326946

rjmccall added a comment. Yeah, I think the test is probably a bit abusive to run unconditionally for all hosts. We can just know that we improved things, and if we regress, it will break them again. Repository: rC Clang https://reviews.llvm.org/D5 __

[PATCH] D43322: Diagnose cases of "return x" that should be "return std::move(x)" for efficiency

Quuxplusone updated this revision to Diff 138457. Quuxplusone added a comment. Boldly add `-Wreturn-std-move` to `-Wmove` (and thus also to `-Wall`). The backward-compatibility-concerned diagnostic, `-Wreturn-std-move-in-c++11`, is *not* appropriate for `-Wmove`; but I believe this main diagnosti

[PATCH] D44445: CodeGen: Reduce LValue and CallArgList memory footprint before recommitting r326946

yaxunl added a comment. I have to remove the lit test since it causes failure on atom http://lab.llvm.org:8011/builders/clang-atom-d525-fedora-rel/builds/15477 It seems when the lit test is running on atom, it is compiled with default CPU for x86_64, therefor __atom__ is not defined and there i

r327578 - Remove test deep-ast-tree.cpp

Author: yaxunl Date: Wed Mar 14 14:40:55 2018 New Revision: 327578 URL: http://llvm.org/viewvc/llvm-project?rev=327578&view=rev Log: Remove test deep-ast-tree.cpp Since there is no reliable way to change the AST depth of this test by supported stack size of the test environment, remove this test

[PATCH] D44435: Add the module name to __cuda_module_ctor and __cuda_module_dtor for unique function names

v.g.vassilev added inline comments. Comment at: lib/CodeGen/CGCUDANV.cpp:281 + // get name from the module to generate unique ctor name for every module + SmallString<128> ModuleName rjmccall wrote: > SimeonEhrig wrote: > > tra wrote: > > > SimeonEhrig wrote:

[PATCH] D44494: [libunwind] Support __register_frame with a full .eh_frame section

mstorsjo updated this revision to Diff 138451. mstorsjo added a comment. Avoid using the C++ header. https://reviews.llvm.org/D44494 Files: src/UnwindCursor.hpp src/libunwind.cpp Index: src/libunwind.cpp === --- src/libunwind

[PATCH] D44494: [libunwind] Support __register_frame with a full .eh_frame section

mstorsjo added inline comments. Comment at: src/UnwindCursor.hpp:53 unw_word_t fde, unw_word_t mh)); + static void iterateSections(std::function func); rnk wrote: > I'm concerned that std::function might introduc

[PATCH] D25820: [Sema][Objective-C] Formatting warnings should see through Objective-C message sends

benhamilton added a comment. >@benhamilton We're planning to use the new attribute in >https://reviews.llvm.org/D27165 to address this issue. I'll get back to that >patch in the near future. Great, thanks for the update. Repository: rL LLVM https://reviews.llvm.org/D25820 __

r327573 - [Tooling] Fix some Clang-tidy modernize and Include What You Use warnings; other minor fixes (NFC).

Author: eugenezelenko Date: Wed Mar 14 14:05:51 2018 New Revision: 327573 URL: http://llvm.org/viewvc/llvm-project?rev=327573&view=rev Log: [Tooling] Fix some Clang-tidy modernize and Include What You Use warnings; other minor fixes (NFC). Modified: cfe/trunk/include/clang/Tooling/ArgumentsA

[PATCH] D25820: [Sema][Objective-C] Formatting warnings should see through Objective-C message sends

arphaman added a comment. @benhamilton We're planning to use the new attribute in https://reviews.llvm.org/D27165 to address this issue. I'll get back to that patch in the near future. Repository: rL LLVM https://reviews.llvm.org/D25820 ___ cf

[PATCH] D43737: Improve -Winfinite-recursion

rtrieu added a comment. Two more changes, then everything is good to commit. Comment at: lib/Sema/AnalysisBasedWarnings.cpp:218-220 +// Found a path to the exit node without a recursive call. +if (ExitID == Block->getBlockID()) + return false; Move

[PATCH] D44493: [libunwind] Add a cmake option for disabling the use of the dynamic linker

rnk accepted this revision. rnk added a comment. This revision is now accepted and ready to land. lgtm Repository: rUNW libunwind https://reviews.llvm.org/D44493 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bi

[PATCH] D44494: [libunwind] Support __register_frame with a full .eh_frame section

rnk added inline comments. Comment at: src/UnwindCursor.hpp:53 unw_word_t fde, unw_word_t mh)); + static void iterateSections(std::function func); I'm concerned that std::function might introduce runtime dependen

[PATCH] D41102: Setup clang-doc frontend framework

lebedev.ri added inline comments. Comment at: clang-doc/BitcodeWriter.cpp:230 + prepRecordData(ID); + for (const char C : RecordIdNameMap[ID].Name) Record.push_back(C); + Stream.EmitRecord(llvm::bitc::BLOCKINFO_CODE_SETRECORDNAME, Record); lebedev.ri wrote: >

[PATCH] D39050: Add index-while-building support to Clang

akyrtzi added a comment. Hey Marc, > The fact that both clang and clangd have to agree on the format so that > index-while-building can be used seems to make it inherently not possible to > extend I don't think "not possible to extend" is quite correct, we can make it so that the format allow

r327570 - Reduce AST depth for test deep-ast-tree.cpp for atom

Author: yaxunl Date: Wed Mar 14 13:41:05 2018 New Revision: 327570 URL: http://llvm.org/viewvc/llvm-project?rev=327570&view=rev Log: Reduce AST depth for test deep-ast-tree.cpp for atom Modified: cfe/trunk/test/CodeGenCXX/deep-ast-tree.cpp Modified: cfe/trunk/test/CodeGenCXX/deep-ast-tree.cp

[PATCH] D44494: [libunwind] Support __register_frame with a full .eh_frame section

mstorsjo created this revision. mstorsjo added reviewers: rnk, compnerd. Previously, the __register_frame function supported registering an FDE for one individual function at a time. The function could also be used registering a full .eh_frame section of a module (which is how libgcc sets up unw

[PATCH] D44189: [RISCV] Verify the input value of -march=

asb added a comment. Thanks for submitting this Kito. I've added some minor in-line comments. It might also be worth adding a couple of extra cases to the tests: - Repeated letters in the ISA string (e.g. rv32immafd) - Upper case letters in the ISA string. We currently reject these (as does GCC

[PATCH] D44493: [libunwind] Add a cmake option for disabling the use of the dynamic linker

mstorsjo created this revision. mstorsjo added reviewers: rnk, compnerd. Herald added a subscriber: mgorny. On windows, the psapi function for querying the dynamic linker for loaded modules (EnumProcessModules) are unavailable when targeting the UWP/"Windows Store" api subsets. Such a build rel

[PATCH] D43766: [clang-tidy][modernize-make-unique] Checks c++14 flag before using std::make_unique

aaron.ballman accepted this revision. aaron.ballman added a comment. LGTM! https://reviews.llvm.org/D43766 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D44491: Set dso_local for CFConstantStringClassReference

espindola created this revision. espindola added reviewers: rnk, echristo. This one cannot use setGVProperties since it has special logic for when it is dllimport or not. https://reviews.llvm.org/D44491 Files: lib/CodeGen/CodeGenModule.cpp test/CodeGen/cfstring-windows.c Index: test/Code

[PATCH] D41357: WIP: Fix Diagnostic layering, moving diagnostics out of Basic

dblaikie added a comment. Updated with a functional implementation - a few points: - Some tests could use only the Common diagnostics (see one of the intermediate changes where I moved those tests over to use all diagnostics) except for the tablegen required for the diagnostic groups makes that

Re: r327547 - Attempt to fix failure of deep-ast-tree.cpp on atom and s390

Hi Yaxun, the test continues to be broken on the sanitizer buildbots: http://lab.llvm.org:8011/builders/sanitizer-x86_64-linux-bootstrap/builds/4639 http://lab.llvm.org:8011/builders/sanitizer-x86_64-linux-bootstrap-msan/builds/3298 http://lab.llvm.org:8011/builders/sanitizer-x86_64-linux-fast/buil

Re: r327345 - [analyzer] Destroy and lifetime-extend inlined function return values properly.

Hmm, indeed, sorry. This was fixed independently by Pavel Labath in r327491 (this code had moved before the fix). On 13/03/2018 11:34 PM, Mikael Holmén wrote: Hi Artem, This commit gives the following warning: ../tools/clang/lib/StaticAnalyzer/Core/ExprEngineCXX.cpp:283:23: error: unused var

[PATCH] D43162: [Parser] (C++) Make -Wextra-semi slightly more useful

This revision was automatically updated to reflect the committed changes. Closed by commit rL327558: [Parser] (C++) Make -Wextra-semi slightly more useful (authored by lebedevri, committed by ). Herald added a subscriber: llvm-commits. Changed prior to commit: https://reviews.llvm.org/D43162?vs

r327558 - [Parser] (C++) Make -Wextra-semi slightly more useful

Author: lebedevri Date: Wed Mar 14 12:31:34 2018 New Revision: 327558 URL: http://llvm.org/viewvc/llvm-project?rev=327558&view=rev Log: [Parser] (C++) Make -Wextra-semi slightly more useful Summary: Let's suppose the `-Weverything` is passed. Given code like ``` void F() {} ; ``` If the code is

[PATCH] D44462: [clangd] Don't use DraftMgr in implementation of forceReparse.

cfe-commits added a comment. - F5892491: msg-4647-88.txt Repository: rL LLVM https://reviews.llvm.org/D44462 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listi

Re: [PATCH] D44462: [clangd] Don't use DraftMgr in implementation of forceReparse.

On Wed, Mar 14, 2018, 19:39 Simon Marchi via Phabricator < revi...@reviews.llvm.org> wrote: > simark added inline comments. > > > > Comment at: clangd/TUScheduler.h:69 > + /// FIXME: remove the callback from this function > + void updateCompileCommand(PathRef File, tooling::Comp

[PATCH] D44462: [clangd] Don't use DraftMgr in implementation of forceReparse.

simark added inline comments. Comment at: clangd/TUScheduler.h:69 + /// FIXME: remove the callback from this function + void updateCompileCommand(PathRef File, tooling::CompileCommand NewCommand, +IntrusiveRefCntPtr FS, ilya-biryukov

[clang-tools-extra] r327550 - [clangd] Use Contents from inputs in codeComplete and signatureHelp

Author: simark Date: Wed Mar 14 11:31:48 2018 New Revision: 327550 URL: http://llvm.org/viewvc/llvm-project?rev=327550&view=rev Log: [clangd] Use Contents from inputs in codeComplete and signatureHelp Summary: ClangdServer::{codeComplete,signatureHelp} both use the Contents from the draft manager

[PATCH] D44484: [clangd] Use Contents from inputs in codeComplete and signatureHelp

This revision was automatically updated to reflect the committed changes. Closed by commit rCTE327550: [clangd] Use Contents from inputs in codeComplete and signatureHelp (authored by simark, committed by ). Changed prior to commit: https://reviews.llvm.org/D44484?vs=138417&id=138424#toc Repos

[PATCH] D39679: [C++11] Fix warning when dropping cv-qualifiers when assigning to a reference with a braced initializer list

Rakete updated this revision to Diff 138423. Rakete added a comment. Addressed review comments :) I added a test case for the crashing code. Note: I didn't change `Args[0]` to `OnlyArg` in `FK_AddressOfUnaddressableFunction`, because I'm pretty sure that C++ doesn't have unaddressable f

[PATCH] D44482: Set dso_local for NSConcreteStackBlock

espindola closed this revision. espindola added a comment. r327544 https://reviews.llvm.org/D44482 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

r327547 - Attempt to fix failure of deep-ast-tree.cpp on atom and s390

Author: yaxunl Date: Wed Mar 14 11:24:38 2018 New Revision: 327547 URL: http://llvm.org/viewvc/llvm-project?rev=327547&view=rev Log: Attempt to fix failure of deep-ast-tree.cpp on atom and s390 Modified: cfe/trunk/test/CodeGenCXX/deep-ast-tree.cpp Modified: cfe/trunk/test/CodeGenCXX/deep-ast

[PATCH] D44408: Move DraftMgr from ClangdServer to ClangdLSPServer

ilya-biryukov added a comment. In https://reviews.llvm.org/D44408#1037520, @simark wrote: > I see, I made this as a separate patch: > > https://reviews.llvm.org/D44484 I LGTMed it, so feel free to submit it. However, if you do it in this patch it's also fine. Repository: rCTE Clang Tools Ex

[PATCH] D41655: [clang-tidy] New check bugprone-unused-return-value

khuttun added a comment. In https://reviews.llvm.org/D41655#1037234, @alexfh wrote: > Do you need help committing the patch? Yes please, I don't have commit access to the repo. I think the next step for improving this checker could be to make it work with class template member functions. That

[PATCH] D41217: [Concepts] Concept Specialization Expressions

saar.raz added inline comments. Comment at: lib/AST/ExprCXX.cpp:1478 + { +// We do not want error diagnostics escaping here. +Sema::SFINAETrap Trap(S); faisalv wrote: > Hubert: This needs a TODO: the idea is not to drop SFINAE errors, but to > avoid ins

r327546 - Update DR script to mark Clang 6 as 'done' not 'svn'.

Author: rsmith Date: Wed Mar 14 11:20:45 2018 New Revision: 327546 URL: http://llvm.org/viewvc/llvm-project?rev=327546&view=rev Log: Update DR script to mark Clang 6 as 'done' not 'svn'. Modified: cfe/trunk/www/make_cxx_dr_status Modified: cfe/trunk/www/make_cxx_dr_status URL: http://llvm.o

r327545 - [www] Update C++ DR status to match latest issues list.

Author: rsmith Date: Wed Mar 14 11:19:41 2018 New Revision: 327545 URL: http://llvm.org/viewvc/llvm-project?rev=327545&view=rev Log: [www] Update C++ DR status to match latest issues list. Modified: cfe/trunk/www/cxx_dr_status.html Modified: cfe/trunk/www/cxx_dr_status.html URL: http://llvm

r327544 - Set dso_local for NSConcreteStackBlock.

Author: rafael Date: Wed Mar 14 11:19:26 2018 New Revision: 327544 URL: http://llvm.org/viewvc/llvm-project?rev=327544&view=rev Log: Set dso_local for NSConcreteStackBlock. Modified: cfe/trunk/lib/CodeGen/CGBlocks.cpp cfe/trunk/test/CodeGen/blocks-windows.c Modified: cfe/trunk/lib/CodeGe

[PATCH] D44435: Add the module name to __cuda_module_ctor and __cuda_module_dtor for unique function names

tra added inline comments. Comment at: unittests/CodeGen/IncrementalProcessingTest.cpp:176-178 + +// In CUDA incremental processing, a CUDA ctor or dtor will be generated for +// every statement if a fatbinary file exists. SimeonEhrig wrote: > tra wrote: > > I d

[PATCH] D44233: Set dso_local on external rtti GVs

espindola closed this revision. espindola added a comment. r327543 https://reviews.llvm.org/D44233 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

r327543 - Set dso_local on external rtti GVs.

Author: rafael Date: Wed Mar 14 11:14:46 2018 New Revision: 327543 URL: http://llvm.org/viewvc/llvm-project?rev=327543&view=rev Log: Set dso_local on external rtti GVs. In this particular case it would be possible to just add an else with CGM.setDSOLocal(GV), but it seems better to have as many c

[PATCH] D44346: [clang-tidy] Add Zircon module to clang-tidy

aaron.ballman added inline comments. Comment at: clang-tidy/zircon/TemporaryObjectsCheck.cpp:51 + "creating a temporary object of type %0 is prohibited") +<< D->getConstructor()->getParent()->getQualifiedNameAsString(); +} aaron.ballman wrote: > a

[PATCH] D44408: Move DraftMgr from ClangdServer to ClangdLSPServer

simark added a comment. In https://reviews.llvm.org/D44408#1037327, @ilya-biryukov wrote: > In https://reviews.llvm.org/D44408#1036941, @simark wrote: > > > I don't see how to avoid adding the Contents parameter to the codeComplete > > and signatureHelp methods, since they needed to fetch the do

[PATCH] D44484: [clangd] Use Contents from inputs in codeComplete and signatureHelp

simark created this revision. Herald added subscribers: cfe-commits, ioeric, jkorous-apple, ilya-biryukov, klimek. ClangdServer::{codeComplete,signatureHelp} both use the Contents from the draft manager. Since we want to move the draft manager from ClangdServer to ClangdLSPServer, this patch cha

[PATCH] D44346: [clang-tidy] Add Zircon module to clang-tidy

juliehockett added inline comments. Comment at: clang-tidy/fuchsia/FuchsiaTidyModule.cpp:44 +CheckFactories.registerCheck( +"fuchsia-zx-temporary-objects"); } aaron.ballman wrote: > Do we want a zircon module instead? I'm wondering about people who

[PATCH] D44346: [clang-tidy] Add Zircon module to clang-tidy

aaron.ballman added inline comments. Comment at: clang-tidy/zircon/TemporaryObjectsCheck.cpp:51 + "creating a temporary object of type %0 is prohibited") +<< D->getConstructor()->getParent()->getQualifiedNameAsString(); +} aaron.ballman wrote: > Y

[PATCH] D44233: Set dso_local on external rtti GVs

rnk accepted this revision. rnk added inline comments. This revision is now accepted and ready to land. Comment at: lib/CodeGen/ItaniumCXXABI.cpp:2618-2620 +const CXXRecordDecl *RD = nullptr; +if (const auto *RecordTy = dyn_cast(Ty)) + RD = cast(RecordTy->getDecl());

[PATCH] D44482: Set dso_local for NSConcreteStackBlock

rnk accepted this revision. rnk added a comment. This revision is now accepted and ready to land. lgtm https://reviews.llvm.org/D44482 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D44480: [Sema] Don't skip function bodies with 'auto' without trailing return type

aaron.ballman added a reviewer: rsmith. aaron.ballman added a comment. Adding Richard as a reviewer, because this seems somewhat clever to me (so there may be a better change to make). Comment at: lib/Sema/SemaDecl.cpp:12611 +// false on C++14's auto return type without tr

[clang-tools-extra] r327539 - [clangd] Fix indentation in the comment. NFC

Author: ibiryukov Date: Wed Mar 14 10:49:19 2018 New Revision: 327539 URL: http://llvm.org/viewvc/llvm-project?rev=327539&view=rev Log: [clangd] Fix indentation in the comment. NFC Modified: clang-tools-extra/trunk/clangd/TUScheduler.h Modified: clang-tools-extra/trunk/clangd/TUScheduler.h U

[PATCH] D44463: [clangd] Don't expose vfs in TUScheduler::runWithPreamble.

This revision was automatically updated to reflect the committed changes. Closed by commit rCTE327537: [clangd] Don't expose vfs in TUScheduler::runWithPreamble. (authored by ibiryukov, committed by ). Changed prior to commit: https://reviews.llvm.org/D44463?vs=138409&id=138411#toc Repository:

[clang-tools-extra] r327537 - [clangd] Don't expose vfs in TUScheduler::runWithPreamble.

Author: ibiryukov Date: Wed Mar 14 10:46:52 2018 New Revision: 327537 URL: http://llvm.org/viewvc/llvm-project?rev=327537&view=rev Log: [clangd] Don't expose vfs in TUScheduler::runWithPreamble. Summary: It was previously an easy way to concurrently access a mutable vfs, which is a recipe for dis

[PATCH] D44482: Set dso_local for NSConcreteStackBlock

espindola created this revision. espindola added reviewers: rnk, echristo. https://reviews.llvm.org/D44482 Files: lib/CodeGen/CGBlocks.cpp test/CodeGen/blocks-windows.c Index: test/CodeGen/blocks-windows.c === --- test/CodeGen/

[PATCH] D44463: [clangd] Don't expose vfs in TUScheduler::runWithPreamble.

ilya-biryukov updated this revision to Diff 138409. ilya-biryukov added a comment. - Rebase on top of master - Add the suggested comment Repository: rCTE Clang Tools Extra https://reviews.llvm.org/D44463 Files: clangd/ClangdServer.cpp clangd/TUScheduler.cpp clangd/TUScheduler.h unitt

[PATCH] D44435: Add the module name to __cuda_module_ctor and __cuda_module_dtor for unique function names

rjmccall added inline comments. Comment at: lib/CodeGen/CGCUDANV.cpp:281 + // get name from the module to generate unique ctor name for every module + SmallString<128> ModuleName SimeonEhrig wrote: > tra wrote: > > SimeonEhrig wrote: > > > rjmccall wrote: > >

[PATCH] D41217: [Concepts] Concept Specialization Expressions

faisalv added inline comments. Comment at: include/clang/AST/ExprCXX.h:4416 +/// According to C++2a [expr.prim.id]p3 an id-expression that denotes the +/// specialization of a concepts results in a prvalue of type bool. +class ConceptSpecializationExpr final : public Expr { -

[PATCH] D44188: Misc typos

tra added a comment. You may want to split the patch into smaller pieces -- per leaf directory, for example. That way potential reviewers would at least be able to see the changes (hundreds of files in one patch is a bit too much), and the subset of changes would be small enough for someone to

[PATCH] D43967: [ASTImporter] Add test helper Fixture

a.sidorin added a comment. Hello Gabor, Sorry for the delay with review: the patch is pretty big and it was hard to find time for reviewing it. I like the patch but it requires some cleanup like formatting changes. Could you please clang-format new code? Also, I'd like to avoid code duplication

[PATCH] D41968: [libunwind][MIPS] Support MIPS floating-point registers for hard-float ABIs.

bsdjhb added a comment. @sdardis ping. I think the approach I've used for O32 is probably the right one in that it matches what DWARF expects (DWARF doesn't treat the 32-bit floating point registers as pairs but as individual registers). I think the question is if I O32 with 32-bit FP registe

[PATCH] D43766: [clang-tidy][modernize-make-unique] Checks c++14 flag before using std::make_unique

ftingaud updated this revision to Diff 138398. ftingaud added a comment. Clean code along code review recommendations. https://reviews.llvm.org/D43766 Files: clang-tidy/modernize/MakeSmartPtrCheck.cpp clang-tidy/modernize/MakeSmartPtrCheck.h clang-tidy/modernize/MakeUniqueCheck.cpp clan

[PATCH] D44462: [clangd] Don't use DraftMgr in implementation of forceReparse.

This revision was automatically updated to reflect the committed changes. Closed by commit rL327532: [clangd] Remove forceReparse, add a flag to addDocument instead (authored by ibiryukov, committed by ). Herald added a subscriber: llvm-commits. Repository: rL LLVM https://reviews.llvm.org/D44

[clang-tools-extra] r327532 - [clangd] Remove forceReparse, add a flag to addDocument instead

Author: ibiryukov Date: Wed Mar 14 10:08:41 2018 New Revision: 327532 URL: http://llvm.org/viewvc/llvm-project?rev=327532&view=rev Log: [clangd] Remove forceReparse, add a flag to addDocument instead Summary: To make the removal of DraftMgr from ClangdServer easier (D44408). Reviewers: sammccall

[PATCH] D44462: [clangd] Don't use DraftMgr in implementation of forceReparse.

ilya-biryukov added inline comments. Comment at: unittests/clangd/SyncAPI.h:23 +void runAddDocument(ClangdServer &Server, PathRef File, StringRef Contents, +bool SkipCache = false); sammccall wrote: > it's slightly odd that wantdiagnostics i

[PATCH] D44462: [clangd] Don't use DraftMgr in implementation of forceReparse.

ilya-biryukov updated this revision to Diff 138397. ilya-biryukov marked 2 inline comments as done. ilya-biryukov added a comment. - Add WantDiagnostics param to runAddDocument - Revert changes in TUScheduler Repository: rCTE Clang Tools Extra https://reviews.llvm.org/D44462 Files: clangd/

[PATCH] D39050: Add index-while-building support to Clang

nathawes added a comment. In https://reviews.llvm.org/D39050#1037008, @malaperle wrote: > In https://reviews.llvm.org/D39050#1036394, @nathawes wrote: > > > @malaperle Just to clarify, what's the particular end-loc we're talking > > about here? e.g. for a function call, would this be the end of

[PATCH] D44408: Move DraftMgr from ClangdServer to ClangdLSPServer

ilya-biryukov added a comment. In https://reviews.llvm.org/D44408#1036941, @simark wrote: > I don't see how to avoid adding the Contents parameter to the codeComplete > and signatureHelp methods, since they needed to fetch the document from the > draft manager and pass it to the backend. You

[PATCH] D44462: [clangd] Don't use DraftMgr in implementation of forceReparse.

sammccall accepted this revision. sammccall added inline comments. Comment at: clangd/TUScheduler.cpp:220 +FileInputs = std::move(Inputs); +rebuildASTLocked(WantDiags, std::move(OnUpdated)); }; you might want to inline this function here again - it's n

r327531 - [CMake] Properly quote string arguments to quiet errors from r327528 when built

Author: marsupial Date: Wed Mar 14 09:56:02 2018 New Revision: 327531 URL: http://llvm.org/viewvc/llvm-project?rev=327531&view=rev Log: [CMake] Properly quote string arguments to quiet errors from r327528 when built with LLVM_ENABLE_EH and LLVM_ENABLE_RTTI. Modified: cfe/trunk/examples/clang-

r327529 - Attempt to fix failure of deep-ast-tree.cpp on ppc64 and atom

Author: yaxunl Date: Wed Mar 14 09:47:49 2018 New Revision: 327529 URL: http://llvm.org/viewvc/llvm-project?rev=327529&view=rev Log: Attempt to fix failure of deep-ast-tree.cpp on ppc64 and atom Modified: cfe/trunk/test/CodeGenCXX/deep-ast-tree.cpp Modified: cfe/trunk/test/CodeGenCXX/deep-as

[PATCH] D44462: [clangd] Don't use DraftMgr in implementation of forceReparse.

ilya-biryukov added inline comments. Comment at: clangd/TUScheduler.h:69 + /// FIXME: remove the callback from this function + void updateCompileCommand(PathRef File, tooling::CompileCommand NewCommand, +IntrusiveRefCntPtr FS, sammcc

[PATCH] D44462: [clangd] Don't use DraftMgr in implementation of forceReparse.

ilya-biryukov updated this revision to Diff 138394. ilya-biryukov marked 2 inline comments as done. ilya-biryukov added a comment. - Remove TUScheduler::updateCompileCommands, add a new optional parameter to clear the cache of compile commands instead - Address review comments Repository: rCT

[PATCH] D44346: [clang-tidy] Add Zircon module to clang-tidy

juliehockett updated this revision to Diff 138392. juliehockett marked 3 inline comments as done. juliehockett added a comment. Fixing tests and updating docs https://reviews.llvm.org/D44346 Files: clang-tidy/CMakeLists.txt clang-tidy/tool/CMakeLists.txt clang-tidy/tool/ClangTidyMain.cpp

[PATCH] D44295: [clang-tidy] Detects and fixes calls to grand-...parent virtual methods instead of calls to parent's virtual methods

alexfh requested changes to this revision. alexfh added inline comments. This revision now requires changes to proceed. Comment at: clang-tidy/bugprone/ParentVirtualCallCheck.cpp:24-25 + const CXXRecordDecl *ThisClass) { + assert(Parent); + assert(ThisClas

[PATCH] D23130: [Clang-tidy] Add a check for definitions in the global namespace.

bkramer added a comment. I'd like to, but I don't know when I find time to rebase this thing after more than a year of waiting for review. https://reviews.llvm.org/D23130 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org

[PATCH] D44480: [Sema] Don't skip function bodies with 'auto' without trailing return type

ilya-biryukov created this revision. ilya-biryukov added reviewers: aaron.ballman, sammccall. Skipping them was clearly not intentional. It's impossible to guarantee correctness if the bodies are skipped. Also adds a test case for r327504, now that it does not produce invalid errors that made the

  1   2   >