dblaikie added a comment.

Updated with a functional implementation - a few points:

- Some tests could use only the Common diagnostics (see one of the intermediate 
changes where I moved those tests over to use all diagnostics) except for the 
tablegen required for the diagnostic groups makes that a bit heavier - though 
doing so would help reduce dependencies.
- Naming (of the "DiagnosticTable" header, and the functions/entities contained 
there) could be improved - open to ideas
- API (currently passing in like 6 different raw arrays and ArrayRefs to 
DiagnosticIDs) could be improved - open to ideas


Repository:
  rC Clang

https://reviews.llvm.org/D41357



_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Reply via email to