kito-cheng marked 2 inline comments as done.
kito-cheng added inline comments.
Comment at: lib/Driver/ToolChains/Arch/RISCV.cpp:48
+ break;
+default:
+ // First letter should be 'i' or 'g'.
apazos wrote:
> In the switch cases move default to first p
kito-cheng updated this revision to Diff 137547.
Repository:
rC Clang
https://reviews.llvm.org/D44189
Files:
lib/Driver/ToolChains/Arch/RISCV.cpp
test/Driver/riscv-arch.c
Index: test/Driver/riscv-arch.c
===
--- /dev/null
+++
Author: sberg
Date: Wed Mar 7 23:34:40 2018
New Revision: 326990
URL: http://llvm.org/viewvc/llvm-project?rev=326990&view=rev
Log:
Propagate DLLAttr to friend re-declarations of member functions
...that have already been constructed (e.g., in inner classes) while parsing the
class definition. T
This revision was automatically updated to reflect the committed changes.
Closed by commit rL326990: Propagate DLLAttr to friend re-declarations of
member functions (authored by sberg, committed by ).
Herald added a subscriber: llvm-commits.
Changed prior to commit:
https://reviews.llvm.org/D16
Author: gbiv
Date: Wed Mar 7 21:32:30 2018
New Revision: 326988
URL: http://llvm.org/viewvc/llvm-project?rev=326988&view=rev
Log:
[CodeGen] Emit lifetime.ends in both EH and non-EH blocks
Before this, we'd only emit lifetime.ends for these temps in
non-exceptional paths. This potentially made ou
rjmccall accepted this revision.
rjmccall added a comment.
This revision is now accepted and ready to land.
LGTM, thanks.
Comment at: lib/CodeGen/CGNonTrivialStruct.cpp:764
+Object = CGF->EmitObjCConsumeObject(QT, Object);
+CGF->EmitARCStoreWeak(Addrs[DstIdx], Object, t
This revision was automatically updated to reflect the committed changes.
Closed by commit rC326982: [analyzer] Correctly model iteration through
"nil" objects (authored by george.karpenkov, committed by ).
Herald added a subscriber: cfe-commits.
Changed prior to commit:
https://reviews.llvm.or
Author: george.karpenkov
Date: Wed Mar 7 18:53:39 2018
New Revision: 326982
URL: http://llvm.org/viewvc/llvm-project?rev=326982&view=rev
Log:
[analyzer] Correctly model iteration through "nil" objects
Previously, iteration through nil objects which resulted from
objc-messages being set to nil we
Author: gbiv
Date: Wed Mar 7 18:15:12 2018
New Revision: 326980
URL: http://llvm.org/viewvc/llvm-project?rev=326980&view=rev
Log:
Fix an unused variable warning; NFC
Modified:
cfe/trunk/lib/StaticAnalyzer/Core/ExprEngine.cpp
Modified: cfe/trunk/lib/StaticAnalyzer/Core/ExprEngine.cpp
URL:
h
pfultz2 created this revision.
pfultz2 added reviewers: clang-tools-extra, aaron.ballman.
pfultz2 added a project: clang-tools-extra.
Herald added a subscriber: mgorny.
Diagnoses when a non-trivial type is not assigned to a variable. This is useful
to check for problems like unnamed lock guards.
NoQ added inline comments.
Comment at: lib/Analysis/CFG.cpp:1700
/// way return valid LocalScope object.
LocalScope* CFGBuilder::createOrReuseLocalScope(LocalScope* Scope) {
if (Scope)
NoQ wrote:
> It seems that something has moved asterisks to a weird spot
NoQ accepted this revision.
NoQ added a comment.
This revision is now accepted and ready to land.
I think we should land this and celebrate.
@szepet: Ouch, i was sure i already answered this, sorry, dunno where this went.
> So, LoopExit and ScopeExit would be the same but the underlying TriggerS
Author: eugenezelenko
Date: Wed Mar 7 17:37:39 2018
New Revision: 326979
URL: http://llvm.org/viewvc/llvm-project?rev=326979&view=rev
Log:
[Documentation] Fix Release notes problems introduced in r326889. Add
highlighting.
Modified:
cfe/trunk/docs/ReleaseNotes.rst
Modified: cfe/trunk/docs/
NoQ created this revision.
NoQ added reviewers: dcoughlin, xazax.hun, a.sidorin, george.karpenkov, szepet.
Herald added subscribers: cfe-commits, rnkovacs.
NoQ added a dependency: D44238: [CFG] Fix automatic destructors when a member
is bound to a reference..
In code like
const int &x = C().x;
NoQ created this revision.
NoQ added reviewers: rsmith, doug.gregor, dcoughlin, xazax.hun, a.sidorin,
george.karpenkov, szepet.
Herald added subscribers: cfe-commits, rnkovacs.
In code like
const int &x = A().x;
the destructor for `A()` was not present in the CFG due to two problems in the
p
rnk accepted this revision.
rnk added a comment.
This revision is now accepted and ready to land.
lgtm
https://reviews.llvm.org/D16632
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
Author: rnk
Date: Wed Mar 7 17:12:22 2018
New Revision: 326974
URL: http://llvm.org/viewvc/llvm-project?rev=326974&view=rev
Log:
Revert "[Sema] Make getCurFunction() return null outside function parsing"
This reverts r326965. It seems to have caused repeating test failures in
clang/test/Sema/dia
Author: rsmith
Date: Wed Mar 7 17:07:33 2018
New Revision: 326973
URL: http://llvm.org/viewvc/llvm-project?rev=326973&view=rev
Log:
When substituting previously-checked template arguments into a template
template parameter that is an expanded parameter pack, only substitute into the
current slice
Author: rnk
Date: Wed Mar 7 16:55:09 2018
New Revision: 326971
URL: http://llvm.org/viewvc/llvm-project?rev=326971&view=rev
Log:
[MS] Pass CVRU qualifiers properly in Itanium mangler
We already have a mangling for the __unaligned qualifier, we just have
to call Qualifiers::getFromCVRUMask instea
Author: gbiv
Date: Wed Mar 7 16:22:04 2018
New Revision: 326968
URL: http://llvm.org/viewvc/llvm-project?rev=326968&view=rev
Log:
Fix a doc typo; NFC
Modified:
cfe/trunk/lib/CodeGen/CGExpr.cpp
Modified: cfe/trunk/lib/CodeGen/CGExpr.cpp
URL:
http://llvm.org/viewvc/llvm-project/cfe/trunk/lib
This revision was automatically updated to reflect the committed changes.
Closed by commit rL326965: [Sema] Make getCurFunction() return null outside
function parsing (authored by rnk, committed by ).
Herald added a subscriber: llvm-commits.
Changed prior to commit:
https://reviews.llvm.org/D44
This revision was automatically updated to reflect the committed changes.
Closed by commit rC326965: [Sema] Make getCurFunction() return null outside
function parsing (authored by rnk, committed by ).
Changed prior to commit:
https://reviews.llvm.org/D44039?vs=137472&id=137506#toc
Repository:
Author: rnk
Date: Wed Mar 7 16:14:34 2018
New Revision: 326965
URL: http://llvm.org/viewvc/llvm-project?rev=326965&view=rev
Log:
[Sema] Make getCurFunction() return null outside function parsing
Summary:
Before this patch, Sema pre-allocated a FunctionScopeInfo and kept it in
the first, always p
eugenis added inline comments.
Comment at: clang/lib/Driver/ToolChains/Gnu.cpp:311
+ if (Args.hasArg(options::OPT_shared) || Args.hasArg(options::OPT_static) ||
+ Args.hasArg(options::OPT_r))
return false;
mgrang wrote:
> We also need to check for -Wl,
espindola created this revision.
espindola added a reviewer: rnk.
In this particular case it would be possible to just add an else with
CGM.setDSOLocal(GV), but it seems better to have as many callers as possible
just call setGVProperties so that we can centralize the logic there.
This patch t
Author: rnk
Date: Wed Mar 7 15:26:02 2018
New Revision: 326962
URL: http://llvm.org/viewvc/llvm-project?rev=326962&view=rev
Log:
[MS] Accept __unaligned as a qualifier on member function pointers
We need to treat __unaligned like the other 'cvr' qualifiers when it
appears at the end of a functio
ahatanak added inline comments.
Comment at: include/clang/AST/Decl.h:3631
+PassedIndirectly = true;
+ }
+
rjmccall wrote:
> I feel like this flag should be set by Sema for C++ types that have to be
> passed indirectly as well; it can then become the single
ahatanak updated this revision to Diff 137500.
ahatanak marked 2 inline comments as done.
ahatanak added a comment.
Address review comments.
https://reviews.llvm.org/D44095
Files:
include/clang/AST/Decl.h
include/clang/AST/DeclCXX.h
include/clang/AST/Type.h
lib/AST/ASTImporter.cpp
lib
espindola closed this revision.
espindola added a comment.
r326961
https://reviews.llvm.org/D43990
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
rjmccall added a comment.
I agree that having those sites just no-op themselves is the cleanest approach.
https://reviews.llvm.org/D44039
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-comm
thakis closed this revision.
thakis marked an inline comment as done.
thakis added a comment.
r326960, thanks!
https://reviews.llvm.org/D44223
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe
Author: rafael
Date: Wed Mar 7 15:18:06 2018
New Revision: 326961
URL: http://llvm.org/viewvc/llvm-project?rev=326961&view=rev
Log:
Set dso_local on tls init functions.
We copy the visibility, so copying the dso_local flag seems the
natural thing to do.
Modified:
cfe/trunk/lib/CodeGen/Itani
Author: nico
Date: Wed Mar 7 15:15:20 2018
New Revision: 326960
URL: http://llvm.org/viewvc/llvm-project?rev=326960&view=rev
Log:
[ms] Emit vtordisp initializers in a deterministic order.
No effective behavior change, just for cleanliness.
Analysis and typing by me, actual patch mostly by Reid.
pfultz2 updated this revision to Diff 137499.
https://reviews.llvm.org/D44231
Files:
clang-tidy/misc/SizeofExpressionCheck.cpp
clang-tidy/misc/SizeofExpressionCheck.h
test/clang-tidy/misc-sizeof-expression.cpp
Index: test/clang-tidy/misc-sizeof-expression.cpp
==
pfultz2 updated this revision to Diff 137497.
https://reviews.llvm.org/D44231
Files:
clang-tidy/misc/SizeofExpressionCheck.cpp
clang-tidy/misc/SizeofExpressionCheck.h
test/clang-tidy/misc-sizeof-expression.cpp
Index: test/clang-tidy/misc-sizeof-expression.cpp
==
pfultz2 updated this revision to Diff 137496.
https://reviews.llvm.org/D44231
Files:
clangd/CodeComplete.cpp
test/clangd/protocol.test
unittests/clangd/CodeCompleteTests.cpp
Index: unittests/clangd/CodeCompleteTests.cpp
===
-
pfultz2 created this revision.
pfultz2 added reviewers: clang-tools-extra, hokein, alexfh, aaron.ballman,
ilya-biryukov.
Herald added a subscriber: jkorous-apple.
A common mistake that I have found in our codebase is calling a function to get
an integer or enum that represents the type such as:
mgrang added inline comments.
Comment at: clang/lib/Driver/ToolChains/Gnu.cpp:311
+ if (Args.hasArg(options::OPT_shared) || Args.hasArg(options::OPT_static) ||
+ Args.hasArg(options::OPT_r))
return false;
We also need to check for -Wl,-r and -Xlinker -
srhines accepted this revision.
srhines added a comment.
This revision is now accepted and ready to land.
Thanks for fixing this quickly. :)
https://reviews.llvm.org/D44229
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.or
eugenis created this revision.
eugenis added a reviewer: srhines.
Android, in particular, got PIE enabled by default in r316606. It resulted in
relocatable links passing both -r and -pie to the linker, which is not allowed.
https://reviews.llvm.org/D44229
Files:
clang/lib/Driver/ToolChains/Gn
Author: marshall
Date: Wed Mar 7 14:51:16 2018
New Revision: 326958
URL: http://llvm.org/viewvc/llvm-project?rev=326958&view=rev
Log:
Include since we use it. Thanks to Andrey Maksimov for the catch.
Modified:
libcxx/trunk/test/std/numerics/rand/rand.device/eval.pass.cpp
Modified: libcxx/
This revision was automatically updated to reflect the committed changes.
Closed by commit rC326957: Avoid including ScopeInfo.h from Sema.h (authored by
rnk, committed by ).
Changed prior to commit:
https://reviews.llvm.org/D44221?vs=137487&id=137488#toc
Repository:
rC Clang
https://review
This revision was automatically updated to reflect the committed changes.
Closed by commit rL326957: Avoid including ScopeInfo.h from Sema.h (authored by
rnk, committed by ).
Herald added a subscriber: llvm-commits.
Changed prior to commit:
https://reviews.llvm.org/D44221?vs=137487&id=137489#to
Author: rnk
Date: Wed Mar 7 14:48:35 2018
New Revision: 326957
URL: http://llvm.org/viewvc/llvm-project?rev=326957&view=rev
Log:
Avoid including ScopeInfo.h from Sema.h
Summary:
This provides no measurable build speedup, but it reinstates an
optimization from r112038 that was lost in r179618. I
rnk updated this revision to Diff 137487.
rnk added a comment.
- remove Sema::recordEvaluatedWeakUse to fix Linux build
https://reviews.llvm.org/D44221
Files:
clang/include/clang/Sema/ScopeInfo.h
clang/include/clang/Sema/Sema.h
clang/include/clang/Sema/SemaLambda.h
clang/lib/Sema/Sema.c
george.karpenkov accepted this revision.
george.karpenkov added a comment.
This revision is now accepted and ready to land.
LGTM
https://reviews.llvm.org/D44131
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/ma
simark added a comment.
In https://reviews.llvm.org/D44226#1030625, @ilya-biryukov wrote:
> I would vouch for adding a log level instead. It's a very well understood
> concept that certainly covers this use-case and can be useful in other places.
> WDYT?
I agree. How would you prefer the fla
Author: eugenezelenko
Date: Wed Mar 7 14:30:50 2018
New Revision: 326954
URL: http://llvm.org/viewvc/llvm-project?rev=326954&view=rev
Log:
[Documentation] Fix Clang-tidy checks list broken in r326909.
Modified:
clang-tools-extra/trunk/docs/clang-tidy/checks/list.rst
Modified: clang-tools-ex
niko added a comment.
If this is OK as it is, can someone with commit access push this? Thanks!
Repository:
rCTE Clang Tools Extra
https://reviews.llvm.org/D43847
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-b
ilya-biryukov added a comment.
I would vouch for adding a log level instead. It's a very well understood
concept that certainly covers this use-case and can be useful in other places.
WDYT?
Repository:
rCTE Clang Tools Extra
https://reviews.llvm.org/D44226
This revision was automatically updated to reflect the committed changes.
Closed by commit rC326952: [analyzer] [PointerArithChecker] do not warn on
indexes into vector types (authored by george.karpenkov, committed by ).
Herald added a subscriber: cfe-commits.
Repository:
rC Clang
https://rev
This revision was automatically updated to reflect the committed changes.
Closed by commit rC326951: [analyzer] Don't crash with assertion failure
on structured bindings (authored by george.karpenkov, committed by ).
Herald added a subscriber: cfe-commits.
Changed prior to commit:
https://revie
Author: george.karpenkov
Date: Wed Mar 7 14:20:39 2018
New Revision: 326952
URL: http://llvm.org/viewvc/llvm-project?rev=326952&view=rev
Log:
[analyzer] [PointerArithChecker] do not warn on indexes into vector types
rdar://35041502
Differential Revision: https://reviews.llvm.org/D44172
Modifie
Author: george.karpenkov
Date: Wed Mar 7 14:20:35 2018
New Revision: 326951
URL: http://llvm.org/viewvc/llvm-project?rev=326951&view=rev
Log:
[analyzer] Don't crash with assertion failure on structured bindings
Proper modeling still remains to be done.
Note that BindingDecl#getHoldingVar() is al
simark updated this revision to Diff 137478.
simark added a comment.
Changed -log-to-stderr to -log-lsp-to-stderr
The first version disabled a bit too much, this version removes the LSP
communication logging in a more fine grained way.
Repository:
rCTE Clang Tools Extra
https://reviews.llvm.
This revision was automatically updated to reflect the committed changes.
Closed by commit rC326948: [OpenMP] Remove implicit data sharing code gen that
aims to use device shared… (authored by gbercea, committed by ).
Changed prior to commit:
https://reviews.llvm.org/D43625?vs=136570&id=137475#
mclow.lists updated this revision to Diff 137474.
mclow.lists added a comment.
Added the proposed resolution for https://wg21.link/lwg3075 as well, and some
deduction guide tests for `string_view`
https://reviews.llvm.org/D37994
Files:
include/string
test/std/strings/basic.string/string.co
Author: gbercea
Date: Wed Mar 7 13:59:50 2018
New Revision: 326948
URL: http://llvm.org/viewvc/llvm-project?rev=326948&view=rev
Log:
[OpenMP] Remove implicit data sharing code gen that aims to use device shared
memory
Summary: Remove this scheme for now since it will be covered by another more
rnk accepted this revision.
rnk added a comment.
This revision is now accepted and ready to land.
lgtm
Comment at: lib/CodeGen/MicrosoftCXXABI.cpp:1207
uint64_t ConstantVBaseOffset =
-Layout.getVBaseClassOffset(I->first).getQuantity();
+Layout.getVBaseClass
Author: wizard
Date: Wed Mar 7 10:59:25 2018
New Revision: 326928
URL: http://llvm.org/viewvc/llvm-project?rev=326928&view=rev
Log:
do not register matcher for objc-only checks when analyzing non-objc sources to
save resources
Summary: I did not put lang opt check in AvoidSpinlockCheck since OS
simark created this revision.
Herald added subscribers: cfe-commits, ioeric, JDevlieghere, jkorous-apple,
ilya-biryukov, klimek.
Currently, clangd prints all the LSP communication on stderr. While
this is good for developping, I don't think it's good as a general
default. For example, we are in
thakis marked an inline comment as done.
thakis added inline comments.
Comment at: lib/CodeGen/MicrosoftCXXABI.cpp:1206
+
+ for (const VBase &V : VBases) {
+if (!V.second.hasVtorDisp())
rnk wrote:
> I think we can avoid the sort altogether if we iterate `RD-
thakis updated this revision to Diff 137470.
thakis added a comment.
rnk comment
https://reviews.llvm.org/D44223
Files:
lib/CodeGen/MicrosoftCXXABI.cpp
Index: lib/CodeGen/MicrosoftCXXABI.cpp
===
--- lib/CodeGen/MicrosoftCXXABI.
rnk updated this revision to Diff 137472.
rnk added a comment.
Bring back Sema::setFunctionHas* methods which internally do nothing when
called outside function scope. This appears to happen in practice when parsing
invalid code involving things like statement expressions, VLAs at global scope,
et
Joel, can you investigate the issue?
~Aaron
On Wed, Mar 7, 2018 at 4:32 PM, Nico Weber via cfe-commits
wrote:
> (I had to revert this since it caused
> https://bugs.llvm.org/show_bug.cgi?id=36620)
>
> On Fri, Mar 2, 2018 at 2:03 PM, Joel E. Denny via cfe-commits
> wrote:
>>
>> Author: jdenny
>>
This revision was automatically updated to reflect the committed changes.
Closed by commit rCTE326947: [clangd] Remove unused field in HandlerRegisterer
(authored by simark, committed by ).
Changed prior to commit:
https://reviews.llvm.org/D44213?vs=137410&id=137471#toc
Repository:
rCTE Clan
This revision was automatically updated to reflect the committed changes.
Closed by commit rL326946: CodeGen: Fix address space of indirect function
argument (authored by yaxunl, committed by ).
Herald added a subscriber: llvm-commits.
Changed prior to commit:
https://reviews.llvm.org/D34367?vs
Author: yaxunl
Date: Wed Mar 7 13:45:40 2018
New Revision: 326946
URL: http://llvm.org/viewvc/llvm-project?rev=326946&view=rev
Log:
CodeGen: Fix address space of indirect function argument
The indirect function argument is in alloca address space in LLVM IR. However,
during Clang codegen for C++
malaperle accepted this revision.
malaperle added a comment.
This revision is now accepted and ready to land.
LGTM
Repository:
rCTE Clang Tools Extra
https://reviews.llvm.org/D44213
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://l
apazos added inline comments.
Comment at: lib/Driver/ToolChains/Arch/RISCV.cpp:48
+ break;
+default:
+ // First letter should be 'i' or 'g'.
In the switch cases move default to first position.
Comment at: lib/Driver/ToolChains/Arc
lebedev.ri added a comment.
Hmm, i'm missing something about the way store sha1...
Comment at: clang-doc/BitcodeWriter.cpp:53
+{// 0. Fixed-size integer (length of the sha1'd USR)
+ llvm::BitCodeAbbrevOp(llvm::BitCodeAbbrevOp::VBR,
+
This revision was automatically updated to reflect the committed changes.
Closed by commit rL326945: [clang-format] Break consecutive string literals in
text protos (authored by krasimir, committed by ).
Herald added a subscriber: llvm-commits.
Repository:
rL LLVM
https://reviews.llvm.org/D442
Author: krasimir
Date: Wed Mar 7 13:30:38 2018
New Revision: 326945
URL: http://llvm.org/viewvc/llvm-project?rev=326945&view=rev
Log:
[clang-format] Break consecutive string literals in text protos
Summary:
This patch fixes a bug where consecutive string literals in text protos were
put on the s
(I had to revert this since it caused
https://bugs.llvm.org/show_bug.cgi?id=36620)
On Fri, Mar 2, 2018 at 2:03 PM, Joel E. Denny via cfe-commits <
cfe-commits@lists.llvm.org> wrote:
> Author: jdenny
> Date: Fri Mar 2 11:03:22 2018
> New Revision: 326602
>
> URL: http://llvm.org/viewvc/llvm-proje
rnk added a comment.
Thanks for investigating!
Comment at: lib/CodeGen/MicrosoftCXXABI.cpp:1206
+
+ for (const VBase &V : VBases) {
+if (!V.second.hasVtorDisp())
I think we can avoid the sort altogether if we iterate `RD->vbases()`, which
should already b
thakis updated this revision to Diff 137463.
thakis added a comment.
Herald added a subscriber: mgrang.
sort unstably
https://reviews.llvm.org/D44223
Files:
lib/CodeGen/MicrosoftCXXABI.cpp
Index: lib/CodeGen/MicrosoftCXXABI.cpp
===
evandro accepted this revision.
evandro added a comment.
This revision is now accepted and ready to land.
Looks pretty straightforward to me.
https://reviews.llvm.org/D44222
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.o
rjmccall accepted this revision.
rjmccall added a comment.
This revision is now accepted and ready to land.
Thanks. LGTM!
https://reviews.llvm.org/D34367
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/
yaxunl updated this revision to Diff 137460.
yaxunl marked an inline comment as done.
yaxunl edited the summary of this revision.
yaxunl added a comment.
Added comment about emit non-null argument check.
https://reviews.llvm.org/D34367
Files:
lib/CodeGen/CGAtomic.cpp
lib/CodeGen/CGCall.cpp
Author: ormris
Date: Wed Mar 7 12:48:16 2018
New Revision: 326942
URL: http://llvm.org/viewvc/llvm-project?rev=326942&view=rev
Log:
Correct the alignment for the PS4 target
https://reviews.llvm.org/D44218
Modified:
cfe/trunk/lib/Basic/Targets/OSTargets.h
cfe/trunk/test/Preprocessor/init
Quuxplusone added a comment.
Btw, I'm going to be talking about this patch tonight at 7 in Palo Alto. :)
https://www.meetup.com/ACCU-Bay-Area/events/248040207/
https://docs.google.com/presentation/d/18ZRnedocXSQKn9Eh67gGv-ignReHfRD7vj_dxrra1kc/
Repository:
rC Clang
https://reviews.llvm.org/D4
Thanks! I’ll commit this.
From: Eric Christopher [mailto:echri...@gmail.com]
Sent: Wednesday, March 7, 2018 12:33 PM
To: reviews+d44218+public+fd8ca19cc9985...@reviews.llvm.org
Cc: cfe-commits@lists.llvm.org; craig.top...@gmail.com; erich.ke...@intel.com;
filcab+llvm.phabrica...@gmail.com; Voss,
juliehockett updated this revision to Diff 137457.
juliehockett marked 13 inline comments as done.
juliehockett added a comment.
Updating bitcode writer for hashed USRs, and re-running clang-format. Also
cleaning up a couple of unused fields.
https://reviews.llvm.org/D41102
Files:
CMakeLists
efriedma added inline comments.
Comment at: lib/CodeGen/MicrosoftCXXABI.cpp:1202
+ SmallVector VBases(VBaseMap.begin(), VBaseMap.end());
+ std::stable_sort(VBases.begin(), VBases.end(),
+ [](const VBaseEntry &a, const VBaseEntry &b) {
Using st
LGTM.
On Wed, Mar 7, 2018, 11:02 AM Matthew Voss via Phabricator <
revi...@reviews.llvm.org> wrote:
> ormris created this revision.
> ormris added reviewers: rsmith, craig.topper, echristo, erichkeane.
>
> See above.
>
>
> Repository:
> rC Clang
>
> https://reviews.llvm.org/D44218
>
> Files:
>
thakis added inline comments.
Comment at: lib/CodeGen/MicrosoftCXXABI.cpp:1207
+
+ for (const VBaseEntry E : VBases) {
+if (!E.second.hasVtorDisp())
(I added the missing `&` here locally.)
https://reviews.llvm.org/D44223
thakis created this revision.
thakis added a reviewer: rnk.
No effective behavior change, just for cleanliness.
Fixes PR36159.
https://reviews.llvm.org/D44223
Files:
lib/CodeGen/MicrosoftCXXABI.cpp
Index: lib/CodeGen/MicrosoftCXXABI.cpp
=
rjmccall added inline comments.
Comment at: lib/CodeGen/CGCall.cpp:3427
(void)InitialArgSize;
-RValue RVArg = Args.back().RV;
-EmitNonNullArgCheck(RVArg, ArgTypes[Idx], (*Arg)->getExprLoc(), AC,
-ParamsToSkip + Idx);
-// @llvm.objectsize s
SjoerdMeijer created this revision.
SjoerdMeijer added reviewers: az, evandro, olista01.
Herald added subscribers: kristof.beyls, javed.absar, rengolin.
Add 2 vmulxh_lane vector intrinsics that were commented out.
https://reviews.llvm.org/D44222
Files:
include/clang/Basic/arm_neon.td
test/C
rjmccall accepted this revision.
rjmccall added a comment.
This revision is now accepted and ready to land.
LGTM.
https://reviews.llvm.org/D44221
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/
lebedev.ri added a comment.
In https://reviews.llvm.org/D41102#1028995, @lebedev.ri wrote:
> Some further notes based on the SHA1 nature.
I'm sorry, brainfreeze, i meant `40` chars, not `20`.
Updated comments...
Comment at: clang-doc/BitcodeWriter.cpp:309
+ assert(Ref.USR.s
rnk created this revision.
rnk added a reviewer: rjmccall.
This provides no measurable build speedup, but it reinstates an
optimization from r112038 that was lost in r179618. It requires moving
CapturedScopeInfo::Capture out to clang::sema, which might be too
general since we have plenty of other
devnexen updated this revision to Diff 137448.
https://reviews.llvm.org/D44069
Files:
test/Driver/fsanitize.c
Index: test/Driver/fsanitize.c
===
--- test/Driver/fsanitize.c
+++ test/Driver/fsanitize.c
@@ -388,6 +388,25 @@
// RUN
rnk added a comment.
Thanks!
John touched this code last in https://reviews.llvm.org/rL112038 in 2010, so
maybe he has some thoughts on how to clean this and the follow-up. I think I'll
land this as is since it fixes the crash and we can discuss more improvements
in https://reviews.llvm.org/D4
devnexen updated this revision to Diff 137447.
https://reviews.llvm.org/D44069
Files:
test/Driver/fsanitize.c
Index: test/Driver/fsanitize.c
===
--- test/Driver/fsanitize.c
+++ test/Driver/fsanitize.c
@@ -388,6 +388,21 @@
// RUN
This revision was automatically updated to reflect the committed changes.
Closed by commit rC326937: [OpenCL] Remove block invoke function from emitted
block literal struct (authored by yaxunl, committed by ).
Repository:
rC Clang
https://reviews.llvm.org/D43783
Files:
lib/CodeGen/CGBlocks.
Author: yaxunl
Date: Wed Mar 7 11:32:58 2018
New Revision: 326937
URL: http://llvm.org/viewvc/llvm-project?rev=326937&view=rev
Log:
[OpenCL] Remove block invoke function from emitted block literal struct
OpenCL runtime tracks the invoke function emitted for
any block expression. Due to restricti
This revision was automatically updated to reflect the committed changes.
Closed by commit rC326935: [analyzer] [NFC] Minor refactoring of
NonNullParamChecker (authored by george.karpenkov, committed by ).
Herald added a subscriber: cfe-commits.
Repository:
rC Clang
https://reviews.llvm.org/D4
Author: george.karpenkov
Date: Wed Mar 7 11:27:32 2018
New Revision: 326935
URL: http://llvm.org/viewvc/llvm-project?rev=326935&view=rev
Log:
[analyzer] [NFC] Minor refactoring of NonNullParamChecker
Differential Revision: https://reviews.llvm.org/D43917
Modified:
cfe/trunk/lib/StaticAnalyz
On Sat, Feb 24, 2018 at 7:17 PM, Marshall Clow
wrote:
> On Thu, Feb 22, 2018 at 7:58 AM, Nico Weber wrote:
>
>> I have a small personal project where I used to use this. I tried
>> switching to instead, but that apparently requires -std=c++17.
>> With that, things build fine with my locally-bui
1 - 100 of 151 matches
Mail list logo
