kito-cheng marked 2 inline comments as done.
kito-cheng added inline comments.
================
Comment at: lib/Driver/ToolChains/Arch/RISCV.cpp:48
+ break;
+ default:
+ // First letter should be 'i' or 'g'.
----------------
apazos wrote:
> In the switch cases move default to first position.
Done :)
================
Comment at: lib/Driver/ToolChains/Arch/RISCV.cpp:60
case 'm':
Features.push_back("+m");
break;
----------------
apazos wrote:
> So the subsequent features can appear in any order?
Yeah, here is a canonical order specified in ISA manual, I've check the order
now.
Repository:
rC Clang
https://reviews.llvm.org/D44189
_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
