rnk accepted this revision.
rnk added a comment.
This revision is now accepted and ready to land.
lgtm
================
Comment at: lib/CodeGen/MicrosoftCXXABI.cpp:1207
uint64_t ConstantVBaseOffset =
- Layout.getVBaseClassOffset(I->first).getQuantity();
+ Layout.getVBaseClassOffset(VBase).getQuantity();
----------------
The `getVBaseClassOffset` call turns around and does the same hashtable lookup
we just did. Let's keep the iterator around and say
`I->second.VBaseOffset.getQuantity()`.
https://reviews.llvm.org/D44223
_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
