r298487 - Move setting of LangOpts based on target flags out of CompilerInstance

Author: echristo Date: Wed Mar 22 01:36:09 2017 New Revision: 298487 URL: http://llvm.org/viewvc/llvm-project?rev=298487&view=rev Log: Move setting of LangOpts based on target flags out of CompilerInstance and into TargetInfo::adjust so that it gets called in more places throughout the compiler (A

[PATCH] D31234: Implement P0599 - noexcept for hash functions

mclow.lists created this revision. Mark most of the hash functions provided by libc++ as noexcept; the exceptions being `optional` and `variant`. Tests to ensure this. There's still some investigation to be done on `unique_ptr` and fancy pointer support, but that can come later. https://revie

Re: [clang-tools-extra] r298421 - Prevent cppcoreguidelines-pro-bounds-array-to-pointer-decay from diagnosing array to pointer decay stemming from system macros.

Hi, Thanks for the suggestions. I actually had tested with a fake header file (so I could build more interesting testcases) but it didn't occur to me to actually make it part of the codebase test. I was afraid of being too kind to exempt PredefinedExpr symbols in any context, and that's why I onl

Re: [clang-tools-extra] r298421 - Prevent cppcoreguidelines-pro-bounds-array-to-pointer-decay from diagnosing array to pointer decay stemming from system macros.

On 21 March 2017 at 18:57, Breno Guimarães via cfe-commits < cfe-commits@lists.llvm.org> wrote: > Hey guys, > > I'm sorry the test did not make the decay explicit. It's indeed sort of > tricky: https://bugs.llvm.org/show_bug.cgi?id=32239 > > Basically, assert is expanded into: > > (__builtin_expec

[PATCH] D30018: [XRay] Add __xray_customeevent(...) as a clang-supported builtin

dberris added a reviewer: rnk. dberris added a subscriber: rnk. dberris added a comment. @rnk -- if you have time, a review for this would be appreciated too. https://reviews.llvm.org/D30018 ___ cfe-commits mailing list cfe-commits@lists.llvm.org ht

[PATCH] D31069: Don't warn about an unreachable fallthrough annotation in a template function

This revision was automatically updated to reflect the committed changes. Closed by commit rL298477: Suppress warning on unreachable [[clang::fallthrough]] within a template… (authored by rsmith). Changed prior to commit: https://reviews.llvm.org/D31069?vs=92104&id=92588#toc Repository: rL L

r298477 - Suppress warning on unreachable [[clang::fallthrough]] within a template instantiation.

Author: rsmith Date: Tue Mar 21 20:49:19 2017 New Revision: 298477 URL: http://llvm.org/viewvc/llvm-project?rev=298477&view=rev Log: Suppress warning on unreachable [[clang::fallthrough]] within a template instantiation. We don't know whether some other instantiation of the template might be abl

Re: [clang-tools-extra] r298421 - Prevent cppcoreguidelines-pro-bounds-array-to-pointer-decay from diagnosing array to pointer decay stemming from system macros.

Hey guys, I'm sorry the test did not make the decay explicit. It's indeed sort of tricky: https://bugs.llvm.org/show_bug.cgi?id=32239 Basically, assert is expanded into: (__builtin_expect(!(e), 0) ? __assert_rtn(__func__, __FILE__, __LINE__, #e) Well, __func__ and __FILE__ are const char[], wh

[PATCH] D31210: [AMDGPU] Add new address space mapping

yaxunl updated this revision to Diff 92587. yaxunl added a comment. Fix getDWARFAddressSpace. https://reviews.llvm.org/D31210 Files: include/clang/Driver/Options.td lib/Basic/Targets.cpp test/CodeGenOpenCL/amdgpu-new-addr.cl Index: test/CodeGenOpenCL/amdgpu-new-addr.cl ==

[PATCH] D30760: Record command lines in objects built by clang

aprantl added a comment. In https://reviews.llvm.org/D30760#707178, @zhizhouy wrote: > Hi aprantl, thanks for replying. I checked the usage of DwarfDebugFlags, it > seems that it really did the same work of recording command line options. > > And I noticed that it is set to false by default. Is

Re: [clang-tools-extra] r298421 - Prevent cppcoreguidelines-pro-bounds-array-to-pointer-decay from diagnosing array to pointer decay stemming from system macros.

Thank you! On 21 March 2017 at 18:22, Aaron Ballman wrote: > On Tue, Mar 21, 2017 at 9:15 PM, Richard Smith > wrote: > > On 21 March 2017 at 12:01, Aaron Ballman via cfe-commits > > wrote: > >> > >> Author: aaronballman > >> Date: Tue Mar 21 14:01:17 2017 > >> New Revision: 298421 > >> > >> UR

[PATCH] D22391: [Sema] Add warning for implicitly casting a null constant to a non null pointer type

ahatanak updated this revision to Diff 92583. ahatanak added a comment. Rebase and ping. https://reviews.llvm.org/D22391 Files: include/clang/Basic/DiagnosticGroups.td include/clang/Basic/DiagnosticSemaKinds.td include/clang/Sema/Sema.h lib/Sema/SemaChecking.cpp lib/Sema/SemaDecl.cpp

[PATCH] D31130: B32239 clang-tidy should not warn about array to pointer decay on system macros

aaron.ballman reopened this revision. aaron.ballman added a comment. This revision is now accepted and ready to land. This change was reverted in r298470. The use of the include is a problem because this is not a clang-supplied header file. Also, there's a (good) question about what array decay

Re: [clang-tools-extra] r298421 - Prevent cppcoreguidelines-pro-bounds-array-to-pointer-decay from diagnosing array to pointer decay stemming from system macros.

On Tue, Mar 21, 2017 at 9:15 PM, Richard Smith wrote: > On 21 March 2017 at 12:01, Aaron Ballman via cfe-commits > wrote: >> >> Author: aaronballman >> Date: Tue Mar 21 14:01:17 2017 >> New Revision: 298421 >> >> URL: http://llvm.org/viewvc/llvm-project?rev=298421&view=rev >> Log: >> Prevent cppc

[clang-tools-extra] r298470 - Reverting r298421 due to using a header that's unavailable to all systems and some other post-commit review feedback.

Author: aaronballman Date: Tue Mar 21 20:08:54 2017 New Revision: 298470 URL: http://llvm.org/viewvc/llvm-project?rev=298470&view=rev Log: Reverting r298421 due to using a header that's unavailable to all systems and some other post-commit review feedback. Modified: clang-tools-extra/trunk/

Re: [clang-tools-extra] r298421 - Prevent cppcoreguidelines-pro-bounds-array-to-pointer-decay from diagnosing array to pointer decay stemming from system macros.

On 21 March 2017 at 12:01, Aaron Ballman via cfe-commits < cfe-commits@lists.llvm.org> wrote: > Author: aaronballman > Date: Tue Mar 21 14:01:17 2017 > New Revision: 298421 > > URL: http://llvm.org/viewvc/llvm-project?rev=298421&view=rev > Log: > Prevent cppcoreguidelines-pro-bounds-array-to-point

r298469 - Remove -ffp-contract=fast from this test

Author: anemet Date: Tue Mar 21 19:58:18 2017 New Revision: 298469 URL: http://llvm.org/viewvc/llvm-project?rev=298469&view=rev Log: Remove -ffp-contract=fast from this test It does not need it and causes mismatch after -ffp-contract=fast is turned into an FMF. Modified: cfe/trunk/test/CodeG

r298468 - Change -ffp-contract=fast test to run on Aarch64

Author: anemet Date: Tue Mar 21 19:58:15 2017 New Revision: 298468 URL: http://llvm.org/viewvc/llvm-project?rev=298468&view=rev Log: Change -ffp-contract=fast test to run on Aarch64 (I don't have powerpc enabled in my build and I am changing how -ffp-contract=fast works.) Modified: cfe/trunk

Buildbot numbers for the week of 03/12/2017 - 03/18/2017

Hello everyone, Below are some buildbot numbers for the last week of 03/12/2017 - 03/18/2017. Please see the same data in attached csv files: The longest time each builder was red during the last week; "Status change ratio" by active builder (percent of builds that changed the builder status fro

Buildbot numbers for the week of 03/05/2017 - 03/11/2017

Hello everyone, Below are some buildbot numbers for the week of 03/05/2017 - 03/11/2017. Please see the same data in attached csv files: The longest time each builder was red during the last week; "Status change ratio" by active builder (percent of builds that changed the builder status from gre

[PATCH] D30283: [ubsan] Reduce alignment checking of C++ object pointers

efriedma added inline comments. Comment at: test/CodeGenCXX/ubsan-global-alignment.cpp:9 +extern S1 S1_array[]; +extern S1 *S1ptr_array[]; + Probably a good idea to also test extern globals which aren't arrays; arrays are sort of a special-case due to array->poi

[PATCH] D30760: Record command lines in objects built by clang

zhizhouy added a comment. Hi aprantl, thanks for replying. I checked the usage of DwarfDebugFlags, it seems that it really did the same work of recording command line options. And I noticed that it is set to false by default. Is it because of some concerns like the debug info size? Is it prope

Re: [PATCH] D30760: Record command lines in objects built by clang

I think that's a good idea. On Tue, Mar 21, 2017 at 5:19 PM Adrian Prantl via Phabricator < revi...@reviews.llvm.org> wrote: > aprantl added a comment. > > Sorry for being late to the party, but have you looked at > CodeGenOptions::DwarfDebugFlags? It looks like it almost does what you > want, bu

[PATCH] D30810: Preserve vec3 type.

jaykang10 added a comment. In https://reviews.llvm.org/D30810#706677, @Anastasia wrote: > In https://reviews.llvm.org/D30810#706676, @Anastasia wrote: > > > In https://reviews.llvm.org/D30810#699428, @Anastasia wrote: > > > > > Would you be able to update ScalarExprEmitter::VisitAsTypeExpr > > >

r298464 - [Modules] Rebuild modules on umbrella header mismatch

Author: bruno Date: Tue Mar 21 19:11:21 2017 New Revision: 298464 URL: http://llvm.org/viewvc/llvm-project?rev=298464&view=rev Log: [Modules] Rebuild modules on umbrella header mismatch This restores behavior pre-r230064 since after PCMCache work (r298278) we don't reload PCMs from disk within th

[PATCH] D30283: [ubsan] Reduce alignment checking of C++ object pointers

vsk updated this revision to Diff 92572. vsk added a comment. Add a test which shows that we don't regress alignment-checking when accessing extern variables. https://reviews.llvm.org/D30283 Files: lib/CodeGen/CGExpr.cpp lib/CodeGen/CGExprCXX.cpp lib/CodeGen/CodeGenFunction.cpp test/Co

[PATCH] D30760: Record command lines in objects built by clang

aprantl added a comment. Sorry for being late to the party, but have you looked at CodeGenOptions::DwarfDebugFlags? It looks like it almost does what you want, but it is currently only enabled for MachO and when a specific environment variable is set. Would it make sense to generalize that mech

[PATCH] D30283: [ubsan] Reduce alignment checking of C++ object pointers

vsk added a comment. In https://reviews.llvm.org/D30283#707007, @efriedma wrote: > It's possible to misalign a global definition by misaligning its section with > a linker script... but we can probably ignore that possibility. The current implementation does ignore this case. > It's very easy

[PATCH] D31210: [AMDGPU] Add new address space mapping

yaxunl added a comment. In https://reviews.llvm.org/D31210#707014, @scchan wrote: > In https://reviews.llvm.org/D31210#706955, @yaxunl wrote: > > > In https://reviews.llvm.org/D31210#706890, @kzhuravl wrote: > > > > > In https://reviews.llvm.org/D31210#706880, @rampitec wrote: > > > > > > > I'm c

[PATCH] D30954: Modules: Simulate diagnostic settings for implicit modules

rsmith accepted this revision. rsmith added a comment. This revision is now accepted and ready to land. LGTM > - The patch-as-is checks whether pragmas should be demoted to warnings for > all AST files, not just implicit modules. I can add a bit of logic to > `ReadPragmaDiagnosticMappings` that

[PATCH] D31168: Set FMF for -ffp-contract=fast rather than a TargetConfig

anemet updated this revision to Diff 92564. anemet added a comment. Address Akira's comments https://reviews.llvm.org/D31168 Files: lib/CodeGen/CGExprScalar.cpp test/CodeGen/ffp-contract-fast-option.c Index: test/CodeGen/ffp-contract-fast-option.c =

[PATCH] D31168: Set FMF for -ffp-contract=fast rather than a TargetConfig

anemet added a comment. Thanks, Akira. You're right on both accounts. I actually had a test written but failed to git add it. https://reviews.llvm.org/D31168 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/ma

[PATCH] D31210: [AMDGPU] Add new address space mapping

scchan added a comment. In https://reviews.llvm.org/D31210#706955, @yaxunl wrote: > In https://reviews.llvm.org/D31210#706890, @kzhuravl wrote: > > > In https://reviews.llvm.org/D31210#706880, @rampitec wrote: > > > > > I'm concerned about the default address space to be 64 bit. It would move >

[PATCH] D30283: [ubsan] Reduce alignment checking of C++ object pointers

efriedma added a comment. It's possible to misalign a global definition by misaligning its section with a linker script... but we can probably ignore that possibility. It's very easy to misalign global declaration, though; for example: a.c: extern int a[]; int f(int x) { return a[x]; } b.

[PATCH] D31219: Update the SamplePGO test to verify that unroll/icp is not invoked in thinlto compile phase.

danielcdh created this revision. Herald added a subscriber: Prazek. This is the test added for https://reviews.llvm.org/D31217 https://reviews.llvm.org/D31219 Files: test/CodeGen/Inputs/pgo-sample-thinlto-summary.prof test/CodeGen/pgo-sample-thinlto-summary.c Index: test/CodeGen/pgo-sampl

[PATCH] D30283: [ubsan] Reduce alignment checking of C++ object pointers

vsk added a comment. Hi Eli, thanks for your feedback :). In https://reviews.llvm.org/D30283#702085, @efriedma wrote: > I'm not sure we actually want to skip these checks for DeclRefExps. I mean, > you can rely on the backend to correctly align a local variable (assuming the > stack is correc

[PATCH] D30415: Fix -mno-altivec cannot overwrite -maltivec option

echristo added a comment. In https://reviews.llvm.org/D30415#706370, @sfertile wrote: > > I have a patch to do this now. I'll plan on committing it in a bit. > > Is there a way to mark the -f form of the option as deprecated? We should > warn and suggest users switch to the -maltivec option for

r298449 - Remove the -faltivec alias option and replace it with -maltivec everywhere.

Author: echristo Date: Tue Mar 21 17:06:18 2017 New Revision: 298449 URL: http://llvm.org/viewvc/llvm-project?rev=298449&view=rev Log: Remove the -faltivec alias option and replace it with -maltivec everywhere. The alias was only ever used on darwin and had some issues there, and isn't used in pra

[PATCH] D31210: [AMDGPU] Add new address space mapping

yaxunl added a comment. In https://reviews.llvm.org/D31210#706890, @kzhuravl wrote: > In https://reviews.llvm.org/D31210#706880, @rampitec wrote: > > > I'm concerned about the default address space to be 64 bit. It would move > > alloca into generic address space effectively making private addre

r298446 - Add support for -fno-auto-profile and -fno-profile-sample-use

Author: dehao Date: Tue Mar 21 16:40:53 2017 New Revision: 298446 URL: http://llvm.org/viewvc/llvm-project?rev=298446&view=rev Log: Add support for -fno-auto-profile and -fno-profile-sample-use Summary: We need to be able to disable samplepgo for specific files by supporting -fno-auto-profile an

[PATCH] D31213: Add support for -fno-auto-profile and -fno-profile-sample-use

echristo accepted this revision. echristo added a comment. This revision is now accepted and ready to land. LGTM. -eric https://reviews.llvm.org/D31213 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/li

[PATCH] D31213: Add support for -fno-auto-profile and -fno-profile-sample-use

danielcdh updated this revision to Diff 92554. danielcdh added a comment. add more test https://reviews.llvm.org/D31213 Files: include/clang/Driver/Options.td lib/Driver/ToolChains/Clang.cpp lib/Driver/ToolChains/CommonArgs.cpp lib/Driver/ToolChains/CommonArgs.h test/Driver/clang_f_op

r298443 - Apply clang-tidy's performance-unnecessary-value-param to parts of clang.

Author: d0k Date: Tue Mar 21 16:35:04 2017 New Revision: 298443 URL: http://llvm.org/viewvc/llvm-project?rev=298443&view=rev Log: Apply clang-tidy's performance-unnecessary-value-param to parts of clang. No functionality change intended. Modified: cfe/trunk/include/clang/Driver/ToolChain.h

[clang-tools-extra] r298442 - Apply clang-tidy's performance-unnecessary-value-param to clang-tidy.

Author: d0k Date: Tue Mar 21 16:34:58 2017 New Revision: 298442 URL: http://llvm.org/viewvc/llvm-project?rev=298442&view=rev Log: Apply clang-tidy's performance-unnecessary-value-param to clang-tidy. No functionality change intended. Modified: clang-tools-extra/trunk/clang-tidy/cppcoreguide

Re: r298392 - [index/AST] Determine if a typedef shares a name and spelling location with its underlying tag type

Fixed in r298441, thanks! > On Mar 21, 2017, at 2:05 PM, Vitaly Buka wrote: > > Could you please take a look at these leaks > > http://lab.llvm.org:8011/builders/sanitizer-x86_64-linux-fast/builds/3606/steps/check-clang%20asan/logs/stdio > >

[PATCH] D31213: Add support for -fno-auto-profile and -fno-profile-sample-use

echristo added a comment. Can you add a test for fno-auto-profile? https://reviews.llvm.org/D31213 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

r298441 - [c-index-test] Fix memory leak in c-index-test tool.

Author: akirtzidis Date: Tue Mar 21 16:34:05 2017 New Revision: 298441 URL: http://llvm.org/viewvc/llvm-project?rev=298441&view=rev Log: [c-index-test] Fix memory leak in c-index-test tool. Modified: cfe/trunk/tools/c-index-test/c-index-test.c Modified: cfe/trunk/tools/c-index-test/c-index-t

[PATCH] D31213: Add support for -fno-auto-profile and -fno-profile-sample-use

danielcdh created this revision. We need to be able to disable samplepgo for specific files by supporting -fno-auto-profile and -fno-profile-sample-use https://reviews.llvm.org/D31213 Files: include/clang/Driver/Options.td lib/Driver/ToolChains/Clang.cpp lib/Driver/ToolChains/CommonArgs.

[PATCH] D30760: Record command lines in objects built by clang

echristo requested changes to this revision. echristo added a comment. This revision now requires changes to proceed. Why aren't we passing the flags down as a string in the IR? Needs a testcase: you should only check for IR in clang tests. To make sure something is propagated to the other end u

[PATCH] D31210: [AMDGPU] Add new address space mapping

kzhuravl added a comment. In https://reviews.llvm.org/D31210#706880, @rampitec wrote: > I'm concerned about the default address space to be 64 bit. It would move > alloca into generic address space effectively making private address to be 64 > bit. > This may have very undesirable performance

[PATCH] D30760: Record command lines in objects built by clang

zhizhouy updated this revision to Diff 92546. zhizhouy marked 3 inline comments as done. zhizhouy edited the summary of this revision. zhizhouy added a reviewer: dblaikie. zhizhouy added a comment. Herald added a subscriber: mehdi_amini. Fixed George's comments. Still need to create a test for th

[PATCH] D31210: [AMDGPU] Add new address space mapping

rampitec added a comment. I'm concerned about the default address space to be 64 bit. It would move alloca into generic address space effectively making private address to be 64 bit. This may have very undesirable performance implications, like address arithmetic can become expensive 64 bit and

[PATCH] D31210: [AMDGPU] Add new address space mapping

kzhuravl added a comment. getDWARFAddressSpace also needs to be updated. https://reviews.llvm.org/D31210 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D31210: [AMDGPU] Add new address space mapping

yaxunl created this revision. Herald added subscribers: Anastasia, tpr, dstuttard, nhaehnle, wdng, kzhuravl. A new target feature new-addr is added. When it is on, AMDGPU uses new address space mapping where generic address space is 0 and private address space is 5. The data layout is also chang

RE: r298410 - Correct class-template deprecation behavior

Thanks, and yes, the PS4 target has slightly different defaults for both C and C++. I should have mentioned that in my original email, but I also was running out to lunch. :) Sorry about that. Douglas Yung > -Original Message- > From: Keane, Erich [mailto:erich.ke...@intel.com] > Sent:

[libcxx] r298438 - Fix test failure I introduced

Author: marshall Date: Tue Mar 21 16:05:28 2017 New Revision: 298438 URL: http://llvm.org/viewvc/llvm-project?rev=298438&view=rev Log: Fix test failure I introduced Modified: libcxx/trunk/include/type_traits Modified: libcxx/trunk/include/type_traits URL: http://llvm.org/viewvc/llvm-project

Re: r298392 - [index/AST] Determine if a typedef shares a name and spelling location with its underlying tag type

Could you please take a look at these leaks http://lab.llvm.org:8011/builders/sanitizer-x86_64-linux-fast/builds/3606/steps/check-clang%20asan/logs/stdio = ==32547==ERROR: LeakSanitizer: detected memory leaks Direct leak of 24 byte

[PATCH] D30547: [clang-tidy] Forwarding reference overload in constructors

leanil updated this revision to Diff 92542. leanil added a comment. Suppress warning only on std::enable_if. Make note on copy and move constructors. Repository: rL LLVM https://reviews.llvm.org/D30547 Files: clang-tidy/misc/CMakeLists.txt clang-tidy/misc/ForwardingReferenceOverloadCheck

RE: r298410 - Correct class-template deprecation behavior

Ended up being simpler than I expected. I added -r298433 To fix this. The issue is that the test had a conditional based on the "C" version, so I explicitly added a test for C89 and C99, which the PS4 is apparently not defaulting to. Thanks! -Erich -Original Message- From: Yung, D

[clang-tools-extra] r298434 - Don't make unqualified calls to functions that could well be found via

Author: chandlerc Date: Tue Mar 21 15:15:42 2017 New Revision: 298434 URL: http://llvm.org/viewvc/llvm-project?rev=298434&view=rev Log: Don't make unqualified calls to functions that could well be found via ADL as reasonable extension points. All of this would be cleaner if this code followed the

r298433 - iFix Test deprecation behavior in C89 mode as a result of r298410

Author: erichkeane Date: Tue Mar 21 15:14:46 2017 New Revision: 298433 URL: http://llvm.org/viewvc/llvm-project?rev=298433&view=rev Log: iFix Test deprecation behavior in C89 mode as a result of r298410 Modified: cfe/trunk/test/Sema/attr-deprecated.c Modified: cfe/trunk/test/Sema/attr-deprec

r298431 - Let llvm.objectsize be conservative with null pointers

Author: gbiv Date: Tue Mar 21 15:09:35 2017 New Revision: 298431 URL: http://llvm.org/viewvc/llvm-project?rev=298431&view=rev Log: Let llvm.objectsize be conservative with null pointers D28494 adds another parameter to @llvm.objectsize. Clang needs to be sure to pass that third arg whenever appli

RE: r298410 - Correct class-template deprecation behavior

I saw that, I was digging into it, then went to lunch. I'm hoping to push a fix by EOD if I can. Thanks for the heads up though! -Original Message- From: Yung, Douglas [mailto:douglas.y...@sony.com] Sent: Tuesday, March 21, 2017 12:59 PM To: Keane, Erich Cc: cfe-commits Subject: RE:

[PATCH] D31168: Set FMF for -ffp-contract=fast rather than a TargetConfig

ahatanak added a comment. I think you can add a test case in this patch (after the llvm changes are checked in)? Comment at: lib/CodeGen/CGExprScalar.cpp:262 +ApplyFPFeatures(llvm::IRBuilderBase &Builder, Expr *E) +: CGBuilderTy::FastMathFlagGuard(Builder) { +

Re: [PATCH] D31140: [LLVMbugs] [Bug 18710] Only generate .ARM.exidx and .ARM.extab when needed in EHABI

On 3/21/17 1:53 PM, Christian Bruel via Phabricator wrote: chrib added a comment. In https://reviews.llvm.org/D31140#706411, @jroelofs wrote: Can you clarify the logic here? It's my understanding that: `-fno-exceptions` does *not* imply `-fno-unwind-tables` however: `-fno-unwind-tables` *

[PATCH] D30954: Modules: Simulate diagnostic settings for implicit modules

dexonsmith added a comment. Ping! https://reviews.llvm.org/D30954 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

r298429 - Clang change: Do not inline hot callsites for samplepgo in thinlto compile phase.

Author: dehao Date: Tue Mar 21 14:55:46 2017 New Revision: 298429 URL: http://llvm.org/viewvc/llvm-project?rev=298429&view=rev Log: Clang change: Do not inline hot callsites for samplepgo in thinlto compile phase. Summary: Because SamplePGO passes will be invoked twice in ThinLTO build: once at

[PATCH] D31177: [ARC][ObjC++] Use ObjC semantic rules for comparisons between a pointer and objective-c object pointer

ahatanak added inline comments. Comment at: lib/Sema/SemaExpr.cpp:9431 + ? 2 + : 1)) { if (convertPointersToCompositeType(*this, Loc, LHS, RHS)) It wasn't clear to me why the code has to be added to the right hand side of the >= op

[PATCH] D28952: [analyzer] Add new Z3 constraint manager backend

ddcc added inline comments. Comment at: lib/StaticAnalyzer/Core/Z3ConstraintManager.cpp:60 +// Set timeout to 15000ms = 15s +Z3_set_param_value(Config, "timeout", "15000"); + } xazax.hun wrote: > Sorry for being a bit late in the party, I was wondering w

RE: r298410 - Correct class-template deprecation behavior

Hi Erich, Your change is causing the Sema/attr-deprecated.c test to fail on the PS4 bot (http://lab.llvm.org:8011/builders/llvm-clang-lld-x86_64-scei-ps4-windows10pro-fast/builds/7087). Can you take a look? Douglas Yung > -Original Message- > From: cfe-commits [mailto:cfe-commits-boun.

[PATCH] D31140: [LLVMbugs] [Bug 18710] Only generate .ARM.exidx and .ARM.extab when needed in EHABI

chrib added a comment. In https://reviews.llvm.org/D31140#706411, @jroelofs wrote: > Can you clarify the logic here? It's my understanding that: > > `-fno-exceptions` does *not* imply `-fno-unwind-tables` > > however: > > `-fno-unwind-tables` *does* imply that exceptions cannot be used on targets

[PATCH] D31202: Clang change: Do not inline hot callsites for samplepgo in thinlto compile phase.

tejohnson accepted this revision. tejohnson added a comment. This revision is now accepted and ready to land. LGTM https://reviews.llvm.org/D31202 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo

r298426 - [X86][MS-compatability][clang] allow MS TYPE/SIZE/LENGTH operators as a part of a compound expression

Author: coby Date: Tue Mar 21 14:33:32 2017 New Revision: 298426 URL: http://llvm.org/viewvc/llvm-project?rev=298426&view=rev Log: [X86][MS-compatability][clang] allow MS TYPE/SIZE/LENGTH operators as a part of a compound expression This patch introduces X86AsmParser with the ability to handle t

[PATCH] D31174: [X86][MS-compatability] allow MS TYPE/SIZE/LENGTH operators as a part of a compound expression

This revision was automatically updated to reflect the committed changes. Closed by commit rL298426: [X86][MS-compatability][clang] allow MS TYPE/SIZE/LENGTH operators as a part of… (authored by coby). Changed prior to commit: https://reviews.llvm.org/D31174?vs=92437&id=92529#toc Repository:

Re: [PATCH] D30415: Fix -mno-altivec cannot overwrite -maltivec option

On 03/21/2017 12:19 PM, Ulrich Weigand via Phabricator wrote: uweigand added a comment. In https://reviews.llvm.org/D30415#705889, @echristo wrote: In https://reviews.llvm.org/D30415#705196, @uweigand wrote: Well, mainline GCC doesn't have -faltivec at all and never had, I think this was o

[PATCH] D31202: Clang change: Do not inline hot callsites for samplepgo in thinlto compile phase.

danielcdh created this revision. Herald added subscribers: Prazek, mehdi_amini. Because SamplePGO passes will be invoked twice in ThinLTO build: once at compile phase, the other at backend. We want to make sure the IR at the 2nd phase matches the hot part in pro file, thus we do not want to inli

r298424 - [CMake] fix CLANG_INCLUDE_DIRS CMake export

Author: papin_g Date: Tue Mar 21 14:17:53 2017 New Revision: 298424 URL: http://llvm.org/viewvc/llvm-project?rev=298424&view=rev Log: [CMake] fix CLANG_INCLUDE_DIRS CMake export Summary: This change should fixes the export of CLANG_INCLUDE_DIRS variable in ClangConfig.cmake. Unlike for the othe

[libcxx] r298422 - Fix a couple of 'C++11'-isms from the last checkin, which broke the '03 bot.

Author: marshall Date: Tue Mar 21 14:12:21 2017 New Revision: 298422 URL: http://llvm.org/viewvc/llvm-project?rev=298422&view=rev Log: Fix a couple of 'C++11'-isms from the last checkin, which broke the '03 bot. Modified: libcxx/trunk/include/type_traits libcxx/trunk/test/std/utilities/t

[PATCH] D31130: B32239 clang-tidy should not warn about array to pointer decay on system macros

aaron.ballman closed this revision. aaron.ballman added a comment. I've commit in r298421. https://reviews.llvm.org/D31130 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang-tools-extra] r298421 - Prevent cppcoreguidelines-pro-bounds-array-to-pointer-decay from diagnosing array to pointer decay stemming from system macros.

Author: aaronballman Date: Tue Mar 21 14:01:17 2017 New Revision: 298421 URL: http://llvm.org/viewvc/llvm-project?rev=298421&view=rev Log: Prevent cppcoreguidelines-pro-bounds-array-to-pointer-decay from diagnosing array to pointer decay stemming from system macros. Patch by Breno Rodrigues Guim

[PATCH] D30845: Fix array sizes where address space is not yet known

This revision was automatically updated to reflect the committed changes. kzhuravl marked an inline comment as done. Closed by commit rL298420: Fix array sizes where address space is not yet known (authored by kzhuravl). Changed prior to commit: https://reviews.llvm.org/D30845?vs=91404&id=92523

r298420 - Fix array sizes where address space is not yet known

Author: kzhuravl Date: Tue Mar 21 13:55:39 2017 New Revision: 298420 URL: http://llvm.org/viewvc/llvm-project?rev=298420&view=rev Log: Fix array sizes where address space is not yet known For variables in generic address spaces, for example: ``` unsigned char V[6442450944]; ... ``` the address

[PATCH] D31153: Add the ability to use the children() range API in a const-correct manner

aaron.ballman updated this revision to Diff 92522. aaron.ballman added a comment. Missed a case for `UnaryExprOrTypeTraitExpr`. https://reviews.llvm.org/D31153 Files: include/clang/AST/Expr.h include/clang/AST/StmtIterator.h lib/AST/Expr.cpp Index: lib/AST/Expr.cpp ==

[PATCH] D30810: Preserve vec3 type.

Anastasia added a comment. In https://reviews.llvm.org/D30810#706676, @Anastasia wrote: > In https://reviews.llvm.org/D30810#699428, @Anastasia wrote: > > > Would you be able to update ScalarExprEmitter::VisitAsTypeExpr > > implementation accordingly to make things consistent? > > > Not sure it

[PATCH] D30810: Preserve vec3 type.

Anastasia added a comment. In https://reviews.llvm.org/D30810#699428, @Anastasia wrote: > Would you be able to update ScalarExprEmitter::VisitAsTypeExpr implementation > accordingly to make things consistent? Not sure it got lost somewhere... do you think you could address this too? https://

[PATCH] D30810: Preserve vec3 type.

Anastasia added a comment. > Hi Anastasia, Bruno, > > Do you still have other opinion? or Can we go ahead and commit this patch? I would like to see this patch committed. I see clear evidence of it improving existing GPU targets in the master repo as well as outside of the main tree implemen

[libcxx] r298418 - Add a bit more to one of the chrono tests

Author: marshall Date: Tue Mar 21 13:40:46 2017 New Revision: 298418 URL: http://llvm.org/viewvc/llvm-project?rev=298418&view=rev Log: Add a bit more to one of the chrono tests Modified: libcxx/trunk/test/std/utilities/time/time.duration/time.duration.arithmetic/op_+.pass.cpp Modified: lib

[libcxx] r298416 - Implement P0548: 'common_type and duration' This involves a subtle change in the return type of the unary +/- operators for std::chrono::duration, though I expect that no one will n

Author: marshall Date: Tue Mar 21 13:38:57 2017 New Revision: 298416 URL: http://llvm.org/viewvc/llvm-project?rev=298416&view=rev Log: Implement P0548: 'common_type and duration' This involves a subtle change in the return type of the unary +/- operators for std::chrono::duration, though I expec

[PATCH] D31134: [Serialization] Serialize DependentSizedExtVectorType

bruno accepted this revision. bruno added a comment. This revision is now accepted and ready to land. LGTM Alex, thanks! Repository: rL LLVM https://reviews.llvm.org/D31134 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm

r298414 - Modules: Remove an invalid check in unit tests for r298278

Author: dexonsmith Date: Tue Mar 21 13:26:18 2017 New Revision: 298414 URL: http://llvm.org/viewvc/llvm-project?rev=298414&view=rev Log: Modules: Remove an invalid check in unit tests for r298278 This is a fixup for the unit tests from r298278 (originally r298165). Since the buffer that RawB2 po

Re: FW: SemaAccess bug (protected members of derived)

Thanks, It looks like your solution isn't quite right as it causes Clang to accept invalid access to protected members, e.g. as tested by "test/CXX/class.access/class.protected/p1.cpp". Do you think there's an alternative solution that you could use? Alex On 21 March 2017 at 14:48, Dixon Ryan (

[PATCH] D31130: B32239 clang-tidy should not warn about array to pointer decay on system macros

brenoguim added a comment. I appreciate it! https://reviews.llvm.org/D31130 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D31130: B32239 clang-tidy should not warn about array to pointer decay on system macros

aaron.ballman added a comment. In https://reviews.llvm.org/D31130#706623, @brenoguim wrote: > Hi @aaron.ballman, > > Thanks for the review! > > I don't have rights to push this. Who should I contact to push the change in > my behalf? I'm happy to do so on your behalf (it'll happen later this a

[PATCH] D31130: B32239 clang-tidy should not warn about array to pointer decay on system macros

brenoguim marked 4 inline comments as done. brenoguim added a comment. Hi @aaron.ballman, Thanks for the review! I don't have rights to push this. Who should I contact to push the change in my behalf? https://reviews.llvm.org/D31130 ___ cfe-commi

[PATCH] D31179: Objective-C categories should support attributes

arphaman added inline comments. Comment at: test/SemaObjC/attr-deprecated.m:124-128 +@interface A(Blah) // no warning +- (A*)getA; @end +@implementation A(Blah) // no warning aaron.ballman wrote: > I would have assumed the use in the `@implementation` would ha

[PATCH] D27486: Correct class-template deprecation behavior

This revision was automatically updated to reflect the committed changes. Closed by commit rL298410: Correct class-template deprecation behavior (authored by erichkeane). Changed prior to commit: https://reviews.llvm.org/D27486?vs=84330&id=92514#toc Repository: rL LLVM https://reviews.llvm.

r298410 - Correct class-template deprecation behavior

Author: erichkeane Date: Tue Mar 21 12:49:17 2017 New Revision: 298410 URL: http://llvm.org/viewvc/llvm-project?rev=298410&view=rev Log: Correct class-template deprecation behavior Based on the comment in the test, and my reading of the standard, a deprecated warning should be issued in the foll

[PATCH] D30009: Add support for '#pragma clang attribute'

arphaman added a comment. In https://reviews.llvm.org/D30009#706515, @aaron.ballman wrote: > In https://reviews.llvm.org/D30009#706171, @arphaman wrote: > > > I would be ok with that. We could merge `apply_to` and `apply_only_to` into > > a single `apply_to` matching rule set specifier (it would

[PATCH] D30415: Fix -mno-altivec cannot overwrite -maltivec option

uweigand added a comment. In https://reviews.llvm.org/D30415#705889, @echristo wrote: > In https://reviews.llvm.org/D30415#705196, @uweigand wrote: > > > Well, mainline GCC doesn't have -faltivec at all and never had, I think > > this was only an Apple GCC extension ... Not sure what exactly th

[PATCH] D31174: [X86][MS-compatability] allow MS TYPE/SIZE/LENGTH operators as a part of a compound expression

rnk accepted this revision. rnk added a comment. This revision is now accepted and ready to land. lgtm Repository: rL LLVM https://reviews.llvm.org/D31174 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailm

  1   2   >