Author: dexonsmith Date: Tue Mar 21 13:26:18 2017 New Revision: 298414 URL: http://llvm.org/viewvc/llvm-project?rev=298414&view=rev Log: Modules: Remove an invalid check in unit tests for r298278
This is a fixup for the unit tests from r298278 (originally r298165). Since the buffer that RawB2 pointed at was later deleted, a new call to getBuffer may very well return a buffer at the same/old address. Which is fine. Just delete the spurious check. A Windows bot was occasionally hitting this in practice: http://lab.llvm.org:8011/builders/llvm-clang-lld-x86_64-scei-ps4-windows10pro-fast/builds/7086 Modified: cfe/trunk/unittests/Basic/MemoryBufferCacheTest.cpp Modified: cfe/trunk/unittests/Basic/MemoryBufferCacheTest.cpp URL: http://llvm.org/viewvc/llvm-project/cfe/trunk/unittests/Basic/MemoryBufferCacheTest.cpp?rev=298414&r1=298413&r2=298414&view=diff ============================================================================== --- cfe/trunk/unittests/Basic/MemoryBufferCacheTest.cpp (original) +++ cfe/trunk/unittests/Basic/MemoryBufferCacheTest.cpp Tue Mar 21 13:26:18 2017 @@ -50,7 +50,6 @@ TEST(MemoryBufferCacheTest, addBuffer) { // Replace the middle buffer. B2 = getBuffer(2); - ASSERT_NE(RawB2, B2.get()); RawB2 = B2.get(); EXPECT_EQ(RawB2, &Cache.addBuffer("2", std::move(B2))); _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
