Hahnfeld abandoned this revision.
Hahnfeld added a comment.
http://lists.llvm.org/pipermail/cfe-dev/2017-January/052512.html suggested to
install runtime libraries (like libomp, but I think libc++ in certain cases may
fall under the same category) to ResourceDir and I wanted the headers to be
c
aaron.ballman added inline comments.
Comment at: clang-tidy/misc/ForwardingReferenceOverloadCheck.cpp:23
+AST_MATCHER(QualType, isEnableIf) {
+ auto checkTemplate = [](const TemplateSpecializationType *Spec) {
+if (!Spec || !Spec->getTemplateName().getAsTemplateDecl()) {
---
djasper requested changes to this revision.
djasper added a comment.
This revision now requires changes to proceed.
So, while it might be convenient to view this all in one file, a test here is
not convenient for me (or presumably other clang-format developers) to work
with. You can make a prett
pelikan updated this revision to Diff 90431.
pelikan marked an inline comment as done.
pelikan added a comment.
- clarify comment and rename variable so it'll all fit.
https://reviews.llvm.org/D29704
Files:
include/clang/Basic/Attr.td
include/clang/Basic/AttrDocs.td
lib/CodeGen/CodeGenFun
Author: ericwf
Date: Thu Mar 2 21:43:25 2017
New Revision: 296854
URL: http://llvm.org/viewvc/llvm-project?rev=296854&view=rev
Log:
Clean up more usages of _LIBCPP_HAS_NO_RVALUE_REFERENCES
Modified:
libcxx/trunk/test/std/iterators/predef.iterators/insert.iterators/back.insert.iter.ops/back.
Author: ericwf
Date: Thu Mar 2 20:02:07 2017
New Revision: 296851
URL: http://llvm.org/viewvc/llvm-project?rev=296851&view=rev
Log:
Fix sign-compare warning in test; Oddly this only appears on OS X
Modified:
libcxx/trunk/test/std/containers/sequences/forwardlist/forwardlist.cons/move_alloc.
danielmarjamaki added inline comments.
Comment at: lib/StaticAnalyzer/Checkers/CallAndMessageChecker.cpp:211
// Generate a report for this bug.
- StringRef Desc =
- describeUninitializedArgumentInCall(Call, IsFirstArgument);
+ std::string Desc =
+
zaks.anna added a comment.
> I’ve added the single file output option but I would like to keep the
> multi-file option default
This sounds good to me! I agree that this is a very useful addition.
https://reviews.llvm.org/D30406
___
cfe-commits m
yaxunl updated this revision to Diff 90399.
yaxunl added a comment.
Make some arguments constant.
https://reviews.llvm.org/D30551
Files:
include/clang/Basic/BuiltinsAMDGPU.def
lib/CodeGen/CGBuiltin.cpp
test/CodeGenOpenCL/builtins-amdgcn.cl
test/SemaOpenCL/builtins-amdgcn-error.cl
Index
vlad.tsyrklevich added inline comments.
Comment at: lib/StaticAnalyzer/Core/HTMLDiagnostics.cpp:211
+
+ if (I + 1 != E) {
+os << "getHashValue()
Is there a cleaner way to do these two comparisons?
https://reviews.llvm.org/D30406
vlad.tsyrklevich updated this revision to Diff 90417.
vlad.tsyrklevich edited the summary of this revision.
vlad.tsyrklevich added a comment.
Updated the formatting to make the file split more obvious (padding/line break
height) and added simple navigation across files, example here:
https://raw
DaveBartolomeo closed this revision.
DaveBartolomeo added a comment.
269843
https://reviews.llvm.org/D30518
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
Author: dbartol
Date: Thu Mar 2 18:08:55 2017
New Revision: 296843
URL: http://llvm.org/viewvc/llvm-project?rev=296843&view=rev
Log:
Fix msc-version.c test to handle _MSC_VER=1910
Previously, VC++ has always set _MSC_VER to a four-digit value with the two
least significant digits set to zero. V
ddcc reopened this revision.
ddcc added a comment.
This revision is now accepted and ready to land.
Made a mistake with the last commit, I believe this should be fine now?
Repository:
rL LLVM
https://reviews.llvm.org/D30373
___
cfe-commits mailin
arsenm added a comment.
In https://reviews.llvm.org/D30551#691149, @b-sumner wrote:
> mov_dpp should be under the VI+ comment
Also should be made to use TARGET_BUILTIN and dependent on dpp feature
https://reviews.llvm.org/D30551
___
cfe-commits m
Author: ericwf
Date: Thu Mar 2 17:18:40 2017
New Revision: 296840
URL: http://llvm.org/viewvc/llvm-project?rev=296840&view=rev
Log:
Work around test failure on 32 bit OS X
Modified:
libcxx/trunk/test/std/strings/basic.string/string.modifiers/string_replace/size_size_T_size_size.pass.cpp
Mo
yaxunl added inline comments.
Comment at: lib/CodeGen/CGBuiltin.cpp:8391-8398
+ case AMDGPU::BI__builtin_amdgcn_ds_permute:
+return emitBinaryBuiltin(*this, E, Intrinsic::amdgcn_ds_permute);
+ case AMDGPU::BI__builtin_amdgcn_ds_bpermute:
+return emitBinaryBuiltin(*this,
arsenm added inline comments.
Comment at: lib/CodeGen/CGBuiltin.cpp:8391-8398
+ case AMDGPU::BI__builtin_amdgcn_ds_permute:
+return emitBinaryBuiltin(*this, E, Intrinsic::amdgcn_ds_permute);
+ case AMDGPU::BI__builtin_amdgcn_ds_bpermute:
+return emitBinaryBuiltin(*this,
b-sumner added a comment.
mov_dpp should be under the VI+ comment
https://reviews.llvm.org/D30551
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
ddcc reopened this revision.
ddcc added a comment.
This revision is now accepted and ready to land.
You're right about the failure being specific to Windows, I'll roll back to the
original implementation in `lit.local.cfg` and just skip on Windows.
Repository:
rL LLVM
https://reviews.llvm.or
arsenm added inline comments.
Comment at: lib/CodeGen/CGBuiltin.cpp:8391-8398
+ case AMDGPU::BI__builtin_amdgcn_ds_permute:
+return emitBinaryBuiltin(*this, E, Intrinsic::amdgcn_ds_permute);
+ case AMDGPU::BI__builtin_amdgcn_ds_bpermute:
+return emitBinaryBuiltin(*this,
danielmarjamaki added inline comments.
Comment at: lib/StaticAnalyzer/Checkers/CallAndMessageChecker.cpp:211
// Generate a report for this bug.
- StringRef Desc =
- describeUninitializedArgumentInCall(Call, IsFirstArgument);
+ std::string Desc =
+
Author: ericwf
Date: Thu Mar 2 16:10:14 2017
New Revision: 296831
URL: http://llvm.org/viewvc/llvm-project?rev=296831&view=rev
Log:
remove max_size() extension from polymorphic_allocator. It is unneeded
Removed:
libcxx/trunk/test/libcxx/experimental/memory/memory.polymorphic.allocator.class
Author: mehdi_amini
Date: Thu Mar 2 16:08:42 2017
New Revision: 296830
URL: http://llvm.org/viewvc/llvm-project?rev=296830&view=rev
Log:
Fix libc++ test experimental/algorithms/alg.random.sample/sample.pass.cpp when
ran in c++11 mode 32 bits
Modified:
libcxx/trunk/test/std/experimental/alg
dcoughlin added a comment.
Thanks for sticking with this!!
This looks good to me, although I would prefer if the definition of the
AnalyzerTest class were moved to the bottom of the lit.cfg file. The other
configuration and substitutions are far more important to the rest of clang --
people sh
yaxunl created this revision.
Herald added subscribers: tpr, dstuttard, tony-tye, nhaehnle, wdng, kzhuravl.
https://reviews.llvm.org/D30551
Files:
include/clang/Basic/BuiltinsAMDGPU.def
lib/CodeGen/CGBuiltin.cpp
test/CodeGenOpenCL/builtins-amdgcn.cl
Index: test/CodeGenOpenCL/builtins-amdg
Author: ericwf
Date: Thu Mar 2 15:55:17 2017
New Revision: 296823
URL: http://llvm.org/viewvc/llvm-project?rev=296823&view=rev
Log:
Work around GCC linking errors within libc++abi due to missing new/delete
definitions
Modified:
libcxxabi/trunk/CMakeLists.txt
Modified: libcxxabi/trunk/CMake
Author: ericwf
Date: Thu Mar 2 15:55:03 2017
New Revision: 296822
URL: http://llvm.org/viewvc/llvm-project?rev=296822&view=rev
Log:
Work around GCC linking errors within libc++abi due to missing new/delete
definitions
Modified:
libcxx/trunk/CMakeLists.txt
Modified: libcxx/trunk/CMakeLists.
JonasToth added a comment.
please add the check in the release notes as well.
https://reviews.llvm.org/D30547
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
Author: ericwf
Date: Thu Mar 2 15:16:35 2017
New Revision: 296813
URL: http://llvm.org/viewvc/llvm-project?rev=296813&view=rev
Log:
Fix test failures caused by new/delete calls getting optimized away
Modified:
libcxx/trunk/test/std/language.support/support.dynamic/new.delete/new.delete.arra
watsond added a comment.
In https://reviews.llvm.org/D29858#690700, @alexfh wrote:
> Do you need someone to commit the patch for you?
I think so. This is my only LLVM patch, so I doubt I have permissions. Thanks
in advance!
https://reviews.llvm.org/D29858
_
pirama updated this revision to Diff 90373.
pirama added a comment.
Add -rpath only when a runtime is included as a shared library. And, cleanup
tests.
https://reviews.llvm.org/D30015
Files:
include/clang/Driver/ToolChain.h
lib/Driver/ToolChain.cpp
lib/Driver/Tools.cpp
test/Driver/Inp
JonasToth added a comment.
added my thoughts. i like the check, seems really thought out :)
Comment at: docs/clang-tidy/checks/misc-forwarding-reference-overload.rst:36
+
+The check warns for constructors C1 and C2, because those can act like
+described above. We suppress w
leanil added inline comments.
Comment at: clang-tidy/misc/ForwardingReferenceOverloadCheck.cpp:22
+// Check if the given type is related to std::enable_if.
+AST_MATCHER(QualType, isEnableIf) {
+ auto checkTemplate = [](const TemplateSpecializationType *Spec) {
T
pirama marked 2 inline comments as done.
pirama added inline comments.
Comment at: lib/Driver/Tools.cpp:289
+ CmdArgs.push_back("-rpath");
+ CmdArgs.push_back(Args.MakeArgString(CandidateRPath.c_str()));
+}
rnk wrote:
> We shouldn't add rpath to eve
leanil created this revision.
leanil added a project: clang-tools-extra.
Herald added subscribers: JDevlieghere, mgorny.
Perfect forwarding constructors are called instead of copy constructors if the
forwarding reference provides a closer match (e.g. with non-const parameter).
This can be confus
Author: rjmccall
Date: Thu Mar 2 14:04:19 2017
New Revision: 296806
URL: http://llvm.org/viewvc/llvm-project?rev=296806&view=rev
Log:
Promote ConstantInitBuilder to be a public CodeGen API; it's
a generally useful utility for other frontends. NFC.
Added:
cfe/trunk/include/clang/CodeGen/Cons
EricWF added a comment.
In https://reviews.llvm.org/D30517#690328, @mehdi_amini wrote:
> LGTM.
Comment at: CMakeLists.txt:416
+set(LIBCXXABI_HAS_UNDEFINED_SYMBOLS ((NOT
LIBCXXABI_ENABLE_NEW_DELETE_DEFINITIONS)
+OR (LIBCXXABI_BUILD_EXTERNAL_THREAD_LIBRARY AND LIBCXXABI_
Author: ericwf
Date: Thu Mar 2 13:35:33 2017
New Revision: 296802
URL: http://llvm.org/viewvc/llvm-project?rev=296802&view=rev
Log:
[libc++] Add option to disable new/delete overloads when libc++abi provides
them.
Summary:
Currently both libc++ and libc++abi provide definitions for operator
ne
Author: ericwf
Date: Thu Mar 2 13:34:35 2017
New Revision: 296801
URL: http://llvm.org/viewvc/llvm-project?rev=296801&view=rev
Log:
[libc++abi] Add option to enable definitions for the new/delete overloads.
Summary:
Currently both libc++ and libc++abi provide definitions for operator
new/delete
Author: hans
Date: Thu Mar 2 13:31:35 2017
New Revision: 296800
URL: http://llvm.org/viewvc/llvm-project?rev=296800&view=rev
Log:
Creating release candidate rc3 from release_400 branch
Added:
libunwind/tags/RELEASE_400/rc3/ (props changed)
- copied from r296799, libunwind/branches/re
Author: hans
Date: Thu Mar 2 13:31:16 2017
New Revision: 296794
URL: http://llvm.org/viewvc/llvm-project?rev=296794&view=rev
Log:
Creating release candidate rc3 from release_400 branch
Added:
libcxxabi/tags/RELEASE_400/rc3/ (props changed)
- copied from r296793, libcxxabi/branches/re
Author: hans
Date: Thu Mar 2 13:31:13 2017
New Revision: 296793
URL: http://llvm.org/viewvc/llvm-project?rev=296793&view=rev
Log:
Creating release candidate rc3 from release_400 branch
Added:
libcxx/tags/RELEASE_400/rc3/ (props changed)
- copied from r296792, libcxx/branches/release_
Author: ericwf
Date: Thu Mar 2 13:25:53 2017
New Revision: 296787
URL: http://llvm.org/viewvc/llvm-project?rev=296787&view=rev
Log:
[libc++abi] Update new/delete definitions to match libc++
Summary:
Currently both libc++ and libc++abi provide definitions for new/delete. However
libc++abi's defi
EricWF added a comment.
In https://reviews.llvm.org/D30214#690774, @jroelofs wrote:
> In https://reviews.llvm.org/D30214#690375, @Hahnfeld wrote:
>
> > In https://reviews.llvm.org/D30214#690010, @jroelofs wrote:
> >
> > > libc++ headers should not be installed in the resource dir.
> >
> >
> > The
v.g.vassilev updated this revision to Diff 90360.
v.g.vassilev added a comment.
Rebase + ping.
https://reviews.llvm.org/D29877
Files:
lib/Sema/Sema.cpp
lib/Sema/SemaDecl.cpp
test/SemaCXX/warn-unused-filescoped.cpp
Index: test/SemaCXX/warn-unused-filescoped.cpp
==
v.g.vassilev closed this revision.
v.g.vassilev added a comment.
Landed in r296781.
Repository:
rL LLVM
https://reviews.llvm.org/D26030
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-com
Author: vvassilev
Date: Thu Mar 2 12:47:22 2017
New Revision: 296781
URL: http://llvm.org/viewvc/llvm-project?rev=296781&view=rev
Log:
Add coding and shebang.
Reviewed by Artem Dergachev (D26030)!
Modified:
cfe/trunk/tools/scan-view/share/Reporter.py
cfe/trunk/tools/scan-view/share/star
arphaman added inline comments.
Comment at: test/Misc/diag-template-diffing.cpp:27
// CHECK-ELIDE-NOTREE: no matching function for call to 'f'
-// CHECK-ELIDE-NOTREE: candidate function not viable: no known conversion from
'vector' to 'vector' for 1st argument
+// CHECK-ELIDE-N
Author: vvassilev
Date: Thu Mar 2 12:13:19 2017
New Revision: 296779
URL: http://llvm.org/viewvc/llvm-project?rev=296779&view=rev
Log:
Mark function as llvm dump method.
Modified:
cfe/trunk/lib/Serialization/ASTReader.cpp
Modified: cfe/trunk/lib/Serialization/ASTReader.cpp
URL:
http://llvm
Author: adrian
Date: Thu Mar 2 12:06:51 2017
New Revision: 296776
URL: http://llvm.org/viewvc/llvm-project?rev=296776&view=rev
Log:
Document that code inlined into a nodebug function also won't get any
debug info.
Suggested by Paul Robinson in feedback on r296488, thanks!
Modified:
cfe/trun
jroelofs added a comment.
In https://reviews.llvm.org/D30214#690375, @Hahnfeld wrote:
> In https://reviews.llvm.org/D30214#690010, @jroelofs wrote:
>
> > libc++ headers should not be installed in the resource dir.
>
>
> They are currently not by default. But with https://reviews.llvm.org/D30015
Author: compnerd
Date: Thu Mar 2 11:37:11 2017
New Revision: 296769
URL: http://llvm.org/viewvc/llvm-project?rev=296769&view=rev
Log:
Serialization: use the PCH chain to check PCH mode
When we are deciding whether we are creating a PCH or a module, we would
check if the ModuleMgr had any element
mehdi_amini added a comment.
In https://reviews.llvm.org/D30514#690702, @jroelofs wrote:
> In https://reviews.llvm.org/D30514#690318, @mehdi_amini wrote:
>
> > LGTM.
> >
> > (It seems that having libc++ and libc++abi in the same repo would help
> > sharing code like this)
>
>
> I think it would
rnk added inline comments.
Comment at: include/clang/Driver/ToolChain.h:305
+ // as OpenMP) to find arch-specific libraries.
+ const std::string getArchSpecificLibPath() const;
+
Why const qualify the std::string?
Comment at: lib/Driver/Tools
dberlin added a comment.
In https://reviews.llvm.org/D30538#690699, @hans wrote:
> +1 for documenting this, but I have to leave it to the language lawyers for
> how to fomulate it.
>
> > Enables/disables the strict aliasing assumption, which assumes that objects
> > of different types do not sh
Merged to 4.0 in r296762.
On Wed, Mar 1, 2017 at 11:18 AM, Bruno Cardoso Lopes via cfe-commits
wrote:
> Author: bruno
> Date: Wed Mar 1 13:18:42 2017
> New Revision: 296656
>
> URL: http://llvm.org/viewvc/llvm-project?rev=296656&view=rev
> Log:
> [PCH] Avoid VarDecl emission attempt if no owning
jroelofs added a comment.
In https://reviews.llvm.org/D30514#690318, @mehdi_amini wrote:
> LGTM.
>
> (It seems that having libc++ and libc++abi in the same repo would help
> sharing code like this)
I think it would be a step backwards in terms of opening things up for layering
violations. We
alexfh added a comment.
Do you need someone to commit the patch for you?
https://reviews.llvm.org/D29858
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
hans added a comment.
+1 for documenting this, but I have to leave it to the language lawyers for how
to fomulate it.
> Enables/disables the strict aliasing assumption, which assumes that objects
> of different types do not share the same location in memory.
I think it needs to say incompatibl
On Thu, Mar 02, 2017 at 04:20:47PM +, Simon Byrne via Phabricator via
cfe-commits wrote:
> simonbyrne created this revision.
>
> This is probably good to document, as the behaviour of `-fstrict-aliasing`
> differs from gcc in a quite important way (see
> https://bugs.llvm.org//show_bug.cgi?
hfinkel added inline comments.
Comment at: docs/UsersManual.rst:1106
+
+ NOTE: unlike gcc, clang does not allow "type-punning" by writing and
+ reading from different union members without `-fno-strict-aliasing`
Capitalize Unlike.
https://reviews.llvm.org/D
sylvestre.ledru added a comment.
> What problem is this addressing, though? Have we frequently changed
> formatting in a way that has negatively impacted Mozilla code?
We are integrating more clang-format into gecko processes.
About the reason, I believed I explained them in the comment above
simonbyrne created this revision.
This is probably good to document, as the behaviour of `-fstrict-aliasing`
differs from gcc in a quite important way (see
https://bugs.llvm.org//show_bug.cgi?id=31928) .
https://reviews.llvm.org/D30538
Files:
docs/UsersManual.rst
Index: docs/UsersManual.r
djasper added inline comments.
Comment at: include/clang/Format/Format.h:309
+ /// inheritance.
+ bool BreakInhertianceBeforeColonAndComma;
+
Hm. I am still not sure about this flag and it's name. Fundamentally, this is
currently controlling two different th
Author: alexfh
Date: Thu Mar 2 09:47:28 2017
New Revision: 296755
URL: http://llvm.org/viewvc/llvm-project?rev=296755&view=rev
Log:
[clang-tidy] google-readability-casting: detect redundant casts with top-level
const
Modified:
clang-tools-extra/trunk/clang-tidy/google/AvoidCStyleCastsCheck.
djasper added a comment.
Please don't add this as is. I don't usually run the file-based tests in my
development workflow and suspect that I might be breaking this a lot.
If you want something like this, please add it as unittest(s) in
unittests/Format/... (either in a new file or in an existin
dcoughlin added a comment.
In https://reviews.llvm.org/D30373#689613, @ddcc wrote:
> With the first method, I'm not sure how to refer to the `AnalyzerTest` class
> defined in `lit.cfg` from `lit.local.cfg`. It doesn't seem to be in scope, so
> unless I store an instantiation in the `config` obj
Author: alexfh
Date: Thu Mar 2 09:27:34 2017
New Revision: 296753
URL: http://llvm.org/viewvc/llvm-project?rev=296753&view=rev
Log:
[clang-tidy] Fix a few more issues in google-readability-casting
* suggest static_cast instead of reinterpret_cast for casts from void*
* top-level const doesn't ne
redm123 added a comment.
Any idea how to continue with that? Should I add another reviewer? Whom?
https://reviews.llvm.org/D29944
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
Author: nico
Date: Thu Mar 2 08:51:54 2017
New Revision: 296749
URL: http://llvm.org/viewvc/llvm-project?rev=296749&view=rev
Log:
Don't write to LLVMStyle.JavaScriptQuotes twice. No behavior change.
Modified:
cfe/trunk/lib/Format/Format.cpp
Modified: cfe/trunk/lib/Format/Format.cpp
URL:
ht
etienneb accepted this revision.
etienneb added a comment.
thx for the improvement
lgtm
https://reviews.llvm.org/D29858
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
sylvestre.ledru updated this revision to Diff 90331.
sylvestre.ledru added a comment.
With the rst generation
https://reviews.llvm.org/D30532
Files:
docs/ClangFormatStyleOptions.rst
include/clang/Format/Format.h
Index: docs/ClangFormatStyleOptions.rst
==
sylvestre.ledru added inline comments.
Comment at: docs/ClangFormatStyleOptions.rst:218
+
+#define A \
+int ; \
klimek wrote:
> Do we really align these 3 spaces out?
nope, bad copy and paste it seems. Sorry
Comment at: docs/Cla
sylvestre.ledru updated this revision to Diff 90330.
sylvestre.ledru marked 3 inline comments as done.
https://reviews.llvm.org/D30532
Files:
docs/ClangFormatStyleOptions.rst
include/clang/Format/Format.h
Index: docs/ClangFormatStyleOptions.rst
===
hokein added a comment.
I like removing the leading "::" when possible. :)
Comment at: change-namespace/ChangeNamespace.cpp:291
+ assert(!SymbolSplitted.empty());
+ SymbolSplitted.pop_back();
+
Is this needed? Looks like you are removing the name of the symbo
klimek added inline comments.
Comment at: docs/ClangFormatStyleOptions.rst:218
+
+#define A \
+int ; \
Do we really align these 3 spaces out?
Comment at: docs/ClangFormatStyleOptions.rst:447
+ SomeClass::Constructor()
+
NoQ created this revision.
The test case provided demonstrates a regression due to my earlier attempt to
fix temporaries in https://reviews.llvm.org/D26839. Neither before nor after,
we did not properly copy the symbolic rvalue of the object to the newly created
memory region; in different ways
sylvestre.ledru added a comment.
If you think it makes sense, I will do that for the rest of the options
https://reviews.llvm.org/D30532
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commi
sylvestre.ledru created this revision.
https://reviews.llvm.org/D30532
Files:
docs/ClangFormatStyleOptions.rst
include/clang/Format/Format.h
Index: docs/ClangFormatStyleOptions.rst
===
--- docs/ClangFormatStyleOptions.rst
+++ do
sylvestre.ledru added a comment.
This isn't about testing individual issues. This is to make sure that the
Mozilla coding style remains consistent and we don't regress specific coding
style. I found that easy and simple to have a single file to check for the
specificities.
After https://review
krasimir added a comment.
My input:
Maybe this CL is trying to solve a non-existing problem, as separate issues may
be tracked as bugs, fixed, and unittests added for each of them as appropriate,
as happens in https://reviews.llvm.org/D30487, which adds an option to break
multiple inheritance d
djasper added a comment.
As discussed offline, I think this solves the wrong problem. My guess is that
breakProtrudingToken checks State.Stack.back().NoLinebreak, but I forget to
make it also check NoLinebreakInOperand.
https://reviews.llvm.org/D30492
___
rmaprath added a comment.
Thanks for these patches!
We had some downstream hacks to workaround this, never got around to sort it
out. Now it looks much better.
https://reviews.llvm.org/D30516
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
krasimir updated this revision to Diff 90312.
krasimir added a comment.
- Reformat newly added chunk of code
https://reviews.llvm.org/D30492
Files:
lib/Format/ContinuationIndenter.cpp
unittests/Format/FormatTest.cpp
unittests/Format/FormatTestObjC.cpp
Index: unittests/Format/FormatTestOb
krasimir updated this revision to Diff 90310.
krasimir added a comment.
- Remove DEBUG statement
https://reviews.llvm.org/D30492
Files:
lib/Format/ContinuationIndenter.cpp
unittests/Format/FormatTest.cpp
unittests/Format/FormatTestObjC.cpp
Index: unittests/Format/FormatTestObjC.cpp
=
krasimir updated this revision to Diff 90309.
krasimir added a comment.
- Add missing test cases for commas and handling for Objective-C string literals
https://reviews.llvm.org/D30492
Files:
lib/Format/ContinuationIndenter.cpp
unittests/Format/FormatTest.cpp
unittests/Format/FormatTestOb
Author: d0k
Date: Thu Mar 2 04:25:00 2017
New Revision: 296737
URL: http://llvm.org/viewvc/llvm-project?rev=296737&view=rev
Log:
[clangd] Fix a potential race by copying the FixIts out of ASTManager before
releasing the lock.
Also document the locking semantics a bit better.
Modified:
clan
This revision was automatically updated to reflect the committed changes.
Closed by commit rL296736: [clang-format] Use number of unwrapped lines for
short namespace (authored by krasimir).
Changed prior to commit:
https://reviews.llvm.org/D30528?vs=90299&id=90302#toc
Repository:
rL LLVM
ht
Author: krasimir
Date: Thu Mar 2 03:54:44 2017
New Revision: 296736
URL: http://llvm.org/viewvc/llvm-project?rev=296736&view=rev
Log:
[clang-format] Use number of unwrapped lines for short namespace
Summary:
This patch makes the namespace comment fixer use the number of unwrapped lines
that a na
Abpostelnicu updated this revision to Diff 90300.
Abpostelnicu marked an inline comment as done.
Abpostelnicu added a comment.
Updated patch with the proposed modifications.
Repository:
rL LLVM
https://reviews.llvm.org/D30487
Files:
docs/ClangFormatStyleOptions.rst
include/clang/Format/F
Abpostelnicu marked 9 inline comments as done.
Abpostelnicu added inline comments.
Comment at: lib/Format/TokenAnnotator.cpp:2398
+// Determine if the next token from the closing scope is an inheritance token
+static bool hasMultipleInheritance(const FormatToken &Tok) {
---
djasper accepted this revision.
djasper added a comment.
This revision is now accepted and ready to land.
Please include the reasoning in the patch description, i.e. that otherwise
clang-format might need to runs to add all the namespace comments.
https://reviews.llvm.org/D30528
Hahnfeld updated this revision to Diff 90296.
Hahnfeld edited the summary of this revision.
Hahnfeld added a comment.
Adapt and add tests.
https://reviews.llvm.org/D30214
Files:
lib/Driver/ToolChains.cpp
test/Driver/Inputs/resource_dir_libcxx/include/c++/v1/.keep
test/Driver/Inputs/resour
Hahnfeld updated this revision to Diff 90295.
Hahnfeld marked an inline comment as done.
Hahnfeld added a comment.
Reword comment
https://reviews.llvm.org/D30087
Files:
lib/Driver/Tools.cpp
test/Driver/fopenmp.c
Index: test/Driver/fopenmp.c
=
alexfh accepted this revision.
alexfh added a comment.
This revision is now accepted and ready to land.
LG unless Etienne has any concerns.
https://reviews.llvm.org/D29858
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org
Author: alexfh
Date: Thu Mar 2 02:28:55 2017
New Revision: 296734
URL: http://llvm.org/viewvc/llvm-project?rev=296734&view=rev
Log:
[clang-tidy] Function names configurable for cppcoreguidelines-nomalloc -
checker
Summary:
Hello everybody,
this is an incremental patch for the NoMalloc-Checker
97 matches
Mail list logo
