mehdi_amini added a comment.

In https://reviews.llvm.org/D30514#690702, @jroelofs wrote:

> In https://reviews.llvm.org/D30514#690318, @mehdi_amini wrote:
>
> > LGTM.
> >
> > (It seems that having libc++ and libc++abi in the same repo would help 
> > sharing code like this)
>
>
> I think it would be a step backwards in terms of opening things up for 
> layering violations. We already have one unavoidable one that comes from they 
> way typeinfo matching works in ARM EHABI... I'd be afraid of it getting worse.


I don't see why: this is about discipline and bots. Enforcing layering using 
separate repository sounds awful to me.


https://reviews.llvm.org/D30514



_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Reply via email to