Re: [PATCH] D23855: Make exception-throwing from a noexcept build `abort()`.

mclow.lists added inline comments. Comment at: src/thread.cpp:59 @@ -58,1 +58,3 @@ throw system_error(error_code(ec, system_category()), "thread::join failed"); +#else +if (ec) Need to fix these, too. https://reviews.llvm.org/D23855

Re: [PATCH] D23855: Make exception-throwing from a noexcept build `abort()`.

mclow.lists added inline comments. Comment at: include/stdexcept:174 @@ -173,1 +173,3 @@ +// in the dylib +_LIBCPP_BEGIN_NAMESPACE_STD This comment belongs to `__throw_runtime_error` https://reviews.llvm.org/D23855 __

Re: [PATCH] D23855: Make exception-throwing from a noexcept build `abort()`.

mclow.lists updated this revision to Diff 69201. mclow.lists added a comment. I like this revision better; I need to check, but I think this hits all the exception classes. Goal: Every exception class in the standard should have a `VSTD::__throw_XXX` function, marked `_LIBCPP_NORETURN inline _L

Re: [PATCH] D23853: Assert in performTrivialCopy - Bug report and a possible solution

xazax.hun added a comment. > Also: I think r270511 is unlikely to be the change that caused this -- that > is a change in LLVM's treatment of DebugInfo, which shouldn't affect the > analyzer. I think Peter means that, that revision introduced the code that the analyzer fails to analyze (and

Re: r278984 - Add test missed from r278983.

Thanks! 2016-08-25 0:39 GMT+03:00 Richard Smith : > As of r279668, we shouldn't run this test for ASan builds any more. > Perhaps we should increase Clang's minimum stack allocation when built with > ASan to compensate for it making stack frames larger. > On Wed, Aug 24, 2016 at 12:33 AM, Yaron

Re: [PATCH] D23832: cmake: Add ordering dep between HTML Sphinx docs and manpages

axw accepted this revision. axw added a comment. This revision is now accepted and ready to land. LGTM https://reviews.llvm.org/D23832 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[libunwind] r279716 - Creating release candidate rc3 from release_390 branch

Author: hans Date: Wed Aug 24 22:32:43 2016 New Revision: 279716 URL: http://llvm.org/viewvc/llvm-project?rev=279716&view=rev Log: Creating release candidate rc3 from release_390 branch Added: libunwind/tags/RELEASE_390/rc3/ (props changed) - copied from r279715, libunwind/branches/re

[libcxx] r279709 - Creating release candidate rc3 from release_390 branch

Author: hans Date: Wed Aug 24 22:32:22 2016 New Revision: 279709 URL: http://llvm.org/viewvc/llvm-project?rev=279709&view=rev Log: Creating release candidate rc3 from release_390 branch Added: libcxx/tags/RELEASE_390/rc3/ (props changed) - copied from r279708, libcxx/branches/release_

[libcxxabi] r279710 - Creating release candidate rc3 from release_390 branch

Author: hans Date: Wed Aug 24 22:32:25 2016 New Revision: 279710 URL: http://llvm.org/viewvc/llvm-project?rev=279710&view=rev Log: Creating release candidate rc3 from release_390 branch Added: libcxxabi/tags/RELEASE_390/rc3/ (props changed) - copied from r279709, libcxxabi/branches/re

Re: [PATCH] D22584: constexpr array support C++1z (P0031)

lefticus updated this revision to Diff 69195. lefticus added a comment. Address formatting concerns and out-of-date-ness of patch relative to trunk/master https://reviews.llvm.org/D22584 Files: include/array include/iterator test/std/containers/sequences/array/at.pass.cpp test/std/cont

Re: [PATCH] D23855: Make exception-throwing from a noexcept build `abort()`.

sebpop added a comment. I like the patch. Thanks for removing #ifdefs from the code: it improves readability in general. Would it be possible to move the __throw_* functions in a same .h file to avoid having them all over? Comment at: include/array:212 @@ -214,3 +211,3 @@ #els

Re: [PATCH] D23853: Assert in performTrivialCopy - Bug report and a possible solution

dcoughlin added a comment. I'm not sure that weakening the assert is the right thing to do here. It seems like if V is undef that the analyzer ideally ought to have issued a diagnostic (and a sink) somewhere before. Do you have a test case that reproduces? (It would be good to add that to the t

r279702 - Remove a pointless LLVM_CONSTEXPR. NFC.

Author: gbiv Date: Wed Aug 24 20:54:37 2016 New Revision: 279702 URL: http://llvm.org/viewvc/llvm-project?rev=279702&view=rev Log: Remove a pointless LLVM_CONSTEXPR. NFC. Modified: cfe/trunk/lib/AST/ASTContext.cpp Modified: cfe/trunk/lib/AST/ASTContext.cpp URL: http://llvm.org/viewvc/llvm-p

Buildbot numbers for the last week of 8/14/2016 - 8/20/2016

Hello everyone, Below are some buildbot numbers for the last week of 8/14/2016 - 8/20/2016. Please see the same data in attached csv files: The longest time each builder was red during the last week; "Status change ratio" by active builder (percent of builds that changed the builder status from

r279694 - Lazily load the ContextDecl for a lambda's DefinitionData, to fix a

Author: rsmith Date: Wed Aug 24 19:34:00 2016 New Revision: 279694 URL: http://llvm.org/viewvc/llvm-project?rev=279694&view=rev Log: Lazily load the ContextDecl for a lambda's DefinitionData, to fix a deserialization cycle caused by the ContextDecl recursively importing members of the lambda's clo

[libclc] r279692 - Strip opencl.ocl.version metadata

Author: arsenm Date: Wed Aug 24 19:25:10 2016 New Revision: 279692 URL: http://llvm.org/viewvc/llvm-project?rev=279692&view=rev Log: Strip opencl.ocl.version metadata This should be uniqued when linking, but right now it creates a lot of metadata spam listing the same version. This should also pr

[PATCH] D23860: [Sema][Comments] Add support for TypeAliasTemplate

bruno created this revision. bruno added a reviewer: gribozavr. bruno added a subscriber: cfe-commits. Emit proper diagnostics when -Wdocumentation is used with constructs such as: template using fn = int(T aaa, int ccc); Previously clang wouldn't recognize the function and complain with 'co

r279691 - [Sema][Comments] Factor out function type loc logic. NFCI

Author: bruno Date: Wed Aug 24 19:22:08 2016 New Revision: 279691 URL: http://llvm.org/viewvc/llvm-project?rev=279691&view=rev Log: [Sema][Comments] Factor out function type loc logic. NFCI This is in prepatation for @param TypeAliasTemplate support. Modified: cfe/trunk/lib/AST/Comment.cpp

Re: [PATCH] D23279: clang-reorder-fields

alexshap added a comment. so looks like i have marked all the inline comments as done - please, let me know if i need to change smth else. Many thanks for the code review/comments/suggestions. Repository: rL LLVM https://reviews.llvm.org/D23279

Re: [PATCH] D23279: clang-reorder-fields

alexshap marked an inline comment as done. alexshap added a comment. Repository: rL LLVM https://reviews.llvm.org/D23279 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Re: [PATCH] D23279: clang-reorder-fields

alexshap updated this revision to Diff 69186. alexshap added a comment. Use a more elaborate approach for command line options. alexshap-mbp:srcs alexshap$ clang-reorder-fields -record-name Foo -fields-order s1,x,z,s2 main.cpp >/dev/null && echo ok ok alexshap-mbp:srcs alexshap$ clang-reorder-fi

[PATCH] D23859: [Preprocessor] Add a macro for -fno-gnu-inline-asm

bruno created this revision. bruno added reviewers: rsmith, echristo. bruno added subscribers: cfe-commits, friss. Herald added a subscriber: mehdi_amini. When building with -fno-gnu-inline-asm and -fmodules on Darwin, the compilation might fail if some of the implicit modules try to use gnu asm

[PATCH] D23858: Don't diagnose non-modular includes when we are not compiling a module

manmanren created this revision. manmanren added reviewers: rsmith, benlangmuir. manmanren added a subscriber: cfe-commits. We used to have -fmodule-implementation-of and it was merged with -fmodule-name. But this causes some regression on our internal projects. We are now seeing non-modular inc

r279687 - DebugInfo: Let -gsplit-dwarf and -gmlt compose if -fno-split-dwarf-inlining is used

Author: dblaikie Date: Wed Aug 24 18:22:36 2016 New Revision: 279687 URL: http://llvm.org/viewvc/llvm-project?rev=279687&view=rev Log: DebugInfo: Let -gsplit-dwarf and -gmlt compose if -fno-split-dwarf-inlining is used If the inline info is not duplicated into the skeleton CU, then there's value

Re: [PATCH] D23783: [Sema][Comments] Support @param with c++ 'using' keyword

bruno closed this revision. bruno added a comment. r279662 https://reviews.llvm.org/D23783 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D23856: [libc++] Perform configuration checks with -nodefaultlibs

smeenai created this revision. smeenai added reviewers: EricWF, compnerd. smeenai added subscribers: cfe-commits, kastiglione. We're compiling libc++ with -nodefaultlibs, so we should also pass this option during the configuration checks to ensure those checks are consistent with the actual build.

Re: [PATCH] D22431: clang-format: [JS] nested and tagged template strings.

djasper accepted this revision. djasper added a comment. This revision is now accepted and ready to land. Looks good. Sorry for the delay! Comment at: lib/Format/FormatTokenLexer.h:68 @@ +67,3 @@ + // embedding expressions nested in ${expr-here}. Template strings can be + // n

[PATCH] D23855: Make exception-throwing from a noexcept build `abort()`.

mclow.lists created this revision. mclow.lists added reviewers: EricWF, hiraditya, kparzysz. mclow.lists added a subscriber: cfe-commits. This is a follow on to D21232, which marked a bunch of exception-throwing helper routines as `noreturn`. Now, make them really never return. Either they thro

Re: [PATCH] D23699: [CMake] Be more consistent about naming targets and components

This revision was automatically updated to reflect the committed changes. Closed by commit rL279675: [CMake] Be more consistent about naming targets and components (authored by cbieneman). Changed prior to commit: https://reviews.llvm.org/D23699?vs=68637&id=69177#toc Repository: rL LLVM htt

[libcxx] r279675 - [CMake] Be more consistent about naming targets and components

Author: cbieneman Date: Wed Aug 24 17:17:06 2016 New Revision: 279675 URL: http://llvm.org/viewvc/llvm-project?rev=279675&view=rev Log: [CMake] Be more consistent about naming targets and components Summary: The point of this patch is to have a consistent convention for naming build, check and i

Re: [PATCH] D23699: [CMake] Be more consistent about naming targets and components

beanz added a comment. Ping. https://reviews.llvm.org/D23699 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Re: [PATCH] D23848: Add a clang-tidy Visual Studio extension

amccarth added a comment. I don't know enough C# to review for language usage. I was mostly reading for understandability. Overall, I think this looks really nice. Comment at: clang-tidy-vs/ClangTidy/CheckTree.cs:67 @@ +66,3 @@ +if (ParentPath == null) +

r279673 - [Order Files] On Darwin use DTrace's oneshot probe

Author: cbieneman Date: Wed Aug 24 17:09:46 2016 New Revision: 279673 URL: http://llvm.org/viewvc/llvm-project?rev=279673&view=rev Log: [Order Files] On Darwin use DTrace's oneshot probe The oneshot probe only gets executed the first time the probe is hit in the process. For order file generatio

Re: [PATCH] D23279: clang-reorder-fields

alexshap marked 17 inline comments as done. alexshap added a comment. Repository: rL LLVM https://reviews.llvm.org/D23279 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Re: [PATCH] D23279: clang-reorder-fields

alexshap updated this revision to Diff 69174. alexshap added a comment. Address @djasper 's comments 1. Add brief comments to the helper functions. 2. Get rid of the workaround. (https://reviews.llvm.org/D23828 has been merged in and i have rebased on the latest revision) 3. Made stylistic / n

Re: [PATCH] D23848: Add a clang-tidy Visual Studio extension

alexfh added inline comments. Comment at: clang-tidy-vs/ClangTidy/ClangTidyProperties.cs:82 @@ +81,3 @@ +public bool CERTDCL50 +{ +get { return GetInheritableProperty("CERTDCL50").Value; } zturner wrote: > alexfh wrote: > > zturner wro

Re: [PATCH] D23848: Add a clang-tidy Visual Studio extension

zturner added inline comments. Comment at: clang-tidy-vs/ClangTidy/ClangTidyProperties.cs:82 @@ +81,3 @@ +public bool CERTDCL50 +{ +get { return GetInheritableProperty("CERTDCL50").Value; } alexfh wrote: > zturner wrote: > > Are the .r

Re: r278984 - Add test missed from r278983.

As of r279668, we shouldn't run this test for ASan builds any more. Perhaps we should increase Clang's minimum stack allocation when built with ASan to compensate for it making stack frames larger. On Wed, Aug 24, 2016 at 12:33 AM, Yaron Keren wrote: > I see the same stack overflow asan error in

Re: [PATCH] D23848: Add a clang-tidy Visual Studio extension

alexfh added inline comments. Comment at: clang-tidy-vs/ClangTidy/ClangTidyProperties.cs:82 @@ +81,3 @@ +public bool CERTDCL50 +{ +get { return GetInheritableProperty("CERTDCL50").Value; } zturner wrote: > Are the .rst files in the rep

r279668 - Disable test under asan: it uses a lot of stack, and asan increases the

Author: rsmith Date: Wed Aug 24 16:30:00 2016 New Revision: 279668 URL: http://llvm.org/viewvc/llvm-project?rev=279668&view=rev Log: Disable test under asan: it uses a lot of stack, and asan increases the per-frame stack usage enough to cause it to hit our stack limit. This is not ideal; we should

[clang-tools-extra] r279666 - [clang-tidy misc-move-const-arg] more specific messages + suggest alternative solution

Author: alexfh Date: Wed Aug 24 16:23:24 2016 New Revision: 279666 URL: http://llvm.org/viewvc/llvm-project?rev=279666&view=rev Log: [clang-tidy misc-move-const-arg] more specific messages + suggest alternative solution Modified: clang-tools-extra/trunk/clang-tidy/misc/MoveConstantArgumentCh

Re: [PATCH] D23848: Add a clang-tidy Visual Studio extension

zturner added a comment. BTW, since I forgot to do so in the original review, here is a screenshot of what the UI for the property editor looks like in this extension: F2328405: clang-tidy.png Comment at: clang-tidy-vs/ClangTidy/ClangTidy.vs

r279662 - [Sema][Comments] Support @param with c++ 'using' keyword

Author: bruno Date: Wed Aug 24 16:11:43 2016 New Revision: 279662 URL: http://llvm.org/viewvc/llvm-project?rev=279662&view=rev Log: [Sema][Comments] Support @param with c++ 'using' keyword Give appropriate warnings with -Wdocumentation for @param comments that refer to function aliases defined wi

Re: [PATCH] D23848: Add a clang-tidy Visual Studio extension

zturner added inline comments. Comment at: clang-tidy-vs/ClangTidy/ClangTidyProperties.cs:82 @@ +81,3 @@ +public bool CERTDCL50 +{ +get { return GetInheritableProperty("CERTDCL50").Value; } Are the .rst files in the repo somewhere alre

Re: [PATCH] D23842: [CFG] Add iterator_ranges to CFG and CFGBlock.

alexfh accepted this revision. alexfh added a comment. This revision is now accepted and ready to land. Actually, there's just one comment. Otherwise it's looking good. https://reviews.llvm.org/D23842 ___ cfe-commits mailing list cfe-commits@lists.l

Re: [PATCH] D23848: Add a clang-tidy Visual Studio extension

alexfh added a comment. In https://reviews.llvm.org/D23848#524608, @zturner wrote: > I can fix the empty lines, but keep in mind that Visual Studio's C# editor is > MUCH more aggressive about auto-formatting your code. So it seems like a > fruitless endeavor to me, as we will constantly be fig

[PATCH] D23852: [SemaObjC] Fix crash while parsing type arguments and protocols

bruno created this revision. bruno added a reviewer: doug.gregor. bruno added subscribers: cfe-commits, manmanren. Fix a crash-on-invalid. When parsing type arguments and protocols, ParseTypeName() tries to find matching tokens for '[', '(', etc whenever they appear among potential type names. If

Re: [PATCH] D20512: [PATCH] Bug 27475 - Request header guard check processes .hpp files as well as .h files

alexfh added inline comments. Comment at: docs/clang-tidy/checks/llvm-header-guard.rst:13 @@ +12,2 @@ + +A comma-separated list of filename extensions of header files (The filename extension should not contain "." prefix). Default value is ",h,hh,hpp,hxx". For extension-less he

Re: [PATCH] D21968: [libcxx] Externally threaded libc++ variant - Take 2

rmaprath added inline comments. Comment at: include/__config:830 @@ -829,1 +829,3 @@ +!defined(_LIBCPP_HAS_THREAD_API_PTHREAD) && \ +!defined(_LIBCPP_HAS_THREAD_API_EXTERNAL) # if defined(__FreeBSD__) || \ compnerd wrote: > I meant on the lines that you a

Re: [PATCH] D23848: Add a clang-tidy Visual Studio extension

zturner added inline comments. Comment at: CMakeLists.txt:6 @@ -5,2 +5,3 @@ add_subdirectory(clang-tidy) +add_subdirectory(clang-tidy-vs) endif() alexfh wrote: > Should the plugin be placed inside clang-tidy directory? I followed the same way that the clang form

Re: [PATCH] D23848: Add a clang-tidy Visual Studio extension

zturner added a comment. I can fix the empty lines, but keep in mind that Visual Studio's C# editor is MUCH more aggressive about auto-formatting your code. So it seems like a fruitless endeavor to me, as we will constantly be fighting against their auto formatter, which does this automaticall

Re: [PATCH] D23848: Add a clang-tidy Visual Studio extension

Eugene.Zelenko added a subscriber: Eugene.Zelenko. Comment at: clang-tidy-vs/ClangTidy/CheckTree.cs:79 @@ +78,3 @@ +} + + Unnecessary empty line. Comment at: clang-tidy-vs/ClangTidy/CheckTree.cs:93 @@ +92,3 @@ +{ + +}

Re: [PATCH] D20512: [PATCH] Bug 27475 - Request header guard check processes .hpp files as well as .h files

madsravn added inline comments. Comment at: docs/clang-tidy/checks/llvm-header-guard.rst:13 @@ +12,3 @@ + + ... + alexfh wrote: > `...` was meant to represent the description of the option. Not literally > `...` ;) > > The description should be indented by at l

Re: [PATCH] D20512: [PATCH] Bug 27475 - Request header guard check processes .hpp files as well as .h files

madsravn updated this revision to Diff 69164. https://reviews.llvm.org/D20512 Files: clang-tidy/llvm/HeaderGuardCheck.cpp clang-tidy/llvm/HeaderGuardCheck.h clang-tidy/utils/HeaderFileExtensionsUtils.cpp clang-tidy/utils/HeaderFileExtensionsUtils.h clang-tidy/utils/HeaderGuard.cpp cla

Re: [PATCH] D21502: Fix heuristics skipping invalid ctor-initializers with C++11

rsmith added a comment. Please produce patches with more lines of context in future; phabricator only lets us comment on lines that are included in the patch, and in this case some of the relevant parts of the function are not in the context. (The equivalent of diff -U1000 is a common approach

Re: [PATCH] D20512: [PATCH] Bug 27475 - Request header guard check processes .hpp files as well as .h files

alexfh added inline comments. Comment at: docs/clang-tidy/checks/llvm-header-guard.rst:13 @@ +12,3 @@ + + ... + `...` was meant to represent the description of the option. Not literally `...` ;) The description should be indented by at least two columns and sho

Re: [PATCH] D23815: [Clang-tidy] Documentation style. Two Google checks are aliases

This revision was automatically updated to reflect the committed changes. Closed by commit rL279659: Clang-tidy documentation style. Two Google checks are aliases. (authored by eugenezelenko). Changed prior to commit: https://reviews.llvm.org/D23815?vs=69138&id=69161#toc Repository: rL LLVM

[clang-tools-extra] r279659 - Clang-tidy documentation style. Two Google checks are aliases.

Author: eugenezelenko Date: Wed Aug 24 15:05:36 2016 New Revision: 279659 URL: http://llvm.org/viewvc/llvm-project?rev=279659&view=rev Log: Clang-tidy documentation style. Two Google checks are aliases. Differential revision: https://reviews.llvm.org/D23815 Modified: clang-tools-extra/trunk

Re: [PATCH] D23848: Add a clang-tidy Visual Studio extension

alexfh requested changes to this revision. alexfh added a comment. This revision now requires changes to proceed. Awesome! A few comments. Comment at: CMakeLists.txt:6 @@ -5,2 +5,3 @@ add_subdirectory(clang-tidy) +add_subdirectory(clang-tidy-vs) endif() Shoul

Re: [PATCH] D23837: Fix colored diagnostics from tools

bruno added a comment. Hi Olivier, Can you add a test? Can you also include some context to the patch? Thanks, https://reviews.llvm.org/D23837 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/c

Re: [PATCH] D20512: [PATCH] Bug 27475 - Request header guard check processes .hpp files as well as .h files

madsravn added a comment. I have commit access. I can commit it myself :) thanks though. Is the documentation correct? I wasn't sure about the "\n ..." part. Comment at: clang-tidy/utils/HeaderGuard.h:15 @@ -14,1 +14,3 @@ +#include "../utils/HeaderFileExtensionsUtils.h" +#incl

Re: [PATCH] D20512: [PATCH] Bug 27475 - Request header guard check processes .hpp files as well as .h files

madsravn updated this revision to Diff 69158. madsravn marked 2 inline comments as done. madsravn added a comment. Documentation fix. https://reviews.llvm.org/D20512 Files: clang-tidy/llvm/HeaderGuardCheck.cpp clang-tidy/llvm/HeaderGuardCheck.h clang-tidy/utils/HeaderFileExtensionsUtils.c

Re: [PATCH] D20512: [PATCH] Bug 27475 - Request header guard check processes .hpp files as well as .h files

alexfh accepted this revision. alexfh added a comment. This revision is now accepted and ready to land. LG with a couple of nits. Do you need me to submit the patch for you? (If yes, I can fix the doc myself) Comment at: docs/clang-tidy/checks/llvm-header-guard.rst:8 @@ +7,3 @@

[libclc] r279656 - amdgcn: Also correct get_local_size type for HSA

Author: arsenm Date: Wed Aug 24 14:11:52 2016 New Revision: 279656 URL: http://llvm.org/viewvc/llvm-project?rev=279656&view=rev Log: amdgcn: Also correct get_local_size type for HSA Modified: libclc/trunk/amdgcn-amdhsa/lib/workitem/get_local_size.ll Modified: libclc/trunk/amdgcn-amdhsa/lib/w

Re: [PATCH] D20512: [PATCH] Bug 27475 - Request header guard check processes .hpp files as well as .h files

madsravn updated this revision to Diff 69152. madsravn marked 5 inline comments as done. madsravn added a comment. More suggestions by alexfh fixed. https://reviews.llvm.org/D20512 Files: clang-tidy/llvm/HeaderGuardCheck.cpp clang-tidy/llvm/HeaderGuardCheck.h clang-tidy/utils/HeaderFileEx

r279653 - Fix offload bundler tests so that diagnostic can start with caps.

Author: sfantao Date: Wed Aug 24 13:52:18 2016 New Revision: 279653 URL: http://llvm.org/viewvc/llvm-project?rev=279653&view=rev Log: Fix offload bundler tests so that diagnostic can start with caps. Windows require that. Modified: cfe/trunk/test/Driver/clang-offload-bundler.c Modified: cfe

Re: [PATCH] D23815: [Clang-tidy] Documentation style. Two Google checks are aliases

alexfh accepted this revision. alexfh added a comment. This revision is now accepted and ready to land. Awesome. Thanks! LG Repository: rL LLVM https://reviews.llvm.org/D23815 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.l

Re: [PATCH] D22507: Clang-tidy - Enum misuse check

alexfh requested changes to this revision. This revision now requires changes to proceed. Comment at: clang-tidy/misc/EnumMisuseCheck.cpp:215 @@ +214,3 @@ +"number(s)"); + diag(RhsExpr->getExprLoc(), "Used here as a bitmask.", +

Re: [PATCH] D20512: [PATCH] Bug 27475 - Request header guard check processes .hpp files as well as .h files

alexfh added a comment. Thank you! I've just noticed that we had completely ignored the actual docs =\ See the inline comment for details. Comment at: clang-tidy/llvm/HeaderGuardCheck.h:20 @@ -19,1 +19,3 @@ /// Finds and fixes header guards that do not adhere to LLVM style. +/

r279651 - DebugInfo: Add flag to CU to disable emission of inline debug info into the skeleton CU

Author: dblaikie Date: Wed Aug 24 13:29:58 2016 New Revision: 279651 URL: http://llvm.org/viewvc/llvm-project?rev=279651&view=rev Log: DebugInfo: Add flag to CU to disable emission of inline debug info into the skeleton CU In cases where .dwo/.dwp files are guaranteed to be available, skipping t

LLVM buildmaster will be updated and restarted tonight

Hello everyone, LLVM buildmaster will be updated and restarted after 6 PM Pacific time today. Thanks Galina ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Re: [PATCH] D20512: [PATCH] Bug 27475 - Request header guard check processes .hpp files as well as .h files

madsravn updated this revision to Diff 69143. madsravn added a comment. Fixed suggested by alexfh https://reviews.llvm.org/D20512 Files: clang-tidy/llvm/HeaderGuardCheck.cpp clang-tidy/llvm/HeaderGuardCheck.h clang-tidy/utils/HeaderFileExtensionsUtils.cpp clang-tidy/utils/HeaderFileExte

[libclc] r279644 - amdgcn: Fix return type for get_global_size

Author: arsenm Date: Wed Aug 24 12:52:04 2016 New Revision: 279644 URL: http://llvm.org/viewvc/llvm-project?rev=279644&view=rev Log: amdgcn: Fix return type for get_global_size Added: libclc/trunk/amdgcn/lib/workitem/get_global_size.ll libclc/trunk/r600/lib/workitem/get_global_size.ll

Re: [PATCH] D23815: [Clang-tidy] Documentation style. Two Google checks are aliases

Eugene.Zelenko updated this revision to Diff 69138. Eugene.Zelenko added a comment. Links are already there. Sorry for not uploading full diff at beginning. Repository: rL LLVM https://reviews.llvm.org/D23815 Files: docs/clang-tidy/checks/google-readability-namespace-comments.rst docs/cl

Re: [PATCH] D21134: clang-tidy: new check readability-misplaced-array-index

alexfh requested changes to this revision. alexfh added a comment. This revision now requires changes to proceed. A few nits. Comment at: clang-tidy/readability/MisplacedArrayIndexCheck.h:19 @@ +18,3 @@ + +/// Warn about unusual array index syntax (index[array] instead of +/// a

Re: [PATCH] D23842: [CFG] Add iterator_ranges to CFG and CFGBlock.

alexfh requested changes to this revision. This revision now requires changes to proceed. Comment at: include/clang/Analysis/CFG.h:526 @@ -524,1 +525,3 @@ typedef AdjacentBlocks::const_reverse_iterator const_pred_reverse_iterator; + typedef llvm::iterator_range

Re: [PATCH] D20512: [PATCH] Bug 27475 - Request header guard check processes .hpp files as well as .h files

alexfh requested changes to this revision. This revision now requires changes to proceed. Comment at: clang-tidy/llvm/HeaderGuardCheck.cpp:18 @@ +17,3 @@ + StringRef extension = ::llvm::sys::path::extension(Filename); + if (extension.size() > 0 && extension.front() == '.') { +

r279641 - clang-offload-bundler: Update libdeps.

Author: chapuni Date: Wed Aug 24 12:05:48 2016 New Revision: 279641 URL: http://llvm.org/viewvc/llvm-project?rev=279641&view=rev Log: clang-offload-bundler: Update libdeps. Modified: cfe/trunk/tools/clang-offload-bundler/CMakeLists.txt Modified: cfe/trunk/tools/clang-offload-bundler/CMakeLis

r279639 - fix typo "varaible"

Author: nico Date: Wed Aug 24 11:37:21 2016 New Revision: 279639 URL: http://llvm.org/viewvc/llvm-project?rev=279639&view=rev Log: fix typo "varaible" Modified: cfe/trunk/test/SemaCXX/warn-range-loop-analysis.cpp Modified: cfe/trunk/test/SemaCXX/warn-range-loop-analysis.cpp URL: http://llvm

Re: [PATCH] D20512: [PATCH] Bug 27475 - Request header guard check processes .hpp files as well as .h files

madsravn updated this revision to Diff 69131. madsravn marked 8 inline comments as done. madsravn added a comment. Updated the patch as suggested by hokein and alexfh. https://reviews.llvm.org/D20512 Files: clang-tidy/llvm/HeaderGuardCheck.cpp clang-tidy/llvm/HeaderGuardCheck.h clang-tidy

Re: [PATCH] D23842: [CFG] Add iterator_ranges to CFG and CFGBlock.

mboehme updated this revision to Diff 69129. mboehme added a comment. Re-add inadvertently deleted blank line https://reviews.llvm.org/D23842 Files: include/clang/Analysis/CFG.h Index: include/clang/Analysis/CFG.h === --- includ

[PATCH] D23842: [CFG] Add iterator_ranges to CFG and CFGBlock.

mboehme created this revision. mboehme added a reviewer: alexfh. mboehme added a subscriber: cfe-commits. (Needed for D23353.) https://reviews.llvm.org/D23842 Files: include/clang/Analysis/CFG.h Index: include/clang/Analysis/CFG.h ==

Re: [PATCH] D22584: constexpr array support C++1z (P0031)

mclow.lists added a comment. This diff no longer applies cleanly, and I've added some formatting concerns. However, the //content// looks fine to me. Comment at: include/array:176 @@ -175,3 +175,3 @@ _LIBCPP_INLINE_VISIBILITY -const_iterator cend() const _NOEXCEPT {re

r279635 - Add target REQUIRES directives to offload bundler test.

Author: sfantao Date: Wed Aug 24 10:47:06 2016 New Revision: 279635 URL: http://llvm.org/viewvc/llvm-project?rev=279635&view=rev Log: Add target REQUIRES directives to offload bundler test. Modified: cfe/trunk/test/Driver/clang-offload-bundler.c Modified: cfe/trunk/test/Driver/clang-offload

r279634 - [Driver][OpenMP][CUDA] Add capability to bundle object files in sections of the host binary format.

Author: sfantao Date: Wed Aug 24 10:39:07 2016 New Revision: 279634 URL: http://llvm.org/viewvc/llvm-project?rev=279634&view=rev Log: [Driver][OpenMP][CUDA] Add capability to bundle object files in sections of the host binary format. Summary: This patch adds the capability to bundle object files

Re: [PATCH] D23279: clang-reorder-fields

djasper added inline comments. Comment at: clang-reorder-fields/ReorderFieldsAction.cpp:137 @@ +136,3 @@ +std::end(NewWrittenInitializersOrder), ByFieldNewPosition); + assert(OldWrittenInitializersOrder.size() == + NewWrittenInitializersOrder.size());

Re: [PATCH] D23840: New options -fexceptions-fp-math and -fdenormal-fp-math

SjoerdMeijer updated this revision to Diff 69125. https://reviews.llvm.org/D23840 Files: include/clang/Driver/Options.td include/clang/Frontend/CodeGenOptions.def include/clang/Frontend/CodeGenOptions.h lib/CodeGen/CGCall.cpp lib/Driver/Tools.cpp lib/Frontend/CompilerInvocation.cpp

r279632 - clang-offload-bundler - offload files bundling/unbundling tool

Author: sfantao Date: Wed Aug 24 10:21:05 2016 New Revision: 279632 URL: http://llvm.org/viewvc/llvm-project?rev=279632&view=rev Log: clang-offload-bundler - offload files bundling/unbundling tool Summary: One of the goals of programming models that support offloading (e.g. OpenMP) is to enable

Re: [PATCH] D13909: clang-offload-bundler - offload files bundling/unbundling tool

Hahnfeld added a comment. SGTM https://reviews.llvm.org/D13909 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Re: [PATCH] D13909: clang-offload-bundler - offload files bundling/unbundling tool

sfantao added a comment. Hi Jonas, Thanks again for the review! Comment at: test/CMakeLists.txt:27-33 @@ -26,8 +26,9 @@ list(APPEND CLANG_TEST_DEPS clang clang-headers clang-format c-index-test diagtool clang-tblgen + clang-offload-bundler ) -

Re: [PATCH] D13909: clang-offload-bundler - offload files bundling/unbundling tool

sfantao updated this revision to Diff 69124. sfantao marked an inline comment as done. sfantao added a comment. - Add clang-offload bundler as dependency to clang. https://reviews.llvm.org/D13909 Files: test/CMakeLists.txt test/Driver/clang-offload-bundler.c tools/CMakeLists.txt tools/c

[PATCH] D23840: New options -fexceptions-fp-math and -fdenormal-fp-math

SjoerdMeijer created this revision. SjoerdMeijer added reviewers: jmolloy, ddunbar, rengolin, sanjoy. SjoerdMeijer added a subscriber: cfe-commits. This adds options -fexceptions-fp-math and -fdenormal-fp-math, which are translated to function attributes. This is intended to be mapped on build a

[PATCH] D23837: Fix colored diagnostics from tools

ogoffart created this revision. ogoffart added reviewers: bruno, dexonsmith, cfe-commits. Herald added a subscriber: klimek. r271042 changed the way the diagnostic arguments are parsed. It assumes that the diagnostics options were already parsed by the "Driver". For tools using clang::Tooling, the

Re: [PATCH] D21502: Fix heuristics skipping invalid ctor-initializers with C++11

ogoffart added a comment. Ping! https://reviews.llvm.org/D21502 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Re: [PATCH] D21134: clang-tidy: new check readability-misplaced-array-index

danielmarjamaki marked 6 inline comments as done. Comment at: clang-tidy/readability/MisplacedArrayIndexCheck.cpp:57 @@ +56,2 @@ +} // namespace tidy +} // namespace clang I removed hasMacroId() and use fixit::getText(). The replacements look good now. ==

Re: [PATCH] D21134: clang-tidy: new check readability-misplaced-array-index

danielmarjamaki updated this revision to Diff 69113. danielmarjamaki added a comment. fixed review comments https://reviews.llvm.org/D21134 Files: clang-tidy/readability/CMakeLists.txt clang-tidy/readability/MisplacedArrayIndexCheck.cpp clang-tidy/readability/MisplacedArrayIndexCheck.h

Re: [PATCH] D23787: Add builder for clang extra tools Sphinx docs

gribozavr added a comment. We need to ask Galina Kistanova to reload the configuration. Repository: rL LLVM https://reviews.llvm.org/D23787 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe

Re: [PATCH] D23787: Add builder for clang extra tools Sphinx docs

alexfh added a comment. Do you know whether build slaves should pick this configuration change up automatically? Repository: rL LLVM https://reviews.llvm.org/D23787 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cg

Re: [PATCH] D23787: Add builder for clang extra tools Sphinx docs

This revision was automatically updated to reflect the committed changes. alexfh marked an inline comment as done. Closed by commit rL279624: Add builder for clang extra tools Sphinx docs (authored by alexfh). Changed prior to commit: https://reviews.llvm.org/D23787?vs=68967&id=69110#toc Repos

Re: [PATCH] D23787: Add builder for clang extra tools Sphinx docs

gribozavr accepted this revision. gribozavr added a comment. This revision is now accepted and ready to land. Thanks, LGTM! https://reviews.llvm.org/D23787 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman

  1   2   >