Eugene.Zelenko updated this revision to Diff 69138.
Eugene.Zelenko added a comment.
Links are already there. Sorry for not uploading full diff at beginning.
Repository:
rL LLVM
https://reviews.llvm.org/D23815
Files:
docs/clang-tidy/checks/google-readability-namespace-comments.rst
docs/clang-tidy/checks/google-readability-redundant-smartptr-get.rst
docs/clang-tidy/checks/list.rst
docs/clang-tidy/checks/llvm-namespace-comment.rst
docs/clang-tidy/checks/misc-definitions-in-headers.rst
docs/clang-tidy/checks/misc-string-constructor.rst
docs/clang-tidy/checks/readability-redundant-control-flow.rst
docs/clang-tidy/checks/readability-redundant-smartptr-get.rst
Index: docs/clang-tidy/checks/readability-redundant-smartptr-get.rst
===================================================================
--- docs/clang-tidy/checks/readability-redundant-smartptr-get.rst
+++ docs/clang-tidy/checks/readability-redundant-smartptr-get.rst
@@ -3,12 +3,14 @@
readability-redundant-smartptr-get
==================================
+`google-readability-redundant-smartptr-get` redirects here as an alias for this
+check.
Find and remove redundant calls to smart pointer's ``.get()`` method.
Examples:
-.. code:: c++
+.. code-block:: c++
ptr.get()->Foo() ==> ptr->Foo()
*ptr.get() ==> *ptr
Index: docs/clang-tidy/checks/readability-redundant-control-flow.rst
===================================================================
--- docs/clang-tidy/checks/readability-redundant-control-flow.rst
+++ docs/clang-tidy/checks/readability-redundant-control-flow.rst
@@ -4,17 +4,16 @@
==================================
This check looks for procedures (functions returning no value) with ``return``
-statements at the end of the function. Such ``return`` statements are
-redundant.
+statements at the end of the function. Such ``return`` statements are redundant.
Loop statements (``for``, ``while``, ``do while``) are checked for redundant
``continue`` statements at the end of the loop body.
Examples:
-The following function `f` contains a redundant `return` statement:
+The following function `f` contains a redundant ``return`` statement:
-.. code:: c++
+.. code-block:: c++
extern void g();
void f() {
@@ -24,16 +23,16 @@
becomes
-.. code:: c++
+.. code-block:: c++
extern void g();
void f() {
g();
}
-The following function `k` contains a redundant `continue` statement:
+The following function `k` contains a redundant ``continue`` statement:
-.. code:: c++
+.. code-block:: c++
void k() {
for (int i = 0; i < 10; ++i) {
@@ -43,7 +42,7 @@
becomes
-.. code:: c++
+.. code-block:: c++
void k() {
for (int i = 0; i < 10; ++i) {
Index: docs/clang-tidy/checks/google-readability-namespace-comments.rst
===================================================================
--- docs/clang-tidy/checks/google-readability-namespace-comments.rst
+++ docs/clang-tidy/checks/google-readability-namespace-comments.rst
@@ -1,11 +1,9 @@
.. title:: clang-tidy - google-readability-namespace-comments
+.. meta::
+ :http-equiv=refresh: 5;URL=llvm-namespace-comment.html
google-readability-namespace-comments
=====================================
-
-Checks that long namespaces have a closing comment.
-
-http://llvm.org/docs/CodingStandards.html#namespace-indentation
-
-https://google.github.io/styleguide/cppguide.html#Namespaces
+The google-readability-namespace-comments check is an alias, please see
+`llvm-namespace-comment <llvm-namespace-comment.html>`_ for more information.
Index: docs/clang-tidy/checks/misc-string-constructor.rst
===================================================================
--- docs/clang-tidy/checks/misc-string-constructor.rst
+++ docs/clang-tidy/checks/misc-string-constructor.rst
@@ -9,27 +9,24 @@
Examples:
-.. code:: c++
+.. code-block:: c++
std::string('x', 50) str; // should be std::string(50, 'x')
-
Calling the string-literal constructor with a length bigger than the literal is
suspicious and adds extra random characters to the string.
Examples:
-.. code:: c++
+.. code-block:: c++
std::string("test", 200); // Will include random characters after "test".
-
Creating an empty string from constructors with parameters is considered
suspicious. The programmer should use the empty constructor instead.
Examples:
-.. code:: c++
+.. code-block:: c++
std::string("test", 0); // Creation of an empty string.
-
Index: docs/clang-tidy/checks/llvm-namespace-comment.rst
===================================================================
--- docs/clang-tidy/checks/llvm-namespace-comment.rst
+++ docs/clang-tidy/checks/llvm-namespace-comment.rst
@@ -3,6 +3,8 @@
llvm-namespace-comment
======================
+`google-readability-namespace-comments` redirects here as an alias for this
+check.
Checks that long namespaces have a closing comment.
Index: docs/clang-tidy/checks/google-readability-redundant-smartptr-get.rst
===================================================================
--- docs/clang-tidy/checks/google-readability-redundant-smartptr-get.rst
+++ docs/clang-tidy/checks/google-readability-redundant-smartptr-get.rst
@@ -1,16 +1,10 @@
.. title:: clang-tidy - google-readability-redundant-smartptr-get
+.. meta::
+ :http-equiv=refresh: 5;URL=readability-redundant-smartptr-get.html
google-readability-redundant-smartptr-get
=========================================
-
-Find and remove redundant calls to smart pointer's ``.get()`` method.
-
-Examples:
-
-.. code:: c++
-
- ptr.get()->Foo() ==> ptr->Foo()
- *ptr.get() ==> *ptr
- *ptr->get() ==> **ptr
-
+The google-readability-redundant-smartptr-get check is an alias, please see
+`readability-redundant-smartptr-get <readability-redundant-smartptr-get.html>`_
+for more information.
Index: docs/clang-tidy/checks/list.rst
===================================================================
--- docs/clang-tidy/checks/list.rst
+++ docs/clang-tidy/checks/list.rst
@@ -40,8 +40,8 @@
google-readability-braces-around-statements (redirects to readability-braces-around-statements) <google-readability-braces-around-statements>
google-readability-casting
google-readability-function-size (redirects to readability-function-size) <google-readability-function-size>
- google-readability-namespace-comments
- google-readability-redundant-smartptr-get
+ google-readability-namespace-comments (redirects to llvm-namespace-comment) <google-readability-namespace-comments>
+ google-readability-redundant-smartptr-get (redirects to readability-redundant-smartptr-get) <google-readability-redundant-smartptr-get>
google-readability-todo
google-runtime-int
google-runtime-member-string-references
Index: docs/clang-tidy/checks/misc-definitions-in-headers.rst
===================================================================
--- docs/clang-tidy/checks/misc-definitions-in-headers.rst
+++ docs/clang-tidy/checks/misc-definitions-in-headers.rst
@@ -7,7 +7,7 @@
which can lead to potential ODR violations in case these headers are included
from multiple translation units.
-.. code:: c++
+.. code-block:: c++
// Foo.h
int a = 1; // Warning: variable definition.
@@ -38,9 +38,10 @@
}
class A {
- public:
+ public:
int f1() { return 1; } // OK: implicitly inline member function definition is allowed.
int f2();
+
static int d;
};
_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
