Author: ericwf
Date: Thu May 5 01:30:05 2016
New Revision: 268613
URL: http://llvm.org/viewvc/llvm-project?rev=268613&view=rev
Log:
Try and fix sphinx build
Modified:
libcxx/trunk/docs/TestingLibcxx.rst
Modified: libcxx/trunk/docs/TestingLibcxx.rst
URL:
http://llvm.org/viewvc/llvm-project/
pxli168 added a comment.
If we want to save some space, could we use some macro to expand the gentype or
some script to expand the gentype into each types when the clang is build?
http://reviews.llvm.org/D18369
___
cfe-commits mailing list
cfe-comm
pxli168 added a comment.
Could we output a generic function in CodeGen?
This seems to have no big difference to have a lot of declaration in an opencl
c header file.
http://reviews.llvm.org/D19932
___
cfe-commits mailing list
cfe-commits@lists.llvm
nicholas updated this revision to Diff 56236.
nicholas added a comment.
(Whoops, forgot to generate diff with full context for phab.)
http://reviews.llvm.org/D19851
Files:
include/clang/Basic/DiagnosticSemaKinds.td
lib/Sema/SemaInit.cpp
test/CXX/expr/expr.prim/expr.prim.lambda/p5.cpp
te
nicholas updated this revision to Diff 56235.
nicholas marked an inline comment as done.
http://reviews.llvm.org/D19851
Files:
include/clang/Basic/DiagnosticSemaKinds.td
lib/Sema/SemaInit.cpp
test/CXX/expr/expr.prim/expr.prim.lambda/p5.cpp
test/Parser/cxx-casting.cpp
test/SemaCXX/cstyle
nicholas marked 2 inline comments as done.
Comment at: lib/Sema/SemaInit.cpp:3514-3518
@@ +3513,7 @@
+static void CheckForNullPointerDereference(Sema &S, const Expr *E) {
+ // Check to see if we are dereferencing a null pointer. If so,
+ // and if not volatile-qualified, this i
Author: rsmith
Date: Wed May 4 21:53:55 2016
New Revision: 268600
URL: http://llvm.org/viewvc/llvm-project?rev=268600&view=rev
Log:
Documentation updates for recent changes to VLAs and default-initialization of
const-qualified class objects.
Modified:
cfe/trunk/www/compatibility.html
Modif
majnemer added inline comments.
Comment at: lib/AST/MicrosoftMangle.cpp:1583-1584
@@ -1579,2 +1582,4 @@
case QMM_Result:
+// Presence of __unaligned qualifier shouldn't affect mangling here.
+Quals.removeUnaligned();
if ((!IsPointer && Quals) || isa(T)) {
-
rsmith added a comment.
In http://reviews.llvm.org/D19851#420762, @nicholas wrote:
> I did not expand this to SK_BindReferenceToTemporary, please review this
> decision. It's also missing missing bit-field and vector element checks that
> SK_BindReference has.
That's fine. SK_BindReferenceToT
etienneb requested changes to this revision.
etienneb added a comment.
This revision now requires changes to proceed.
If the 'original' size is available, the checkers should by-pass the heuristic.
Can you check if there is a way to get the original size.
Comment at: clang-tidy/
Author: rsmith
Date: Wed May 4 21:14:06 2016
New Revision: 268595
URL: http://llvm.org/viewvc/llvm-project?rev=268595&view=rev
Log:
Update FIXME.
Modified:
cfe/trunk/lib/Sema/SemaLookup.cpp
Modified: cfe/trunk/lib/Sema/SemaLookup.cpp
URL:
http://llvm.org/viewvc/llvm-project/cfe/trunk/lib/S
Author: rsmith
Date: Wed May 4 21:13:49 2016
New Revision: 268594
URL: http://llvm.org/viewvc/llvm-project?rev=268594&view=rev
Log:
Fix implementation of C++'s restrictions on using-declarations referring to
enumerators:
* an unscoped enumerator whose enumeration is a class member is itself a
Author: ahatanak
Date: Wed May 4 20:41:07 2016
New Revision: 268589
URL: http://llvm.org/viewvc/llvm-project?rev=268589&view=rev
Log:
Do not add uwtable attribute by default for MachO targets.
r217178 changed clang to add function attribute uwtable by default on
Win64, which caused the __eh_fram
Author: rsmith
Date: Wed May 4 19:56:12 2016
New Revision: 268585
URL: http://llvm.org/viewvc/llvm-project?rev=268585&view=rev
Log:
[modules] Enforce the rules that an explicit or partial specialization must be
declared before it is used. Because we don't use normal name lookup to find
these, the
Hello,
> I would appreciate a bit more background on this attribute's
> semantics. How would a user know when to add this attribute to their
> function definition? Are there other attributes that cannot be used in
> conjunction with this one? Should this apply to member functions? What
> about Obj
majnemer added inline comments.
Comment at: lib/AST/MicrosoftMangle.cpp:1583-1584
@@ -1579,2 +1582,4 @@
case QMM_Result:
+// Presence of __unaligned qualifier shouldn't affect mangling here.
+Quals.removeUnaligned();
if ((!IsPointer && Quals) || isa(T)) {
-
Eugene.Zelenko created this revision.
Eugene.Zelenko added reviewers: hans, aaron.ballman.
Eugene.Zelenko added a subscriber: cfe-commits.
Eugene.Zelenko set the repository for this revision to rL LLVM.
I checked this patch on my own build on RHEL 6. Regressions were OK.
Repository:
rL LLVM
ht
Author: alexfh
Date: Wed May 4 19:09:29 2016
New Revision: 268579
URL: http://llvm.org/viewvc/llvm-project?rev=268579&view=rev
Log:
[clang-tidy] Improve -warnings-as-errors tests.
Added:
clang-tools-extra/trunk/test/clang-tidy/werrors-diagnostics.cpp
Modified:
clang-tools-extra/trunk/tes
Author: koriakin
Date: Wed May 4 18:37:40 2016
New Revision: 268575
URL: http://llvm.org/viewvc/llvm-project?rev=268575&view=rev
Log:
[SystemZ] Add -mbackchain option.
This option, like the corresponding gcc option, is SystemZ-specific and
enables storing frame backchain links, as specified in t
This revision was automatically updated to reflect the committed changes.
Closed by commit rL268575: [SystemZ] Add -mbackchain option. (authored by
koriakin).
Changed prior to commit:
http://reviews.llvm.org/D19891?vs=56072&id=56223#toc
Repository:
rL LLVM
http://reviews.llvm.org/D19891
Fi
dschuff updated this revision to Diff 56218.
dschuff added a comment.
- Introduce CGCXXABI::canCallMismatchedFunctionType
http://reviews.llvm.org/D19275
Files:
lib/CodeGen/CGCXXABI.h
lib/CodeGen/CGDeclCXX.cpp
lib/CodeGen/ItaniumCXXABI.cpp
test/CodeGenCXX/static-destructor.cpp
Index: te
dschuff added a comment.
Thanks for the feedback, PTAL
http://reviews.llvm.org/D19275
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
uweigand accepted this revision.
uweigand added a comment.
This revision is now accepted and ready to land.
LGTM.
Repository:
rL LLVM
http://reviews.llvm.org/D19891
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi
etienneb added inline comments.
Comment at: lib/ASTMatchers/Dynamic/Marshallers.h:102
@@ +101,3 @@
+ static clang::CastKind getCastKind(llvm::StringRef AttrKind) {
+return llvm::StringSwitch(AttrKind)
+ .Case("CK_Dependent", CK_Dependent)
aaron.ballman w
What Reid said...
Yours,
Andrey
> 5 мая 2016 г., в 1:48, Reid Kleckner написал(а):
>
> rnk added inline comments.
>
>
> Comment at: lib/AST/MicrosoftMangle.cpp:1583-1584
> @@ -1579,2 +1582,4 @@
> case QMM_Result:
> +// Presence of __unaligned qualifier shouldn't affect m
etienneb added a comment.
Other opinions?
I'll proceed to the cleanup if no one else has comments.
Comment at: include/clang/ASTMatchers/ASTMatchers.h:1575
@@ +1574,3 @@
+/// \code
+/// char *s = "abcd"; wchar_t *ws = L"abcd";
+/// char *t = "a";
aaron.ballm
rnk added inline comments.
Comment at: lib/AST/MicrosoftMangle.cpp:1583-1584
@@ -1579,2 +1582,4 @@
case QMM_Result:
+// Presence of __unaligned qualifier shouldn't affect mangling here.
+Quals.removeUnaligned();
if ((!IsPointer && Quals) || isa(T)) {
--
majnemer added inline comments.
Comment at: lib/AST/MicrosoftMangle.cpp:1583-1584
@@ -1579,2 +1582,4 @@
case QMM_Result:
+// Presence of __unaligned qualifier shouldn't affect mangling here.
+Quals.removeUnaligned();
if ((!IsPointer && Quals) || isa(T)) {
-
george.burgess.iv added a comment.
Ping :)
http://reviews.llvm.org/D17462
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
On Tue, May 3, 2016 at 4:38 PM, Paul Robinson via cfe-commits <
cfe-commits@lists.llvm.org> wrote:
> probinson marked 2 inline comments as done.
>
>
> Comment at: include/clang/Basic/Attr.td:86-88
> @@ -85,1 +85,5 @@
> +def NonParmVar : SubsetSubject +
On Wed, May 4, 2016 at 1:43 PM, Aaron Ballman via cfe-commits <
cfe-commits@lists.llvm.org> wrote:
> jbcoe wrote:
> > aaron.ballman wrote:
> > > I believe we use "modernize" to really mean "migrate from the old way
> to the new way", which this definitely fits into since I think the point to
> thi
Author: alexfh
Date: Wed May 4 16:18:31 2016
New Revision: 268555
URL: http://llvm.org/viewvc/llvm-project?rev=268555&view=rev
Log:
[clang-tidy] Apply NOLINT filtering to Clang warnings.
Modified:
clang-tools-extra/trunk/clang-tidy/ClangTidyDiagnosticConsumer.cpp
clang-tools-extra/trunk/
aaron.ballman closed this revision.
aaron.ballman added a comment.
I have commit in r268553
http://reviews.llvm.org/D19062
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
Author: aaronballman
Date: Wed May 4 16:08:13 2016
New Revision: 268553
URL: http://llvm.org/viewvc/llvm-project?rev=268553&view=rev
Log:
Add the Pure attribute to C99 builtin functions from ctype.h. This is a
corrected version of r266199 with test case fixes.
Patch by Taewook Oh.
Added:
c
bcraig created this revision.
bcraig added reviewers: olista01, t.p.northover.
bcraig added a subscriber: cfe-commits.
note_fe_backend_invalid_loc expects three arguments (file, line, column), and
will assert when only given two. The other two places in this file that use
note_fe_backend_invali
Sounds great. Thanks!
-eric
On Wed, May 4, 2016 at 4:36 AM Andrey Turetskiy
wrote:
> aturetsk added a comment.
>
> Hi,
> Thanks for the review.
>
> Committed:
>
> 1. Add a test for driver options from m_x86_Features_Group (
> http://reviews.llvm.org/rL268487)
> 2. Add missing -mno-cx16 driver o
Author: sbenza
Date: Wed May 4 15:45:00 2016
New Revision: 268548
URL: http://llvm.org/viewvc/llvm-project?rev=268548&view=rev
Log:
Fix the doc extraction script to work with hasAnyName and with equalsNode.
The change from llvm::VariadicFunction to internal::VariadicFunction
broke the extraction
aaron.ballman added inline comments.
Comment at: clang-tidy/readability/ReadabilityTidyModule.cpp:17
@@ -15,2 +16,2 @@
#include "ContainerSizeEmptyCheck.h"
#include "DeletedDefaultCheck.h"
jbcoe wrote:
> aaron.ballman wrote:
> > I believe we use "modernize" to r
Author: ericwf
Date: Wed May 4 15:29:19 2016
New Revision: 268543
URL: http://llvm.org/viewvc/llvm-project?rev=268543&view=rev
Log:
Removing some trailing whitespace
Modified:
libcxx/trunk/test/std/utilities/utility/pairs/pairs.pair/swap.pass.cpp
libcxx/trunk/test/std/utilities/utility/p
Author: kcc
Date: Wed May 4 15:24:54 2016
New Revision: 268541
URL: http://llvm.org/viewvc/llvm-project?rev=268541&view=rev
Log:
fix docs
Modified:
cfe/trunk/docs/UsersManual.rst
Modified: cfe/trunk/docs/UsersManual.rst
URL:
http://llvm.org/viewvc/llvm-project/cfe/trunk/docs/UsersManual.rs
Author: kcc
Date: Wed May 4 15:21:47 2016
New Revision: 268540
URL: http://llvm.org/viewvc/llvm-project?rev=268540&view=rev
Log:
document -f[no-]sanitize-recover=all and mention it in warning messages
Modified:
cfe/trunk/docs/UsersManual.rst
cfe/trunk/lib/Driver/SanitizerArgs.cpp
cfe
twoh updated this revision to Diff 56198.
twoh added a comment.
Rebased on ToT. Thanks @aaron.ballman!
http://reviews.llvm.org/D19062
Files:
include/clang/Basic/Builtins.def
include/clang/Basic/Builtins.h
lib/Sema/SemaDecl.cpp
test/FixIt/typo.m
test/Sema/enable_if.c
test/Sema/libbui
erik.pilkington created this revision.
erik.pilkington added a reviewer: rsmith.
erik.pilkington added a subscriber: cfe-commits.
Previously, `clang::VersionTuple`'s fields were laid out in an unfortunate way
that made the object larger than it ought to have been. This patch just
reorders the fi
jbcoe added inline comments.
Comment at: clang-tidy/readability/ReadabilityTidyModule.cpp:17
@@ -15,2 +16,2 @@
#include "ContainerSizeEmptyCheck.h"
#include "DeletedDefaultCheck.h"
aaron.ballman wrote:
> I believe we use "modernize" to really mean "migrate from
jbcoe added a comment.
After some pondering I think I **will**extend move this check to
cppcoreguidelines and call it rule-of-five.
https://github.com/isocpp/CppCoreGuidelines/blob/master/CppCoreGuidelines.md#c21-if-you-define-or-delete-any-default-operation-define-or-delete-them-all
http://r
yaxunl updated this revision to Diff 56194.
yaxunl added a comment.
Update the test.
http://reviews.llvm.org/D19932
Files:
include/clang/Basic/Builtins.def
include/clang/Basic/DiagnosticSemaKinds.td
lib/AST/Decl.cpp
lib/CodeGen/CGBuiltin.cpp
lib/Sema/SemaChecking.cpp
lib/Sema/SemaEx
yaxunl created this revision.
yaxunl added reviewers: Anastasia, pxli168.
yaxunl added subscribers: cfe-commits, tstellarAMD.
OpenCL builtin functions to_{global|local|private} accepts argument of pointer
type to arbitrary pointee type, and return a pointer to the same pointee type
in different
timshen created this revision.
timshen added a reviewer: rsmith.
timshen added a subscriber: cfe-commits.
Use pushCleanupAfterFullExpr to add lifetime.end markers for
lifetime-extended temporaries, similar to the way destructor calls get
generated.
It does not change the AST representation. It
On Tue, May 3, 2016 at 12:18 PM, Ettore Speziale
wrote:
> Hello,
>
> the attached patch introduces the `convergent` attribute.
>
> It is meant to be lowered into the LLVM `convergent` attribute, to restrict
> optimizations of attributed functions — e.g. you can attach convergent to
> OpenCL’s ba
aaron.ballman added a comment.
In http://reviews.llvm.org/D19062#41, @twoh wrote:
> Ping. Can someone please commit this patch for me? Thanks!
Can you rebase the diff on ToT and update the review with the new patch? When I
try to apply, I get merge conflicts. Thanks!
http://reviews.llvm.
aaron.ballman added inline comments.
Comment at: clang-tidy/readability/ReadabilityTidyModule.cpp:17
@@ -15,2 +16,2 @@
#include "ContainerSizeEmptyCheck.h"
#include "DeletedDefaultCheck.h"
I believe we use "modernize" to really mean "migrate from the old way to
aaron.ballman accepted this revision.
aaron.ballman added a comment.
This revision is now accepted and ready to land.
LGTM!
http://reviews.llvm.org/D19754
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/
aaron.ballman accepted this revision.
aaron.ballman added a comment.
This revision is now accepted and ready to land.
This generally LGTM, but you should wait for @rsmith to sign off before
committing.
Comment at: test/CXX/expr/expr.prim/expr.prim.lambda/p5.cpp:39
@@ -38,3 +38,
aaron.ballman added a comment.
Generally, I think this should make use of the patchable function functionality
from http://reviews.llvm.org/D19046 when lowering, but I do have some comments
on the attribute itself as well.
Comment at: include/clang/Basic/Attr.td:2032
@@ -2031,
Author: ahatanak
Date: Wed May 4 13:40:33 2016
New Revision: 268532
URL: http://llvm.org/viewvc/llvm-project?rev=268532&view=rev
Log:
[CodeGenObjCXX] Fix handling of blocks in lambda.
This fixes a crash that occurs when a block captures a reference that is
captured by its enclosing lambda.
rdar
This revision was automatically updated to reflect the committed changes.
Closed by commit rL268532: [CodeGenObjCXX] Fix handling of blocks in lambda.
(authored by ahatanak).
Changed prior to commit:
http://reviews.llvm.org/D19536?vs=56090&id=56183#toc
Repository:
rL LLVM
http://reviews.llv
On Wed, May 4, 2016 at 2:41 PM, Piotr Padlewski via cfe-commits
wrote:
> Prazek added a comment.
>
> In http://reviews.llvm.org/D18919#419902, @curdeius wrote:
>
>> I'm really interested in the manner this check works when a typedef has
>> multiple declarations in it (same example as in the comme
Prazek added a comment.
In http://reviews.llvm.org/D18919#419902, @curdeius wrote:
> I'm really interested in the manner this check works when a typedef has
> multiple declarations in it (same example as in the comment):
>
> typedef int m_int, *m_int_p, &m_int_r, m_int_arr[10], (&m_int_fun)(in
aaron.ballman added inline comments.
Comment at: include/clang/ASTMatchers/ASTMatchers.h:1575
@@ +1574,3 @@
+/// \code
+/// char *s = "abcd"; wchar_t *ws = L"abcd";
+/// char *t = "a";
etienneb wrote:
> aaron.ballman wrote:
> > Split these onto two lines?
> If
This revision was automatically updated to reflect the committed changes.
Closed by commit rL268527: [ObjC] Enter a new evaluation context before calling
(authored by ahatanak).
Changed prior to commit:
http://reviews.llvm.org/D18815?vs=56092&id=56178#toc
Repository:
rL LLVM
http://reviews.
Author: ahatanak
Date: Wed May 4 13:07:20 2016
New Revision: 268527
URL: http://llvm.org/viewvc/llvm-project?rev=268527&view=rev
Log:
[ObjC] Enter a new evaluation context before calling
BuildBlockForLambdaConversion.
Previously, clang would build an incorrect AST for the following code:
id tes
etienneb added a comment.
Aaron? could you comment on it?
Comment at: include/clang/ASTMatchers/ASTMatchers.h:1575
@@ +1574,3 @@
+/// \code
+/// char *s = "abcd"; wchar_t *ws = L"abcd";
+/// char *t = "a";
aaron.ballman wrote:
> Split these onto two lines?
I
etienneb updated this revision to Diff 56173.
etienneb marked 4 inline comments as done.
etienneb added a comment.
address alexfh comments
http://reviews.llvm.org/D19846
Files:
clang-tidy/misc/DanglingHandleCheck.cpp
clang-tidy/misc/SuspiciousStringCompareCheck.cpp
clang-tidy/performance/
mamai abandoned this revision.
mamai added a comment.
The test have been fixed otherwise in rev 268523.
Repository:
rL LLVM
http://reviews.llvm.org/D19925
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailm
Author: pete
Date: Wed May 4 12:37:27 2016
New Revision: 268523
URL: http://llvm.org/viewvc/llvm-project?rev=268523&view=rev
Log:
Update test CHECK lines after r268509. NFC.
r268509 causes this test case to be fully unrolled, so checking for an icmp is
no longer valid. Given that this test is
mamai created this revision.
mamai added a reviewer: compnerd.
mamai added a subscriber: cfe-commits.
mamai set the repository for this revision to rL LLVM.
This test have been broken by http://reviews.llvm.org/D19827, which re-enables
loop unrolling at /Os. Since the goal of this test does not s
filcab updated this revision to Diff 56164.
filcab added a comment.
Remove unneeded comments.
Simplify code.
http://reviews.llvm.org/D19666
Files:
docs/UndefinedBehaviorSanitizer.rst
include/clang/Driver/Options.td
include/clang/Frontend/CodeGenOptions.def
lib/CodeGen/CGExpr.cpp
lib/D
rmaprath added a comment.
@mclow.lists, @EricWF: Gentle ping.
http://reviews.llvm.org/D19412
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
rmaprath added a comment.
In http://reviews.llvm.org/D19920#421230, @bcraig wrote:
> > We could, on the other hand, do this tightening for all the supported
> > architectures (for the new, native-only libunwind build suggested by
> > @jroelofs) with appropriate asserts in place so that we maint
bcraig added a subscriber: bcraig.
bcraig added a comment.
> We could, on the other hand, do this tightening for all the supported
> architectures (for the new, native-only libunwind build suggested by
> @jroelofs) with appropriate asserts in place so that we maintain these tight
> bounds as we
klimek added inline comments.
Comment at: include-fixer/find-all-symbols/SymbolInfo.h:98-101
@@ +97,6 @@
+
+ static SymbolInfo
+ CreateFunctionSymbolInfo(const std::string &Name, const std::string
&FilePath,
+ const std::vector &Contexts, int
LineNumb
This revision was automatically updated to reflect the committed changes.
Closed by commit rL268511: [Coverage] Fix an issue where a coverage region
might not be created for a… (authored by ikudrin).
Changed prior to commit:
http://reviews.llvm.org/D19725?vs=55602&id=56159#toc
Repository:
rL
Author: ikudrin
Date: Wed May 4 10:38:26 2016
New Revision: 268511
URL: http://llvm.org/viewvc/llvm-project?rev=268511&view=rev
Log:
[Coverage] Fix an issue where a coverage region might not be created for a
macro containing a loop statement.
The issue happened when a macro contained a full for
rjmccall added a comment.
LGTM.
http://reviews.llvm.org/D18815
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
rjmccall added a comment.
Yes, that looks good, thanks.
http://reviews.llvm.org/D19536
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
rmaprath added a comment.
In http://reviews.llvm.org/D19920#421189, @jroelofs wrote:
> In http://reviews.llvm.org/D19920#421173, @rmaprath wrote:
>
> > In http://reviews.llvm.org/D19920#421145, @jroelofs wrote:
> >
> > > Wouldn't this break cross unwinding?
> >
> >
> > I wasn't aware of cross unw
Author: marshall
Date: Wed May 4 10:35:50 2016
New Revision: 268510
URL: http://llvm.org/viewvc/llvm-project?rev=268510&view=rev
Log:
Fixed some spelling errors in assert messages. No functional change. Thanks to
giffu...@yahoo.com for the report.
Modified:
libcxx/trunk/include/experimental
This revision was automatically updated to reflect the committed changes.
Closed by commit rL268509: Do not disable completely loop unroll when
optimizing for size. (authored by mamai).
Changed prior to commit:
http://reviews.llvm.org/D19827?vs=56133&id=56158#toc
Repository:
rL LLVM
http://
Author: mamai
Date: Wed May 4 10:26:28 2016
New Revision: 268509
URL: http://llvm.org/viewvc/llvm-project?rev=268509&view=rev
Log:
Do not disable completely loop unroll when optimizing for size.
Let the loop unroll pass handle /Os. It already checks that option and adjust
its thresholds accordi
jroelofs added a comment.
In http://reviews.llvm.org/D19920#421173, @rmaprath wrote:
> In http://reviews.llvm.org/D19920#421145, @jroelofs wrote:
>
> > Wouldn't this break cross unwinding?
>
>
> I wasn't aware of cross unwinding, I think you are referring to [1]. Thanks
> for the pointer.
>
> Wo
rnk added a subscriber: rnk.
rnk accepted this revision.
rnk added a reviewer: rnk.
rnk added a comment.
This revision is now accepted and ready to land.
lgtm
To be clear, loop unrolling just lowers its size threshold when -Os is on:
// Apply size attributes
if (L->getHeader()->getParent()->
rmaprath added a comment.
In http://reviews.llvm.org/D19920#421145, @jroelofs wrote:
> Wouldn't this break cross unwinding?
I wasn't aware of cross unwinding, I think you are referring to [1]. Thanks for
the pointer.
Would it make sense to support a libunwind build that only supports native
rmaprath added a comment.
In http://reviews.llvm.org/D19920#421131, @t.p.northover wrote:
> I think it would be better to use a generic method so the size is minimal
> everywhere rather than making ARM a special case. Possibly move the #define
> bits from libunwind.cpp to __libunwind_config.h a
rengolin added a comment.
I agree with Tim, I think this should be more generic.
http://reviews.llvm.org/D19920
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
jroelofs added a comment.
Wouldn't this break cross unwinding?
http://reviews.llvm.org/D19920
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
t.p.northover added a subscriber: t.p.northover.
t.p.northover added a comment.
I think it would be better to use a generic method so the size is minimal
everywhere rather than making ARM a special case. Possibly move the #define
bits from libunwind.cpp to __libunwind_config.h and use REGISTER_K
hokein added a comment.
It looks good to me now, but need to wait @klimek acceptance.
Comment at: include-fixer/find-all-symbols/SymbolInfo.h:98-101
@@ +97,6 @@
+
+ static SymbolInfo
+ CreateFunctionSymbolInfo(const std::string &Name, const std::string
&FilePath,
+
rmaprath created this revision.
rmaprath added a reviewer: jroelofs.
rmaprath added a subscriber: cfe-commits.
Herald added subscribers: rengolin, aemerson.
Currently, `unw_context_t` and `unw_cursor_t` are sized to allow the virtual
register set of any target supported by libunwind. This does no
ioeric updated this revision to Diff 56148.
ioeric added a comment.
- Removed SetCommonInfo declaration from header.
http://reviews.llvm.org/D19913
Files:
include-fixer/InMemoryXrefsDB.cpp
include-fixer/find-all-symbols/SymbolInfo.cpp
include-fixer/find-all-symbols/SymbolInfo.h
unittest
nhaustov created this revision.
nhaustov added reviewers: tstellarAMD, arsenm.
nhaustov added a subscriber: cfe-commits.
http://reviews.llvm.org/D19918
Files:
lib/CodeGen/TargetInfo.cpp
test/CodeGenOpenCL/amdgpu-calling-conv.cl
test/CodeGenOpenCL/amdgpu-num-gpr-attr.cl
Index: test/CodeGenO
ioeric updated this revision to Diff 56147.
ioeric added a comment.
- Removed unused function in unit test.
http://reviews.llvm.org/D19913
Files:
include-fixer/InMemoryXrefsDB.cpp
include-fixer/find-all-symbols/SymbolInfo.cpp
include-fixer/find-all-symbols/SymbolInfo.h
unittests/include
hokein added inline comments.
Comment at: unittests/include-fixer/find-all-symbols/FindAllSymbolsTests.cpp:92
@@ -107,5 +91,3 @@
-SymbolInfo
-CreateSymbolInfo(StringRef Name, SymbolInfo::SymbolKind Type,
- const std::string FilePath, int LineNumber,
-
ioeric updated this revision to Diff 56145.
ioeric added a comment.
- Use template to compare llvm::Optional types.
http://reviews.llvm.org/D19913
Files:
include-fixer/InMemoryXrefsDB.cpp
include-fixer/find-all-symbols/SymbolInfo.cpp
include-fixer/find-all-symbols/SymbolInfo.h
unittests
ioeric updated this revision to Diff 56143.
ioeric added a comment.
- Use static creator functions in SymbolInfo in FindAllSymbolTests, and make
SymbolInfo::operator== compare all fields.
http://reviews.llvm.org/D19913
Files:
include-fixer/InMemoryXrefsDB.cpp
include-fixer/find-all-symbols
ioeric updated this revision to Diff 56139.
ioeric marked 7 inline comments as done.
ioeric added a comment.
Use static creator functions in SymbolInfo in FindAllSymbolTests, and make
SymbolInfo::operator== compare all fields.
http://reviews.llvm.org/D19913
Files:
include-fixer/find-all-symb
ABataev accepted this revision.
ABataev added a comment.
This revision is now accepted and ready to land.
LG
http://reviews.llvm.org/D19812
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-co
Prazek retitled this revision from "Add modernize-bool-to-integer-conversion"
to "Add bugprone-bool-to-integer-conversion".
Prazek updated this revision to Diff 56138.
Prazek added a comment.
It seems that it works right now.
The other funny thing that the check found is cases like
bool b;
if (b
Thank you!
On 02.05.2016 06:40, Justin Bogner wrote:
Igor Kudrin writes:
+ /// \brief Check whether a region with bounds \c StartLoc and \c EndLoc
+ /// is already added to \c SourceRegions.
+ bool isRegionAlreadyAdded(SourceLocation StartLoc, SourceLocation EndLoc) {
+return SourceR
mamai retitled this revision from "Do not disable completely loop unroll
according to optimization level." to "Do not disable completely loop unroll
when optimizing for size.".
mamai updated the summary for this revision.
mamai updated this revision to Diff 56133.
mamai added a comment.
Modified
klimek added inline comments.
Comment at: include-fixer/find-all-symbols/SymbolInfo.h:90-93
@@ +89,6 @@
+
+ static SymbolInfo
+ CreateFunctionSymbolInfo(const std::string &Name, const std::string
&FilePath,
+ const std::vector &Contexts, int
LineNumbe
1 - 100 of 146 matches
Mail list logo
