This revision was automatically updated to reflect the committed changes.
Closed by commit rL266719: Warn if function or variable cannot be implicitly
instantiated (authored by sepavloff).
Changed prior to commit:
http://reviews.llvm.org/D16396?vs=54085&id=54163#toc
Repository:
rL LLVM
http
Author: sepavloff
Date: Tue Apr 19 01:19:52 2016
New Revision: 266719
URL: http://llvm.org/viewvc/llvm-project?rev=266719&view=rev
Log:
Warn if function or variable cannot be implicitly instantiated
With this patch compiler emits warning if it tries to make implicit
instantiation
of a template b
EricWF added a comment.
It's almost there.
Please move "fallback_malloc.ipp" into "fallback_malloc.cpp" and then delete
it all together. We can't have other files trying to include it.
Comment at: src/fallback_malloc.cpp:23
@@ +22,3 @@
+namespace __cxxabiv1 {
+
+void * __cxa_
This revision was automatically updated to reflect the committed changes.
Closed by commit rL266707: [CUDA] Add --cuda-compile-host-device, which
overrides --cuda-host-only and… (authored by jlebar).
Changed prior to commit:
http://reviews.llvm.org/D19248?vs=54148&id=54152#toc
Repository:
rL
This revision was automatically updated to reflect the committed changes.
Closed by commit rL266708: [CUDA] Add --no-cuda-noopt-debug, which disables
--cuda-noopt-debug. (authored by jlebar).
Changed prior to commit:
http://reviews.llvm.org/D19251?vs=54145&id=54153#toc
Repository:
rL LLVM
h
Author: jlebar
Date: Mon Apr 18 21:27:11 2016
New Revision: 266708
URL: http://llvm.org/viewvc/llvm-project?rev=266708&view=rev
Log:
[CUDA] Add --no-cuda-noopt-debug, which disables --cuda-noopt-debug.
Reviewers: tra
Subscribers: cfe-commits, jhen
Differential Revision: http://reviews.llvm.org/
Author: jlebar
Date: Mon Apr 18 21:27:07 2016
New Revision: 266707
URL: http://llvm.org/viewvc/llvm-project?rev=266707&view=rev
Log:
[CUDA] Add --cuda-compile-host-device, which overrides --cuda-host-only and
--cuda-device-only.
Summary:
This completes the flag's tristate, letting you override i
Thanks for catching this, r266706.
> On Apr 18, 2016, at 11:38 AM, Richard Smith wrote:
>
> On Mon, Apr 18, 2016 at 11:19 AM, Akira Hatanaka via cfe-commits
> mailto:cfe-commits@lists.llvm.org>> wrote:
> Author: ahatanak
> Date: Mon Apr 18 13:19:45 2016
> New Revision: 266645
>
> URL: http://l
Author: ahatanak
Date: Mon Apr 18 21:21:47 2016
New Revision: 266706
URL: http://llvm.org/viewvc/llvm-project?rev=266706&view=rev
Log:
Add a test case to check a member's default constructor is also run.
This is a follow-up to r266645.
Modified:
cfe/trunk/test/Parser/objc-default-ctor-init.m
ikudrin updated this revision to Diff 54151.
ikudrin added a comment.
Regenerated the patch against project's root.
http://reviews.llvm.org/D17815
Files:
src/CMakeLists.txt
src/cxa_exception.cpp
src/cxa_exception_storage.cpp
src/fallback_malloc.cpp
src/fallback_malloc.h
test/test_ex
EricWF created this revision.
EricWF added a reviewer: mclow.lists.
EricWF added a subscriber: cfe-commits.
See http://www.open-std.org/jtc1/sc22/wg21/docs/papers/2016/p0033r1.html
http://reviews.llvm.org/D19254
Files:
include/memory
test/std/utilities/memory/util.smartptr/util.smartptr.ena
Author: ericwf
Date: Mon Apr 18 20:19:25 2016
New Revision: 266703
URL: http://llvm.org/viewvc/llvm-project?rev=266703&view=rev
Log:
Make tuples constructors conditionally EXPLICIT. See N4387
Added:
libcxx/trunk/test/std/utilities/tuple/tuple.tuple/tuple.cnstr/alloc_const_Types.fail.cpp
jlebar added a comment.
Wow, oops. Thank you.
http://reviews.llvm.org/D19248
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
jlebar updated this revision to Diff 54148.
jlebar marked 2 inline comments as done.
jlebar added a comment.
Fix help text.
http://reviews.llvm.org/D19248
Files:
include/clang/Driver/Options.td
lib/Driver/Driver.cpp
test/Driver/cuda-options.cu
test/Driver/cuda-unused-arg-warning.cu
Ind
tra added a comment.
Help strings seem to be backwards.
LGTM otherwise.
Comment at: include/clang/Driver/Options.td:378
@@ -377,2 +377,3 @@
def cuda_device_only : Flag<["--"], "cuda-device-only">,
- HelpText<"Do device-side CUDA compilation only">;
+ HelpText<"Compile CUDA co
jlebar created this revision.
jlebar added a reviewer: tra.
jlebar added subscribers: jhen, cfe-commits.
http://reviews.llvm.org/D19251
Files:
include/clang/Driver/Options.td
lib/Driver/Tools.cpp
test/Driver/cuda-external-tools.cu
Index: test/Driver/cuda-external-tools.cu
=
chh created this revision.
chh added reviewers: srhines, alexfh.
chh added a subscriber: cfe-commits.
Herald added subscribers: danalbert, tberghammer.
https://llvm.org/bugs/show_bug.cgi?id=27355
To compile with other binary output directory structures in build systems like
Android.
http://rev
alexfh added a subscriber: alexfh.
alexfh added a comment.
Would be nice, if you could write a patch. I don't yet have a reduced test
case (it crashes without delayed template parsing), since my creduce is
still running after many hours ;)
Repository:
rL LLVM
http://reviews.llvm.org/D18584
Would be nice, if you could write a patch. I don't yet have a reduced test
case (it crashes without delayed template parsing), since my creduce is
still running after many hours ;)
On Apr 18, 2016 8:45 PM, "Michael Miller" wrote:
> michael_miller added a comment.
>
> In http://reviews.llvm.org/D1
jlebar created this revision.
jlebar added a reviewer: tra.
jlebar added subscribers: jhen, cfe-commits.
This completes the flag's tristate, letting you override it at will on
the command line.
http://reviews.llvm.org/D19248
Files:
include/clang/Driver/Options.td
lib/Driver/Driver.cpp
test
rsmith added inline comments.
Comment at: include/clang/Basic/DiagnosticSemaKinds.td:7417-7421
@@ -7416,4 +7416,7 @@
InGroup;
-def warn_va_start_of_reference_type_is_undefined : Warning<
- "'va_start' has undefined behavior with reference types">, InGroup;
+def warn_va_start_t
aaron.ballman added inline comments.
Comment at: include/clang/Basic/DiagnosticSemaKinds.td:7417-7421
@@ -7416,4 +7416,7 @@
InGroup;
-def warn_va_start_of_reference_type_is_undefined : Warning<
- "'va_start' has undefined behavior with reference types">, InGroup;
+def warn_va_
EricWF accepted this revision.
EricWF added a comment.
This revision is now accepted and ready to land.
LGTM. It's up to you if you want to address the inline comments before
committing.
Thanks for updating the Doc. I really need to kill one version of it.
Comment at: test/lib
EricWF created this revision.
EricWF added a reviewer: mclow.lists.
EricWF added a subscriber: cfe-commits.
This patch deprecates almost all C++03 extensions offered by .
These extensions started as fallback implementations for compilers without
variadic template support.
Since compiler support
Author: adrian
Date: Mon Apr 18 18:48:16 2016
New Revision: 266698
URL: http://llvm.org/viewvc/llvm-project?rev=266698&view=rev
Log:
[ObjC++] Fix crash when emitting debug info for a block member capturing this.
rdar://problem/23871824
Added:
cfe/trunk/test/CodeGenObjCXX/debug-info-block-cap
Hello everyone,
LLVM buildmaster will be updated and restarted after 6 PM Pacific time
today.
Thanks
Galina
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
alexfh added a comment.
In http://reviews.llvm.org/D19144#404234, @sbenza wrote:
> Sent http://reviews.llvm.org/D19231 to fix the underlying bug in
> `hasAncestor`.
> We can proceed with this change if you want, but it is not required anymore.
> I don't know whether we need the extra complexit
alexfh accepted this revision.
alexfh added a comment.
This revision is now accepted and ready to land.
Looks good. Thanks!
http://reviews.llvm.org/D19231
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/
rsmith added inline comments.
Comment at: include/clang/Basic/DiagnosticSemaKinds.td:7417-7421
@@ -7416,4 +7416,7 @@
InGroup;
-def warn_va_start_of_reference_type_is_undefined : Warning<
- "'va_start' has undefined behavior with reference types">, InGroup;
+def warn_va_start_t
Author: rsmith
Date: Mon Apr 18 18:12:59 2016
New Revision: 266695
URL: http://llvm.org/viewvc/llvm-project?rev=266695&view=rev
Log:
Mark -Xclang as being a compilation-only option so that the clang driver
doesn't warn if it's passed to a link action. This matches the behavior for
most other compi
aaron.ballman created this revision.
aaron.ballman added reviewers: rsmith, dblaikie.
aaron.ballman added a subscriber: cfe-commits.
Herald added a subscriber: aemerson.
The va_start macro currently diagnoses passing a reference as the second
argument (the one representing the parameter before th
vsk updated the summary for this revision.
vsk updated this revision to Diff 54128.
vsk added a comment.
- Remove extraneous whitespace changes.
http://reviews.llvm.org/D19243
Files:
lib/CodeGen/CGBlocks.cpp
lib/CodeGen/CGCall.cpp
lib/CodeGen/CGExpr.cpp
lib/CodeGen/CGObjC.cpp
lib/Code
vsk created this revision.
vsk added a reviewer: bogner.
vsk added a subscriber: cfe-commits.
Cons: 1 extra malloc per CodeGenFunction instantiation.
Pros: This makes incremental builds noticeably faster, especially on my laptop.
E.g with this patch there's no need to re-compile
clang/lib/CodeG
mprobst created this revision.
mprobst added a reviewer: djasper.
mprobst added a subscriber: cfe-commits.
Herald added a subscriber: klimek.
Change `import` and `export` parsing to special case the renaming
syntax (`import x, {y as bar} ...`, `export {x}`) and otherwise just
parse a regular struc
Author: rsmith
Date: Mon Apr 18 16:54:58 2016
New Revision: 266687
URL: http://llvm.org/viewvc/llvm-project?rev=266687&view=rev
Log:
[modules] Remove some more unnecessary forwarding functions.
Modified:
cfe/trunk/include/clang/Serialization/ASTWriter.h
cfe/trunk/lib/Serialization/ASTWrit
mprobst created this revision.
mprobst added a reviewer: djasper.
mprobst added a subscriber: cfe-commits.
Herald added a subscriber: klimek.
`interface` can be used as a fee standing identifier in JavaScript/TypeScript.
This change uses the heuristic of whether it's followed by another identifier
Author: kcc
Date: Mon Apr 18 16:30:17 2016
New Revision: 266673
URL: http://llvm.org/viewvc/llvm-project?rev=266673&view=rev
Log:
[sanitizer-coverage] make sure coverage flags are not passed to clang if the
driver thinks they are unused
Modified:
cfe/trunk/lib/Driver/SanitizerArgs.cpp
cf
Author: kcc
Date: Mon Apr 18 16:28:37 2016
New Revision: 266672
URL: http://llvm.org/viewvc/llvm-project?rev=266672&view=rev
Log:
[sanitizer-coverage] better docs for -fsanitize-coverage=trace-bb
Modified:
cfe/trunk/docs/SanitizerCoverage.rst
Modified: cfe/trunk/docs/SanitizerCoverage.rst
UR
echristo requested changes to this revision.
echristo added a comment.
This revision now requires changes to proceed.
As a note I'm going to want to review this before it goes in.
http://reviews.llvm.org/D19072
___
cfe-commits mailing list
cfe-commi
rnk marked an inline comment as done.
Comment at: lib/CodeGen/CGDebugInfo.h:97
@@ -273,3 +96,3 @@
/// Set the main CU's DwoId field to \p Signature.
- void setDwoId(uint64_t Signature);
+ virtual void setDwoId(uint64_t Signature) = 0;
aprantl wrote:
> Why d
bcraig marked 2 inline comments as done.
bcraig added a comment.
http://reviews.llvm.org/D16544
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
bcraig updated the summary for this revision.
bcraig updated this revision to Diff 54112.
bcraig added a comment.
EricWF's feedback. Removed libcxx_library option. I plan on submitting this
tomorrow morning.
http://reviews.llvm.org/D16544
Files:
docs/TestingLibcxx.rst
test/CMakeLists.txt
bcraig updated this revision to Diff 54110.
bcraig marked an inline comment as done.
bcraig added a comment.
EricWF's feedback. I plan on submitting this tomorrow morning.
http://reviews.llvm.org/D16545
Files:
CMakeLists.txt
test/CMakeLists.txt
test/libcxxabi/test/config.py
test/lit.si
EricWF added a comment.
In http://reviews.llvm.org/D16544#404283, @bcraig wrote:
> In http://reviews.llvm.org/D16544#403273, @EricWF wrote:
>
> > Just spitballing but have you considered simply passing the full path,
> > including the library name, to LIT? Instead of needing `enable_shared`
> >
On 18/04/16 21:06, Richard Smith wrote:
On Mon, Apr 18, 2016 at 11:49 AM, Vassil Vassilev
mailto:v.g.vassi...@gmail.com>> wrote:
On 18/04/16 20:32, Richard Smith wrote:
On Mon, Apr 18, 2016 at 6:28 AM, Vassil Vassilev
mailto:v.g.vassi...@gmail.com>> wrote:
On 08/04/16 03:2
bcraig added a comment.
In http://reviews.llvm.org/D16544#403273, @EricWF wrote:
> Just spitballing but have you considered simply passing the full path,
> including the library name, to LIT? Instead of needing `enable_shared`
> variables we would simply use the named library, be it DSO or arch
aprantl added inline comments.
Comment at: lib/CodeGen/CGDebugInfo.h:97
@@ -273,3 +96,3 @@
/// Set the main CU's DwoId field to \p Signature.
- void setDwoId(uint64_t Signature);
+ virtual void setDwoId(uint64_t Signature) = 0;
Why does this need to be virt
EricWF added a comment.
Could you generate a diff against the normal directory layout? Your's is
against "libcxxabi/trunk/" where 'trunk' is the actual libcxxabi directory.
http://reviews.llvm.org/D17815
___
cfe-commits mailing list
cfe-commits@lis
sbenza added a comment.
Sent http://reviews.llvm.org/D19231 to fix the underlying bug in `hasAncestor`.
We can proceed with this change if you want, but it is not required anymore. I
don't know whether we need the extra complexity of `TemplateArgumentLess`.
http://reviews.llvm.org/D19144
___
bader added inline comments.
Comment at: lib/Headers/opencl.h:14476-14479
@@ +14475,6 @@
+
+#ifdef _HAS_READ_WRITE_IMAGE
+float4 __attribute__((overloadable)) read_imagef(read_write image2d_t image,
sampler_t sampler, int2 coord);
+float4 __attribute__((overloadable)) read_imagef
On Mon, Apr 18, 2016 at 11:49 AM, Vassil Vassilev
wrote:
> On 18/04/16 20:32, Richard Smith wrote:
>
> On Mon, Apr 18, 2016 at 6:28 AM, Vassil Vassilev <
> v.g.vassi...@gmail.com> wrote:
>
>> On 08/04/16 03:24, Richard Smith via cfe-commits wrote:
>>
>>> Author: rsmith
>>> Date: Thu Apr 7 20:23:
erik.pilkington added a comment.
Ping!
http://reviews.llvm.org/D18868
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
rnk added a comment.
ping
http://reviews.llvm.org/D19072
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
On 18/04/16 20:32, Richard Smith wrote:
On Mon, Apr 18, 2016 at 6:28 AM, Vassil Vassilev
mailto:v.g.vassi...@gmail.com>> wrote:
On 08/04/16 03:24, Richard Smith via cfe-commits wrote:
Author: rsmith
Date: Thu Apr 7 20:23:59 2016
New Revision: 265766
URL: h
Author: mren
Date: Mon Apr 18 13:40:51 2016
New Revision: 266648
URL: http://llvm.org/viewvc/llvm-project?rev=266648&view=rev
Log:
Block: Fix a crash when we have type attributes or qualifiers with omitted
return type.
Emit a warning instead of crashing in IR generation.
rdar://22762981
Differe
This revision was automatically updated to reflect the committed changes.
Closed by commit rL266648: Block: Fix a crash when we have type attributes or
qualifiers with omitted (authored by mren).
Changed prior to commit:
http://reviews.llvm.org/D18567?vs=52398&id=54090#toc
Repository:
rL LLV
michael_miller added a comment.
In http://reviews.llvm.org/D18584#403872, @alexfh wrote:
> FYI, the check has started crashing after this patch. I'll try to provide a
> minimal test case soon. The relevant part of the stack trace is:
>
> @ 0x7fc9c255efa0 8 clang::Stmt::getLocStar
Author: kparzysz
Date: Mon Apr 18 13:38:11 2016
New Revision: 266647
URL: http://llvm.org/viewvc/llvm-project?rev=266647&view=rev
Log:
[Hexagon] Define macros __HVX__ and __HVXDBL__ when appropriate
Added:
cfe/trunk/test/Preprocessor/hexagon-predefines.c
Modified:
cfe/trunk/lib/Basic/Targ
ahatanak updated this revision to Diff 54088.
ahatanak added a comment.
Address Richard's review comments and add a test case.
The test case currently asserts when fn0 is instantiated. This doesn't happen
if I give the template parameter a name.
template auto fn0 = [] {};
instead of
template
On Mon, Apr 18, 2016 at 11:19 AM, Akira Hatanaka via cfe-commits <
cfe-commits@lists.llvm.org> wrote:
> Author: ahatanak
> Date: Mon Apr 18 13:19:45 2016
> New Revision: 266645
>
> URL: http://llvm.org/viewvc/llvm-project?rev=266645&view=rev
> Log:
> [Parser][ObjC] Make sure c++11 in-class initial
sbenza created this revision.
sbenza added a reviewer: alexfh.
sbenza added a subscriber: cfe-commits.
Herald added a subscriber: klimek.
Prevent hasAncestor from comparing nodes that are not supported.
hasDescendant was fixed some time ago to avoid this problem.
I'm applying the same fix to hasAn
On Mon, Apr 18, 2016 at 6:28 AM, Vassil Vassilev
wrote:
> On 08/04/16 03:24, Richard Smith via cfe-commits wrote:
>
>> Author: rsmith
>> Date: Thu Apr 7 20:23:59 2016
>> New Revision: 265766
>>
>> URL: http://llvm.org/viewvc/llvm-project?rev=265766&view=rev
>> Log:
>> [modules] Add a comment to
Author: ahatanak
Date: Mon Apr 18 13:19:45 2016
New Revision: 266645
URL: http://llvm.org/viewvc/llvm-project?rev=266645&view=rev
Log:
[Parser][ObjC] Make sure c++11 in-class initialization is done when the
constructor's definition is in an implementation block.
Without this commit, ptr doesn't g
rsmith accepted this revision.
rsmith added a comment.
This revision is now accepted and ready to land.
Thanks!
http://reviews.llvm.org/D16396
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe
Author: aaronballman
Date: Mon Apr 18 13:10:53 2016
New Revision: 266644
URL: http://llvm.org/viewvc/llvm-project?rev=266644&view=rev
Log:
Clarifying the wording of this diagnostic; it confused parameter and argument.
Modified:
cfe/trunk/include/clang/Basic/DiagnosticSemaKinds.td
cfe/trun
sepavloff updated this revision to Diff 54085.
sepavloff added a comment.
Updated patch
Changed text of messages as proposed by reviewer. As a result, printing
template parameters is not needed anymore, related code is removed.
http://reviews.llvm.org/D16396
Files:
include/clang/AST/DeclBase
Author: jfb
Date: Mon Apr 18 13:01:49 2016
New Revision: 266641
URL: http://llvm.org/viewvc/llvm-project?rev=266641&view=rev
Log:
NFC: unify clang / LLVM atomic ordering
This makes the C11 / C++11 *ABI* atomic ordering accessible from LLVM,
as discussed in http://reviews.llvm.org/D18200#inline-15
Author: davidxl
Date: Mon Apr 18 12:48:12 2016
New Revision: 266638
URL: http://llvm.org/viewvc/llvm-project?rev=266638&view=rev
Log:
Update InstrProf pass creator API reference
Modified:
cfe/trunk/lib/CodeGen/BackendUtil.cpp
Modified: cfe/trunk/lib/CodeGen/BackendUtil.cpp
URL:
http://llvm.
Author: eugenezelenko
Date: Mon Apr 18 12:40:18 2016
New Revision: 266635
URL: http://llvm.org/viewvc/llvm-project?rev=266635&view=rev
Log:
[CMake] Fix misleading error message in CMakeLists.txt.
Differential revision: http://reviews.llvm.org/D17117
Modified:
libcxxabi/trunk/CMakeLists.txt
bader added inline comments.
Comment at: lib/Headers/opencl.h:14473-14474
@@ +14472,4 @@
+
+float4 __const_func __attribute__((overloadable)) read_imagef(read_only
image2d_t image, sampler_t sampler, int2 coord);
+float4 __const_func __attribute__((overloadable)) read_imagef(read
bruno added a comment.
LGTM
http://reviews.llvm.org/D18398
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
This revision was automatically updated to reflect the committed changes.
Closed by commit rL266625: [ARM] predefines __ELF__ macro for arm-none-eabi
(authored by weimingz).
Changed prior to commit:
http://reviews.llvm.org/D19225?vs=54070&id=54074#toc
Repository:
rL LLVM
http://reviews.llvm
Author: weimingz
Date: Mon Apr 18 11:25:46 2016
New Revision: 266625
URL: http://llvm.org/viewvc/llvm-project?rev=266625&view=rev
Log:
[ARM] predefines __ELF__ macro for arm-none-eabi
Summary: predefines __ELF__ macro for arm-none-eabi
Reviewers: silviu.baranga, rengolin
Subscribers: aemerson,
rengolin accepted this revision.
rengolin added a comment.
This revision is now accepted and ready to land.
LGTM, thanks!
http://reviews.llvm.org/D19225
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/li
weimingz created this revision.
weimingz added reviewers: rengolin, silviu.baranga.
weimingz added a subscriber: cfe-commits.
Herald added subscribers: rengolin, aemerson.
redefines __ELF__ macro for arm-none-eabi
http://reviews.llvm.org/D19225
Files:
lib/Basic/Targets.cpp
test/Preprocessor/
ikudrin added a comment.
Ping! Could anyone check this patch, please?
http://reviews.llvm.org/D17815
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
klimek added inline comments.
Comment at: lib/Format/Format.cpp:1450
@@ -1447,3 +1449,3 @@
public:
- Formatter(const FormatStyle &Style, SourceManager &SourceMgr, FileID ID,
-ArrayRef Ranges)
+ CodeProcessor(const FormatStyle &Style, SourceManager &SourceMgr, FileID
klimek added inline comments.
Comment at: include/clang/Format/Format.h:769
@@ -768,1 +768,3 @@
+/// \brief Returns the replacements corresponding to applying \p Replaces and
+/// cleaning up the code after that.
cleanupAroundReplacements sounds good.
=
vsk added a comment.
Lgtm
http://reviews.llvm.org/D19184
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
alexfh added a comment.
In http://reviews.llvm.org/D19144#402853, @sbenza wrote:
> I think the bug is coming from `memoizedMatchesAncestorOfRecursively`.
> `memoizedMatchesRecursively` has a special case at the top to skip the cache
> if the node is not sortable. The other function should do th
alexfh added a comment.
Looks better now, thanks!
Comment at: clang-tidy/ClangTidyOptions.cpp:163
@@ +162,3 @@
+DefaultOptionsProvider::getRawOptions(llvm::StringRef FileName) {
+ return {OptionsSource(DefaultOptions, OptionsSourceTypeDefaultBinary)};
+}
I'm no
alexfh added inline comments.
Comment at: clang-tidy/boost/UseToStringCheck.cpp:53
@@ +52,3 @@
+ CharType->isSpecificBuiltinType(BuiltinType::Char_U))
+// Is CharType 'char'.
+StringType = "string";
These comments don't seem to be useful, but if you w
alexfh requested changes to this revision.
This revision now requires changes to proceed.
Comment at: clang-tidy/modernize/UseNoexceptCheck.cpp:18
@@ +17,3 @@
+
+// FIXME: Move to ASTMatchers.h on acceptance.
+namespace ast_matchers {
Please send a separate patch
bcraig closed this revision.
bcraig added a comment.
r266611
http://reviews.llvm.org/D17410
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
Author: bcraig
Date: Mon Apr 18 08:30:38 2016
New Revision: 266611
URL: http://llvm.org/viewvc/llvm-project?rev=266611&view=rev
Log:
Respect LIBCXXABI_LIBDIR_SUFFIX before an install
Prior to this patch, setting LIBCXXABI_LIBDIR_SUFFIX would confuse the
check-libcxxabi target. libc++abi.* would g
bcraig added a comment.
In http://reviews.llvm.org/D17410#403263, @EricWF wrote:
> So we already do this for the standalone builds but not for in-tree builds.
> Before committing please make sure to remove the code on CMakeLists.txt line
> 99 that does this same thing.
Done
> I'm assuming c
hokein updated this revision to Diff 54056.
hokein added a comment.
Export SourceType.
http://reviews.llvm.org/D18694
Files:
clang-tidy/ClangTidyOptions.cpp
clang-tidy/ClangTidyOptions.h
clang-tidy/tool/ClangTidyMain.cpp
test/clang-tidy/Inputs/explain-config/.clang-tidy
test/clang-tid
On 08/04/16 03:24, Richard Smith via cfe-commits wrote:
Author: rsmith
Date: Thu Apr 7 20:23:59 2016
New Revision: 265766
URL: http://llvm.org/viewvc/llvm-project?rev=265766&view=rev
Log:
[modules] Add a comment to explain why -E leaves some #includes in the
preprocessed output.
Modified:
aturetsk added a comment.
Ping.
http://reviews.llvm.org/D18398
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
courbet added a comment.
Thanks, PTAL.
Comment at: clang-tidy/misc/FoldInitTypeCheck.cpp:21
@@ +20,3 @@
+/// Returns the value_type for an InputIterator type.
+static QualType getInputIteratorValueType(const Type &IteratorType,
+ const AS
courbet updated the summary for this revision.
courbet updated this revision to Diff 54045.
courbet marked 7 inline comments as done.
courbet added a comment.
- Use matchers for most of the check logic,
- Implement checking for reduce and inner_product,
- more tests.
http://reviews.llvm.org/D184
alexfh added a comment.
FYI, the check has started crashing after this patch. I'll try to provide a
minimal test case soon. The relevant part of the stack trace is:
@ 0x7fc9c255efa0 8 clang::Stmt::getLocStart()
@ 0x7fc9c48fdac1 64 clang::tidy::cppcoreguidelines::(a
Author: djasper
Date: Mon Apr 18 06:31:21 2016
New Revision: 266599
URL: http://llvm.org/viewvc/llvm-project?rev=266599&view=rev
Log:
clang-format: Improve heuristics to detect function declarations/definitions.
Specifically understand ellipses in parameter lists and treat trailing
reference qual
hokein marked an inline comment as done.
hokein added a comment.
http://reviews.llvm.org/D18694
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
hokein updated this revision to Diff 54043.
hokein added a comment.
Update.
http://reviews.llvm.org/D18694
Files:
clang-tidy/ClangTidyOptions.cpp
clang-tidy/ClangTidyOptions.h
clang-tidy/tool/ClangTidyMain.cpp
test/clang-tidy/Inputs/explain-config/.clang-tidy
test/clang-tidy/explain-c
hokein updated this revision to Diff 54042.
hokein added a comment.
Use a more elegant solution to track ClangTidyOptions.
http://reviews.llvm.org/D18694
Files:
clang-tidy/ClangTidyOptions.cpp
clang-tidy/ClangTidyOptions.h
clang-tidy/tool/ClangTidyMain.cpp
test/clang-tidy/Inputs/explain
RedX2501 added a comment.
Ping
http://reviews.llvm.org/D10834
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
RedX2501 added a comment.
Ping
http://reviews.llvm.org/D10833
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
Author: mehdi_amini
Date: Mon Apr 18 04:08:59 2016
New Revision: 266594
URL: http://llvm.org/viewvc/llvm-project?rev=266594&view=rev
Log:
Add missing include for StringRef (NFC)
From: Mehdi Amini
Modified:
cfe/trunk/lib/Format/Encoding.h
Modified: cfe/trunk/lib/Format/Encoding.h
URL:
http
Author: ericwf
Date: Mon Apr 18 01:58:50 2016
New Revision: 266592
URL: http://llvm.org/viewvc/llvm-project?rev=266592&view=rev
Log:
Mark P0152R1 as complete.
Modified:
libcxx/trunk/www/cxx1z_status.html
Modified: libcxx/trunk/www/cxx1z_status.html
URL:
http://llvm.org/viewvc/llvm-project/l
100 matches
Mail list logo
