alexfh added a comment.

In http://reviews.llvm.org/D19144#402853, @sbenza wrote:

> I think the bug is coming from `memoizedMatchesAncestorOfRecursively`.
>  `memoizedMatchesRecursively` has a special case at the top to skip the cache 
> if the node is not sortable. The other function should do that too.
>  Although the check is stale also because it is only checking for 
> memoizationData and not whether the node itself works for < and ==.
>
> Note that adding TemplateArgument to the function is ok, but that won't fix 
> the bug because we still have other nodes that are not comparable.


With this I would be entering "I have no idea what I'm doing" land ;) Might 
make sense for you to take over the patch, if you know how to fix the issue. 
WDYT?


http://reviews.llvm.org/D19144



_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Reply via email to