pxli168 added a comment.
Hi Anastasia,
https://cvs.khronos.org/bugzilla/show_bug.cgi?id=15603
Now we got clarify from khronos. I will continue on this patch.
BTW, https://cvs.khronos.org/bugzilla/show_bug.cgi?id=15599 is also fixed in
the same revision.
Thanks
Xiuli
http://reviews.llvm.org/D17
Author: rsmith
Date: Mon Mar 28 01:08:37 2016
New Revision: 264564
URL: http://llvm.org/viewvc/llvm-project?rev=264564&view=rev
Log:
P0138R2: Allow direct-list-initialization of an enumeration from an integral
value that can convert to the enum's underlying type.
Added:
cfe/trunk/test/CXX/dcl
faisalv created this revision.
faisalv added a reviewer: rsmith.
faisalv added a subscriber: cfe-commits.
Mark the lambda's conversion to function-pointer as incontrovertibly constexpr.
auto L = [](auto a) { return a; };
constexpr int* (*fp)(int*) = L; // This is now allowed.
By itself this is
LegalizeAdulthood created this revision.
LegalizeAdulthood added a reviewer: alexfh.
LegalizeAdulthood added a subscriber: cfe-commits.
Update `add_new_check.py` to stub out information in the release notes for the
new check.
http://reviews.llvm.org/D18509
Files:
clang-tidy/add_new_check.py
Author: legalize
Date: Sun Mar 27 23:15:41 2016
New Revision: 264563
URL: http://llvm.org/viewvc/llvm-project?rev=264563&view=rev
Log:
clang-tidy: Fix broken buildbot
VS 2013 does not support char16_t or char32_t
Modified:
clang-tools-extra/trunk/test/clang-tidy/modernize-raw-string-literal.
Good call, fixed in r264562.
On Sun, Mar 27, 2016 at 12:29 AM, Richard Smith
wrote:
> On Sat, Mar 26, 2016 at 9:46 PM, David Majnemer via cfe-commits
> wrote:
> > Author: majnemer
> > Date: Sat Mar 26 23:46:07 2016
> > New Revision: 264529
> >
> > URL: http://llvm.org/viewvc/llvm-project?rev=26
Author: majnemer
Date: Sun Mar 27 22:19:50 2016
New Revision: 264562
URL: http://llvm.org/viewvc/llvm-project?rev=264562&view=rev
Log:
Fix serialization/deserialization for __uuidof
I broke this back in r264529 because I forgot to serialize the UuidAttr
member. Fix this by replacing the UuidAttr
ariccio added a comment.
In http://reviews.llvm.org/D18497#384362, @mspertus wrote:
> In http://reviews.llvm.org/D18497#384351, @ariccio wrote:
>
> > Otherwise, assuming everything builds correctly, LGTM.
>
>
> There are a lot scenarios. What do all of these files in the build tree like
> `cmake
mspertus updated this revision to Diff 51764.
mspertus added a comment.
Adding missing period in comment!
http://reviews.llvm.org/D18497
Files:
CMakeLists.txt
utils/LLVMVisualizers/CMakeLists.txt
utils/LLVMVisualizers/llvm.natvis
utils/llvm.natvis
Index: utils/llvm.natvis
=
mspertus updated this revision to Diff 51762.
mspertus added a comment.
Incorporating ariccio's comments and fixing some html
http://reviews.llvm.org/D18498
Files:
CMakeLists.txt
utils/ClangVisualizers/CMakeLists.txt
utils/ClangVisualizers/clang.natvis
utils/clang.natvis
www/hacking.h
mspertus marked an inline comment as done.
mspertus added a comment.
http://reviews.llvm.org/D18498
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
mspertus marked an inline comment as done.
Comment at: utils/ClangVisualizers/CMakeLists.txt:2
@@ +1,3 @@
+# Do this by hand instead of using add_llvm_utilities(), which
+# tries to create a corresponding executable, which we don't want
+if (LLVM_ADD_NATIVE_VISUALIZERS_TO_SOLUTION
mspertus added a comment.
In http://reviews.llvm.org/D18497#384351, @ariccio wrote:
> `utils/llvm.natvis` is a duplicate of `utils/LLVMVisualizers/llvm.natvis`?
The file was moved to a more appropriate directory (Otherwise, the project
files were stepping on each other).
`svn mv utils/llvm.nat
ariccio added a comment.
Assuming everything builds correctly, LGTM.
Your CMake is better than mine, so I'm not sure if there're better ways to do
this ;)
Comment at: utils/ClangVisualizers/CMakeLists.txt:2
@@ +1,3 @@
+# Do this by hand instead of using add_llvm_utilities(), w
ariccio added a comment.
In http://reviews.llvm.org/D18498#384274, @zturner wrote:
> Ahh that's surprising. If it works even with the none tag, i guess my
> concerns are not valid
I'm only partly surprised... It's not the first time that a Microsoft product
behaves surprisingly :)
http://re
ariccio added a comment.
`utils/llvm.natvis` is a duplicate of `utils/LLVMVisualizers/llvm.natvis`?
Otherwise, assuming everything builds correctly, LGTM.
Once again, thanks for doing this!
http://reviews.llvm.org/D18497
___
cfe-commits mailing li
mspertus updated this revision to Diff 51759.
mspertus added a comment.
Now that we are generating projects for native visualizers, have it properly
reflected in the directory structure
http://reviews.llvm.org/D18498
Files:
CMakeLists.txt
utils/ClangVisualizers/CMakeLists.txt
utils/Clang
mspertus updated this revision to Diff 51756.
mspertus added a comment.
Add missing newline
http://reviews.llvm.org/D18497
Files:
CMakeLists.txt
utils/LLVMVisualizers/CMakeLists.txt
utils/LLVMVisualizers/llvm.natvis
utils/llvm.natvis
Index: utils/llvm.natvis
===
mspertus updated this revision to Diff 51754.
mspertus added a comment.
Since this is now creating a project, we should do some housekeeping to move
the files to different directories so that the build tree has an
LLVMVisualizers project directory.
http://reviews.llvm.org/D18497
Files:
CMak
dim added a comment.
Note that these compilation errors came up specifically because @bdrewery is
doing cross-compilation of FreeBSD with recent versions of gcc. Apparently
clang does not give the same errors on these undefined identifiers, but I'm not
entirely sure why not...
http://reviews
dim created this revision.
dim added reviewers: mclow.lists, EricWF, emaste.
dim added subscribers: cfe-commits, bdrewery.
Herald added a subscriber: emaste.
On FreeBSD, a number of math.h functions are actually defined as macros,
such as `signbit()`, `fpclassify()` and others. Since libc++'s
at
Author: rsmith
Date: Sun Mar 27 15:13:24 2016
New Revision: 264540
URL: http://llvm.org/viewvc/llvm-project?rev=264540&view=rev
Log:
[modules] When encoding SourceLocations in bitcode, rotate the 'is macro' flag
bit from the top bit to the bottom bit, so that we don't need 6 VBR6 hunks for
each ma
Yea sounds fine
On Sun, Mar 27, 2016 at 12:20 PM Mike Spertus wrote:
> mspertus added a comment.
>
> I understand your concerns, but on balance, I don't see a better course of
> action than what I've done. If I have some time, I'll submit a CMake change
> so we can eventually migrate to having CM
mspertus added a comment.
I understand your concerns, but on balance, I don't see a better course of
action than what I've done. If I have some time, I'll submit a CMake change so
we can eventually migrate to having CMake generate a Natvis tag, but that will
take a long time to propagate, so I
Ahh that's surprising. If it works even with the none tag, i guess my
concerns are not valid
On Sun, Mar 27, 2016 at 12:11 PM Mike Spertus wrote:
> mspertus added a comment.
>
> No. Testing shows that it works fine in the project with the `` tag.
> VS2015 empirically looks at the extension.
>
>
>
mspertus added a comment.
No. Testing shows that it works fine in the project with the `` tag.
VS2015 empirically looks at the extension.
http://reviews.llvm.org/D18498
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/c
If it's not using a natvis tag in the vcxproj (which it isn't since CMake
doesn't support it during generation) then the new natvis project file
support won't work right? In which case the files would need to be copied
into documents\vs2015, otherwise it won't work, unless I'm misunderstanding
some
mspertus added a comment.
I'm not sure I understand. I'm not installing anything for VS2013. You still
have to manually copy into `Documents\VS2013`. The purpose of this change is to
eliminate this manual step for VS2015 by leveraging the new Natvis project
support. Am I missing something?
ht
Code paths. For vs2013 you're installing the natvis files, can we just do
that for vs2015 as well?
On Sun, Mar 27, 2016 at 11:23 AM Mike Spertus wrote:
> mspertus added a comment.
>
> What do you mean by "making both paths the same"?
>
>
> http://reviews.llvm.org/D18498
>
>
>
>
__
mspertus added a comment.
What do you mean by "making both paths the same"?
http://reviews.llvm.org/D18498
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
Yea, CMake doesn't actually support natvis files. You'd have to actually
patch CMake to make it work.
Can you make the vs2015 and vs2013 paths the same? It will still work for
2015 i think, just that 2015 also supports putting them in the project file
On Sun, Mar 27, 2016 at 10:04 AM Mike Spertus
Hi Daniel,
Thanks a lot for your answer and clarifications.
Sorry for the long answer, TLDR at the beginning (and end for code
examples).
To answer your 2 questions immediately:
- It happens a lot more than I thought, about 10% of the few thousands file
I checked had instances of this.
- Yes, the
mspertus added a comment.
Hmmm, I just tried adding ` set_source_files_properties(utils/clang.natvis
LANGUAGE natvis)` similar to what you suggest in
http://lists.llvm.org/pipermail/llvm-dev/2016-January/093887.html, but it still
produces the `None` tag in the `.vcxproj` file. Any suggestion wh
jlebar added a comment.
> OK, so the question for you is, how much ABI compatibility with NVCC are you
> prepared to give up in order to allow HD / D overloading and HD / H
> overloading?
At the moment, getting this feature to work seems more important than
maintaining ABI compatibility with
Author: legalize
Date: Sun Mar 27 11:43:44 2016
New Revision: 264539
URL: http://llvm.org/viewvc/llvm-project?rev=264539&view=rev
Log:
clang-tidy: Add check modernize-raw-string-literal
Added:
clang-tools-extra/trunk/clang-tidy/modernize/RawStringLiteralCheck.cpp
clang-tools-extra/trunk/c
faisalv updated this revision to Diff 51742.
faisalv marked 2 inline comments as done.
faisalv added a comment.
Updated the patch with the following:
- while checking dependent template template arguments at template definition
time, we must accept the more general (pack) as compatible with the
mspertus added a comment.
In http://reviews.llvm.org/D18498#384233, @zturner wrote:
> For vs2015, the files still need to be in the project right? (In the
> vcxproj with a tag)
This change puts the natvis files in the project for VS2015 but it appears to
use the `none` tag
http://schem
For vs2015, the files still need to be in the project right? (In the
vcxproj with a tag)
On Sun, Mar 27, 2016 at 9:09 AM Mike Spertus wrote:
> mspertus updated this revision to Diff 51741.
> mspertus added a comment.
>
> Apply whitespace comments from http://reviews.llvm.org/D18497 mutatis
> mut
faisalv marked 2 inline comments as done.
Comment at: lib/Sema/SemaTemplate.cpp:793-800
@@ -792,10 +792,2 @@
if (!Default.isInvalid()) {
-// Check only that we have a template template argument. We don't want to
-// try to check well-formedness now, because our template
mspertus updated this revision to Diff 51741.
mspertus added a comment.
Apply whitespace comments from http://reviews.llvm.org/D18497 mutatis mutandis
to this change
http://reviews.llvm.org/D18498
Files:
CMakeLists.txt
utils/clang.natvis
www/hacking.html
Index: www/hacking.html
mspertus marked an inline comment as done.
mspertus added a comment.
http://reviews.llvm.org/D18497
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
mspertus updated this revision to Diff 51740.
mspertus added a comment.
Missed one (the missing period in llvm.natvis).
http://reviews.llvm.org/D18497
Files:
CMakeLists.txt
utils/llvm.natvis
Index: utils/llvm.natvis
===
--- ut
aaron.ballman accepted this revision.
aaron.ballman added a comment.
This revision is now accepted and ready to land.
LGTM, thank you!
http://reviews.llvm.org/D18497
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-b
mspertus marked 3 inline comments as done.
mspertus added a comment.
http://reviews.llvm.org/D18497
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
mspertus updated this revision to Diff 51739.
mspertus added a comment.
Accepting Aaron's suggestions
http://reviews.llvm.org/D18497
Files:
CMakeLists.txt
utils/llvm.natvis
Index: utils/llvm.natvis
===
--- utils/llvm.natvis
++
aaron.ballman added a comment.
This is fantastic! Just a few nits, but nothing substantial.
Comment at: CMakeLists.txt:739
@@ +738,3 @@
+# tries to create a corresponding executable, which we don't want
+if(LLVM_ADD_NATIVE_VISUALIZERS_TO_SOLUTION)
+ set( LLVM_VISUALIZERS utils/
LegalizeAdulthood updated this revision to Diff 51738.
LegalizeAdulthood added a comment.
Remove brace initializers from test code.
http://reviews.llvm.org/D16529
Files:
clang-tidy/modernize/CMakeLists.txt
clang-tidy/modernize/ModernizeTidyModule.cpp
clang-tidy/modernize/RawStringLiteralC
mspertus updated this revision to Diff 51735.
mspertus added a comment.
Correctly handle non-Visual Studio case (e.g., Linux)
http://reviews.llvm.org/D18497
Files:
CMakeLists.txt
utils/llvm.natvis
Index: utils/llvm.natvis
===
mspertus created this revision.
mspertus added reviewers: ariccio, aaron.ballman, zturner.
mspertus added a subscriber: cfe-commits.
This change uses the [[
https://blogs.msdn.microsoft.com/vcblog/2014/06/12/project-support-for-natvis/
| Project Support for Natvis ]] added in VS2015 to eliminate
mspertus created this revision.
mspertus added reviewers: ariccio, aaron.ballman, zturner.
mspertus added a subscriber: cfe-commits.
This change uses the [[
https://blogs.msdn.microsoft.com/vcblog/2014/06/12/project-support-for-natvis/
| Project Support for Natvis ]] added in VS2015 to eliminate
Author: rsmith
Date: Sun Mar 27 02:28:06 2016
New Revision: 264534
URL: http://llvm.org/viewvc/llvm-project?rev=264534&view=rev
Log:
Encapsulate a couple of on-disk structures a little more.
Modified:
cfe/trunk/include/clang/Serialization/ASTBitCodes.h
cfe/trunk/include/clang/Serializatio
On Sat, Mar 26, 2016 at 9:46 PM, David Majnemer via cfe-commits
wrote:
> Author: majnemer
> Date: Sat Mar 26 23:46:07 2016
> New Revision: 264529
>
> URL: http://llvm.org/viewvc/llvm-project?rev=264529&view=rev
> Log:
> Improve the representation of CXXUuidofExpr
>
> Keep a pointer to the UuidAttr
52 matches
Mail list logo
