ariccio added a comment. In http://reviews.llvm.org/D18497#384362, @mspertus wrote:
> In http://reviews.llvm.org/D18497#384351, @ariccio wrote: > > > Otherwise, assuming everything builds correctly, LGTM. > > > There are a lot scenarios. What do all of these files in the build tree like > `cmake_install.cmake`, `install.vcxproj`, `Package.vcxproj`? How do I test > them? Do you have a clean copy of the tree? Maybe do something like the equivalent of `make clean` <http://stackoverflow.com/questions/9680420/looking-for-a-cmake-clean-command-to-clear-up-cmake-output>? Then try to regenerate everything? > > Once again, thanks for doing this! > > > You're welcome. Thanks for all your help. I am in India right now with a > limited environment. I will likely due some more testing when I get home and > check in at the end of the week. Well that's certainly more exotic than me! I'm impressed. I assume you have a laptop, and you're not doing this on your smartphone. http://reviews.llvm.org/D18497 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
