hvarga added a comment.
Are there any thoughts about this patch?
http://reviews.llvm.org/D17378
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
flx added inline comments.
Comment at: clang-tidy/performance/UnnecessaryValueParamCheck.cpp:42
@@ +41,3 @@
+ decl().bind("param"));
+ Finder->addMatcher(
+ functionDecl(isDefinition(), unless(cxxMethodDecl(isOverride())),
alexfh wrote:
> Ca
flx updated the summary for this revision.
flx updated this revision to Diff 51385.
flx marked 5 inline comments as done.
flx added a comment.
After testing the check against a large corpus I was able to remove the
unnecessary param index check. But I discovered that the check crashed on value
jlebar created this revision.
jlebar added a reviewer: tra.
jlebar added a subscriber: cfe-commits.
Principally, don't hardcode the line numbers of various notes. This
lets us make changes to the test without recomputing linenos everywhere.
Instead, just tell -verify that we may get 0 or more no
jlebar created this revision.
jlebar added a reviewer: tra.
jlebar added a subscriber: cfe-commits.
Previously we were using the codegen test to ensure that we choose the
right overload. But we can do this within sema, with a bit of
cleverness.
I left the constructor/destructor checks in CodeGen
jlebar updated this revision to Diff 51384.
jlebar added a comment.
Update test as discussed -- now we check that we're invoking the correct
overloads.
http://reviews.llvm.org/D18380
Files:
include/clang/Basic/LangOptions.def
include/clang/Driver/CC1Options.td
lib/Driver/Tools.cpp
lib/
This revision was automatically updated to reflect the committed changes.
Closed by commit rL264132: [Sema] Allow implicit conversions of &overloaded_fn
in C. (authored by gbiv).
Changed prior to commit:
http://reviews.llvm.org/D13704?vs=49333&id=51378#toc
Repository:
rL LLVM
http://reviews
Author: gbiv
Date: Tue Mar 22 21:33:58 2016
New Revision: 264132
URL: http://llvm.org/viewvc/llvm-project?rev=264132&view=rev
Log:
[Sema] Allow implicit conversions of &overloaded_fn in C.
Also includes a minor ``enable_if`` docs update.
Currently, our address-of overload machinery will only all
george.burgess.iv marked 3 inline comments as done.
Comment at: lib/Sema/SemaOverload.cpp:10419
@@ -10418,3 +10429,1 @@
- ResultTy) ||
- (!S.getLangOpts().CPlusPlus && TargetType->isVoidPointerType())) {
Matches.push_back(std::make
ahatanak added a comment.
In http://reviews.llvm.org/D18196#375997, @rjmccall wrote:
> You should also check that any back-end peepholes we have in place (null type
> infos to signify a call-terminate landingpad?) aren't disturbed by the
> lifetime intrinsics.
I looked at the back-end passes
ahatanak updated this revision to Diff 51376.
ahatanak added a comment.
Added a test in test/CodeGenCXX/microsoft-abi-eh-cleanups.cpp to check expected
patterns are emitted.
http://reviews.llvm.org/D18196
Files:
lib/CodeGen/CGCleanup.cpp
lib/CodeGen/CGDecl.cpp
lib/CodeGen/EHScopeStack.h
rsmith accepted this revision.
This revision is now accepted and ready to land.
Comment at: lib/Sema/SemaOverload.cpp:10419
@@ -10418,3 +10429,1 @@
- ResultTy) ||
- (!S.getLangOpts().CPlusPlus && TargetType->isVoidPointerType())) {
Author: cbieneman
Date: Tue Mar 22 20:47:05 2016
New Revision: 264125
URL: http://llvm.org/viewvc/llvm-project?rev=264125&view=rev
Log:
[Apple Clang] Expose llvm-config from stage2 builds in stage1
This exposes the stage2-llvm-config target though the stage1 build
configuration.
Modified:
c
george.burgess.iv added inline comments.
Comment at: lib/CodeGen/CGCall.cpp:142-143
@@ -132,1 +141,4 @@
+ appendParameterTypes(CGT, prefix, FTP, FD, &SynthesizedParams);
+ RequiredArgs Required =
+ RequiredArgs::forPrototypePlus(FTP, StartParams + SynthesizedParams);
Can
george.burgess.iv updated this revision to Diff 51374.
george.burgess.iv marked an inline comment as done.
george.burgess.iv added a comment.
Addressed all feedback
http://reviews.llvm.org/D17462
Files:
include/clang/CodeGen/CGFunctionInfo.h
lib/CodeGen/CGCall.cpp
lib/CodeGen/CGExprCXX.cp
Hi Daniel,
Sorry for the delay, but I've been both away and catching up:
On Wed, Mar 9, 2016 at 4:00 AM Daniel Sanders
wrote:
> > > From: Eric Christopher [echri...@gmail.com]
> > > Sent: 09 March 2016 06:50
> > > To: reviews+d16139+public+275805419034a...@reviews.llvm.org; Bhushan
> Attarde; V
jlebar added a comment.
In http://reviews.llvm.org/D18380#381031, @tra wrote:
> We need tests to demonstrate that we pick correct function when we have mix
> of HD+H/D in the overload set.
> Existing tests only cover resolution of {HD,HD}, {H,H} {D,D} {H,D} sets
Aha, got it. I think adding t
jlebar updated this revision to Diff 51366.
jlebar added a comment.
Add tests checking host+device overloading.
http://reviews.llvm.org/D18380
Files:
include/clang/Basic/LangOptions.def
include/clang/Driver/CC1Options.td
lib/Driver/Tools.cpp
lib/Frontend/CompilerInvocation.cpp
lib/Sem
We need tests to demonstrate that we pick correct function when we have mix
of HD+H/D in the overload set.
Existing tests only cover resolution of {HD,HD}, {H,H} {D,D} {H,D} sets
On Tue, Mar 22, 2016 at 4:59 PM, Justin Lebar wrote:
> jlebar added a comment.
>
> In http://reviews.llvm.org/D18380#
jlebar added a comment.
In http://reviews.llvm.org/D18380#381025, @tra wrote:
> Now that H/D and HD cal all be in the same overload set, we'll also need
> additional tests in CodeGenCUDA/function-overload.cu for cases that now
> became legal.
There are lots of tests that used to be compile er
tra added a comment.
Now that H/D and HD cal all be in the same overload set, we'll also need
additional tests in CodeGenCUDA/function-overload.cu for cases that now became
legal.
http://reviews.llvm.org/D18380
___
cfe-commits mailing list
cfe-com
alexfh accepted this revision.
alexfh added a comment.
This revision is now accepted and ready to land.
LG
Comment at: include/clang/ASTMatchers/ASTMatchersInternal.h:80
@@ +79,3 @@
+ ResultT operator()(ArrayRef Args) const {
+std::vector InnerArgs;
+for (const ArgT &Ar
echristo added a comment.
First I'd like to note that the code quality here is really high, most of my
comments are higher level design decisions going with the driver and the
implementation here rather than that.
One meta comment: offload appears to be something that could be used for CUDA
an
rsmith resigned from this audit.
Users:
jyknight (Author, Auditor)
3.7-release (Auditor)
cfe-commits (Auditor)
tstellarAMD (Auditor)
compnerd (Auditor)
majnemer (Auditor)
rsmith (Auditor)
dim (Auditor)
http://reviews.llvm.org/rL244063
___
jlebar updated this revision to Diff 51357.
jlebar added a comment.
Actually run the tests, and fix the CUDA overloading test.
http://reviews.llvm.org/D18380
Files:
include/clang/Basic/LangOptions.def
include/clang/Driver/CC1Options.td
lib/Driver/Tools.cpp
lib/Frontend/CompilerInvocatio
richard.barton.arm added a comment.
Thanks for the help Eric. I'm just running a new patch now will put the new
patch up when I get back in to office tomorrow.
http://reviews.llvm.org/D18347
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
h
This revision was automatically updated to reflect the committed changes.
Closed by commit rL264106: [CUDA] Don't allow templated variadic functions.
(authored by jlebar).
Changed prior to commit:
http://reviews.llvm.org/D18373?vs=51332&id=51354#toc
Repository:
rL LLVM
http://reviews.llvm.o
Author: jlebar
Date: Tue Mar 22 17:06:19 2016
New Revision: 264106
URL: http://llvm.org/viewvc/llvm-project?rev=264106&view=rev
Log:
[CUDA] Don't allow templated variadic functions.
Reviewers: tra
Subscribers: cfe-commits
Differential Revision: http://reviews.llvm.org/D18373
Modified:
cfe/
rsmith added inline comments.
Comment at: lib/CodeGen/CGCall.cpp:142-143
@@ -132,1 +141,4 @@
+ appendParameterTypes(CGT, prefix, FTP, FD, &SynthesizedParams);
+ RequiredArgs Required =
+ RequiredArgs::forPrototypePlus(FTP, StartParams + SynthesizedParams);
CanQualType re
jlebar created this revision.
jlebar added a reviewer: tra.
jlebar added subscribers: rsmith, rnk, cfe-commits.
All constexpr functions are implicitly host+device, except for variadic
functions, which are not allowed on the device side.
As part of this change, we now allow you to overload a host+
jlebar abandoned this revision.
jlebar marked 7 inline comments as done.
jlebar added a comment.
Okay, after much discussion, we've decided to go with --relaxed-constexpr
instead of this. I have a patch for that which seems to mostly work, will send
it out soon.
http://reviews.llvm.org/D18328
jfb updated this revision to Diff 51346.
jfb added a comment.
- Define __cpp_lib_atomic_is_always_lock_free in libc++
http://reviews.llvm.org/D17951
Files:
include/atomic
test/std/atomics/atomics.lockfree/isalwayslockfree.pass.cpp
Index: test/std/atomics/atomics.lockfree/isalwayslockfree.p
eraman marked 2 inline comments as done.
Comment at: lib/CodeGen/CodeGenModule.cpp:398-399
@@ -397,3 +397,4 @@
if (PGOReader) {
getModule().setMaximumFunctionCount(PGOReader->getMaximumFunctionCount());
+getModule().setProfileSummary(PGOReader->getSummary().getMD(VMCon
eraman updated this revision to Diff 51342.
eraman added a comment.
Address Vedant's comments
http://reviews.llvm.org/D18289
Files:
lib/CodeGen/CodeGenModule.cpp
test/Profile/Inputs/profile-summary.proftext
test/Profile/profile-summary.c
Index: test/Profile/profile-summary.c
EricWF added a comment.
Re-building clang now so I can test the most recent changes.
Comment at: include/atomic:850
@@ +849,3 @@
+#if defined(__cpp_lib_atomic_is_always_lock_free)
+ static _LIBCPP_CONSTEXPR bool is_always_lock_free =
__atomic_always_lock_free(sizeof(__a_), 0);
vsk added inline comments.
Comment at: test/Profile/profile-summary.c:5
@@ +4,3 @@
+// RUN: %clang %s -o - -mllvm -disable-llvm-optzns -emit-llvm -S
-fprofile-instr-use=%t.profdata | FileCheck %s
+//
+int begin(int i) {
davidxl wrote:
> vsk wrote:
> > ISTM that a
jfb added a comment.
As discussed in now-abandoned http://reviews.llvm.org/D17950 I'll implement
everything in libc++. I just have to move the feature test macro to libc++.
http://reviews.llvm.org/D17951
___
cfe-commits mailing list
cfe-commits@lis
davidxl added inline comments.
Comment at: lib/CodeGen/CodeGenModule.cpp:398
@@ -397,2 +397,3 @@
if (PGOReader) {
getModule().setMaximumFunctionCount(PGOReader->getMaximumFunctionCount());
+auto *SummaryMD = PGOReader->getSummary().getMD(getModule().getContext());
jfb abandoned this revision.
Comment at: lib/Frontend/InitPreprocessor.cpp:465
@@ +464,3 @@
+ if (LangOpts.CPlusPlus1z) {
+Builder.defineMacro("__cpp_lib_atomic_is_always_lock_free", "201603");
+ }
jfb wrote:
> rsmith wrote:
> > This should be defined by the
rjmccall added a comment.
Yes, you should just stick with your post-processing pass or something like it.
The design of linkonce_odr linkage is that such definitions will only be
emitted when they are actually used. Even with this attribute, a translation
unit that consists solely of:
__att
Author: jfb
Date: Tue Mar 22 16:12:48 2016
New Revision: 264098
URL: http://llvm.org/viewvc/llvm-project?rev=264098&view=rev
Log:
Update cxx-features test to C++1z
Forked from the following patch:
http://reviews.llvm.org/D17950
Modified:
cfe/trunk/test/Lexer/cxx-features.cpp
Modified: cfe
EricWF added a comment.
And looking at the current state of the single-threaded test suite this isn't
the only test that needs this fix applied.
http://lab.llvm.org:8011/builders/libcxx-libcxxabi-singlethreaded-x86_64-linux-debian/builds/869
http://reviews.llvm.org/D18347
__
Author: jtsoftware
Date: Tue Mar 22 15:57:51 2016
New Revision: 264092
URL: http://llvm.org/viewvc/llvm-project?rev=264092&view=rev
Log:
D18325: Added mm_malloc module export.
Modified:
cfe/trunk/lib/Headers/module.modulemap
cfe/trunk/test/Headers/xmmintrin.c
Modified: cfe/trunk/lib/Head
EricWF added a comment.
I think the correct fix is "// UNSUPPORTED: libcpp-has-no-threads"
http://reviews.llvm.org/D18347
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
tstellarAMD added a comment.
Hi John,
The problem we are trying to solve here is linking a LLVM bitcode program
(OpenCL kernel in this specific case) with an LLVM bitcode library (OpenCL
builtin library) and having the resulting LLVM bitcode module contain only the
program code and the library
richard.barton.arm added a comment.
Hi Eric
Sorry for the delay - I originally detected the failure while not running in a
totally clean environment with clean sources, but I can reproduce on clean code.
I can reproduce by building with clean clang and libcxx sources:
cmake -DLLVM_PATH=/work/ri
tra added inline comments.
Comment at: include/clang/Driver/Action.h:79
@@ +78,3 @@
+OFFLOAD_None = 0x00,
+OFFLOAD_CUDA = 0x01,
+ };
Nit: All-caps CUDA looks weird here. _Cuda may be better choice.
If you can shorten the prefix that would be nice, too. OK
rjmccall added a comment.
You could also get this effect by somehow making the definitions linkonce_odr
when they're linked in from the library. Or you could simply use the classic
static-archive technique of putting each symbol in its own object file and
linking against the whole thing as a s
rjmccall added a comment.
Does your linker not supported dead-code stripping?
http://reviews.llvm.org/D18095
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
yaxunl added a comment.
Sorry my previous example may have caused some confusion.
Previously I said I wanted to override function definitions. However the only
reason we want to add this attribute is so that unused functions will be
dropped by the linker.
http://reviews.llvm.org/D18095
___
jlebar created this revision.
jlebar added a reviewer: tra.
jlebar added a subscriber: cfe-commits.
http://reviews.llvm.org/D18373
Files:
lib/Sema/SemaDecl.cpp
test/SemaCUDA/vararg.cu
Index: test/SemaCUDA/vararg.cu
===
--- test/
yaxunl updated this revision to Diff 51326.
yaxunl marked an inline comment as done.
yaxunl added a comment.
Add -x cl to the test when compiling it for spir target.
http://reviews.llvm.org/D17552
Files:
lib/CodeGen/BackendUtil.cpp
test/Frontend/backend-option.c
Index: test/Frontend/backen
rjmccall added a comment.
You still don't actually want linkonce_odr linkage. You don't want the weak
definition to be inlined, so it can't be ODR, and you want to force it to be
emitted in your library, so it can't be linkonce. You just want weak linkage.
There's an existing attribute for t
pcc updated this revision to Diff 51324.
pcc added a comment.
- Use llvm.load.relative (http://reviews.llvm.org/D18367)
http://reviews.llvm.org/D18199
Files:
docs/UsersManual.rst
lib/CodeGen/CGClass.cpp
lib/CodeGen/CGDebugInfo.cpp
lib/CodeGen/CGVTables.cpp
lib/CodeGen/CGVTables.h
li
rsmith accepted this revision.
rsmith added a comment.
This revision is now accepted and ready to land.
LGTM
http://reviews.llvm.org/D18325
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-co
Hello everyone,
Below are some buildbot numbers for the last week of 3/13/2016 - 3/19/2016.
Thanks
Galina
"Status change ratio" by active builder (percent of builds that changed the
builder status from greed to red or from red to green):
buildername
Hello everyone,
Below are some buildbot numbers for the week of 3/06/2016 - 3/12/2016.
Thanks
Galina
"Status change ratio" by active builder (percent of builds that changed the
builder status from greed to red or from red to green):
buildername
Anastasia added inline comments.
Comment at: test/Frontend/backend-option.c:2
@@ +1,3 @@
+// RUN: %clang_cc1 %s -emit-llvm -backend-option -time-passes -o - 2>&1 |
FileCheck %s
+// RUN: %clang_cc1 %s -emit-llvm -backend-option -time-passes -o - -triple
spir-unknown-unknown 2>&1
Thanks!
On Tue, Mar 22, 2016 at 9:34 AM, Chris Bieneman wrote:
> Sean,
>
> All good feedback.
>
> Using print_function was done in r257936 with some other feedback from
> Bogner.
>
> The rest of your feedback I believe I have addressed in r264063.
>
> -Chris
>
> On Mar 21, 2016, at 9:21 PM, Sean
EricWF added a comment.
I don't actually understand this change. This test should compile with or
without "-Wthread-safety" warning. This test doesn't actually turn the
annotations on, that's the point. If annotations were actually enabled this
test would fail to compile.
Could you explain the
richard.barton.arm updated this revision to Diff 51316.
richard.barton.arm added a comment.
Sorry - not sure what happened there. That looks better for me.
http://reviews.llvm.org/D18347
Files:
test/libcxx/thread/thread.mutex/thread_safety_annotations_not_enabled.pass.cpp
Index:
test/libcxx
yaxunl marked an inline comment as done.
Comment at: test/Frontend/backend-option.c:2
@@ +1,3 @@
+// RUN: %clang_cc1 %s -emit-llvm -backend-option -time-passes -o - 2>&1 |
FileCheck %s
+// RUN: %clang_cc1 %s -emit-llvm -backend-option -time-passes -o - -triple
spir-unknown-unkno
jtsoftware edited reviewers, added: rsmith; removed: probinson, silvas.
jtsoftware updated this revision to Diff 51313.
jtsoftware added a comment.
Right. Also undoing moving stuff around. How about this? Thanks.
http://reviews.llvm.org/D18325
Files:
lib/Headers/module.modulemap
test/Hea
Anastasia accepted this revision.
Anastasia added a comment.
LGTM, apart from small remark on the test!
Comment at: test/Frontend/backend-option.c:2
@@ +1,3 @@
+// RUN: %clang_cc1 %s -emit-llvm -backend-option -time-passes -o - 2>&1 |
FileCheck %s
+// RUN: %clang_cc1 %s -emit-l
Author: etienneb
Date: Tue Mar 22 13:21:17 2016
New Revision: 264080
URL: http://llvm.org/viewvc/llvm-project?rev=264080&view=rev
Log:
[clang-tidy] Fix broken test with redundant string init (msvc).
Summary:
There is a silly bug that got introduced after fixing incorrect paths with this
patch:
h
Anastasia accepted this revision.
Anastasia added a comment.
LGTM!
http://reviews.llvm.org/D17596
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
Anastasia added inline comments.
Comment at: test/SemaOpenCL/invalid-pipe-builtin-cl2.0.cl:1
@@ -1,2 +1,2 @@
// RUN: %clang_cc1 %s -verify -pedantic -fsyntax-only -cl-std=CL2.0
Could you add a test case that fails before your modification here to show that
you
rnk accepted this revision.
rnk added a comment.
This revision is now accepted and ready to land.
lgtm
http://reviews.llvm.org/D18365
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
etienneb created this revision.
etienneb added reviewers: rnk, alexfh.
etienneb added a subscriber: cfe-commits.
There is a silly bug that got introduced after fixing incorrect paths with this
patch:
http://reviews.llvm.org/D18293
The tests was present twice in the file.
http://reviews.llvm.org
srhines accepted this revision.
srhines added a comment.
This revision is now accepted and ready to land.
I think this is trivial enough for me to accept. I also added cfe-commits, so
that they at least have a chance to review/comment.
Repository:
rL LLVM
http://reviews.llvm.org/D18363
__
On Tue, Mar 22, 2016 at 10:50 AM, Justin Bogner via cfe-commits <
cfe-commits@lists.llvm.org> wrote:
> Author: bogner
> Date: Tue Mar 22 12:50:05 2016
> New Revision: 264071
>
> URL: http://llvm.org/viewvc/llvm-project?rev=264071&view=rev
> Log:
> StaticAnalyzer: Avoid an unintentional copy
>
Jus
zaks.anna added inline comments.
Comment at: lib/StaticAnalyzer/Checkers/ConversionChecker.cpp:84
@@ +83,3 @@
+// Can E value be greater or equal than Val?
+static bool canBeGreaterEqual(CheckerContext &C, const Expr *E,
+ unsigned long long Val) {
---
Author: etienneb
Date: Tue Mar 22 13:00:13 2016
New Revision: 264075
URL: http://llvm.org/viewvc/llvm-project?rev=264075&view=rev
Log:
[clang-tidy] Fix redundant-string-cstr check with msvc 14 headers.
Summary:
The string constructors are not defined using optional parameters and are not
recogni
Anastasia updated this revision to Diff 51303.
Anastasia added a comment.
Thanks to Aleksey Bader for rebasing this patch to ToT and fixing some tests
issues!
http://reviews.llvm.org/D17821
Files:
include/clang/AST/ASTContext.h
include/clang/AST/BuiltinTypes.def
include/clang/AST/OpenCLI
Author: etienneb
Date: Tue Mar 22 12:51:27 2016
New Revision: 264073
URL: http://llvm.org/viewvc/llvm-project?rev=264073&view=rev
Log:
[clang-tidy] Skip reporting of not applicable fixes.
Summary:
Invalid source location are causing clang-tidy to crash when manipulating an
invalid file.
Macro d
etienneb updated this revision to Diff 51305.
etienneb added a comment.
rebase + fixing invalid paths
http://reviews.llvm.org/D18262
Files:
clang-tidy/ClangTidy.cpp
test/clang-tidy/misc-macro-parentheses-cmdline.cpp
Index: test/clang-tidy/misc-macro-parentheses-cmdline.cpp
Author: bogner
Date: Tue Mar 22 12:50:05 2016
New Revision: 264071
URL: http://llvm.org/viewvc/llvm-project?rev=264071&view=rev
Log:
StaticAnalyzer: Avoid an unintentional copy
The range here isn't over references, so using `auto &` here incites a
copy. Switching to `auto *` would do, but we migh
sbenza added a comment.
In http://reviews.llvm.org/D17811#380124, @jbcoe wrote:
> Do you have commit access? I can apply this patch for you if not.
I do.
I am waiting on http://reviews.llvm.org/D18275 to fix the problem with using
internal::HasNameMatcher directly.
http://reviews.llvm.org/D1
apaprocki created this revision.
apaprocki added a subscriber: cfe-commits.
This patch adds Clang driver support for the AIX platform. This allows Clang
to be used for compiling code / checking for errors, but does not allow for
building executables, as AIX uses XCOFF and not ELF.
After applyi
Author: etienneb
Date: Tue Mar 22 12:39:36 2016
New Revision: 264069
URL: http://llvm.org/viewvc/llvm-project?rev=264069&view=rev
Log:
[clang-tidy] Fix redundant-string-init check with msvc 14 headers.
Summary:
The string constructors are not defined using optional parameters and are not
recogni
EricWF requested changes to this revision.
EricWF added a comment.
This revision now requires changes to proceed.
I think this diff is messed up a little. Could you upload a fixed diff?
http://reviews.llvm.org/D18347
___
cfe-commits mailing list
cf
Ugh, templates and friend function definitions strike again!
I think this is where "semantic" vs. "lexical" DeclContexts come into play.
Try doing D->getLexicalDeclContext()->isDependentContext().
On Tue, Mar 22, 2016 at 5:23 AM, Stephan Bergmann
wrote:
> On 03/17/2016 09:06 PM, Reid Kleckner v
LegalizeAdulthood added a comment.
Looks like I forgot to remove brace initializers from the test files. I will
fix that.
Chris Lattner has given me commit access now, so I can commit on my own.
http://reviews.llvm.org/D16529
___
cfe-commits maili
LegalizeAdulthood added inline comments.
Comment at: test/clang-tidy/readability-non-const-parameter.cpp:116-134
@@ +115,21 @@
+
+// CHECK-MESSAGES: :[[@LINE+1]]:18: warning: parameter 'p' can be const
+int return1(int *p) {
+ // CHECK-FIXES: {{^}}int return1(const int *p) {{{$}}
etienneb updated this revision to Diff 51298.
etienneb added a comment.
Rebased + fixing invalid paths.
The diff paths were wrong, invalid diff.
http://reviews.llvm.org/D18293
Files:
clang-tidy/readability/RedundantStringInitCheck.cpp
test/clang-tidy/readability-redundant-string-init-msvc.
yaxunl added a comment.
If __attribute__((linkonce_odr_linkage)) is not a proper name for explicitly
setting linkage, how about __attribute((linkage=linkonce_odr))? This can be
extended to other linkages too.
http://reviews.llvm.org/D18095
___
cfe
yaxunl updated the summary for this revision.
yaxunl removed rL LLVM as the repository for this revision.
yaxunl updated this revision to Diff 51297.
yaxunl added a comment.
Simplify description of this attribute in AttrDocs since it causes some
confusion.
http://reviews.llvm.org/D18095
Files:
Author: majnemer
Date: Tue Mar 22 12:10:07 2016
New Revision: 264066
URL: http://llvm.org/viewvc/llvm-project?rev=264066&view=rev
Log:
Make build bots happy
BasicBlock's lose their names for some builders, don't mention such
names.
Modified:
cfe/trunk/test/CodeGenCXX/pr27030.cpp
Modified: c
yaxunl marked an inline comment as done.
Comment at: include/clang/Basic/Attr.td:701
@@ -699,1 +700,3 @@
+def OpenCLNoSVM : Attr {
+ let Spellings = [GNU<"nosvm">];
aaron.ballman wrote:
> yaxunl wrote:
> > aaron.ballman wrote:
> > > Since the attribute is ignor
Author: majnemer
Date: Tue Mar 22 11:44:39 2016
New Revision: 264065
URL: http://llvm.org/viewvc/llvm-project?rev=264065&view=rev
Log:
[MS ABI] Assign an inheritance model for the dest of a member pointer upcast
While we correctly assigned an inheritance model for the source of a
member pointer u
I totally didn’t know python had a portable way to do that!
Updated in r264064.
Thanks!
-Chris
> On Mar 22, 2016, at 9:26 AM, Vedant Kumar wrote:
>
> I think setting `cc1_env["LLVM_PROFILE_FILE"] = os.devnull` would be simpler.
>
> vedant
>
>> On Mar 21, 2016, at 7:55 PM, Chris Bieneman via
Author: cbieneman
Date: Tue Mar 22 11:33:23 2016
New Revision: 264064
URL: http://llvm.org/viewvc/llvm-project?rev=264064&view=rev
Log:
[Perf-training] Using os.devnull instead of a temp file
This is based on post-commit feedback from Vedant. Totally didn't know that
existed and worked on Window
Sean,
All good feedback.
Using print_function was done in r257936 with some other feedback from Bogner.
The rest of your feedback I believe I have addressed in r264063.
-Chris
> On Mar 21, 2016, at 9:21 PM, Sean Silva wrote:
>
>
>
> On Fri, Jan 15, 2016 at 1:21 PM, Chris Bieneman via cfe-c
Author: cbieneman
Date: Tue Mar 22 11:27:35 2016
New Revision: 264063
URL: http://llvm.org/viewvc/llvm-project?rev=264063&view=rev
Log:
[Perf-training] Cleanup based on feedback from Sean Silvas
Sean provided feedback based on r257934 on cfe-commits. This change addresses
that feedback.
Modifie
I think setting `cc1_env["LLVM_PROFILE_FILE"] = os.devnull` would be simpler.
vedant
> On Mar 21, 2016, at 7:55 PM, Chris Bieneman via cfe-commits
> wrote:
>
> Author: cbieneman
> Date: Mon Mar 21 21:55:40 2016
> New Revision: 264021
>
> URL: http://llvm.org/viewvc/llvm-project?rev=264021&vie
alexfh added a comment.
Adding Manuel, who might have better ideas.
In http://reviews.llvm.org/D17981#374904, @rnk wrote:
> In http://reviews.llvm.org/D17981#374553, @etienneb wrote:
>
> > This is a huge difference. I didn't expect dependencies to bring so much
> > code.
> > I'm not a fan of h
fowles added a subscriber: fowles.
Comment at: test/clang-tidy/performance-unnecessary-value-param.cpp:8
@@ +7,3 @@
+ void nonConstMethod() {}
+ virtual ~ExpensiveToCopyType() {}
+};
you don't actually need to fill in these methods, just declare them
==
fowles updated this revision to Diff 51289.
fowles added a comment.
rebased to latest. Can someone submit this for me I don't have commit bits.
http://reviews.llvm.org/D18149
Files:
clang-tidy/performance/UnnecessaryCopyInitialization.cpp
clang-tidy/performance/UnnecessaryCopyInitializatio
fowles added inline comments.
Comment at: clang-tidy/performance/UnnecessaryCopyInitialization.cpp:21
@@ +20,3 @@
+
+void recordFixes(const VarDecl &Var, ASTContext &Context,
+ DiagnosticBuilder &Diagnostic) {
I am inclined to just leave it as is f
alexfh accepted this revision.
alexfh added a comment.
LG
Comment at: clang-tidy/performance/UnnecessaryCopyInitialization.cpp:21
@@ +20,3 @@
+
+void recordFixes(const VarDecl &Var, ASTContext &Context,
+ DiagnosticBuilder &Diagnostic) {
nit: Alt
1 - 100 of 143 matches
Mail list logo
