rsmith added inline comments.

================
Comment at: lib/CodeGen/CGCall.cpp:142-143
@@ -132,1 +141,4 @@
+  appendParameterTypes(CGT, prefix, FTP, FD, &SynthesizedParams);
+  RequiredArgs Required =
+      RequiredArgs::forPrototypePlus(FTP, StartParams + SynthesizedParams);
   CanQualType resultType = FTP->getReturnType().getUnqualifiedType();
----------------
Would it make sense for `RequiredArgs::forPrototypePlus` to do this 
computation? Are the other callers of that function also getting the wrong 
number of required arguments in this case?


http://reviews.llvm.org/D17462



_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Reply via email to