Re: [PATCH] D18149: Add check for unneeded copies of locals

[Alexander Kornienko via cfe-commits]

alexfh accepted this revision.
alexfh added a comment.

LG


================
Comment at: clang-tidy/performance/UnnecessaryCopyInitialization.cpp:21
@@ +20,3 @@
+
+void recordFixes(const VarDecl &Var, ASTContext &Context,
+                 DiagnosticBuilder &Diagnostic) {
----------------
nit: Alternatively, you could return llvm::Optional<FixItHint> and apply it in 
the caller. Might result in a bit better separation of responsibilities.


http://reviews.llvm.org/D18149



_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits