Re: r259976 - [modules] Compress files embedded into a .pcm file, to reduce the disk usage of -fembed-all-files mode.

On 5 Feb 2016 11:12 p.m., "Dmitri Gribenko" wrote: > > On Fri, Feb 5, 2016 at 6:06 PM, Richard Smith via cfe-commits > wrote: > > Author: rsmith > > Date: Fri Feb 5 20:06:43 2016 > > New Revision: 259976 > > > > URL: http://llvm.org/viewvc/llvm-project?rev=259976&view=rev > > Log: > > [modules]

Re: r259976 - [modules] Compress files embedded into a .pcm file, to reduce the disk usage of -fembed-all-files mode.

On Fri, Feb 5, 2016 at 6:06 PM, Richard Smith via cfe-commits wrote: > Author: rsmith > Date: Fri Feb 5 20:06:43 2016 > New Revision: 259976 > > URL: http://llvm.org/viewvc/llvm-project?rev=259976&view=rev > Log: > [modules] Compress files embedded into a .pcm file, to reduce the disk usage > of

r259985 - Re-apply r259977 - [OpenMP] Reorganize code to allow specialized code generation for different devices.

Author: sfantao Date: Sat Feb 6 00:52:48 2016 New Revision: 259985 URL: http://llvm.org/viewvc/llvm-project?rev=259985&view=rev Log: Re-apply r259977 - [OpenMP] Reorganize code to allow specialized code generation for different devices. This was reverted due to a failure in a buildbot, but it t

r259984 - Revert r259977 - [OpenMP] Reorganize code to allow specialized code generation for different devices.

Author: sfantao Date: Sat Feb 6 00:22:46 2016 New Revision: 259984 URL: http://llvm.org/viewvc/llvm-project?rev=259984&view=rev Log: Revert r259977 - [OpenMP] Reorganize code to allow specialized code generation for different devices. It triggered some problem in the configuration related with

Re: [PATCH] D16047: [OpenCL] Add Sema checks for OpenCL 2.0

pxli168 updated this revision to Diff 47074. pxli168 updated the summary for this revision. pxli168 added a comment. Rebase for partition http://reviews.llvm.org/D16047 Files: include/clang/Basic/DiagnosticSemaKinds.td lib/Sema/SemaDecl.cpp lib/Sema/SemaExpr.cpp lib/Sema/SemaInit.cpp

Re: [PATCH] D16873: Refactor MemRegionManager::getVarRegion to call two new functions, improving readability

ariccio marked 11 inline comments as done. ariccio added a comment. Marked some inline comments as done. http://reviews.llvm.org/D16873 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commit

Re: [PATCH] D16873: Refactor MemRegionManager::getVarRegion to call two new functions, improving readability

ariccio marked 9 inline comments as done. ariccio added a comment. Whoops, I didn't //submit// my comments. Comment at: llvm/tools/clang/include/clang/StaticAnalyzer/Core/PathSensitive/MemRegion.h:1185 @@ +1184,3 @@ + /// getMemRegionGloballyStored - Retrieve or create the mem

Re: [PATCH] D16821: Add whole-program vtable optimization feature to Clang.

pete added a comment. Sorry I haven't got to this sooner. I'll try review what I can over the next day or two. Saying that, i'm not experienced enough in the clang codebase to give a LGTM. I can comment on style, but someone else will need to give the final ok. http://reviews.llvm.org/D1682

Re: [PATCH] D16928: [OpenCL] Apply missing restrictions for Blocks in OpenCL v2.0

pxli168 added inline comments. Comment at: lib/Sema/SemaDecl.cpp:13011 @@ -12978,5 +13010,3 @@ - // OpenCL 1.2 spec, s6.9 r: - // The event type cannot be used to declare a structure or union field. - if (LangOpts.OpenCL && T->isEventT()) { -Diag(Loc, diag::err_event_t_st

Re: [PATCH] D16040: [OpenCL] Refine OpenCLImageAccessAttr to OpenCLAccessAttr

pxli168 added inline comments. Comment at: lib/Sema/SemaDeclAttr.cpp:5067 @@ +5066,3 @@ + if (DeclTy->isPipeType() || + (S.getLangOpts().OpenCLVersion < 200 && DeclTy->isImageType())) { +S.Diag(D->getLocation(), diag::err_opencl_invalid_read_write) --

Re: [PATCH] D16040: [OpenCL] Refine OpenCLImageAccessAttr to OpenCLAccessAttr

pxli168 updated this revision to Diff 47073. pxli168 added a comment. Make some optimization http://reviews.llvm.org/D16040 Files: include/clang/Basic/Attr.td include/clang/Basic/DiagnosticSemaKinds.td lib/CodeGen/CodeGenFunction.cpp lib/Sema/SemaChecking.cpp lib/Sema/SemaDeclAttr.cpp

Re: [PATCH] D16686: [OpenCL] Generate metadata for opencl_unroll_hint attribute

pxli168 added a reviewer: rsmith. pxli168 added a comment. Hi richard, What is your opinion about where to put this ParseOpenCLUnrollHintAttribute? Thanks Xiuli Comment at: lib/Parse/ParseStmt.cpp:2214 @@ +2213,3 @@ + +bool Parser::ParseOpenCLUnrollHintAttribute(ParsedAttribut

r259977 - [OpenMP] Reorganize code to allow specialized code generation for different devices.

Author: sfantao Date: Fri Feb 5 20:12:34 2016 New Revision: 259977 URL: http://llvm.org/viewvc/llvm-project?rev=259977&view=rev Log: [OpenMP] Reorganize code to allow specialized code generation for different devices. Summary: Different devices may in some cases require different code generatio

r259976 - [modules] Compress files embedded into a .pcm file, to reduce the disk usage of -fembed-all-files mode.

Author: rsmith Date: Fri Feb 5 20:06:43 2016 New Revision: 259976 URL: http://llvm.org/viewvc/llvm-project?rev=259976&view=rev Log: [modules] Compress files embedded into a .pcm file, to reduce the disk usage of -fembed-all-files mode. Added: cfe/trunk/test/Modules/embed-files-compressed.cp

r259975 - Fix a crash when emitting dbeug info for forward-declared scoped enums.

Author: adrian Date: Fri Feb 5 19:59:09 2016 New Revision: 259975 URL: http://llvm.org/viewvc/llvm-project?rev=259975&view=rev Log: Fix a crash when emitting dbeug info for forward-declared scoped enums. It is possible for enums to be created as part of their own declcontext. We need to cache a p

Re: [PATCH] D16876: [OpenCL] Refine pipe builtin support

pxli168 requested a review of this revision. pxli168 added a reviewer: rsmith. pxli168 added a comment. Hi Richard/Anastasia, I replied in the commit email, and here are some explains: 1. Without the space after comma the "//" will be aligned. 2. We want generic prototypes of the builtin functio

LLVM buildmaster will be restarted tonight

Hello everyone, LLVM buildmaster will be updated and restarted after 6 PM Pacific time today. Thanks Galina ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

r259969 - [www] Update analyzer release notes to correct the checker-278 build date.

Author: dcoughlin Date: Fri Feb 5 18:59:14 2016 New Revision: 259969 URL: http://llvm.org/viewvc/llvm-project?rev=259969&view=rev Log: [www] Update analyzer release notes to correct the checker-278 build date. This is not the future. Modified: cfe/trunk/www/analyzer/release_notes.html Modi

r259967 - [www] Update analyzer website for checker-278.

Author: dcoughlin Date: Fri Feb 5 18:53:33 2016 New Revision: 259967 URL: http://llvm.org/viewvc/llvm-project?rev=259967&view=rev Log: [www] Update analyzer website for checker-278. Modified: cfe/trunk/www/analyzer/latest_checker.html.incl cfe/trunk/www/analyzer/release_notes.html Modif

Re: [PATCH] D16613: Introduce a cmake module to figure out whether we need to link with libatomic.

vkalintiris added a comment. Sorry for the early pings. In case it's not clear from Daniel's comment, without this patch libc++ will be broken for 32-bit MIPS CPUs. The relevant bug report has been nominated as a release block but we'd like to have it committed before the next RC. http://revi

Re: [PATCH] D16914: [CodeGen] Fix an assert in CodeGenFunction::EmitFunctionEpilog

ahatanak added a reviewer: rjmccall. ahatanak updated this revision to Diff 47062. ahatanak added a comment. Enclose the code with "#ifndef NDEBUG". http://reviews.llvm.org/D16914 Files: lib/CodeGen/CGCall.cpp test/CodeGenObjCXX/auto-release-result-assert.mm Index: test/CodeGenObjCXX/auto-

Re: [PATCH] D16914: [CodeGen] Fix an assert in CodeGenFunction::EmitFunctionEpilog

I agree with you, that was actually what John suggested too. I'll update the patch shortly. On Fri, Feb 5, 2016 at 3:38 PM, Duncan P. N. Exon Smith < dexonsm...@apple.com> wrote: > > > On 2016-Feb-04, at 18:54, Akira Hatanaka via cfe-commits < > cfe-commits@lists.llvm.org> wrote: > > > > ahatana

r259955 - [PGO] Test case update

Author: davidxl Date: Fri Feb 5 17:36:08 2016 New Revision: 259955 URL: http://llvm.org/viewvc/llvm-project?rev=259955&view=rev Log: [PGO] Test case update Temporarily relax check in test to avoid breakage for format change in LLVM side. Once that is done, the test case will be retighten

Re: [PATCH] D16914: [CodeGen] Fix an assert in CodeGenFunction::EmitFunctionEpilog

> On 2016-Feb-04, at 18:54, Akira Hatanaka via cfe-commits > wrote: > > ahatanak created this revision. > ahatanak added a subscriber: cfe-commits. > > The assert near CGCall.cpp:2465 is triggered because > QualType::isObjCRetainableType() is called on different types. In > CodeGenFunction::

r259950 - Eliminate an unnecessary enum, use the LLVM version. NFC

Author: probinson Date: Fri Feb 5 17:23:25 2016 New Revision: 259950 URL: http://llvm.org/viewvc/llvm-project?rev=259950&view=rev Log: Eliminate an unnecessary enum, use the LLVM version. NFC Modified: cfe/trunk/include/clang/Frontend/CodeGenOptions.def cfe/trunk/include/clang/Frontend/C

Re: [PATCH] D15829: [PGO] Clang Option that enables IR level PGO instrumentation

davidxl added inline comments. Comment at: include/clang/Frontend/CodeGenOptions.h:234 @@ +233,3 @@ + + /// \brief Check if IR profile instrumenation is on. + bool hasProfileIRInstr() const { typo: instrumentation http://reviews.llvm.org/D15829

[clang-tools-extra] r259949 - Add qualifiers that are about to be necessary. NFC

Author: probinson Date: Fri Feb 5 17:20:02 2016 New Revision: 259949 URL: http://llvm.org/viewvc/llvm-project?rev=259949&view=rev Log: Add qualifiers that are about to be necessary. NFC Modified: clang-tools-extra/trunk/modularize/ModularizeUtilities.cpp Modified: clang-tools-extra/trunk/mo

Re: [PATCH] D3976: -Wcomma, a new warning for questionable uses of the comma operator

So, this week got consumed by -Wconstant-conversion. We'll see how next week goes. On Fri, Jan 29, 2016 at 7:16 PM, Richard Trieu wrote: > rtrieu added a comment. > > Not sure what happened. Will check it out on Monday. > > > http://reviews.llvm.org/D3976 > > > > __

Re: r259271 - Improve -Wconstant-conversion

Thanks! Maybe it's interesting if I list the instances where this fired in Chromium. * libwebp calls _mm_set1_epi16(33050) (but then is careful to only use unsigned intrinsics with this). There's no version of this function that takes unsigned short, so the only thing to change here was to add a

Re: r259271 - Improve -Wconstant-conversion

r259947 will stop this warning on char arrays. On Mon, Feb 1, 2016 at 1:40 PM, Richard Trieu wrote: > C++11 narrowing only happens during certain conversions while this warning > checks all conversions. > > We might be able to avoid char array initialization, but it would be a > little tricky.

r259947 - Exempt char array initializers from -Wconstant-converion.

Author: rtrieu Date: Fri Feb 5 17:02:38 2016 New Revision: 259947 URL: http://llvm.org/viewvc/llvm-project?rev=259947&view=rev Log: Exempt char array initializers from -Wconstant-converion. Sometimes, char arrays are used as bit storage, with no difference made between signed and unsigned char.

Re: [PATCH] D16932: [CUDA] Bug 26497 : Remove wrappers for variants already provided by CUDA headers.

This revision was automatically updated to reflect the committed changes. Closed by commit rL259944: [CUDA] Bug 26497 : Remove wrappers for variants provided by CUDA headers. (authored by tra). Changed prior to commit: http://reviews.llvm.org/D16932?vs=47040&id=47058#toc Repository: rL LLVM

r259944 - [CUDA] Bug 26497 : Remove wrappers for variants provided by CUDA headers.

Author: tra Date: Fri Feb 5 16:54:05 2016 New Revision: 259944 URL: http://llvm.org/viewvc/llvm-project?rev=259944&view=rev Log: [CUDA] Bug 26497 : Remove wrappers for variants provided by CUDA headers. ... and pull global-scope ones into std namespace with using-declaration. Differential Revis

Re: [PATCH] D16761: clang-cl: Support loading plugins on Windows

ehsan updated this revision to Diff 47057. ehsan added a comment. Sorry for the noise, arconist fail... http://reviews.llvm.org/D16761 Files: docs/ClangPlugins.rst examples/PrintFunctionNames/PrintFunctionNames.cpp lib/FrontendTool/ExecuteCompilerInvocation.cpp test/Frontend/plugins.c

Re: [PATCH] D16761: clang-cl: Support loading plugins on Windows

ehsan updated this revision to Diff 47056. ehsan added a comment. Updating based on the LLVM side changes. http://reviews.llvm.org/D16761 Files: docs/ClangPlugins.rst examples/PrintFunctionNames/PrintFunctionNames.cpp include/clang/Basic/DiagnosticASTKinds.td lib/AST/ExprConstant.cpp

[PATCH] D16934: [Coverage] Fix crash in VisitIfStmt

vsk created this revision. vsk added a reviewer: bogner. vsk added a subscriber: cfe-commits. When handling 'if' statements, we crash if the condition and the consequent branch are spanned by a single macro expansion. The crash occurs because of a sanity 'reset' in `popRegions()`: if an expansion

Re: r259931 - [SystemZ] Define __GCC_HAVE_SYNC_COMPARE_AND_SWAP macros

Merged in r259939. Cheers, Hans On Fri, Feb 5, 2016 at 2:06 PM, Ulrich Weigand wrote: > Hans, > > this is one more patch that should go into 3.8 -- it fixes miscompiles of > code using GCC-provided C++11 system headers like . > > With this patch, the test suite is now clean also with a bootstrap

Re: r259931 - [SystemZ] Define __GCC_HAVE_SYNC_COMPARE_AND_SWAP macros

Just a general comment: I believe we've now fixed this bug for at least four different architectures (each time as a separate effort). Is there some kind of auditing we could do to make sure we don't run into this again? -Hal - Original Message - > From: "Ulrich Weigand via cfe-commits

Re: r259931 - [SystemZ] Define __GCC_HAVE_SYNC_COMPARE_AND_SWAP macros

Hans, this is one more patch that should go into 3.8 -- it fixes miscompiles of code using GCC-provided C++11 system headers like . With this patch, the test suite is now clean also with a bootstrapped clang. >Author: uweigand >Date: Fri Feb 5 15:34:28 2016 >New Revision: 259931 > >URL: htt

Re: [PATCH] D16932: [CUDA] Bug 26497 : Remove wrappers for variants already provided by CUDA headers.

jlebar added a comment. Oh right, CUDA headers. We really need to get a buildbot and/or tests in test-suite set up. http://reviews.llvm.org/D16932 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinf

Re: [PATCH] D16932: [CUDA] Bug 26497 : Remove wrappers for variants already provided by CUDA headers.

tra added a comment. I'm not sure what we could test here without CUDA headers. I've tested out-of-tree by compiling thrust unit tests and the test case in PR. http://reviews.llvm.org/D16932 ___ cfe-commits mailing list cfe-commits@lists.llvm.org ht

Re: [PATCH] D16460: Bug 10002 - [opencl] Wrongfully assuming RHS is always unsigned

ichesnokov added a comment. Ping. Repository: rL LLVM http://reviews.llvm.org/D16460 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Re: [PATCH] D16539: [FIX] 26194 - LLVM crash in CXXNameMangler::mangleType

ichesnokov added a comment. Ping. http://reviews.llvm.org/D16539 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Re: [PATCH] D16539: [FIX] 26194 - LLVM crash in CXXNameMangler::mangleType

ichesnokov added a comment. Ping. http://reviews.llvm.org/D16539 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

r259935 - Move DebugInfoKind enum from Driver to Basic. NFC

Author: probinson Date: Fri Feb 5 15:54:42 2016 New Revision: 259935 URL: http://llvm.org/viewvc/llvm-project?rev=259935&view=rev Log: Move DebugInfoKind enum from Driver to Basic. NFC Added: cfe/trunk/include/clang/Basic/DebugInfoOptions.h - copied, changed from r259876, cfe/trunk/in

r259932 - Add an ARC autoreleased-return-value caller marker on i386.

Author: rjmccall Date: Fri Feb 5 15:37:38 2016 New Revision: 259932 URL: http://llvm.org/viewvc/llvm-project?rev=259932&view=rev Log: Add an ARC autoreleased-return-value caller marker on i386. rdar://24531556 Added: cfe/trunk/test/CodeGenObjC/arc-i386.m Modified: cfe/trunk/lib/CodeGen/

Re: [PATCH] D16932: [CUDA] Bug 26497 : Remove wrappers for variants already provided by CUDA headers.

jlebar accepted this revision. jlebar added a comment. This revision is now accepted and ready to land. Is it worth having a test, if only for one or two functions? http://reviews.llvm.org/D16932 ___ cfe-commits mailing list cfe-commits@lists.llvm.o

r259931 - [SystemZ] Define __GCC_HAVE_SYNC_COMPARE_AND_SWAP macros

Author: uweigand Date: Fri Feb 5 15:34:28 2016 New Revision: 259931 URL: http://llvm.org/viewvc/llvm-project?rev=259931&view=rev Log: [SystemZ] Define __GCC_HAVE_SYNC_COMPARE_AND_SWAP macros Define __GCC_HAVE_SYNC_COMPARE_AND_SWAP_[1248] macros on SystemZ. This fixes a miscompile of GCC C++11 s

[PATCH] D16932: [CUDA] Bug 26497 : Remove wrappers for variants already provided by CUDA headers.

tra created this revision. tra added reviewers: jingyue, jlebar. tra added a subscriber: cfe-commits. ... and pull them into std namespace with using-declaration instead. http://reviews.llvm.org/D16932 Files: lib/Headers/__clang_cuda_cmath.h Index: lib/Headers/__clang_cuda_cmath.h ==

Re: [PATCH] D16574: Bug 15685 - OpenCL 'char' is not signed

ichesnokov added a comment. Instead of checking by division by zero, I've used _StaticAssert. Functionally bo change, but more understandable. http://reviews.llvm.org/D16574 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.

r259916 - Do not honor explicit alignment attribute on fields for PS4.

Author: ssrivastava Date: Fri Feb 5 14:50:02 2016 New Revision: 259916 URL: http://llvm.org/viewvc/llvm-project?rev=259916&view=rev Log: Do not honor explicit alignment attribute on fields for PS4. This change reverts r257462 for PS4 triple. Differential Revision: http://reviews.llvm.org/D16788

Re: [PATCH] D16788: Do not honor explicit alignment attribute on fields for PS4.

This revision was automatically updated to reflect the committed changes. Closed by commit rL259916: Do not honor explicit alignment attribute on fields for PS4. (authored by ssrivastava). Changed prior to commit: http://reviews.llvm.org/D16788?vs=47026&id=47039#toc Repository: rL LLVM http

Re: r258524 - Merge templated static member variables, fixes http://llvm.org/pr26179.

This belongs in ASTDeclReader::attachPreviousDecl[Impl]. That's where we propagate data that's supposed to be consistent across a redeclaration chain from earlier declarations to later ones. There's another wrinkle here: we should only be propagating the type from a previous declaration that's dec

Re: [PATCH] D16843: [Sema] Fix bug in TypeLocBuilder::pushImpl

ahatanak updated this revision to Diff 47037. ahatanak added a comment. Fixed a couple of bugs: - Make sure Capacity is a multiple of 8-byte. - "||=" isn't a valid operator. Use "||" instead. http://reviews.llvm.org/D16843 Files: lib/Sema/TypeLocBuilder.cpp lib/Sema/TypeLocBuilder.h test

Re: r258524 - Merge templated static member variables, fixes http://llvm.org/pr26179.

I am not sure where else to put this logic if not in isSameEntity... Could you point me to a better place? --Vassil On 05/02/16 19:56, Richard Smith wrote: On Fri, Feb 5, 2016 at 7:04 AM, Vassil Vassilev mailto:v.g.vassi...@gmail.com>> wrote: Good point. Do you have in mind calling 'cl

Re: [PATCH] D16906: [Parser] Perform CachedTokens update dependent on token consume request

bruno closed this revision. bruno added a comment. Committed r259910 http://reviews.llvm.org/D16906 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

r259910 - [Parser] Perform CachedTokens update dependent on token consumption

Author: bruno Date: Fri Feb 5 13:36:39 2016 New Revision: 259910 URL: http://llvm.org/viewvc/llvm-project?rev=259910&view=rev Log: [Parser] Perform CachedTokens update dependent on token consumption In the context where we break one tok::greatergreater into two tok::greater in order to correctly

Re: [PATCH] D16930: Improve literal operator parameter diagnostics.

rsmith added a comment. Thanks for tackling this! Comment at: include/clang/Basic/DiagnosticSemaKinds.td:6889 @@ +6888,3 @@ +def err_literal_operator_invalid_param : Error< + "invalid literal operator parameter type %0">; +def err_literal_operator_param : Error< ---

r259901 - [modules] Separately track whether an identifier's preprocessor information and

Author: rsmith Date: Fri Feb 5 13:03:40 2016 New Revision: 259901 URL: http://llvm.org/viewvc/llvm-project?rev=259901&view=rev Log: [modules] Separately track whether an identifier's preprocessor information and name lookup information have changed since deserialization. For a C++ modules build,

Re: r259898 - [ASTMatchers] Allow hasName() to look through inline namespaces

Probably not (unless someone corrects me). In that case, it can wait for the next release. Thanks, Hans On Fri, Feb 5, 2016 at 11:02 AM, Aaron Ballman wrote: > Is PR25804 a regression? > > ~Aaron > > On Fri, Feb 5, 2016 at 1:59 PM, Hans Wennborg via cfe-commits > wrote: >> It was requested that

Re: r259898 - [ASTMatchers] Allow hasName() to look through inline namespaces

Is PR25804 a regression? ~Aaron On Fri, Feb 5, 2016 at 1:59 PM, Hans Wennborg via cfe-commits wrote: > It was requested that this be merged to 3.8 as it fixes PR25804. > > Manuel: does this look OK for the branch? > > Thanks, > Hans > > On Fri, Feb 5, 2016 at 10:29 AM, Samuel Benzaquen via cfe-c

Re: [PATCH] D16870: [CUDA] Tweak attribute-based overload resolution to match nvcc behavior.

jingyue added inline comments. Comment at: test/SemaCUDA/function-overload.cu:138 @@ -149,3 +137,3 @@ fp_t cdhp = cdh; - gp_t gp = g; // expected-error {{reference to __global__ function 'g' in __global__ function}} - // expected-note@67 {{'g' declared here}} +

Re: r259898 - [ASTMatchers] Allow hasName() to look through inline namespaces

It was requested that this be merged to 3.8 as it fixes PR25804. Manuel: does this look OK for the branch? Thanks, Hans On Fri, Feb 5, 2016 at 10:29 AM, Samuel Benzaquen via cfe-commits wrote: > Author: sbenza > Date: Fri Feb 5 12:29:24 2016 > New Revision: 259898 > > URL: http://llvm.org/view

Re: r258524 - Merge templated static member variables, fixes http://llvm.org/pr26179.

On Fri, Feb 5, 2016 at 7:04 AM, Vassil Vassilev wrote: > Good point. Do you have in mind calling 'clang::Sema::MergeVarDeclTypes' > or we to just "duplicate" the logic in > clang::ASTDeclReader::mergeRedeclarable? > It's not safe to call into Sema while we're in a partially-deserialized state. W

Re: [PATCH] D16682: 19957 - OpenCL incorrectly accepts implicit address space conversion with ternary operator

bader added a subscriber: bader. Comment at: test/SemaOpenCL/ternary-implicit-casts.cl:10-11 @@ +9,4 @@ +kernel void implicit_cast_generic(global int* gint, local int* lint, int cond) { + // will compile, ptr is generic and can accept global and local + int* ptr = con

Re: [PATCH] D16788: PS4 ABI Round 2. Actual PS4 code.

rjmccall added a comment. Yes, thank you, this looks great. I agree with David's review, but otherwise this LGTM. http://reviews.llvm.org/D16788 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo

Re: [PATCH] D16682: 19957 - OpenCL incorrectly accepts implicit address space conversion with ternary operator

ichesnokov added inline comments. Comment at: test/SemaOpenCL/ternary-implicit-casts.cl:6 @@ +5,3 @@ + // will not compile, ptr is not generic but local + local int *ptr = cond ? gint : lint; // expected-warning {{pointer type mismatch ('__global int *' and '__local int *'

Re: [PATCH] D16682: 19957 - OpenCL incorrectly accepts implicit address space conversion with ternary operator

Anastasia added inline comments. Comment at: test/SemaOpenCL/ternary-implicit-casts.cl:6 @@ +5,3 @@ + // will not compile, ptr is not generic but local + local int *ptr = cond ? gint : lint; // expected-warning {{pointer type mismatch ('__global int *' and '__local int *')

Re: [PATCH] D15506: [ASTMatchers] Allow hasName() to look through inline namespaces

This revision was automatically updated to reflect the committed changes. Closed by commit rL259898: [ASTMatchers] Allow hasName() to look through inline namespaces (authored by sbenza). Changed prior to commit: http://reviews.llvm.org/D15506?vs=45438&id=47029#toc Repository: rL LLVM http:/

r259898 - [ASTMatchers] Allow hasName() to look through inline namespaces

Author: sbenza Date: Fri Feb 5 12:29:24 2016 New Revision: 259898 URL: http://llvm.org/viewvc/llvm-project?rev=259898&view=rev Log: [ASTMatchers] Allow hasName() to look through inline namespaces Summary: Allow hasName() to look through inline namespaces. This will fix the interaction between so

[PATCH] D16930: Improve literal operator parameter diagnostics.

erik.pilkington created this revision. erik.pilkington added a reviewer: rsmith. erik.pilkington added a subscriber: cfe-commits. Previously, invalid parameters in a literal operator function were diagnosed with an uninformative catch all. This commit breaks the catch all into a couple of more i

Re: [PATCH] D16574: Bug 15685 - OpenCL 'char' is not signed

ichesnokov added a comment. No, just make test case more 'standard'. http://reviews.llvm.org/D16574 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Re: [PATCH] D16574: Bug 15685 - OpenCL 'char' is not signed

Anastasia added a comment. I am missing to understand the intention of this change. Are you trying to improve the testing for OpenCL? http://reviews.llvm.org/D16574 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-b

Re: [PATCH] D16788: PS4 ABI Round 2. Actual PS4 code.

majnemer added a subscriber: majnemer. Comment at: include/clang/Basic/TargetInfo.h:206 @@ +205,3 @@ + /// \brief Whether explicit bit field alignment attributes are honored. + unsigned int UseExplicitBitFieldAlignment : 1; + I'd use `unsigned` to match the sty

Re: [PATCH] D16788: PS4 ABI Round 2. Actual PS4 code.

Sunil_Srivastava updated this revision to Diff 47026. Sunil_Srivastava added a comment. Changed the patch based of feedback from John McCall. There is new bit UseExplicitBitFieldAlignment, which is set for everything except for PS4. The r257462 change has been made conditional on this bit. htt

Re: [PATCH] D16922: [clang-tidy] Added check-fixes for misc-virtual-near-miss.

congliu added inline comments. Comment at: test/clang-tidy/misc-virtual-near-miss.cpp:1 @@ -1,2 +1,2 @@ // RUN: %check_clang_tidy %s misc-virtual-near-miss %t alexfh wrote: > Please add a test ensuring replacements are applied correctly in templates > with mul

Re: [PATCH] D16922: [clang-tidy] Added check-fixes for misc-virtual-near-miss.

congliu updated this revision to Diff 47024. congliu added a comment. - Added test cases of macro and template. http://reviews.llvm.org/D16922 Files: clang-tidy/misc/VirtualNearMissCheck.cpp test/clang-tidy/misc-virtual-near-miss.cpp Index: test/clang-tidy/misc-virtual-near-miss.cpp ==

Re: [PATCH] D16876: [OpenCL] Refine pipe builtin support

Anastasia added inline comments. Comment at: lib/Sema/SemaChecking.cpp:294 @@ +293,3 @@ + diag::err_opencl_builtin_pipe_invalid_access_modifier) + << "read_only" << Arg0->getSourceRange(); + return true; Anastasia wrote: > Could we use ge

Re: [PATCH] D16928: [OpenCL] Apply missing restrictions for Blocks in OpenCL v2.0

Leporacanthicus added a subscriber: Leporacanthicus. Comment at: include/clang/Basic/DiagnosticSemaKinds.td:7684 @@ +7683,3 @@ + "the __block storage type is not permitted">; + +def err_opencl_variadic_prototype_not_allowed : Error< Is this blank line there for a

Re: [PATCH] D16876: [OpenCL] Refine pipe builtin support

Anastasia added a comment. I think some comments from Richad's feedback are missing, specifically: - Missing space after comma. - Why are these conversions performed here rather than in Sema? - You should attempt to implicitly convert to the desired type here, rather than demanding the right typ

[PATCH] D16928: [OpenCL] Apply missing restrictions for Blocks in OpenCL v2.0

Anastasia created this revision. Anastasia added reviewers: pekka.jaaskelainen, pxli168. Anastasia added a subscriber: cfe-commits. Anastasia set the repository for this revision to rL LLVM. Applying the following restrictions for block variables in OpenCL (v2.0 s6.12.5): - __block storage class

Re: [PATCH] D16465: [MS ABI] Prevent some expressions from evaluating to a constant

ehsan updated this revision to Diff 47021. ehsan added a comment. Addressed the review comments. http://reviews.llvm.org/D16465 Files: include/clang/AST/Decl.h include/clang/AST/Expr.h include/clang/Basic/DiagnosticASTKinds.td lib/AST/Decl.cpp lib/AST/ExprConstant.cpp lib/CodeGen/CG

Re: [PATCH] D16926: [clang-tidy] Fix assertion failure on `at` function in modernize-loop-convert.

hokein updated this revision to Diff 47019. hokein added a comment. Fix a typo in doc. http://reviews.llvm.org/D16926 Files: clang-tidy/modernize/LoopConvertUtils.cpp docs/clang-tidy/checks/modernize-loop-convert.rst test/clang-tidy/Inputs/modernize-loop-convert/structures.h test/clang-

Re: [PATCH] D16040: [OpenCL] Refine OpenCLImageAccessAttr to OpenCLAccessAttr

Anastasia added inline comments. Comment at: lib/Sema/SemaDeclAttr.cpp:5067 @@ +5066,3 @@ + if (DeclTy->isPipeType() || + (S.getLangOpts().OpenCLVersion < 200 && DeclTy->isImageType())) { +S.Diag(D->getLocation(), diag::err_opencl_invalid_read_write)

Re: [PATCH] D16686: [OpenCL] Generate metadata for opencl_unroll_hint attribute

Anastasia added inline comments. Comment at: lib/Parse/ParseStmt.cpp:2214 @@ +2213,3 @@ + +bool Parser::ParseOpenCLUnrollHintAttribute(ParsedAttributes &Attrs) { + MaybeParseGNUAttributes(Attrs); pxli168 wrote: > I am wondering where should this function goes in,

Re: [PATCH] D16876: [OpenCL] Refine pipe builtin support

yaxunl accepted this revision. yaxunl added a comment. This revision is now accepted and ready to land. LGTM. Thanks. http://reviews.llvm.org/D16876 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listin

Re: [PATCH] D15506: [ASTMatchers] Allow hasName() to look through inline namespaces

bkramer accepted this revision. bkramer added a comment. This revision is now accepted and ready to land. lg http://reviews.llvm.org/D15506 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-co

Re: r258524 - Merge templated static member variables, fixes http://llvm.org/pr26179.

Good point. Do you have in mind calling 'clang::Sema::MergeVarDeclTypes' or we to just "duplicate" the logic in clang::ASTDeclReader::mergeRedeclarable? On 05/02/16 02:50, Richard Smith via cfe-commits wrote: I suspect we'll need to do a little more than this: when we rebuild the redeclaration

Re: [PATCH] D16923: [AST] Implemented missing VisitAccessSpecDecl function in ASTImporter class.

karies added reviewers: klimek, bkramer. karies added a comment. Because of previous review subscriptions... http://reviews.llvm.org/D16923 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-co

[PATCH] D16923: [AST] Implemented missing VisitAccessSpecDecl function in ASTImporter class.

esakella created this revision. esakella added a reviewer: rsmith. esakella added subscribers: cfe-commits, karies. + test. http://reviews.llvm.org/D16923 Files: lib/AST/ASTImporter.cpp test/ASTMerge/Inputs/class1.cpp test/ASTMerge/Inputs/class2.cpp test/ASTMerge/class.cpp Index: test/A

Re: [PATCH] D16922: [clang-tidy] Added check-fixes for misc-virtual-near-miss.

alexfh added inline comments. Comment at: clang-tidy/misc/VirtualNearMissCheck.cpp:252 @@ -251,1 +251,3 @@ // A "virtual near miss" is found. +auto Range = CharSourceRange::getTokenRange(SourceRange( +DerivedMD->getLocation(), DerivedMD->ge

Re: [PATCH] D16310: new clang-tidy checker misc-long-cast

alexfh added inline comments. Comment at: clang-tidy/misc/MisplacedWideningCastCheck.cpp:20 @@ +19,3 @@ +void MisplacedWideningCastCheck::registerMatchers(MatchFinder *Finder) { + auto Calc = stmt(anyOf(binaryOperator(anyOf( + hasOperatorName("+"), has

r259884 - clang-format: Fix corner case in template detection.

Author: djasper Date: Fri Feb 5 08:17:16 2016 New Revision: 259884 URL: http://llvm.org/viewvc/llvm-project?rev=259884&view=rev Log: clang-format: Fix corner case in template detection. Before: f(a.operator() < A > ()); After: f(a.operator()()); Modified: cfe/trunk/lib/Format/Continuat

[PATCH] D16922: [clang-tidy] Added check-fixes for misc-virtual-near-miss.

congliu created this revision. congliu added a reviewer: alexfh. congliu added a subscriber: cfe-commits. Addes FixItHint and updated test. http://reviews.llvm.org/D16922 Files: clang-tidy/misc/VirtualNearMissCheck.cpp test/clang-tidy/misc-virtual-near-miss.cpp Index: test/clang-tidy/misc-v

Re: [PATCH] D16517: ClangTidy check to flag uninitialized builtin and pointer fields.

alexfh added a comment. In http://reviews.llvm.org/D16517#336157, @flx wrote: > In http://reviews.llvm.org/D16517#336148, @alexfh wrote: > > > A high-level comment: I think, this comment > > still applies. I'm also slightly > > concerned about having this

Re: [PATCH] D16113: [clang-tdiy] Add header file extension configuration support.

alexfh added a comment. A couple of post-commit comments. Comment at: clang-tools-extra/trunk/clang-tidy/google/GlobalNamesInHeadersCheck.h:24 @@ +23,3 @@ +/// +/// The check supports these options: +/// - `HeaderFileExtensions`: a comma-separated list of filename extensions

[clang-tools-extra] r259880 - Unbreak the cmake shared build.

Author: d0k Date: Fri Feb 5 05:38:50 2016 New Revision: 259880 URL: http://llvm.org/viewvc/llvm-project?rev=259880&view=rev Log: Unbreak the cmake shared build. Modified: clang-tools-extra/trunk/clang-tidy/google/CMakeLists.txt Modified: clang-tools-extra/trunk/clang-tidy/google/CMakeLists.

Re: [PATCH] D16113: [clang-tdiy] Add header file extension configuration support.

This revision was automatically updated to reflect the committed changes. Closed by commit rL259879: [clang-tdiy] Add header file extension configuration support. (authored by hokein). Changed prior to commit: http://reviews.llvm.org/D16113?vs=46923&id=47007#toc Repository: rL LLVM http://r

[clang-tools-extra] r259879 - [clang-tdiy] Add header file extension configuration support.

Author: hokein Date: Fri Feb 5 05:23:59 2016 New Revision: 259879 URL: http://llvm.org/viewvc/llvm-project?rev=259879&view=rev Log: [clang-tdiy] Add header file extension configuration support. Summary: * Add a `HeaderFileExtensions` check option in misc-definitions-in-headers, google-build-nam

Re: [PATCH] D16113: [clang-tdiy] Add header file extension configuration support.

alexfh added a comment. Still looks good. http://reviews.llvm.org/D16113 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

  1   2   >