pxli168 added a reviewer: rsmith.
pxli168 added a comment.
Hi richard,
What is your opinion about where to put this ParseOpenCLUnrollHintAttribute?
Thanks
Xiuli
================
Comment at: lib/Parse/ParseStmt.cpp:2214
@@ +2213,3 @@
+
+bool Parser::ParseOpenCLUnrollHintAttribute(ParsedAttributes &Attrs) {
+ MaybeParseGNUAttributes(Attrs);
----------------
Anastasia wrote:
> pxli168 wrote:
> > I am wondering where should this function goes in, here or ParseDecl.cpp.
> ParseGNUAttributes is in ParseDecl.cpp, but may be because it's generally
> applicable to Decls?
>
> I am not aware of any rule here.
Maybe we could ask richard for help?
http://reviews.llvm.org/D16686
_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
