I reverted the patch and made a pile of other changes to fix up the CMake
caches on bots. They should all recover now.
-Chris
> On Feb 4, 2016, at 8:33 PM, Richard Smith wrote:
>
> This build might be using gold, I don't recall how that machine is
> configured. I won't be able to test the fix
I'm using gold and it seems like it's been fixed for me.
On Thu, Feb 4, 2016 at 10:33 PM, Richard Smith via cfe-commits <
cfe-commits@lists.llvm.org> wrote:
> This build might be using gold, I don't recall how that machine is
> configured. I won't be able to test the fix until tomorrow, hopefully
pxli168 added a comment.
Hi Anastasia/Pekka,
https://www.khronos.org/bugzilla/show_bug.cgi?id=1459
Bug report has been sent.
Thanks
Xiuli
http://reviews.llvm.org/D15914
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/c
rtrieu added a comment.
In http://reviews.llvm.org/D15636#343856, @AndyG wrote:
> In your case, the first string would be highlighted only. Yes, I see what
> you mean. Is it possible to have multiple ranges for the diagnostic? By
> which I mean, to produce the following:
>
> test.cpp:x:y:
doug.gregor accepted this revision.
doug.gregor added a comment.
This revision is now accepted and ready to land.
LGTM!
http://reviews.llvm.org/D16906
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/list
This build might be using gold, I don't recall how that machine is
configured. I won't be able to test the fix until tomorrow, hopefully the
bits will give you enough.
On 4 Feb 2016 7:07 p.m., "Chris Bieneman" wrote:
> Actually r259871 includes the code to cleanup the “bad” order file…
>
> -Chris
Author: dcoughlin
Date: Thu Feb 4 22:22:15 2016
New Revision: 259875
URL: http://llvm.org/viewvc/llvm-project?rev=259875&view=rev
Log:
[analyzer] Suppress localization diagnostics in debug classes and methods.
If the class or method name case-insensitively contains the term "debug",
suppress war
Author: compnerd
Date: Thu Feb 4 22:12:40 2016
New Revision: 259874
URL: http://llvm.org/viewvc/llvm-project?rev=259874&view=rev
Log:
CodeGen: correct Windows ARM C++ assertion
Because the Decl is explicitly passed as nullptr further up the call chain, it
is possible to invoke isa on a nullptr,
Author: cbieneman
Date: Thu Feb 4 21:59:08 2016
New Revision: 259873
URL: http://llvm.org/viewvc/llvm-project?rev=259873&view=rev
Log:
[CMake] One more try to make CMake clean up after itself
Seriously... CMake... You're on my list...
Modified:
cfe/trunk/CMakeLists.txt
cfe/trunk/tools/d
Author: cbieneman
Date: Thu Feb 4 21:40:37 2016
New Revision: 259872
URL: http://llvm.org/viewvc/llvm-project?rev=259872&view=rev
Log:
Revert "[CMake] Improve the clang order-file generation workflow"
This reverts commit r259862, and attempts to fix builder CMakeCaches.
Will try this again some
ABataev accepted this revision.
ABataev added a comment.
This revision is now accepted and ready to land.
LG
http://reviews.llvm.org/D16784
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-co
pxli168 added a comment.
Hi Pekka/Anastasia,
I find that most of the attribute parses was done in ParseDecl.cpp, should this
also be in there?
Thanks
Xiuli
Comment at: lib/Parse/ParseStmt.cpp:2214
@@ +2213,3 @@
+
+bool Parser::ParseOpenCLUnrollHintAttribute(ParsedAttributes &
Actually r259871 includes the code to cleanup the “bad” order file…
-Chris
> On Feb 4, 2016, at 7:02 PM, Chris Bieneman wrote:
>
> I pushed a speculative fix for this in r259870. I’m unable to reproduce
> locally. There are a few bots that hit the same issue, so I’m watching them.
>
> -Chris
Author: cbieneman
Date: Thu Feb 4 21:02:40 2016
New Revision: 259871
URL: http://llvm.org/viewvc/llvm-project?rev=259871&view=rev
Log:
[CMake] One more try to fix this.
This change will catch any bots that generated the order file that GNU ld
doesn't like and delete it before trying to generate
I pushed a speculative fix for this in r259870. I’m unable to reproduce
locally. There are a few bots that hit the same issue, so I’m watching them.
-Chris
> On Feb 4, 2016, at 6:44 PM, Chris Bieneman via cfe-commits
> wrote:
>
> What linker are you using and on what OS? I’m looking at this n
Author: cbieneman
Date: Thu Feb 4 20:51:33 2016
New Revision: 259870
URL: http://llvm.org/viewvc/llvm-project?rev=259870&view=rev
Log:
[CMake] Speculative fix for linker error on Linux
I can't reproduce this locally, but I think this may fix it.
Modified:
cfe/trunk/CMakeLists.txt
Modified:
ahatanak created this revision.
ahatanak added a subscriber: cfe-commits.
The assert near CGCall.cpp:2465 is triggered because
QualType::isObjCRetainableType() is called on different types. In
CodeGenFunction::StartFunction, it returns true because it is called on the
typedef marked with __attr
:)
We can look at them/deal with them in post-commit review from here on out.
No need to block on me.
-eric
On Thu, Feb 4, 2016 at 6:50 PM Romanova, Katya <
katya_roman...@playstation.sony.com> wrote:
> Thank you!
>
> Paul Robinson did a very detailed code review yesterday, so I suspect that
>
Thank you!
Paul Robinson did a very detailed code review yesterday, so I suspect that this
doxygen comment patch is of very good quality. ☺
Katya.
From: Eric Christopher [mailto:echri...@gmail.com]
Sent: Thursday, February 04, 2016 6:47 PM
To: reviews+d16913+public+13cb39057c425...@reviews.llvm.o
(Without looking)
Please go ahead and feel free to commit any documentation to the intrinsic
files. :)
On Thu, Feb 4, 2016, 5:59 PM Katya Romanova <
katya_roman...@playstation.sony.com> wrote:
> kromanova created this revision.
> kromanova added reviewers: ygao, echristo, jroelofs, gribozavr,
>
What linker are you using and on what OS? I’m looking at this now, and will
revert if I can’t find a solution.
-Chris
> On Feb 4, 2016, at 6:38 PM, Richard Smith wrote:
>
> This is causing my links to fail with:
>
> FAILED: : && /usr/local/google/home/richardsmith/bin/clang++
> -fcolor-dia
pxli168 requested a review of this revision.
Comment at: lib/Sema/SemaChecking.cpp:343
@@ -332,3 +342,3 @@
// Two kinds of read/write pipe
// From OpenCL C Specification 6.13.16.2 the built-in read/write
// functions have following forms.
yaxunl wrote:
>
pxli168 updated this revision to Diff 46991.
http://reviews.llvm.org/D16876
Files:
include/clang/Basic/DiagnosticSemaKinds.td
lib/Sema/SemaChecking.cpp
test/SemaOpenCL/invalid-pipe-builtin-cl2.0.cl
Index: test/SemaOpenCL/invalid-pipe-builtin-cl2.0.cl
===
This is causing my links to fail with:
FAILED: : && /usr/local/google/home/richardsmith/bin/clang++
-fcolor-diagnostics -std=c++11 -stdlib=libc++ -fPIC
-fvisibility-inlines-hidden -Wall -W -Wno-unused-parameter -Wwrite-strings
-Wcast-qual -Wmissing-field-initializers -pedantic -Wno-long-long
-Wcov
kromanova created this revision.
kromanova added reviewers: ygao, echristo, jroelofs, gribozavr, craig.topper,
probinson.
kromanova added a subscriber: cfe-commits.
kromanova set the repository for this revision to rL LLVM.
Hello,
Here is the patch with the doxygen comments for the intrinsincs i
I suspect we'll need to do a little more than this: when we rebuild the
redeclaration chain, we should probably propagate the complete type to
later redeclarations in the same scope. Otherwise, if we import a module
that has a complete type and one that has an incomplete type, the
declaration found
Author: rsmith
Date: Thu Feb 4 19:40:54 2016
New Revision: 259866
URL: http://llvm.org/viewvc/llvm-project?rev=259866&view=rev
Log:
[modules] Factor out common code to mark identifier being "from AST", and add a
call in one more place to reduce the size of identifier tables in non-leaf
modules. N
Author: cbieneman
Date: Thu Feb 4 19:27:31 2016
New Revision: 259864
URL: http://llvm.org/viewvc/llvm-project?rev=259864&view=rev
Log:
[CMake] Trying to fix a bot failure I introduced in r259862
CMake caching behavior makes me sad.
Modified:
cfe/trunk/tools/driver/CMakeLists.txt
Modified:
Author: cbieneman
Date: Thu Feb 4 19:22:03 2016
New Revision: 259862
URL: http://llvm.org/viewvc/llvm-project?rev=259862&view=rev
Log:
[CMake] Improve the clang order-file generation workflow
Summary:
With this change generating clang order files using dtrace uses the following
workflow:
cmake
This revision was automatically updated to reflect the committed changes.
Closed by commit rL259862: [CMake] Improve the clang order-file generation
workflow (authored by cbieneman).
Changed prior to commit:
http://reviews.llvm.org/D16896?vs=46966&id=46982#toc
Repository:
rL LLVM
http://rev
Author: benlangmuir
Date: Thu Feb 4 19:10:05 2016
New Revision: 259859
URL: http://llvm.org/viewvc/llvm-project?rev=259859&view=rev
Log:
Don't synthesize an ImportDecl for a module named in -fmodule-implementation-of
When building a PCH with modules enabled this import would assert in the
ASTWri
bruno created this revision.
bruno added reviewers: rsmith, doug.gregor, akyrtzi.
bruno added subscribers: cfe-commits, dexonsmith.
In the context where we break one tok::greatergreater into two tok::greater in
order to correctly update the cached tokens; update the CachedTokens with two
tok::gr
dcoughlin added a comment.
I guess this is a reasonable refactoring. Although someone with different
tastes might come along and inline it back in since the two extracted functions
each only have single callers.
Comment at:
llvm/tools/clang/include/clang/StaticAnalyzer/Core/P
Hello everyone,
Below are some buildbot numbers for the last week of 1/24/2016 - 1/30/2016.
Thanks
Galina
Number of commits by project:
project | commits
---+---
llvm | 283
cfe | 100
ariccio added a comment.
Responded to comments.
Will happily make changes when questions are answered.
Comment at:
llvm/tools/clang/include/clang/StaticAnalyzer/Core/PathSensitive/MemRegion.h:1186
@@ +1185,3 @@
+ /// associated with a specified globally stored, non-static lo
Author: olesalscheider
Date: Thu Feb 4 17:17:20 2016
New Revision: 259842
URL: http://llvm.org/viewvc/llvm-project?rev=259842&view=rev
Log:
Fix the search path for CMake files
This allows to find the LLVM's CMake files after moving them in
r259821.
Modified:
libcxx/trunk/cmake/Modules/Handl
iid_iunknown created this revision.
iid_iunknown added reviewers: asl, rengolin, t.p.northover.
iid_iunknown added a subscriber: cfe-commits.
iid_iunknown set the repository for this revision to rL LLVM.
Herald added subscribers: rengolin, aemerson.
The driver resets the PIC / PIE flags to false i
joelkevinjones added a comment.
Ping.
http://reviews.llvm.org/D16538
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
beanz updated this revision to Diff 46966.
beanz added a comment.
Gate adding the -order_file linker option on whether the linker supports it.
http://reviews.llvm.org/D16896
Files:
CMakeLists.txt
tools/driver/CMakeLists.txt
utils/perf-training/CMakeLists.txt
Index: utils/perf-training/CM
Author: rsmith
Date: Thu Feb 4 16:54:41 2016
New Revision: 259836
URL: http://llvm.org/viewvc/llvm-project?rev=259836&view=rev
Log:
PR25271: When attaching default template arguments to redeclarations of a
template, keep looking for default arguments if we see a template parameter
pack. There may
rsmith closed this revision.
rsmith added a comment.
Committed as r259836.
Repository:
rL LLVM
http://reviews.llvm.org/D16148
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
echristo added inline comments.
Comment at: lib/Frontend/CompilerInvocation.cpp:446-448
@@ -445,3 +445,5 @@
Opts.DebugTypeExtRefs = Args.hasArg(OPT_dwarf_ext_refs);
- Opts.DebugExplicitImport = Triple.isPS4CPU();
+ Opts.DebugExplicitImport =
+ Opts.getDebuggerTuning() !
probinson added inline comments.
Comment at: lib/Frontend/CompilerInvocation.cpp:446-448
@@ -445,3 +445,5 @@
Opts.DebugTypeExtRefs = Args.hasArg(OPT_dwarf_ext_refs);
- Opts.DebugExplicitImport = Triple.isPS4CPU();
+ Opts.DebugExplicitImport =
+ Opts.getDebuggerTuning()
echristo added inline comments.
Comment at: lib/Frontend/CompilerInvocation.cpp:446-448
@@ -445,3 +445,5 @@
Opts.DebugTypeExtRefs = Args.hasArg(OPT_dwarf_ext_refs);
- Opts.DebugExplicitImport = Triple.isPS4CPU();
+ Opts.DebugExplicitImport =
+ Opts.getDebuggerTuning() !
probinson marked an inline comment as done.
Comment at: lib/Frontend/CompilerInvocation.cpp:446-448
@@ -445,3 +445,5 @@
Opts.DebugTypeExtRefs = Args.hasArg(OPT_dwarf_ext_refs);
- Opts.DebugExplicitImport = Triple.isPS4CPU();
+ Opts.DebugExplicitImport =
+ Opts.getDebugg
echristo added inline comments.
Comment at: lib/Frontend/CompilerInvocation.cpp:446-448
@@ -445,3 +445,5 @@
Opts.DebugTypeExtRefs = Args.hasArg(OPT_dwarf_ext_refs);
- Opts.DebugExplicitImport = Triple.isPS4CPU();
+ Opts.DebugExplicitImport =
+ Opts.getDebuggerTuning() !
echristo added a comment.
In http://reviews.llvm.org/D16538#344540, @joelkevinjones wrote:
> Ping.
The FIXME at cc1as_main.cpp:413
http://reviews.llvm.org/D16538
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bi
probinson marked an inline comment as done.
Comment at: lib/Frontend/CompilerInvocation.cpp:446-448
@@ -445,3 +445,5 @@
Opts.DebugTypeExtRefs = Args.hasArg(OPT_dwarf_ext_refs);
- Opts.DebugExplicitImport = Triple.isPS4CPU();
+ Opts.DebugExplicitImport =
+ Opts.getDebugg
yaxunl updated the summary for this revision.
yaxunl updated this revision to Diff 46961.
yaxunl marked 3 inline comments as done.
yaxunl added a comment.
Revised as Xiuli suggested.
Add test for OpenCL below 2.0.
Add diagnostic for opencl_unroll_hint attribute used below OpenCL 2.0.
http://revi
xur updated this revision to Diff 46960.
xur added a comment.
Now http://reviews.llvm.org/D16730 has been committed (as r259811)
Here is the patch that adds cc1 option -fprofile-instrument=llvm to enable IR
level PGO generate and use.
The pgo use part of the patch depends http://reviews.llvm.or
echristo added inline comments.
Comment at: lib/Frontend/CompilerInvocation.cpp:446-448
@@ -445,3 +445,5 @@
Opts.DebugTypeExtRefs = Args.hasArg(OPT_dwarf_ext_refs);
- Opts.DebugExplicitImport = Triple.isPS4CPU();
+ Opts.DebugExplicitImport =
+ Opts.getDebuggerTuning() !
Chris Bieneman writes:
> beanz created this revision.
> beanz added a reviewer: bogner.
> beanz added a subscriber: cfe-commits.
>
> With this change generating clang order files using dtrace uses the
> following workflow:
>
> # Configure LLVM & Clang using any options on a system with dtrace
> cm
rsmith accepted this revision.
rsmith added a comment.
This revision is now accepted and ready to land.
LGTM
http://reviews.llvm.org/D13357
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-co
beanz created this revision.
beanz added a reviewer: bogner.
beanz added a subscriber: cfe-commits.
With this change generating clang order files using dtrace uses the following
workflow:
# Configure LLVM & Clang using any options on a system with dtrace
cmake
# Builds clang and runs the perf-
LegalizeAdulthood added a comment.
I agree it needs more testing.
I think also my current approach to newlines is overly aggressive and will
result in more raw string literals than people would prefer.
It's really the Windows style path separators and regex ones that are not
controversial tran
Prazek added a subscriber: Prazek.
Prazek added a comment.
What is the status of it?
http://reviews.llvm.org/D15506
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
Author: olesalscheider
Date: Thu Feb 4 14:08:27 2016
New Revision: 259822
URL: http://llvm.org/viewvc/llvm-project?rev=259822&view=rev
Log:
Install cmake files to lib/cmake/clang
This is the right location for platform-specific files.
Also, search for LLVM's CMake files in this directory.
Modi
Author: mren
Date: Thu Feb 4 14:05:40 2016
New Revision: 259820
URL: http://llvm.org/viewvc/llvm-project?rev=259820&view=rev
Log:
Fix a crash when there is a typo in the return statement.
If the typo happens after a successful deduction for an earlier
return statement, we should check if the ded
sfantao marked an inline comment as done.
Comment at: lib/Frontend/CompilerInvocation.cpp:1837
@@ +1836,3 @@
+ Diags.Report(clang::diag::err_drv_omp_host_target_not_supported)
+ << TargetOpts.Triple;
+ break;
Ok, I did as you say. thanks!
http
sfantao updated this revision to Diff 46941.
sfantao added a comment.
Change diagnostic for invalid host target.
http://reviews.llvm.org/D16784
Files:
include/clang/Basic/DiagnosticDriverKinds.td
lib/CodeGen/CGOpenMPRuntimeNVPTX.cpp
lib/CodeGen/CGOpenMPRuntimeNVPTX.h
lib/CodeGen/CMakeLi
ABataev added inline comments.
Comment at: lib/Frontend/CompilerInvocation.cpp:1837
@@ +1836,3 @@
+
Diags.Report(clang::diag::err_drv_omp_host_or_device_target_not_supported)
+ << TargetOpts.Triple << /*Device=*/false;
+ break;
No, I mean do we
Author: davidxl
Date: Thu Feb 4 13:54:17 2016
New Revision: 259819
URL: http://llvm.org/viewvc/llvm-project?rev=259819&view=rev
Log:
[PGO] code simplification: use existing VP annotation API /NFC
Modified:
cfe/trunk/lib/CodeGen/CodeGenPGO.cpp
Modified: cfe/trunk/lib/CodeGen/CodeGenPGO.cpp
U
sfantao updated this revision to Diff 46939.
sfantao added a comment.
Add comment.
http://reviews.llvm.org/D16784
Files:
include/clang/Basic/DiagnosticDriverKinds.td
lib/CodeGen/CGOpenMPRuntimeNVPTX.cpp
lib/CodeGen/CGOpenMPRuntimeNVPTX.h
lib/CodeGen/CMakeLists.txt
lib/CodeGen/CodeGenM
sfantao added inline comments.
Comment at: lib/CodeGen/CodeGenModule.cpp:218
@@ -204,1 +217,3 @@
+ }
+ return;
}
ABataev wrote:
> I think this must be removed
Ok, done.
Comment at: lib/Frontend/CompilerInvocation.cpp:1837
@@ +1836,3 @@
+
rsmith accepted this revision.
rsmith added a comment.
This revision is now accepted and ready to land.
LGTM, thanks!
Repository:
rL LLVM
http://reviews.llvm.org/D16148
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org
sfantao updated this revision to Diff 46937.
sfantao marked 2 inline comments as done.
sfantao added a comment.
Remove return statement and use 'false' instead of relying on OpenMPIsDevice.
http://reviews.llvm.org/D16784
Files:
include/clang/Basic/DiagnosticDriverKinds.td
lib/CodeGen/CGOpen
ABataev added inline comments.
Comment at: lib/CodeGen/CodeGenModule.cpp:218
@@ -204,1 +217,3 @@
+ }
+ return;
}
I think this must be removed
Comment at: lib/Frontend/CompilerInvocation.cpp:1837
@@ +1836,3 @@
+
Diags.Report(clang::diag::
sfantao updated this revision to Diff 46935.
sfantao added a comment.
Create CGOpenMPRuntimeNVPTX header file and mike specialization selection in
CodeGenModule.
http://reviews.llvm.org/D16784
Files:
include/clang/Basic/DiagnosticDriverKinds.td
lib/CodeGen/CGOpenMPRuntimeNVPTX.cpp
lib/Co
probinson added a comment.
Ping #4.
http://reviews.llvm.org/D15881
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
sepavloff added a comment.
Any feedback?
Thanks,
--Serge
http://reviews.llvm.org/D15450
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
Any feedback?
Thanks,
--Serge
2016-02-02 3:31 GMT+06:00 Serge Pavlov :
> sepavloff updated this revision to Diff 46575.
> sepavloff added a comment.
>
> Added regression test.
>
>
> http://reviews.llvm.org/D15450
>
> Files:
> lib/CodeGen/CodeGenAction.cpp
> unittests/Frontend/CMakeLists.txt
jlebar accepted this revision.
jlebar added a comment.
This revision is now accepted and ready to land.
Looks sane to me. Just some suggestions on the comments.
Comment at: lib/Sema/SemaCUDA.cpp:71
@@ -70,3 +70,3 @@
// H - handled in (x)
-// Preferences: b-best, f-fallback, l
Anastasia added inline comments.
Comment at: test/SemaOpenCL/implicit-typedef.cl:3
@@ +2,3 @@
+// RUN: %clang_cc1 %s -cl-std=CL2.0 -fsyntax-only
+
+#if defined(TEST_WARNINGS)
ichesnokov wrote:
> Anastasia wrote:
> > ichesnokov wrote:
> > > Are you mean another tex
yaxunl accepted this revision.
yaxunl added a comment.
This revision is now accepted and ready to land.
LGTM
Comment at: lib/Sema/SemaChecking.cpp:343
@@ -332,3 +342,3 @@
// Two kinds of read/write pipe
// From OpenCL C Specification 6.13.16.2 the built-in read/write
//
Author: xur
Date: Thu Feb 4 12:39:09 2016
New Revision: 259811
URL: http://llvm.org/viewvc/llvm-project?rev=259811&view=rev
Log:
[PGO] cc1 option name change for profile instrumentation
This patch changes cc1 option -fprofile-instr-generate to an enum option
-fprofile-instrument={clang|none}. It
rjmccall added a comment.
Thank you, that's a lot better. Just a few suggestions to promote exhaustive
checking.
Comment at: lib/AST/ExprConstant.cpp:6246
@@ +6245,3 @@
+
+default:
+ break;
Again, try to avoid adding default cases. There's an x-macro
tra marked an inline comment as done.
Comment at: lib/Sema/SemaCUDA.cpp:132-141
@@ -131,12 +131,12 @@
// (d) HostDevice behavior depends on compilation mode.
if (CallerTarget == CFT_HostDevice) {
// Calling a function that matches compilation mode is OK.
// Calling
tra updated this revision to Diff 46927.
tra marked an inline comment as done.
tra added a comment.
Addressed Jingyue's comments.
Fixed function-overload.cu tests to reflect stricter call target checks.
http://reviews.llvm.org/D16870
Files:
include/clang/Sema/Sema.h
lib/Sema/SemaCUDA.cpp
hjl.tools added a comment.
Empty struct/union should be passed and returned as void for all IA psABs.
http://reviews.llvm.org/D16808
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
Sure, r259808.
Thanks,
Hans
On Thu, Feb 4, 2016 at 10:13 AM, Ulrich Weigand
wrote:
> Hans,
>
> would it be OK to backport this test case fix to the 3.8 branch?
> This is currently the only failing test on the branch for SystemZ.
>
> Thanks!
>
>>Author: uweigand
>>Date: Fri Jan 29 04:45:23 2016
>
Hans,
would it be OK to backport this test case fix to the 3.8 branch?
This is currently the only failing test on the branch for SystemZ.
Thanks!
>Author: uweigand
>Date: Fri Jan 29 04:45:23 2016
>New Revision: 259183
>
>URL: http://llvm.org/viewvc/llvm-project?rev=259183&view=rev
>Log:
>Add t
DavidKreitzer added a comment.
From an MCU ABI perspective, yes, returning an empty struct is equivalent to
returning void.
http://reviews.llvm.org/D16808
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman
d.zobnin.bugzilla added a comment.
Thank you for the review!
David, I started from the assertion failure and was going up the call stack
trying to understand what should be changed to make the assertion go away. In
shouldReturnTypeInRegister() function there is isRegisterSize(Size) check for
i
a.sidorin added a subscriber: a.sidorin.
a.sidorin added a comment.
Thanks ariccio! Some inline comments are below.
Comment at:
llvm/tools/clang/include/clang/StaticAnalyzer/Core/PathSensitive/MemRegion.h:1186
@@ +1185,3 @@
+ /// associated with a specified globally stored, n
hokein marked 2 inline comments as done.
hokein added a comment.
http://reviews.llvm.org/D16113
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
hokein updated this revision to Diff 46923.
hokein added a comment.
Update.
http://reviews.llvm.org/D16113
Files:
clang-tidy/ClangTidy.cpp
clang-tidy/ClangTidy.h
clang-tidy/google/GlobalNamesInHeadersCheck.cpp
clang-tidy/google/GlobalNamesInHeadersCheck.h
clang-tidy/google/UnnamedName
ichesnokov added inline comments.
Comment at: test/SemaOpenCL/implicit-typedef.cl:3
@@ +2,3 @@
+// RUN: %clang_cc1 %s -cl-std=CL2.0 -fsyntax-only
+
+#if defined(TEST_WARNINGS)
Anastasia wrote:
> ichesnokov wrote:
> > Are you mean another text of warning? Notice th
alexfh added inline comments.
Comment at: clang-tidy/utils/HeaderFileExtensionsUtils.cpp:46
@@ +45,3 @@
+bool parseHeaderFileExtensions(llvm::StringRef AllHeaderFileExtensions,
+ HeaderFileExtensionsSet &HeaderFileExtensions,
+
Anastasia added inline comments.
Comment at: test/SemaOpenCL/implicit-typedef.cl:3
@@ +2,3 @@
+// RUN: %clang_cc1 %s -cl-std=CL2.0 -fsyntax-only
+
+#if defined(TEST_WARNINGS)
ichesnokov wrote:
> Are you mean another text of warning? Notice that actual patch will w
hokein added inline comments.
Comment at: clang-tidy/utils/HeaderFileExtensionsUtils.cpp:46
@@ +45,3 @@
+bool parseHeaderFileExtensions(llvm::StringRef AllHeaderFileExtensions,
+ HeaderFileExtensionsSet &HeaderFileExtensions,
+
flx added a comment.
Hi Alex,
could you take a look at the questions I posted in my last comment. Maybe there
is some renaming work I can tackle while you review the change in more detail.
http://reviews.llvm.org/D16517
___
cfe-commits mailing lis
alexfh added a comment.
Please include full context to the diffs. See
http://llvm.org/docs/Phabricator.html for instructions.
Repository:
rL LLVM
http://reviews.llvm.org/D16700
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists
alexfh added inline comments.
Comment at: clang-tidy/misc/DefinitionsInHeadersCheck.cpp:40
@@ +39,3 @@
+',')) {
+// FIXME(hokein): Find a more suitable way to handle invalid configuration
+// options.
It's common to
alexfh accepted this revision.
alexfh added a comment.
This revision is now accepted and ready to land.
Looks good with a couple of comments. Thanks for working on this!
Comment at: clang-tidy/utils/HeaderFileExtensionsUtils.cpp:45
@@ +44,3 @@
+
+bool parseHeaderFileExtensions(l
andreybokhanko updated this revision to Diff 46908.
andreybokhanko added a comment.
John, thank you for the review!
I refactored EvaluateBuiltinClassifyType according to your comments; please
re-review.
Yours,
Andrey
http://reviews.llvm.org/D16846
Files:
lib/AST/ExprConstant.cpp
test/Sem
yaxunl added a comment.
Thanks Xiuli.
It seems the review was not closed automatically due to missing Differential
Revision: at the end of commit message. Next time I will add the url to
the review summary.
http://reviews.llvm.org/D16692
___
cfe
Author: hokein
Date: Thu Feb 4 08:06:49 2016
New Revision: 259787
URL: http://llvm.org/viewvc/llvm-project?rev=259787&view=rev
Log:
[clang-tidy] More friendly warning in "google-runtime-references" when meeting
an unnamed function parameter.
Reviewers: alexfh
Subscribers: cfe-commits
Differen
This revision was automatically updated to reflect the committed changes.
Closed by commit rL259787: [clang-tidy] More friendly warning in
"google-runtime-references" when… (authored by hokein).
Changed prior to commit:
http://reviews.llvm.org/D16882?vs=46902&id=46906#toc
Repository:
rL LLVM
alexfh accepted this revision.
alexfh added a comment.
This revision is now accepted and ready to land.
Looks good. Thank you!
Repository:
rL LLVM
http://reviews.llvm.org/D16882
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists
aaron.ballman added inline comments.
Comment at: clang-tidy/readability/ImplicitBoolCastCheck.h:32
@@ -30,1 +31,3 @@
+Options.get("NullPointerLiteral",
+Context->getLangOpts().CPlusPlus11 ? "nullptr" : "0")) {}
void registerMatchers(ast_matchers::MatchFi
1 - 100 of 114 matches
Mail list logo
