hokein added inline comments.

================
Comment at: clang-tidy/utils/HeaderFileExtensionsUtils.cpp:46
@@ +45,3 @@
+bool parseHeaderFileExtensions(llvm::StringRef AllHeaderFileExtensions,
+                               HeaderFileExtensionsSet &HeaderFileExtensions,
+                               char delimiter) {
----------------
alexfh wrote:
> Actually, this could be changed to a more generic `parseStringSetOption` or 
> something similar. Let's do this in a follow up.
> 
> But for now we need to change the output parameter type to 
> llvm::SmallSetImpl<StringRef> to avoid hardcoding the small size template 
> argument. The typedef is then not useful anymore.
> But for now we need to change the output parameter type to 
> llvm::SmallSetImpl<StringRef> to avoid hardcoding the small size template 
> argument. The typedef is then not useful anymore.

I can't find `llvm::SmallSetImpl` or any similar `Set` without size template 
argument.


http://reviews.llvm.org/D16113



_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Reply via email to