rsmith added inline comments.
Comment at: lib/AST/StmtPrinter.cpp:132
@@ -131,2 +131,3 @@
SubPolicy.SuppressSpecifiers = false;
+ SubPolicy.SuppressTag = false;
Decl::printGroup(Decls.data(), Decls.size(), OS, SubPolicy, IndentLevel);
Maybe we should instea
EricWF added a comment.
> - Did I successfully match the coding style? (I'm kind of lost without
> clang-format TBH.)
The style looks pretty good. I'll comment on any nits I have.
> - Should I separate the change to __construct_node_hash() into a separate
> prep commit? (I would if this were
EricWF added a reviewer: mclow.lists.
EricWF added a subscriber: mclow.lists.
EricWF added a comment.
Adding @mclow.lists as a reviewer.
http://reviews.llvm.org/D16360
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi
EricWF added a comment.
Overall the patch looks good but I have a few concerns.
> - If argument.first can be trivially converted to key_type, don't alloc.
I'm concerned with this part of the change because:
- The `is_trivially_*` traits are often not available and can sometimes blow up.
- It a
Author: dcoughlin
Date: Fri Jan 22 01:08:06 2016
New Revision: 258493
URL: http://llvm.org/viewvc/llvm-project?rev=258493&view=rev
Log:
[analyzer] Update SATestBuild.py to handle spaces in paths.
The Jenkins workspace on the new Green Dragon builder for the static analyzer
has spaces
in its path
Author: kromanova
Date: Fri Jan 22 00:50:50 2016
New Revision: 258492
URL: http://llvm.org/viewvc/llvm-project?rev=258492&view=rev
Log:
2 missing intrinsics _cvtss_sh and _mm_cvtps_ph were added to the intrinsics
header f16intrin.h
Differential Revision: http://reviews.llvm.org/D16177
Modified:
This revision was automatically updated to reflect the committed changes.
Closed by commit rL258492: 2 missing intrinsics _cvtss_sh and _mm_cvtps_ph were
added to the intrinsics… (authored by kromanova).
Changed prior to commit:
http://reviews.llvm.org/D16177?vs=45635&id=45650#toc
Repository:
Author: ericwf
Date: Fri Jan 22 00:25:47 2016
New Revision: 258491
URL: http://llvm.org/viewvc/llvm-project?rev=258491&view=rev
Log:
Add __uncvref type for use in later patches
Modified:
libcxx/trunk/include/type_traits
Modified: libcxx/trunk/include/type_traits
URL:
http://llvm.org/viewvc/
On Thu, Jan 21, 2016 at 10:35 PM, Duncan P. N. Exon Smith <
dexonsm...@apple.com> wrote:
>
> > On 2016-Jan-21, at 17:59, Eric Fiselier wrote:
> >
> > EricWF added a comment.
> >
> > In http://reviews.llvm.org/D12354#331776, @dexonsmith wrote:
> >
> >> This patch looks correct to me. Is there any
craig.topper accepted this revision.
craig.topper added a comment.
This revision is now accepted and ready to land.
I agree that the vector initialization code will be prone to changing. I think
what you have is fine.
LGTM
Repository:
rL LLVM
http://reviews.llvm.org/D16177
__
> On 2016-Jan-21, at 17:59, Eric Fiselier wrote:
>
> EricWF added a comment.
>
> In http://reviews.llvm.org/D12354#331776, @dexonsmith wrote:
>
>> This patch looks correct to me. Is there any reason it wasn't committed?
>
>
> I was concerned about using a function-local static in the librar
EricWF accepted this revision.
EricWF added a comment.
This revision is now accepted and ready to land.
LGTM after addressing the `IncompleteClass` comment.
Thanks for the patch!
Comment at: test/std/utilities/meta/meta.rel/is_convertible.pass.cpp:217
@@ -209,1 +216,3 @@
+/
ABataev accepted this revision.
ABataev added a comment.
This revision is now accepted and ready to land.
LG
http://reviews.llvm.org/D16385
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-co
arsenm created this revision.
arsenm added a reviewer: tstellarAMD.
arsenm added a subscriber: cfe-commits.
Keep the one still used by libclc that works
around for now.
Emit the new amdgcn intrinsic name if not targeting r600,
in which case the old AMDGPU name is still used.
http://reviews.llvm.
kromanova added a comment.
In http://reviews.llvm.org/D15999#333173, @silvas wrote:
> For the preview of all the changes, can you please put that in a separate
> patch from this one?
Done.
See http://reviews.llvm.org/D16442
Repository:
rL LLVM
http://reviews.llvm.org/D15999
_
silvas added a comment.
For the preview of all the changes, can you please put that in a separate patch
from this one?
Repository:
rL LLVM
http://reviews.llvm.org/D15999
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.o
dcoughlin abandoned this revision.
dcoughlin added a comment.
Abandoning because the test-case removal was incorporated into
http://reviews.llvm.org/D5023.
http://reviews.llvm.org/D5031
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http:/
silvas added a comment.
@bogner btw, did you say that at Apple you guys have a requirement of
supporting existing profdata? I.e. users can pass older profdata to a newer
compiler?
Realistically, it would be nice if our PGO offering defaulted to the IR stuff
(since it seems like it is going to
silvas added a comment.
@slingn and I had a discussion offline about the potential names and came up
with some ideas, but none is a clear winner.
Overall, my feeling is that from a user's perspective, the frontend stuff is
probably best referred to as "coverage-based". It's not as clear for the
Later today I will post another fix, that will fix all 'sections'
related troubles, including this one. So I don't think it is necessary
to merge it
Best regards,
Alexey Bataev
=
Software Engineer
Intel Compiler Team
22.01.2016 0:10, Hans Wennborg пишет:
> Jack suggested (https://ll
Ok, will do
Best regards,
Alexey Bataev
=
Software Engineer
Intel Compiler Team
22.01.2016 0:10, Hans Wennborg пишет:
> Jack suggested (https://llvm.org/bugs/show_bug.cgi?id=26059#c7) that
> this should be merged to 3.8.
>
> Alexey, you're the code owner here. OK for merging? If yes,
kromanova added a comment.
Craig, do you think it's necessary to make the tests more fancy by checking how
the vector is initialized before the builtin invocation and/or that one element
is extracted from the vector after the builtin returned a value? It will add
additional 10-15 check lines to
silvas added inline comments.
Comment at: include/clang/Frontend/CodeGenOptions.def:108
@@ -107,2 +107,3 @@
///< execution counts to use with PGO.
+CODEGENOPT(ProfileIRInstr, 1, 0) ///< IR level code PGO instrumentation and
use.
CODEGENOP
silvas added a comment.
This needs tests showing that the IR gen/use passes get run. Maybe use
-debug-pass=Structure like test/CodeGen/thinlto_backend.c?
My biggest concern is the naming and user visible parts. I can't come up with
anything better than `-fprofile-ir-instr` TBH. Overall, from a
kromanova updated this revision to Diff 45635.
kromanova marked an inline comment as done.
kromanova added a comment.
I further simplified the macros by removing the statement for the define that I
added (_cvtss_sh) and for the one that was there before (_mm_cvtps_ph).
I also formatted __DEFAULT
nick.sumner created this revision.
nick.sumner added reviewers: bkramer, rsmith.
nick.sumner added a subscriber: cfe-commits.
Allow nested variable declarations using suppressed tags.
This is the logical conclusion of a handful of patches needed to correctly
print types in nested declarations and
kromanova marked an inline comment as done.
Comment at: lib/Headers/f16cintrin.h:47
@@ -34,1 +46,3 @@
+
+
#define _mm_cvtps_ph(a, imm) __extension__ ({ \
craig.topper wrote:
> Can we do something like this to remove the last temporary?
>
> #define _cvtss_sh(a, i
EricWF added a comment.
In http://reviews.llvm.org/D12354#331776, @dexonsmith wrote:
> This patch looks correct to me. Is there any reason it wasn't committed?
I was concerned about using a function-local static in the library headers, I
don't think libc++ does that anywhere else and I wanted
kromanova updated this revision to Diff 45632.
kromanova marked an inline comment as done.
kromanova added a comment.
Updated patch to address Craig's comments.
Repository:
rL LLVM
http://reviews.llvm.org/D16177
Files:
lib/Headers/f16cintrin.h
test/CodeGen/f16c-builtins.c
Index: test/Co
nick.sumner created this revision.
nick.sumner added reviewers: bkramer, rsmith.
nick.sumner added a subscriber: cfe-commits.
Allow C style casts of enums to be printed correctly when the incoming
PrintingPolicy suppresses tags. This can happen, when casts to enums occur
during the initializatio
Author: samsonov
Date: Thu Jan 21 19:35:45 2016
New Revision: 258476
URL: http://llvm.org/viewvc/llvm-project?rev=258476&view=rev
Log:
[Docs] Slightly update LSan documentation.
Modified:
cfe/trunk/docs/AddressSanitizer.rst
cfe/trunk/docs/LeakSanitizer.rst
Modified: cfe/trunk/docs/Addres
george.burgess.iv updated this revision to Diff 45622.
george.burgess.iv added a comment.
- Rebased
- Removed bits that were already upstreamed as part of
http://reviews.llvm.org/D14877
- Added support for LLVM's `allocsize` attribute (under review at
http://reviews.llvm.org/D14933 )
http://re
Hi Hans,
CC Marshall
FYI All my pending libc++ and libc++abi commits have been pushed to the
release_38 branch.
/Eric
On Thu, Jan 21, 2016 at 1:51 PM, Eric Fiselier wrote:
> I'll merge all my commits tonight. Thanks Hans.
>
> /Eric
>
> On Wed, Jan 20, 2016 at 10:38 AM, Hans Wennborg wrote:
>
Author: ericwf
Date: Thu Jan 21 19:13:27 2016
New Revision: 258470
URL: http://llvm.org/viewvc/llvm-project?rev=258470&view=rev
Log:
Merging r258277:
r258277 | ericwf | 2016-01-19 20:04:50 -0700 (Tue, 19 Jan 2016) | 1 line
F
Author: ericwf
Date: Thu Jan 21 19:12:23 2016
New Revision: 258469
URL: http://llvm.org/viewvc/llvm-project?rev=258469&view=rev
Log:
Merging r258249:
r258249 | ericwf | 2016-01-19 16:42:10 -0700 (Tue, 19 Jan 2016) | 7 lines
Author: ericwf
Date: Thu Jan 21 19:11:34 2016
New Revision: 258468
URL: http://llvm.org/viewvc/llvm-project?rev=258468&view=rev
Log:
Merging r258201:
r258201 | ericwf | 2016-01-19 15:07:10 -0700 (Tue, 19 Jan 2016) | 1 line
A
Author: ericwf
Date: Thu Jan 21 19:10:25 2016
New Revision: 258467
URL: http://llvm.org/viewvc/llvm-project?rev=258467&view=rev
Log:
Merging r258198:
r258198 | ericwf | 2016-01-19 14:58:49 -0700 (Tue, 19 Jan 2016) | 1 line
A
This revision was automatically updated to reflect the committed changes.
Closed by commit rL258466: [OpenMP] Sema for depend clause on target enter data
directive. (authored by arpith).
Changed prior to commit:
http://reviews.llvm.org/D16400?vs=45525&id=45621#toc
Repository:
rL LLVM
http:/
Author: ericwf
Date: Thu Jan 21 19:09:23 2016
New Revision: 258464
URL: http://llvm.org/viewvc/llvm-project?rev=258464&view=rev
Log:
Merging r258196:
r258196 | ericwf | 2016-01-19 14:52:04 -0700 (Tue, 19 Jan 2016) | 1 line
A
Author: arpith
Date: Thu Jan 21 19:09:37 2016
New Revision: 258466
URL: http://llvm.org/viewvc/llvm-project?rev=258466&view=rev
Log:
[OpenMP] Sema for depend clause on target enter data directive.
Summary:
Accept depend clause on target enter data directive in sema and add test cases.
Reviewers:
Author: ericwf
Date: Thu Jan 21 19:08:10 2016
New Revision: 258463
URL: http://llvm.org/viewvc/llvm-project?rev=258463&view=rev
Log:
Merging r258217:
r258217 | ericwf | 2016-01-19 16:06:29 -0700 (Tue, 19 Jan 2016) | 1 line
F
Author: dcoughlin
Date: Thu Jan 21 19:01:11 2016
New Revision: 258461
URL: http://llvm.org/viewvc/llvm-project?rev=258461&view=rev
Log:
[analyzer] Suppress nullability warning for defensive super initializer idiom.
A common idiom in Objective-C initializers is for a defensive nil-check on the
res
Author: arpith
Date: Thu Jan 21 18:49:21 2016
New Revision: 258460
URL: http://llvm.org/viewvc/llvm-project?rev=258460&view=rev
Log:
[OpenMP] Sema for depend clause on target directive.
Summary:
Accept depend clause on target directive in sema and add test cases.
Reviewers: ABataev
Differential
This revision was automatically updated to reflect the committed changes.
Closed by commit rL258460: [OpenMP] Sema for depend clause on target directive.
(authored by arpith).
Changed prior to commit:
http://reviews.llvm.org/D16375?vs=45447&id=45616#toc
Repository:
rL LLVM
http://reviews.ll
Author: arpith
Date: Thu Jan 21 18:22:05 2016
New Revision: 258459
URL: http://llvm.org/viewvc/llvm-project?rev=258459&view=rev
Log:
[OpenMP] Parsing + Sema for nowait clause on target exit data directive.
Summary:
Accept nowait clause on target exit data directive in sema and add test cases.
Re
This revision was automatically updated to reflect the committed changes.
Closed by commit rL258459: [OpenMP] Parsing + Sema for nowait clause on target
exit data directive. (authored by arpith).
Changed prior to commit:
http://reviews.llvm.org/D16362?vs=45410&id=45614#toc
Repository:
rL LLV
Author: arpith
Date: Thu Jan 21 18:03:50 2016
New Revision: 258457
URL: http://llvm.org/viewvc/llvm-project?rev=258457&view=rev
Log:
[OpenMP] Parsing + Sema for nowait clause on target enter data directive.
Summary:
Accept nowait clause on target enter data directive in sema and add test cases.
This revision was automatically updated to reflect the committed changes.
Closed by commit rL258457: [OpenMP] Parsing + Sema for nowait clause on target
enter data directive. (authored by arpith).
Changed prior to commit:
http://reviews.llvm.org/D16361?vs=45409&id=45610#toc
Repository:
rL LL
nick.sumner created this revision.
nick.sumner added reviewers: bkramer, rsmith.
nick.sumner added a subscriber: cfe-commits.
Allow StmtPrinter to print signed character literals. Given the code:
char c = '\200';
The character literal is presently printed as:
char c = '\Uff80';
The o
Author: majnemer
Date: Thu Jan 21 17:01:11 2016
New Revision: 258447
URL: http://llvm.org/viewvc/llvm-project?rev=258447&view=rev
Log:
[MSVC Compat] Don't omit frame pointers if /Oy- is specified before /O2
Microsoft's documentation states that specifying
/Oy- after the /O[12x] options disables f
nick.sumner created this revision.
nick.sumner added reviewers: bkramer, rsmith.
nick.sumner added a subscriber: cfe-commits.
Allow nested variable declarations to have their types printed correctly even
when the incoming PrintingPolicy suppresses specifiers. This can happen when
initializing a va
dsanders added a comment.
Thanks.
> May want to wait on mclow though considering the trouble I helped cause with
> the last one of these.
Sure. That wasn't your fault though, it was mine. I should have asked for
clarification first.
http://reviews.llvm.org/D16408
manmanren added a subscriber: manmanren.
manmanren added a comment.
Thanks for working on this. This looks good to me overall, but I am not the
expert on Sema :]
Cheers,
Manman
Comment at: lib/Sema/SemaChecking.cpp:6985
@@ -6984,6 +6984,3 @@
SmallString<16> PrettyTargetValu
bcraig added a comment.
LGTM. May want to wait on mclow though considering the trouble I helped cause
with the last one of these.
http://reviews.llvm.org/D16408
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/
hubert.reinterpretcast accepted this revision.
hubert.reinterpretcast added a comment.
This revision is now accepted and ready to land.
LGTM.
http://reviews.llvm.org/D16163
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.or
This revision was automatically updated to reflect the committed changes.
Closed by commit rL258441: [OpenMP] Parsing + Sema for nowait clause on target
directive (authored by arpith).
Changed prior to commit:
http://reviews.llvm.org/D16358?vs=45399&id=45595#toc
Repository:
rL LLVM
http://r
Author: arpith
Date: Thu Jan 21 16:18:28 2016
New Revision: 258441
URL: http://llvm.org/viewvc/llvm-project?rev=258441&view=rev
Log:
[OpenMP] Parsing + Sema for nowait clause on target directive
Summary:
Allow nowait clause on target directive in sema and add test cases.
Reviewers: ABataev
Diff
EricWF added a comment.
ping.
http://reviews.llvm.org/D13420
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
LegalizeAdulthood added inline comments.
Comment at: clang-tidy/misc/LongCastCheck.cpp:97
@@ +96,3 @@
+
+ if (!CastType->isIntegerType() || !SubType->isIntegerType())
+return;
danielmarjamaki wrote:
> LegalizeAdulthood wrote:
> > Why don't you check for casti
Jack suggested (https://llvm.org/bugs/show_bug.cgi?id=26059#c7) that
this should be merged to 3.8.
Alexey, you're the code owner here. OK for merging? If yes, do you
want to go ahead and merge with utils/release/merge.sh?
On Wed, Jan 20, 2016 at 4:29 AM, Alexey Bataev via cfe-commits
wrote:
> Au
Richard, it was suggested (in
https://llvm.org/bugs/show_bug.cgi?id=26059#c7) that this gets merged
to 3.8. I believe this falls under your ownership.
On Thu, Jan 21, 2016 at 4:54 AM, Alexey Bataev via cfe-commits
wrote:
> Author: abataev
> Date: Thu Jan 21 06:54:48 2016
> New Revision: 258396
>
Jack suggested (https://llvm.org/bugs/show_bug.cgi?id=26059#c7) that
this should be merged to 3.8.
Alexey, you're the code owner here. OK for merging? If yes, do you
want to go ahead and merge with utils/release/merge.sh?
On Thu, Jan 21, 2016 at 4:35 AM, Alexey Bataev via cfe-commits
wrote:
> Au
LegalizeAdulthood added a comment.
In http://reviews.llvm.org/D16310#332200, @danielmarjamaki wrote:
> Why is there a cast in the first place? It is unlikely that the programmer
> added a useless cast for no reason.
If this has universally been your experience on a code base, then I say you
s
On Thu, Jan 21, 2016 at 12:00 PM, Aaron Ballman wrote:
> On Thu, Jan 21, 2016 at 1:01 PM, Hans Wennborg wrote:
>> Thanks.
>>
>> Aaron, do you want to go ahead and merge this with
>> utils/release/merge.sh? Or let me know if you'd prefer me to do the
>> merge.
>
> I'd prefer if you'd handle the me
alexfh accepted this revision.
alexfh added a comment.
This revision is now accepted and ready to land.
LG. Thanks!
http://reviews.llvm.org/D16179
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo
xur added a comment.
Ping.
Passmanagerbuilder change has been committed. Could you take a look at this
command line option patch?
Thanks,
-Rong
http://reviews.llvm.org/D15829
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.l
I'll merge all my commits tonight. Thanks Hans.
/Eric
On Wed, Jan 20, 2016 at 10:38 AM, Hans Wennborg wrote:
> No problem. Please go ahead and merge with utils/release/merge.sh, or
> let me know if you'd prefer me to do it.
>
> On Tue, Jan 19, 2016 at 7:09 PM, Eric Fiselier wrote:
> > Hi Hans,
xazax.hun added inline comments.
Comment at: docs/clang-tidy/checks/performance-inefficient-algorithm.rst:3
@@ -2,3 +2,3 @@
-misc-inefficient-algorithm
+performance-inefficient-algorithm
==
Eugene.Zelenko wrote:
> alexfh wrote:
> > After
Author: dcoughlin
Date: Thu Jan 21 14:09:49 2016
New Revision: 258426
URL: http://llvm.org/viewvc/llvm-project?rev=258426&view=rev
Log:
[driver] Enable some static analyzer "unix" checkers on Windows.
Many of the "unix" checkers are not actually unix-specific and would be valuable
to run on Windo
arpith-jacob added a comment.
Committed revision 258425.
Repository:
rL LLVM
http://reviews.llvm.org/D16341
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
This revision was automatically updated to reflect the committed changes.
Closed by commit rL258425 (authored by arpith).
Changed prior to commit:
http://reviews.llvm.org/D16341?vs=45332&id=45579#toc
Repository:
rL LLVM
http://reviews.llvm.org/D16341
Files:
cfe/trunk/lib/Sema/SemaOpenMP.c
Author: arpith
Date: Thu Jan 21 13:57:55 2016
New Revision: 258425
URL: http://llvm.org/viewvc/llvm-project?rev=258425&view=rev
Log:
[OpenMP] Check for at least one map clause on target data directive.
Summary:
Adds the following restriction in the OpenMP specifications.
OpenMP [2.10.1, Restric
zaks.anna added a comment.
> I don't know, is there a way to install runtime components for ASan if your
> distribution doesn't happen to have one (that must be tricky, as the version
> of ASan should match the version of the compiler).
Correct, there is no recommended way of installing the
On Thu, Jan 21, 2016 at 1:01 PM, Hans Wennborg wrote:
> Thanks.
>
> Aaron, do you want to go ahead and merge this with
> utils/release/merge.sh? Or let me know if you'd prefer me to do the
> merge.
I'd prefer if you'd handle the merge (I'm on Windows), if you don't mind.
Thanks!
~Aaron
>
> On
Author: vedantk
Date: Thu Jan 21 13:25:35 2016
New Revision: 258424
URL: http://llvm.org/viewvc/llvm-project?rev=258424&view=rev
Log:
[Coverage] Reduce complexity of adding function mapping records
Replace a string append operation in addFunctionMappingRecord with a
vector append. The existing be
This revision was automatically updated to reflect the committed changes.
Closed by commit rL258424: [Coverage] Reduce complexity of adding function
mapping records (authored by vedantk).
Changed prior to commit:
http://reviews.llvm.org/D16395?vs=45491&id=45574#toc
Repository:
rL LLVM
http:
davidxl accepted this revision.
davidxl added a comment.
This revision is now accepted and ready to land.
LGTM
http://reviews.llvm.org/D16395
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-
jbcoe updated this revision to Diff 45573.
jbcoe added a comment.
Added symmetric check for user-defined assignment but no copy constructor.
Check now adds '=default' to the missing special function if the user-specified
one was specified as '=default'.
Check needs renaming, I'll update it alon
On Thu, Jan 21, 2016 at 10:58 AM, Reid Kleckner wrote:
> On Thu, Jan 21, 2016 at 10:47 AM, Nico Weber wrote:
>
>> Oh, ok, let's not depend on lld then. So, we need to either determine if
>>> DIA SDK is available at compiler-rt configure time, or teach
>>> llvm-symbolizer.exe to tell us that (as
samsonov added a comment.
In http://reviews.llvm.org/D15225#328218, @zaks.anna wrote:
> > I see, so essentially you want to use a different approach for determining
> > sanitizer availability (on OS X for now): if the library is present, then
> > we support
>
> > sanitizer, otherwise we don't
On Thu, Jan 21, 2016 at 10:47 AM, Nico Weber wrote:
> Oh, ok, let's not depend on lld then. So, we need to either determine if
>> DIA SDK is available at compiler-rt configure time, or teach
>> llvm-symbolizer.exe to tell us that (as we support standalone compiler-rt
>> build)...
>>
>
> Maybe the
On Thu, Jan 21, 2016 at 1:44 PM, Alexey Samsonov wrote:
>
> On Thu, Jan 21, 2016 at 10:20 AM, Nico Weber wrote:
>
>> On Thu, Jan 21, 2016 at 1:19 PM, Alexey Samsonov
>> wrote:
>>
>>>
>>> On Wed, Jan 20, 2016 at 12:42 PM, Nico Weber
>>> wrote:
>>>
thakis added a comment.
After so
On Thu, Jan 21, 2016 at 10:20 AM, Nico Weber wrote:
> On Thu, Jan 21, 2016 at 1:19 PM, Alexey Samsonov
> wrote:
>
>>
>> On Wed, Jan 20, 2016 at 12:42 PM, Nico Weber wrote:
>>
>>> thakis added a comment.
>>>
>>> After some more debugging, the only thing in this test that's still
>>> faiilng on W
Author: marshall
Date: Thu Jan 21 12:22:43 2016
New Revision: 258418
URL: http://llvm.org/viewvc/llvm-project?rev=258418&view=rev
Log:
Implement LWG#2101 'Some transformation types can produce impossible types'
Introduced a new (internal) type trait '__is_referenceable' with tests. Use
that tra
samsonov added a comment.
Thanks.
Comment at: lib/Driver/ToolChains.cpp:322
@@ -321,1 +321,3 @@
+StringRef Darwin::getOSLibraryNameSuffix() const {
+ if (isTargetMacOS())
Fun fact: if TargetPlatform is `TvOSSimulator`, this function will return
`iossim` beca
sfantao updated this revision to Diff 45557.
sfantao retitled this revision from " [OpenMP] Update map clause SEMA to
support OpenMP 4.5 possible list items." to "[OpenMP] Update map clause SEMA to
support OpenMP 4.5 possible list items.".
sfantao updated the summary for this revision.
sfantao ad
On Thu, Jan 21, 2016 at 1:19 PM, Alexey Samsonov wrote:
>
> On Wed, Jan 20, 2016 at 12:42 PM, Nico Weber wrote:
>
>> thakis added a comment.
>>
>> After some more debugging, the only thing in this test that's still
>> faiilng on Windows is the "unsigned-integer-overflow:do_overflow"
>> suppressi
On Wed, Jan 20, 2016 at 12:42 PM, Nico Weber wrote:
> thakis added a comment.
>
> After some more debugging, the only thing in this test that's still
> faiilng on Windows is the "unsigned-integer-overflow:do_overflow"
> suppression -- when llvm-symbolizer gets symbols from PDBs it currently
> req
jbcoe marked 2 inline comments as done.
jbcoe added a comment.
http://reviews.llvm.org/D16376
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
jbcoe marked 5 inline comments as done.
Comment at: clang-tidy/misc/UserDefinedCopyWithoutAssignmentCheck.h:25
@@ +24,3 @@
+/// assignment operator to be `= delete`.
+///
+/// For the user-facing documentation see:
The standard says that compiler generation of the
betulb marked 3 inline comments as done.
Comment at: lib/CodeGen/CodeGenPGO.cpp:768
@@ +767,3 @@
+};
+Builder.CreateCall(
+CGM.getIntrinsic(llvm::Intrinsic::instrprof_value_profile), Args);
I removed the if check instead. It was not needed since th
jbcoe removed rL LLVM as the repository for this revision.
jbcoe updated this revision to Diff 45554.
jbcoe added a comment.
Made requested changes.
http://reviews.llvm.org/D16376
Files:
clang-tidy/misc/CMakeLists.txt
clang-tidy/misc/MiscTidyModule.cpp
clang-tidy/misc/UserDefinedCopyWitho
Thanks.
Aaron, do you want to go ahead and merge this with
utils/release/merge.sh? Or let me know if you'd prefer me to do the
merge.
On Thu, Jan 21, 2016 at 10:00 AM, Alexander Kornienko wrote:
> I'm fine with including this to 3.8. BTW, I'm working on release notes.
>
> On Thu, Jan 21, 2016 at
I'm fine with including this to 3.8. BTW, I'm working on release notes.
On Thu, Jan 21, 2016 at 6:01 PM, Hans Wennborg wrote:
> I'm fine with it. Alex, what do you think?
>
> On Wed, Jan 20, 2016 at 3:07 PM, Aaron Ballman
> wrote:
> > Uncertain whether this meets the bar for inclusion in 3.8.
>
thakis closed this revision.
thakis added a comment.
r258415, thanks!
http://reviews.llvm.org/D16394
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
Author: nico
Date: Thu Jan 21 11:56:24 2016
New Revision: 258415
URL: http://llvm.org/viewvc/llvm-project?rev=258415&view=rev
Log:
Add an isVirtualAsWritten AST matcher.
http://reviews.llvm.org/D16394
Modified:
cfe/trunk/docs/LibASTMatchersReference.html
cfe/trunk/include/clang/ASTMatche
betulb updated this revision to Diff 45550.
betulb added a comment.
In this revision:
- Clang no longer attaches function names as metadata.
- Bug fixed in checking the getNumValueSites return value.
- Addressed review comments.
http://reviews.llvm.org/D8940
Files:
lib/CodeGen/CGCall.cpp
l
thakis updated this revision to Diff 45551.
thakis added a comment.
fix test name
http://reviews.llvm.org/D16413
Files:
include/clang/AST/RecursiveASTVisitor.h
unittests/ASTMatchers/ASTMatchersTest.cpp
Index: include/clang/AST/RecursiveASTVisitor.h
=
thakis created this revision.
thakis added reviewers: rsmith, klimek.
thakis added a subscriber: cfe-commits.
Herald added a subscriber: klimek.
An implicit copy ctor creates loop VarDecls that hang off CXXCtorInitializer.
RecursiveASTVisitor used to not visit them, so that they didn't show up in
I'm not sure why my reply-all dropped Hans from the recipients. Re-added him.
From: cfe-commits [mailto:cfe-commits-boun...@lists.llvm.org] On Behalf Of
Daniel Sanders via cfe-commits
Sent: 21 January 2016 17:31
To: Marshall Clow
Cc: cfe-commits
Subject: RE: [libcxx] r258403 - [libcxx] Add approp
1 - 100 of 140 matches
Mail list logo
