EricWF accepted this revision. EricWF added a comment. This revision is now accepted and ready to land.
LGTM after addressing the `IncompleteClass` comment. Thanks for the patch! ================ Comment at: test/std/utilities/meta/meta.rel/is_convertible.pass.cpp:217 @@ -209,1 +216,3 @@ + // For example CannotInstantiate is instatiated as a part of ADL lookup for arguments of type CannotInstantiate*. + static_assert((std::is_convertible<CannotInstantiate<IncompleteClass>*, CannotInstantiate<IncompleteClass>*>::value), ""); } ---------------- CannotInstantiate<int>* works too. Using `IncompleteClass` seems a little distracting because it has nothing to do with the class being incomplete. The test will fail in the exact same way when a complete class type is given. http://reviews.llvm.org/D16344 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
