EricWF added a comment. > - Did I successfully match the coding style? (I'm kind of lost without > clang-format TBH.)
The style looks pretty good. I'll comment on any nits I have. > - Should I separate the change to __construct_node_hash() into a separate > prep commit? (I would if this were LLVM, but I'm not sure if the common > practice is different for libc++.) Yes please! http://reviews.llvm.org/D16360 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
