Author: ctopper
Date: Sat Nov 7 00:16:16 2015
New Revision: 252398
URL: http://llvm.org/viewvc/llvm-project?rev=252398&view=rev
Log:
Use makeArrayRef instead of explicitly mentioning the type. NFC
Modified:
cfe/trunk/lib/Sema/SemaExpr.cpp
Modified: cfe/trunk/lib/Sema/SemaExpr.cpp
URL:
http
Author: ctopper
Date: Sat Nov 7 00:16:14 2015
New Revision: 252397
URL: http://llvm.org/viewvc/llvm-project?rev=252397&view=rev
Log:
Fix indentation. NFC
Modified:
cfe/trunk/lib/Sema/SemaChecking.cpp
Modified: cfe/trunk/lib/Sema/SemaChecking.cpp
URL:
http://llvm.org/viewvc/llvm-project/cfe
loladiro updated this revision to Diff 39627.
loladiro updated the summary for this revision.
loladiro added a comment.
Address review feedback regarding diagnostic wording/expand tests to full text
of diagnostic.
http://reviews.llvm.org/D13330
Files:
include/clang/AST/ASTContext.h
include
loladiro added inline comments.
Comment at: include/clang/Basic/Attr.td:1463
@@ +1462,3 @@
+ let Spellings = [GNU<"unique_instantiation">];
+ let Subjects = SubjectList<[Function, CXXRecord], ErrorDiag>;
+ let Documentation = [UniqueInstantiationDocs];
loladiro
alexfh accepted this revision.
alexfh added a reviewer: alexfh.
alexfh added a comment.
This revision is now accepted and ready to land.
Looks good with a comment. Thank you for contribution!
Comment at: test/clang-tidy/cppcoreguidelines-pro-type-cstyle-cast.cpp:14
@@ +13,3 @@
+
sfantao updated this revision to Diff 39619.
sfantao added a comment.
Rebase and add check to make sure the pointee of the pointers being casted
match.
In a previous review, it was suggested by Richard Smith to move the check to
the end of `TryReinterpretCast`. However, that does not solve the
ahatanak added a comment.
Send the patch to cfe-commits.
http://reviews.llvm.org/D14471
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
eugenis closed this revision.
eugenis added a comment.
Confirmed and landed as r252385.
Thanks for the quick response!
Repository:
rL LLVM
http://reviews.llvm.org/D14410
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.or
Author: eugenis
Date: Fri Nov 6 19:22:13 2015
New Revision: 252385
URL: http://llvm.org/viewvc/llvm-project?rev=252385&view=rev
Log:
Cleanup: move visibility/linkage attributes to the first declaration.
This change moves visibility attributes from out-of-class method
definitions to in-class decl
Author: ahatanak
Date: Fri Nov 6 18:48:18 2015
New Revision: 252376
URL: http://llvm.org/viewvc/llvm-project?rev=252376&view=rev
Log:
Use regex in test case.
This is a follow-up to r252369.
Modified:
cfe/trunk/test/CodeGen/attr-no-tail.c
Modified: cfe/trunk/test/CodeGen/attr-no-tail.c
URL:
rjmccall added a comment.
In http://reviews.llvm.org/D12614#284158, @sfantao wrote:
> As for the structor variants, I am now using the complete variant to generate
> the names of the kernels as you suggested. I didn't add any method to CXXABI
> as that will require extra logic in ASTContext to
This revision was automatically updated to reflect the committed changes.
Closed by commit rL252369: Add support for function attribute
'not_tail_called'. (authored by ahatanak).
Changed prior to commit:
http://reviews.llvm.org/D12922?vs=39003&id=39607#toc
Repository:
rL LLVM
http://reviews
saugustine updated this revision to Diff 39605.
saugustine added a comment.
Handle unscoped enum with name. Also add test cases.
http://reviews.llvm.org/D14459
Files:
lib/AST/Decl.cpp
unittests/AST/NamedDeclPrinterTest.cpp
Index: unittests/AST/NamedDeclPrinterTest.cpp
=
Author: ahatanak
Date: Fri Nov 6 17:56:15 2015
New Revision: 252369
URL: http://llvm.org/viewvc/llvm-project?rev=252369&view=rev
Log:
Add support for function attribute 'not_tail_called'.
This attribute is used to prevent tail-call optimizations to the marked
function. For example, in the follow
d.zobnin.bugzilla created this revision.
d.zobnin.bugzilla added a reviewer: rnk.
d.zobnin.bugzilla added a subscriber: cfe-commits.
This patch adds support of #pragma vtordisp inside functions in attempt to
improve compatibility. Microsoft compiler appears to save the stack of vtordisp
modes on
ahatanak added a comment.
I intend to change the documentation, but other than that there should be no
changes.
I'll upload a rebased patch after I commit the other tail call patches.
http://reviews.llvm.org/D12547
___
cfe-commits mailing list
cfe
mgehre updated this revision to Diff 39601.
mgehre added a comment.
Add option GslHeader, generate fixes
http://reviews.llvm.org/D13746
Files:
clang-tidy/cppcoreguidelines/CMakeLists.txt
clang-tidy/cppcoreguidelines/CppCoreGuidelinesTidyModule.cpp
clang-tidy/cppcoreguidelines/ProBoundsCon
jroelofs added a comment.
In http://reviews.llvm.org/D14403#284054, @beanz wrote:
> I would prefer if installing these were optional and could be toggled on/off.
I'll add flags for that.
http://reviews.llvm.org/D14403
___
cfe-commits mailing list
Author: dexonsmith
Date: Fri Nov 6 17:04:58 2015
New Revision: 252360
URL: http://llvm.org/viewvc/llvm-project?rev=252360&view=rev
Log:
StaticAnalyzer: Remove implicit ilist iterator conversions, NFC
Remove implicit ilist iterator conversions from clangStaticAnalyzer.
Modified:
cfe/trunk/li
piotrdz abandoned this revision.
piotrdz added a comment.
@alexfh: Ah, I forgot about this review. I will mark it as abandoned, because I
have already started work on new check for localizing variables. It will have
the wider scope that Eugene proposed originally, that is to move variable
decla
Author: dexonsmith
Date: Fri Nov 6 17:00:41 2015
New Revision: 252358
URL: http://llvm.org/viewvc/llvm-project?rev=252358&view=rev
Log:
CodeGen: Remove implicit ilist iterator conversions, NFC
Make ilist iterator conversions explicit in clangCodeGen. Eventually
I'll remove them everywhere.
Mod
tinti marked 6 inline comments as done.
Comment at: lib/Driver/Tools.cpp:3415
@@ -3414,1 +3414,3 @@
+ if (Arg *A = Args.getLastArg(options::OPT_meabi)) {
+CmdArgs.push_back("-meabi");
Good point! Fixed.
Comment at: lib/Frontend/CompilerInv
tinti set the repository for this revision to rL LLVM.
tinti updated this revision to Diff 39596.
tinti marked an inline comment as done.
tinti added a comment.
- Add test for error check
- Change StringSwitch to use lllvm::EABI type
Repository:
rL LLVM
http://reviews.llvm.org/D14184
Files:
sfantao updated this revision to Diff 39594.
sfantao added a comment.
Rebase.
http://reviews.llvm.org/D9888
Files:
include/clang/Basic/DiagnosticDriverKinds.td
include/clang/Driver/Action.h
include/clang/Driver/CC1Options.td
include/clang/Driver/Driver.h
include/clang/Driver/Options.t
sfantao updated this revision to Diff 39590.
sfantao added a comment.
Rebase.
http://reviews.llvm.org/D13909
Files:
tools/CMakeLists.txt
tools/Makefile
tools/clang-offload-bundler/CMakeLists.txt
tools/clang-offload-bundler/ClangOffloadBundler.cpp
tools/clang-offload-bundler/Makefile
eugenis added a comment.
Yes. I'm just using libc++.so as a (incomplete) test that this is actually NFC.
It did catch the extern template issue.
Repository:
rL LLVM
http://reviews.llvm.org/D14410
___
cfe-commits mailing list
cfe-commits@lists.ll
EricWF accepted this revision.
EricWF added a comment.
This revision is now accepted and ready to land.
It's not just libc++.so that could have it's ABI affected by adding/removing
these. It's any shared library build against libc++. However if we are just
moving the attribute to the proper plac
Author: eugenis
Date: Fri Nov 6 16:02:29 2015
New Revision: 252350
URL: http://llvm.org/viewvc/llvm-project?rev=252350&view=rev
Log:
Allow deque to handle incomplete types.
Allow deque and deque::iterator instantiation with incomplete element
type. This is an ABI breaking change, and it is only
eugenis closed this revision.
eugenis added a comment.
Thanks!
Landed as r252350.
Repository:
rL LLVM
http://reviews.llvm.org/D10677
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commit
sfantao added a comment.
In http://reviews.llvm.org/D12614#278101, @rjmccall wrote:
> In http://reviews.llvm.org/D12614#274349, @sfantao wrote:
>
> > Hi John,
> >
> > Thanks for the remark!
> >
> > In http://reviews.llvm.org/D12614#272354, @rjmccall wrote:
> >
> > > CurFuncDecl is supposed to be
eugenis added a comment.
This is a mechanical change, and AFAIR I checked that no bits of libc++.so are
affected.
The same mechanical change in streambuf/istream/ostream (the stuff that's parts
of extern templates) breaks libc++ because of
https://llvm.org/bugs/show_bug.cgi?id=25427, that's wh
EricWF added a comment.
Is this a mechanical change, or do you remove/add some attributes in this patch?
Repository:
rL LLVM
http://reviews.llvm.org/D14410
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mail
sfantao updated this revision to Diff 39588.
sfantao added a comment.
Use `CurFuncDecl` to generate offload kernel names as suggested by John McCall.
http://reviews.llvm.org/D12614
Files:
include/clang/Basic/DiagnosticDriverKinds.td
include/clang/Basic/LangOptions.def
include/clang/Basic/
eugenis set the repository for this revision to rL LLVM.
eugenis updated this revision to Diff 39587.
Repository:
rL LLVM
http://reviews.llvm.org/D12382
Files:
lib/Driver/ToolChains.cpp
test/Driver/Inputs/basic_linux_libcxxv2_tree/usr/bin/.keep
test/Driver/Inputs/basic_linux_libcxxv2_tre
eugenis marked an inline comment as done.
eugenis added a comment.
Repository:
rL LLVM
http://reviews.llvm.org/D12382
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
EricWF accepted this revision.
EricWF added a comment.
This revision is now accepted and ready to land.
I think I've cleared up my own confusion. LGTM.
Repository:
rL LLVM
http://reviews.llvm.org/D10677
___
cfe-commits mailing list
cfe-commits@li
EricWF accepted this revision.
EricWF added a comment.
This revision is now accepted and ready to land.
LGTM.
http://reviews.llvm.org/D13673
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-c
EricWF accepted this revision.
EricWF added a comment.
This revision is now accepted and ready to land.
LGTM. Thanks.
http://reviews.llvm.org/D14130
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listin
aaron.ballman added a subscriber: aaron.ballman.
aaron.ballman added a comment.
I'm wondering about the status of this, since I've not heard much in the past
few months. Is this patch still progressing? (I hope so, I would really love to
see us drop our reliance on Perl!)
http://reviews.llvm.o
bcraig added a subscriber: bcraig.
bcraig added a comment.
For what it's worth, our internal branch installs these by default, and I was
unpleasantly surprised when I found that upstream didn't.
http://reviews.llvm.org/D14403
___
cfe-commits mailin
tinti removed rL LLVM as the repository for this revision.
tinti updated this revision to Diff 39579.
http://reviews.llvm.org/D14184
Files:
include/clang/Driver/Options.td
include/clang/Frontend/CodeGenOptions.h
lib/CodeGen/BackendUtil.cpp
lib/Driver/Tools.cpp
lib/Frontend/CompilerInvoc
beanz added a comment.
I would prefer if installing these were optional and could be toggled on/off.
Other than that this all looks fine to me.
http://reviews.llvm.org/D14403
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm
tstellarAMD added a project: 3.7-release.
Users:
dim (Author)
3.7-release (Auditor)
cfe-commits (Auditor)
tstellarAMD (Auditor)
joerg (Auditor)
rsmith (Auditor)
http://reviews.llvm.org/rL250657
___
cfe-commits mailing list
cfe-commits@lis
mgehre updated this revision to Diff 39576.
mgehre added a comment.
Update for review comments: add braces around else
http://reviews.llvm.org/D14096
Files:
clang-tidy/cppcoreguidelines/CMakeLists.txt
clang-tidy/cppcoreguidelines/CppCoreGuidelinesTidyModule.cpp
clang-tidy/cppcoreguideline
probinson added a comment.
I have an internal release freeze coming up in a couple of weeks, but I should
be able to spend time on exposing the "tuning" in clang after that. I don't
mind this patch going in if you're not able to wait.
http://reviews.llvm.org/D14354
tberghammer added a comment.
If you plan to do the "tuning" in clang in the near future then we can abandon
this change in favor of that one
Comment at: lib/Driver/Tools.cpp:3880
@@ +3879,3 @@
+ // -gdwarf-accel-tables should turn on -g and enable the genereation of the
+ //
probinson added a comment.
In http://reviews.llvm.org/D14354#282988, @tberghammer wrote:
> In http://reviews.llvm.org/D14354#282870, @probinson wrote:
>
> > So, currently you get accel tables by default for platforms that "tune" for
> > LLDB, currently Darwin and FreeBSD.
> > Are you wanting to
alexfh added a comment.
PTAL
Comment at: clang-tidy/ClangTidy.cpp:382
@@ +381,3 @@
+ const CommandLineArguments &Args, StringRef Filename) {
+ClangTidyOptions Opts = Context.getOptionsForFile(Filename);
+CommandLineArguments AdjustedArgs;
The interf
alexfh updated this revision to Diff 39553.
alexfh added a comment.
Updated documentation comments.
http://reviews.llvm.org/D14192
Files:
clang-tidy/ClangTidy.cpp
clang-tidy/ClangTidyDiagnosticConsumer.cpp
clang-tidy/ClangTidyDiagnosticConsumer.h
clang-tidy/ClangTidyOptions.cpp
clang-
alexfh updated this revision to Diff 39551.
alexfh added a comment.
Added ClangTidyContext::getOptionsForFile.
http://reviews.llvm.org/D14192
Files:
clang-tidy/ClangTidy.cpp
clang-tidy/ClangTidyDiagnosticConsumer.cpp
clang-tidy/ClangTidyDiagnosticConsumer.h
clang-tidy/ClangTidyOptions.c
aaron.ballman added inline comments.
Comment at: tools/clang-format-vs/ClangFormat/ClangFormatPackage.cs:86
@@ -69,1 +85,3 @@
+IComponentModel componentModel =
GetService(typeof(SComponentModel)) as IComponentModel;
+editorAdaptersFactoryService =
compo
hans added inline comments.
Comment at: tools/clang-format-vs/ClangFormat/ClangFormatPackage.cs:86
@@ -69,1 +85,3 @@
+IComponentModel componentModel =
GetService(typeof(SComponentModel)) as IComponentModel;
+editorAdaptersFactoryService =
componentModel
rmaprath updated this revision to Diff 39541.
rmaprath added a comment.
Patch updated to add XFAILS for all those tests that are failing on the new
(-fno-exceptions) library variant. Follow-up patches will progressively
un-XFAIL these tests (i.e. adapt them to cope with the new library variant).
junbuml added a comment.
Just ping to see if there is any objection about adding the extra check for
CallSites in EHRs in inliner. I will be happy to hear any opinion, suggestion,
or objection.
http://reviews.llvm.org/D13304
___
cfe-commits maili
aaron.ballman added inline comments.
Comment at: include/clang/Basic/AttrDocs.td:1620
@@ +1619,3 @@
+ let Content = [{
+The declare simd construct can be applied to a function to enable the creation
of one or more versions that can process multiple arguments using SIMD
instruct
Author: angelgarcia
Date: Fri Nov 6 09:47:04 2015
New Revision: 252315
URL: http://llvm.org/viewvc/llvm-project?rev=252315&view=rev
Log:
Allow the alias to be of a different type.
Summary: Consider a declaration an alias even if it doesn't have the same
unqualified type than the container eleme
klimek accepted this revision.
klimek added a comment.
This revision is now accepted and ready to land.
lg
http://reviews.llvm.org/D14442
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-comm
Yeah, what's the motivation for this? I'd actually prefer that these didn't
work in C because I'd like to know if my build system is broken.
On Nov 6, 2015 03:05, "Joerg Sonnenberger via cfe-commits" <
cfe-commits@lists.llvm.org> wrote:
> On Fri, Nov 06, 2015 at 06:30:12AM -, Eric Fiselier via
aaron.ballman added inline comments.
Comment at: tools/clang-format-vs/ClangFormat/ClangFormatPackage.cs:86
@@ -69,1 +85,3 @@
+IComponentModel componentModel =
GetService(typeof(SComponentModel)) as IComponentModel;
+editorAdaptersFactoryService =
compo
angelgarcia updated this revision to Diff 39530.
angelgarcia added a comment.
The test revealed a (already existing) bug. If we called getName() on a
CXXConversionDecl, we would get the following assertion:
include/clang/AST/Decl.h:170: llvm::StringRef clang::NamedDecl::getName()
const: Asserti
berenm added inline comments.
Comment at: tools/clang-format-vs/ClangFormat/ClangFormatPackage.cs:86
@@ -69,1 +85,3 @@
+IComponentModel componentModel =
GetService(typeof(SComponentModel)) as IComponentModel;
+editorAdaptersFactoryService =
componentMod
Author: aaronballman
Date: Fri Nov 6 09:34:03 2015
New Revision: 252314
URL: http://llvm.org/viewvc/llvm-project?rev=252314&view=rev
Log:
Fixing line endings; NFC.
Modified:
cfe/trunk/include/clang/Basic/AttrDocs.td
Modified: cfe/trunk/include/clang/Basic/AttrDocs.td
URL:
http://llvm.org/v
klimek added inline comments.
Comment at: clang-tidy/ClangTidy.cpp:382
@@ +381,3 @@
+ const CommandLineArguments &Args, StringRef Filename) {
+Context.setCurrentFile(Filename);
+const ClangTidyOptions &Opts = Context.getOptions();
alexfh wrote:
> klim
alexfh added inline comments.
Comment at: clang-tidy/ClangTidy.cpp:382
@@ +381,3 @@
+ const CommandLineArguments &Args, StringRef Filename) {
+Context.setCurrentFile(Filename);
+const ClangTidyOptions &Opts = Context.getOptions();
klimek wrote:
> alex
aaron.ballman added a comment.
Are you still looking for review on this patch, or are you intending to make
modifications based on further discussion from the other tail call attribute?
http://reviews.llvm.org/D12547
___
cfe-commits mailing list
cf
klimek added a comment.
Can you add a test with an overloaded conversion operator?
http://reviews.llvm.org/D14442
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
jroelofs updated this revision to Diff 39529.
jroelofs added a comment.
Forgot to `svn add` after rebasing the patch on top of upstream.
http://reviews.llvm.org/D14403
Files:
tools/CMakeLists.txt
tools/Makefile
tools/scan-build/CMakeLists.txt
tools/scan-build/Makefile
tools/scan-build
aaron.ballman added a comment.
Ping. rnk, do you have a moment to look this over? My C#-fu is a bit rusty, but
this seems reasonable to me.
http://reviews.llvm.org/D12407
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org
klimek added inline comments.
Comment at: clang-tidy/ClangTidy.cpp:382
@@ +381,3 @@
+ const CommandLineArguments &Args, StringRef Filename) {
+Context.setCurrentFile(Filename);
+const ClangTidyOptions &Opts = Context.getOptions();
alexfh wrote:
> klim
angelgarcia added a comment.
No. There is a test for that just before the one I added.
http://reviews.llvm.org/D14442
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
klimek added a comment.
Does this still do it for types with a user-provided implicit constructor?
http://reviews.llvm.org/D14442
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
Author: kuba.brecka
Date: Fri Nov 6 09:20:30 2015
New Revision: 252311
URL: http://llvm.org/viewvc/llvm-project?rev=252311&view=rev
Log:
Followup test failure fix for r252310 ("[tsan] Add Clang frontend support for
TSan on OS X").
Modified:
cfe/trunk/test/Driver/fsanitize.c
Modified: cfe/
angelgarcia created this revision.
angelgarcia added a reviewer: klimek.
angelgarcia added subscribers: cfe-commits, alexfh.
Consider a declaration an alias even if it doesn't have the same unqualified
type than the container element, as long as one can be converted to the other
using only impli
alexfh added inline comments.
Comment at: clang-tidy/ClangTidy.cpp:382
@@ +381,3 @@
+ const CommandLineArguments &Args, StringRef Filename) {
+Context.setCurrentFile(Filename);
+const ClangTidyOptions &Opts = Context.getOptions();
klimek wrote:
> My c
This revision was automatically updated to reflect the committed changes.
Closed by commit rL252310: [tsan] Add Clang frontend support for TSan on OS X
(authored by kuba.brecka).
Changed prior to commit:
http://reviews.llvm.org/D14440?vs=39524&id=39526#toc
Repository:
rL LLVM
http://reviews
Author: kuba.brecka
Date: Fri Nov 6 09:09:20 2015
New Revision: 252310
URL: http://llvm.org/viewvc/llvm-project?rev=252310&view=rev
Log:
[tsan] Add Clang frontend support for TSan on OS X
We're currently in process of porting TSan to OS X, and quite a few of the
initial support in the runtime l
bader created this revision.
bader added reviewers: pekka.jaaskelainen, gbenyei.
bader added a subscriber: cfe-commits.
Initial support for OpenCL 2.0 feature: pipe types.
http://reviews.llvm.org/D14441
Files:
include/clang/AST/ASTContext.h
include/clang/AST/DataRecursiveASTVisitor.h
inclu
Author: angelgarcia
Date: Fri Nov 6 09:03:14 2015
New Revision: 252308
URL: http://llvm.org/viewvc/llvm-project?rev=252308&view=rev
Log:
Use the old index identifier by default, instead of 'elem'.
Summary: Use the old index name in the cases where the check would come up with
an invented name.
kubabrecka created this revision.
kubabrecka added reviewers: dvyukov, samsonov, kcc, glider.
kubabrecka added subscribers: cfe-commits, zaks.anna, ismailp, jasonk,
jevinskie.
We're currently in process of porting TSan to OS X, and quite a few of the
initial support in the runtime library has al
aaron.ballman accepted this revision.
aaron.ballman added a comment.
This revision is now accepted and ready to land.
LGTM!
http://reviews.llvm.org/D13048
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/
klimek accepted this revision.
klimek added a comment.
This revision is now accepted and ready to land.
lg
http://reviews.llvm.org/D14438
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-comm
Author: petarj
Date: Fri Nov 6 08:52:46 2015
New Revision: 252307
URL: http://llvm.org/viewvc/llvm-project?rev=252307&view=rev
Log:
Fix __builtin_signbit for ppcf128 type
Function__builtin_signbit returns wrong value for type ppcf128 on big endian
machines. This patch fixes how value is generate
This revision was automatically updated to reflect the committed changes.
Closed by commit rL252307: Fix __builtin_signbit for ppcf128 type (authored by
petarj).
Changed prior to commit:
http://reviews.llvm.org/D14149?vs=39513&id=39523#toc
Repository:
rL LLVM
http://reviews.llvm.org/D14149
angelgarcia created this revision.
angelgarcia added a reviewer: klimek.
angelgarcia added a subscriber: cfe-commits.
Use the old index name in the cases where the check would come up with an
invented name.
http://reviews.llvm.org/D14438
Files:
clang-tidy/modernize/LoopConvertUtils.cpp
test
aaron.ballman added inline comments.
Comment at: include/clang/Basic/DiagnosticSemaKinds.td:2456
@@ -2450,1 +2455,3 @@
+def err_unique_instantiation_not_previous : Error<
+ "'unique_instantiation' attribute must be specified for all declarations and
definitions of this explicit
a.sidorin updated this revision to Diff 39517.
a.sidorin marked an inline comment as done.
a.sidorin added a comment.
Some issues pointed on review were fixed.
Repository:
rL LLVM
http://reviews.llvm.org/D14286
Files:
lib/AST/ASTImporter.cpp
Index: lib/AST/ASTImporter.cpp
a.sidorin marked 7 inline comments as done.
a.sidorin added a comment.
Thank you for your comments. I leaved some replies and will update revision.
Something about lacking tests.
1. We cannot check if expression import is correct until we implement
FunctionDecl body import. I was going to upstre
aaron.ballman accepted this revision.
aaron.ballman added a comment.
This revision is now accepted and ready to land.
With moving the definition of the Deinitializer class closer to its use (it
should be defined within the function itself given the limited use), LGTM.
Comment a
Author: angelgarcia
Date: Fri Nov 6 08:04:12 2015
New Revision: 252303
URL: http://llvm.org/viewvc/llvm-project?rev=252303&view=rev
Log:
Avoid naming conflicts with the old index in modernize-loop-convert.
Summary: The old index declaration is going to be removed anyway, so we can
reuse its nam
klimek accepted this revision.
klimek added a comment.
This revision is now accepted and ready to land.
lg
http://reviews.llvm.org/D14437
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-comm
aaron.ballman added a comment.
LGTM, thank you!
Comment at: include/clang/Basic/DiagnosticSemaKinds.td:4090
@@ +4089,3 @@
+ "'internal_linkage' attribute on a non-static local variable is ignored">,
+ InGroup;
+
Good catch!
Repository:
rL LLVM
http://revi
angelgarcia created this revision.
angelgarcia added a reviewer: klimek.
angelgarcia added subscribers: alexfh, cfe-commits.
The old index declaration is going to be removed anyway, so we can reuse its
name if it is the best candidate for the new index.
http://reviews.llvm.org/D14437
Files:
c
abeserminji updated this revision to Diff 39513.
abeserminji marked 2 inline comments as done.
abeserminji added a comment.
Comment modified
Repository:
rL LLVM
http://reviews.llvm.org/D14149
Files:
lib/CodeGen/CGBuiltin.cpp
test/Analysis/builtin_signbit.cpp
Index: test/Analysis/builtin
vkalintiris added a comment.
Ping.
http://reviews.llvm.org/D13673
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
ismailp added a subscriber: ismailp.
ismailp added a comment.
Thanks!
Users:
ismailp (Author)
rsmith (Auditor)
3.7-release (Auditor)
cfe-commits (Auditor)
tstellarAMD (Auditor)
http://reviews.llvm.org/rL251335
___
cfe-commits mailing list
Thanks!
On Fri, Nov 6, 2015 at 12:44 PM, Tom Stellard wrote:
> tstellarAMD accepted this commit.
> tstellarAMD added a comment.
>
> r252290
>
>
> Users:
> ismailp (Author)
> rsmith (Auditor)
> 3.7-release (Auditor)
> cfe-commits (Auditor)
> tstellarAMD (Auditor)
>
> http://reviews.llvm.
tstellarAMD accepted this commit.
tstellarAMD added a comment.
r252289
Users:
dim (Author)
3.7-release (Auditor)
cfe-commits (Auditor)
tstellarAMD (Auditor)
joerg (Auditor)
rsmith (Auditor)
http://reviews.llvm.org/rL250657
___
cfe-commi
tstellarAMD accepted this commit.
tstellarAMD added a comment.
r252290
Users:
ismailp (Author)
rsmith (Auditor)
3.7-release (Auditor)
cfe-commits (Auditor)
tstellarAMD (Auditor)
http://reviews.llvm.org/rL251335
___
cfe-commits mailing lis
tstellarAMD accepted this commit.
tstellarAMD added a comment.
r252288
Users:
joerg (Author, Auditor)
3.7-release (Auditor)
cfe-commits (Auditor)
tstellarAMD (Auditor)
rsmith (Auditor)
http://reviews.llvm.org/rL248426
___
cfe-commits mail
tstellarAMD accepted this commit.
tstellarAMD added a comment.
r252287
Users:
joerg (Author, Auditor)
3.7-release (Auditor)
cfe-commits (Auditor)
tstellarAMD (Auditor)
rsmith (Auditor)
http://reviews.llvm.org/rL248424
___
cfe-commits mail
1 - 100 of 109 matches
Mail list logo
