EricWF accepted this revision. EricWF added a comment. This revision is now accepted and ready to land.
It's not just libc++.so that could have it's ABI affected by adding/removing these. It's any shared library build against libc++. However if we are just moving the attribute to the proper place that should truly NFC modolo https://llvm.org/bugs/show_bug.cgi?id=25427. LGTM and feel free to commit any similar cleanup without review. I'll have to think a little harder about the extern template issues before working through those. Repository: rL LLVM http://reviews.llvm.org/D14410 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits