tinti marked 6 inline comments as done.

================
Comment at: lib/Driver/Tools.cpp:3415
@@ -3414,1 +3414,3 @@
 
+  if (Arg *A = Args.getLastArg(options::OPT_meabi)) {
+    CmdArgs.push_back("-meabi");
----------------
Good point! Fixed.

================
Comment at: lib/Frontend/CompilerInvocation.cpp:460
@@ +459,3 @@
+    StringRef Value = A->getValue();
+    llvm::EABI EABIVersion = llvm::StringSwitch<llvm::EABI>(Value)
+                                 .Case("default", llvm::EABI::Default)
----------------
I have added. It requires to add an invalid or more apropriate name Unknown 
version.

If the backend ever sees an Unknown it will consider it as a Default.
The frontend considers Unknown as an invalid state and raises an error.


Repository:
  rL LLVM

http://reviews.llvm.org/D14184



_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Reply via email to