r250605 - [Frontend] Name variable correctly.

Author: davide Date: Sat Oct 17 01:46:39 2015 New Revision: 250605 URL: http://llvm.org/viewvc/llvm-project?rev=250605&view=rev Log: [Frontend] Name variable correctly. Reported by: Kim Grasman! Modified: cfe/trunk/lib/Frontend/CompilerInvocation.cpp Modified: cfe/trunk/lib/Frontend/Compile

Re: r250473 - Add an error when calling a builtin that requires features that don't

Can't be. We don't know we're going to make the call until we code gen. :) On Fri, Oct 16, 2015, 7:50 PM Justin Bogner wrote: > Eric Christopher via cfe-commits writes: > > Author: echristo > > Date: Thu Oct 15 18:47:11 2015 > > New Revision: 250473 > > > > URL: http://llvm.org/viewvc/llvm-proj

Re: r250473 - Add an error when calling a builtin that requires features that don't

Eric Christopher via cfe-commits writes: > Author: echristo > Date: Thu Oct 15 18:47:11 2015 > New Revision: 250473 > > URL: http://llvm.org/viewvc/llvm-project?rev=250473&view=rev > Log: > Add an error when calling a builtin that requires features that don't > match the feature set of the functio

r250602 - Add an AST node matcher for TemplateTypeParmDecl objects.

Author: ericwf Date: Fri Oct 16 21:34:44 2015 New Revision: 250602 URL: http://llvm.org/viewvc/llvm-project?rev=250602&view=rev Log: Add an AST node matcher for TemplateTypeParmDecl objects. Modified: cfe/trunk/docs/LibASTMatchersReference.html cfe/trunk/include/clang/ASTMatchers/ASTMatch

Re: [PATCH] D13554: [X86] Enable soft float ABI for x86

rnk accepted this revision. rnk added a comment. This revision is now accepted and ready to land. lgtm Sorry, took me a while to read the document and understand why you want `float inreg`. I think we overload LLVM inreg to mean "put this float / double in an SSE register", but I think it's rea

Re: [Diffusion] rL244063: Add missing atomic libcall support.

tstellarAMD added a subscriber: tstellarAMD. tstellarAMD added auditors: rsmith. tstellarAMD added a comment. Hi Richard, Is this patch OK for the 3.7 branch? Users: jyknight (Author, Auditor) 3.7-release (Auditor) cfe-commits (Auditor) tstellarAMD (Auditor) compnerd (Auditor) majne

Re: r250577 - [modules] Allow the error when explicitly loading an incompatible module file

On Fri, Oct 16, 2015 at 6:30 PM, Sean Silva wrote: > On Fri, Oct 16, 2015 at 6:26 PM, Richard Smith > wrote: > >> On Fri, Oct 16, 2015 at 6:25 PM, Sean Silva >> wrote: >> >>> On Fri, Oct 16, 2015 at 6:12 PM, Richard Smith >>> wrote: >>> On Fri, Oct 16, 2015 at 4:43 PM, Sean Silva wr

Re: r250577 - [modules] Allow the error when explicitly loading an incompatible module file

On Fri, Oct 16, 2015 at 6:26 PM, Richard Smith wrote: > On Fri, Oct 16, 2015 at 6:25 PM, Sean Silva wrote: > >> On Fri, Oct 16, 2015 at 6:12 PM, Richard Smith >> wrote: >> >>> On Fri, Oct 16, 2015 at 4:43 PM, Sean Silva >>> wrote: >>> On Fri, Oct 16, 2015 at 4:20 PM, Richard Smith via cfe

Re: r250577 - [modules] Allow the error when explicitly loading an incompatible module file

On Fri, Oct 16, 2015 at 6:25 PM, Sean Silva wrote: > On Fri, Oct 16, 2015 at 6:12 PM, Richard Smith > wrote: > >> On Fri, Oct 16, 2015 at 4:43 PM, Sean Silva >> wrote: >> >>> On Fri, Oct 16, 2015 at 4:20 PM, Richard Smith via cfe-commits < >>> cfe-commits@lists.llvm.org> wrote: >>> Author:

Re: r250577 - [modules] Allow the error when explicitly loading an incompatible module file

On Fri, Oct 16, 2015 at 6:12 PM, Richard Smith wrote: > On Fri, Oct 16, 2015 at 4:43 PM, Sean Silva wrote: > >> On Fri, Oct 16, 2015 at 4:20 PM, Richard Smith via cfe-commits < >> cfe-commits@lists.llvm.org> wrote: >> >>> Author: rsmith >>> Date: Fri Oct 16 18:20:19 2015 >>> New Revision: 250577

Re: r250577 - [modules] Allow the error when explicitly loading an incompatible module file

On Fri, Oct 16, 2015 at 4:43 PM, Sean Silva wrote: > On Fri, Oct 16, 2015 at 4:20 PM, Richard Smith via cfe-commits < > cfe-commits@lists.llvm.org> wrote: > >> Author: rsmith >> Date: Fri Oct 16 18:20:19 2015 >> New Revision: 250577 >> >> URL: http://llvm.org/viewvc/llvm-project?rev=250577&view=r

Re: [libcxx] r249738 - Split out of .

On Fri, Oct 16, 2015 at 5:30 PM, Adrian Prantl via cfe-commits < cfe-commits@lists.llvm.org> wrote: > > On Oct 16, 2015, at 5:28 PM, Richard Smith wrote: > > > > > Getting there :-) > > In file included from :86: > In file included from > /Volumes/Data/llvm/_build.ninja.release/bin/../lib/clang/

Re: [libcxx] r249738 - Split out of .

> On Oct 16, 2015, at 5:30 PM, Adrian Prantl via cfe-commits > wrote: > > >> On Oct 16, 2015, at 5:28 PM, Richard Smith > > wrote: >> >> > > Getting there :-) > While building module 'Darwin' imported from /Xcode.app/Contents/Developer/Platforms/MacOSX.platfo

Re: Stage 2 bot failure: clang-stage2-configure-Rlto_check

This isn’t just the static analyzer. There are Sema failures here as well: • Clang.Sema.exprs.c • Clang.Sema.shift.c • Clang.Sema.uninit-variables.c • Clang.Sema.warn-unreachable.c • Clang.SemaCXX.runtimediag-ppe.cpp • Clang.SemaCXX.uninitialized.cpp

Re: [libcxx] r249738 - Split out of .

> On Oct 16, 2015, at 5:28 PM, Richard Smith wrote: > > Getting there :-) In file included from :86: In file included from /Volumes/Data/llvm/_build.ninja.release/bin/../lib/clang/3.8.0/include/tgmath.h:29: /Volumes/Data/llvm/_build.ninja.release/bin/../include/c++/v1/math.h:309:10: fatal e

Re: [libcxx] r249738 - Split out of .

On Fri, Oct 16, 2015 at 5:17 PM, Adrian Prantl via cfe-commits < cfe-commits@lists.llvm.org> wrote: > On Oct 16, 2015, at 5:13 PM, Richard Smith wrote: > > On Fri, Oct 16, 2015 at 4:48 PM, Adrian Prantl via cfe-commits < > cfe-commits@lists.llvm.org> wrote: > >> On Oct 16, 2015, at 3:27 PM, Richa

r250592 - Diagnose UnresolvedLookupExprs that resolve to instance members in static methods

Author: rnk Date: Fri Oct 16 19:19:04 2015 New Revision: 250592 URL: http://llvm.org/viewvc/llvm-project?rev=250592&view=rev Log: Diagnose UnresolvedLookupExprs that resolve to instance members in static methods During the initial template parse for this code, 'member' is unresolved and we don't

Re: [PATCH] D6700: Diagnose UnresolvedLookupExprs that resolve to instance members in static methods

This revision was automatically updated to reflect the committed changes. rnk marked an inline comment as done. Closed by commit rL250592: Diagnose UnresolvedLookupExprs that resolve to instance members in static… (authored by rnk). Changed prior to commit: http://reviews.llvm.org/D6700?vs=3730

Re: [libcxx] r249738 - Split out of .

> On Oct 16, 2015, at 5:13 PM, Richard Smith wrote: > > On Fri, Oct 16, 2015 at 4:48 PM, Adrian Prantl via cfe-commits > mailto:cfe-commits@lists.llvm.org>> wrote: >> On Oct 16, 2015, at 3:27 PM, Richard Smith > > wrote: >> >> On Thu, Oct 15, 2015 at 11:14 AM, Adr

Re: [libcxx] r249738 - Split out of .

On Fri, Oct 16, 2015 at 4:48 PM, Adrian Prantl via cfe-commits < cfe-commits@lists.llvm.org> wrote: > On Oct 16, 2015, at 3:27 PM, Richard Smith wrote: > > On Thu, Oct 15, 2015 at 11:14 AM, Adrian Prantl wrote: > >> >> On Oct 14, 2015, at 5:07 PM, Richard Smith wrote: >> >> Ack, there are non-m

Stage 2 bot failure: clang-stage2-configure-Rlto_check

There are 33 commits picked up in this run and we have 107 test failures. This happened at 2pm today. I wonder if any one knows what is going on. http://lab.llvm.org:8080/green/job/clang-stage2-configure-Rlto_check/6222/ http://lab.llvm.org:8080/green/job/clang-stage2-configure-Rlto_check/6222

Re: [libcxx] r249738 - Split out of .

On Wed, Oct 14, 2015 at 5:28 PM, Adrian Prantl via cfe-commits < cfe-commits@lists.llvm.org> wrote: > > On Oct 14, 2015, at 5:07 PM, Richard Smith wrote: > > On Wed, Oct 14, 2015 at 3:58 PM, Adrian Prantl via cfe-commits < > cfe-commits@lists.llvm.org> wrote: > >> On Oct 14, 2015, at 3:32 PM, Ric

Re: r250470 - Fix the subtarget features required by some x86 builtins.

Sure, but if someone is planning on doing this for ARM there's some work in the ARM TargetInfo that needs to be done :) -eric On Fri, Oct 16, 2015 at 3:24 PM Justin Bogner wrote: > Looks like we'll need "and" for ARM's builtins as well - several require > things like neon+fp16 or neon+vfp4. > >

Re: [libcxx] r249738 - Split out of .

> On Oct 16, 2015, at 3:27 PM, Richard Smith wrote: > > On Thu, Oct 15, 2015 at 11:14 AM, Adrian Prantl > wrote: > >> On Oct 14, 2015, at 5:07 PM, Richard Smith > > wrote: >> >> Ack, there are non-modular headers in the Darwin module. =(

Re: [PATCH] D13765: clang-format: [JS] Handle string literals spanning character classes.

mprobst added inline comments. Comment at: lib/Format/Format.cpp:757 @@ -756,3 +756,1 @@ - if (tryMergeEscapeSequence()) -return; if (tryMergeTemplateString()) You cannot actually escape in a template string - backslashes in them are literal b

Re: r250577 - [modules] Allow the error when explicitly loading an incompatible module file

On Fri, Oct 16, 2015 at 4:20 PM, Richard Smith via cfe-commits < cfe-commits@lists.llvm.org> wrote: > Author: rsmith > Date: Fri Oct 16 18:20:19 2015 > New Revision: 250577 > > URL: http://llvm.org/viewvc/llvm-project?rev=250577&view=rev > Log: > [modules] Allow the error when explicitly loading a

Re: [PATCH] D13765: clang-format: [JS] Handle string literals spanning character classes.

mprobst added inline comments. Comment at: lib/Format/Format.cpp:858 @@ +857,3 @@ +} +if (Prev) { + if (Prev->isOneOf(tok::plus, tok::plusplus, tok::minus, djasper wrote: > I'd probably put this into the other two conditions to reduce indentation. >

Re: [PATCH] D13765: clang-format: [JS] Handle string literals spanning character classes.

mprobst updated this revision to Diff 37654. mprobst marked 3 inline comments as done. mprobst added a comment. - add test for if (...) /re/; - address minor review comments - fix unary handling. http://reviews.llvm.org/D13765 Files: lib/Format/Format.cpp unittests/Format/FormatTestJS.cpp

r250577 - [modules] Allow the error when explicitly loading an incompatible module file

Author: rsmith Date: Fri Oct 16 18:20:19 2015 New Revision: 250577 URL: http://llvm.org/viewvc/llvm-project?rev=250577&view=rev Log: [modules] Allow the error when explicitly loading an incompatible module file via -fmodule-file= to be turned off; in that case, just include the relevant files text

Re: r250514 - PS4: Make sure to add the sanitizer runtime before any linker input

Filipe, FYI, this change appears to introduce a somewhat subtle problem. clang compiled with itself starts producing (false positive?) warnings about uninitialized variables. I didn't get a chance to dig deeper yet. --Artem On Fri, Oct 16, 2015 at 8:07 AM, Filipe Cabecinhas via cfe-commits < cfe

Re: [PATCH] D13765: clang-format: [JS] Handle string literals spanning character classes.

djasper added inline comments. Comment at: lib/Format/Format.cpp:755 @@ -754,3 +754,1 @@ - if (tryMergeEscapeSequence()) -return; if (tryMergeTemplateString()) I wonder if escape sequences are also relevant to template strings. If yes, we are

Re: [libcxx] r249738 - Split out of .

On Thu, Oct 15, 2015 at 11:14 AM, Adrian Prantl wrote: > > On Oct 14, 2015, at 5:07 PM, Richard Smith wrote: > > Ack, there are non-modular headers in the Darwin module. =( I seem to > recall that they're not version-locked to your compiler, so we've got to > support them as-is? > > If we can't

Re: r250470 - Fix the subtarget features required by some x86 builtins.

Looks like we'll need "and" for ARM's builtins as well - several require things like neon+fp16 or neon+vfp4. Eric Christopher writes: > Right. My current direction is going to be: > > "foo+bar" we can represent as "and" > "foo,bar" we'll continue to represent as "or" > > this will lead to things

r250559 - [Frontend/CompilerInvocation] Use range-based loop. NFC.

Author: davide Date: Fri Oct 16 17:13:53 2015 New Revision: 250559 URL: http://llvm.org/viewvc/llvm-project?rev=250559&view=rev Log: [Frontend/CompilerInvocation] Use range-based loop. NFC. Modified: cfe/trunk/lib/Frontend/CompilerInvocation.cpp Modified: cfe/trunk/lib/Frontend/CompilerInvoc

Re: [PATCH] D13673: Add initial support for the MUSL C library.

EricWF added a comment. Thanks for the quick turn around. This patch is almost ready to land but still needs a couple more changes. Comment at: CMakeLists.txt:320 @@ -318,1 +319,3 @@ +config_define_if(LIBCXX_LIBC_IS_MUSL _LIBCPP_HAS_MUSL_LIBC) + Yes please, I

[PATCH] D13834: Produce a better diagnostic for global register variables

ahatanak created this revision. ahatanak added a subscriber: cfe-commits. clang doesn't print a very user-friendly message when an invalid register is used for a global register variable: For example, when the following code is compiled, $ cat f1.c volatile register long long A asm ("rdi"); vo

r250554 - Refactor module lookup when looking up a header file, and wire through the requesting module. No functionality change.

Author: rsmith Date: Fri Oct 16 16:42:56 2015 New Revision: 250554 URL: http://llvm.org/viewvc/llvm-project?rev=250554&view=rev Log: Refactor module lookup when looking up a header file, and wire through the requesting module. No functionality change. Modified: cfe/trunk/include/clang/Lex/Di

New public staging silent buildbot

Hello everyone, I just added public staging buildbot and every owner of build machine is welcome to use it. Its' copy of our current LLVM buildbot, but it does not send any notifications. The web page is here: http://lab.llvm.org:8014 Any builder could be easy switched to staging buildbot by simp

Re: r250473 - Add an error when calling a builtin that requires features that don't

Woot! Thanks! > On Oct 15, 2015, at 4:47 PM, Eric Christopher via cfe-commits > wrote: > > Author: echristo > Date: Thu Oct 15 18:47:11 2015 > New Revision: 250473 > > URL: http://llvm.org/viewvc/llvm-project?rev=250473&view=rev > Log: > Add an error when calling a builtin that requires feature

Re: [clang-tools-extra] r250509 - Fix overlapping replacements in clang-tidy.

On Fri, Oct 16, 2015 at 4:43 AM, Angel Garcia Gomez via cfe-commits < cfe-commits@lists.llvm.org> wrote: > Author: angelgarcia > Date: Fri Oct 16 06:43:49 2015 > New Revision: 250509 > > URL: http://llvm.org/viewvc/llvm-project?rev=250509&view=rev > Log: > Fix overlapping replacements in clang-tid

Re: [PATCH] D13746: [clang-tidy] add check cppcoreguidelines-pro-bounds-constant-array-index

sbenza added inline comments. Comment at: clang-tidy/cppcoreguidelines/ProBoundsConstantArrayIndexCheck.cpp:55 @@ +54,3 @@ + if (!IndexExpr->isIntegerConstantExpr(Index, *Result.Context, nullptr, true)) { +//Fixit would need gsl::at() +diag(Matched->getExprLoc(), "do not

Re: [PATCH] D13739: [libcxx] Make libc++.so a linker script by default on most platforms.

EricWF added inline comments. Comment at: cmake/Modules/HandleOutOfTreeLLVM.cmake:123-133 @@ +122,13 @@ + else(WIN32) +if(UNIX) + set(LLVM_ON_WIN32 0) + set(LLVM_ON_UNIX 1) + if(APPLE) +set(LLVM_HAVE_LINK_VERSION_SCRIPT 0) + else(APPLE) +se

Re: [PATCH] D13500: Improve helpfulness of assert message when number of diagnostics overflows number of available enum values.

richard.barton.arm closed this revision. richard.barton.arm added a comment. Committed as r250546 with the suggested change. http://reviews.llvm.org/D13500 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman

r250547 - Once again fix this test to read from stdin rather than an input file

Author: rbarton Date: Fri Oct 16 15:15:33 2015 New Revision: 250547 URL: http://llvm.org/viewvc/llvm-project?rev=250547&view=rev Log: Once again fix this test to read from stdin rather than an input file Modified: cfe/trunk/test/OpenMP/for_simd_codegen.cpp Modified: cfe/trunk/test/OpenMP/for

r250546 - Further increase helfulness of assert message

Author: rbarton Date: Fri Oct 16 15:15:29 2015 New Revision: 250546 URL: http://llvm.org/viewvc/llvm-project?rev=250546&view=rev Log: Further increase helfulness of assert message If you increase the number of diags of a particular type by one more than the number available you get the nice asser

Re: [PATCH] D13820: [libunwind] Add FreeBSD _Unwind_Ptr typedef

This revision was automatically updated to reflect the committed changes. Closed by commit rL250541: Add FreeBSD _Unwind_Ptr typedef (authored by emaste). Changed prior to commit: http://reviews.llvm.org/D13820?vs=37615&id=37628#toc Repository: rL LLVM http://reviews.llvm.org/D13820 Files:

[libunwind] r250541 - Add FreeBSD _Unwind_Ptr typedef

Author: emaste Date: Fri Oct 16 14:40:09 2015 New Revision: 250541 URL: http://llvm.org/viewvc/llvm-project?rev=250541&view=rev Log: Add FreeBSD _Unwind_Ptr typedef Differential Revision: http://reviews.llvm.org/D13820 Modified: libunwind/trunk/src/AddressSpace.hpp Modified: libunwind/trun

Re: [PATCH] D13746: [clang-tidy] add check cppcoreguidelines-pro-bounds-constant-array-index

mgehre added a comment. Fixed most comments in updated revision http://reviews.llvm.org/D13746 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Re: [PATCH] D13746: [clang-tidy] add check cppcoreguidelines-pro-bounds-constant-array-index

mgehre updated this revision to Diff 37627. mgehre marked 5 inline comments as done. mgehre added a comment. Thanks for the comments! http://reviews.llvm.org/D13746 Files: clang-tidy/cppcoreguidelines/CMakeLists.txt clang-tidy/cppcoreguidelines/CppCoreGuidelinesTidyModule.cpp clang-tidy/c

Re: [PATCH] D13746: [clang-tidy] add check cppcoreguidelines-pro-bounds-constant-array-index

mgehre added inline comments. Comment at: clang-tidy/cppcoreguidelines/ProBoundsConstantArrayIndexCheck.cpp:55 @@ +54,3 @@ + if (!IndexExpr->isIntegerConstantExpr(Index, *Result.Context, nullptr, true)) { +//Fixit would need gsl::at() +diag(Matched->getExprLoc(), "do not

Re: [PATCH] D13787: [clang-tidy] add check cppcoreguidelines-pro-type-vararg-use

mgehre added inline comments. Comment at: clang-tidy/cppcoreguidelines/ProTypeVarargUseCheck.cpp:20 @@ +19,3 @@ +void ProTypeVarargUseCheck::registerMatchers(MatchFinder *Finder) { + Finder->addMatcher(callExpr(callee(functionDecl(isVariadic(.bind("expr"), this); +} ---

Re: [PATCH] D13784: [clang-tidy] add check cppcoreguidelines-pro-type-union-access

This revision was automatically updated to reflect the committed changes. Closed by commit rL250537: [clang-tidy] add check cppcoreguidelines-pro-type-union-access (authored by mgehre). Changed prior to commit: http://reviews.llvm.org/D13784?vs=37515&id=37621#toc Repository: rL LLVM http://

Re: [PATCH] D10834: Added functions to retrieve information about variable storage in libclang and its python bindings.

> On Oct 15, 2015, at 2:06 PM, Richard Smith wrote: > > rsmith added a comment. > > Argyrios, I'd appreciate your thoughts here. > > > > Comment at: tools/libclang/CIndex.cpp:6670-6694 > @@ -6669,1 +6669,27 @@ > > +bool clang_Cursor_hasLocalStorage(CXCursor C) { > + if (C.k

Re: r250470 - Fix the subtarget features required by some x86 builtins.

Right. My current direction is going to be: "foo+bar" we can represent as "and" "foo,bar" we'll continue to represent as "or" this will lead to things like (possibly): "foo+bar, baz" - "either foo and bar, or baz." -eric On Fri, Oct 16, 2015 at 11:41 AM Justin Bogner wrote: > Hm. Well, suppo

Re: [PATCH] D13784: [clang-tidy] add check cppcoreguidelines-pro-type-union-access

mgehre marked an inline comment as done. mgehre added a comment. http://reviews.llvm.org/D13784 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

r250536 - Teach MyriadToolchain how to find its C++ header paths.

Author: jyknight Date: Fri Oct 16 13:46:26 2015 New Revision: 250536 URL: http://llvm.org/viewvc/llvm-project?rev=250536&view=rev Log: Teach MyriadToolchain how to find its C++ header paths. Also move the addLibStdCXXIncludePaths helper function from Linux to Generic_GCC. Added: cfe/trunk/te

[clang-tools-extra] r250537 - [clang-tidy] add check cppcoreguidelines-pro-type-union-access

Author: mgehre Date: Fri Oct 16 13:46:30 2015 New Revision: 250537 URL: http://llvm.org/viewvc/llvm-project?rev=250537&view=rev Log: [clang-tidy] add check cppcoreguidelines-pro-type-union-access Summary: This check flags all access to members of unions. Passing unions as a whole is not flagged.

Re: [PATCH] D13820: [libunwind] Add FreeBSD _Unwind_Ptr typedef

jroelofs added a subscriber: jroelofs. jroelofs added a comment. LGTM http://reviews.llvm.org/D13820 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Re: r250470 - Fix the subtarget features required by some x86 builtins.

Hm. Well, supporting both "and" and "or" combinations here sounds like an unpleasant path to go down. I guess the question is, which is weirder? - With fma, we have fma4 which is basically a synonym as far as intrinsics go - some chips have 3-argument versions and some have 4, but I don't thin

[PATCH] D13822: Support linking against OpenMP runtime on FreeBSD.

dim created this revision. dim added reviewers: emaste, joerg, theraven. dim added a subscriber: cfe-commits. Similar to rL248426 (which was a followup to rL248379 and rL248424), add the required libraries for OpenMP on the linker command line, and update the test case. http://reviews.llvm.org/D1

[PATCH] D13820: [libunwind] Add FreeBSD _Unwind_Ptr typedef

emaste created this revision. emaste added a subscriber: cfe-commits. http://reviews.llvm.org/D13820 Files: src/AddressSpace.hpp Index: src/AddressSpace.hpp === --- src/AddressSpace.hpp +++ src/AddressSpace.hpp @@ -35,7 +35,11 @@

Re: [PATCH] D13786: [Sema] Implement __make_integer_seq

majnemer updated this revision to Diff 37612. majnemer added a comment. - Add an llvm_unreachable to ASTDeclReader::VisitBuiltinTemplateDecl - Address Richard's review comments. - Add logic to check [intseq.intseq]p1. http://reviews.llvm.org/D13786 Files: include/clang/AST/ASTContext.h incl

Re: [PATCH] D13746: [clang-tidy] add check cppcoreguidelines-pro-bounds-constant-array-index

sbenza added a comment. Thanks for the patch. A few comments below. Comment at: clang-tidy/cppcoreguidelines/ProBoundsConstantArrayIndexCheck.cpp:23 @@ +22,3 @@ + + Finder->addMatcher(arraySubscriptExpr(hasBase(ignoringImpCasts(hasType(constantArrayType().bind("type", +

Re: [PATCH] D13784: [clang-tidy] add check cppcoreguidelines-pro-type-union-access

sbenza added inline comments. Comment at: clang-tidy/cppcoreguidelines/ProTypeUnionAccessCheck.cpp:20 @@ +19,3 @@ +void ProTypeUnionAccessCheck::registerMatchers(MatchFinder *Finder) { + Finder->addMatcher(memberExpr(hasObjectExpression(hasType(recordDecl(isUnion().bind("exp

Re: [PATCH] D13304: Avoid inlining in throw statement

junbuml added a comment. I just want to ping one more time to see if there is any objection about the basic idea of this change. If the basic idea itself is acceptable, then I want to find the best way to get idea in. Please let me know any new suggestion or any opinion about moving this imple

Re: [PATCH] D13787: [clang-tidy] add check cppcoreguidelines-pro-type-vararg-use

sbenza added inline comments. Comment at: clang-tidy/cppcoreguidelines/ProTypeVarargUseCheck.cpp:20 @@ +19,3 @@ +void ProTypeVarargUseCheck::registerMatchers(MatchFinder *Finder) { + Finder->addMatcher(callExpr(callee(functionDecl(isVariadic(.bind("expr"), this); +} ---

Re: [PATCH] D13784: [clang-tidy] add check cppcoreguidelines-pro-type-union-access

sbenza accepted this revision. sbenza added a comment. This revision is now accepted and ready to land. Seems straightforward. http://reviews.llvm.org/D13784 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailm

Re: r250496 - [X86] Add sse4.2 feature name to CRC32 builtins.

Thanks Craig! -eric On Thu, Oct 15, 2015 at 10:27 PM Craig Topper via cfe-commits < cfe-commits@lists.llvm.org> wrote: > Author: ctopper > Date: Fri Oct 16 00:25:15 2015 > New Revision: 250496 > > URL: http://llvm.org/viewvc/llvm-project?rev=250496&view=rev > Log: > [X86] Add sse4.2 feature name

Re: [PATCH] D13813: Teach MyriadToolchain how to find its C++ header paths.

dougk accepted this revision. dougk added a comment. This revision is now accepted and ready to land. I'd have titled the CL such that emphasis on what people might find generally useful: "Move addLibStdCXXIncludePaths method from Linux to Generic_GCC .. and incidentally make MyriadToolchain use

Re: [PATCH] D13549: Added new options to ClangFormat VSIX package.

zturner added a comment. Oh I see. Makes sense then. http://reviews.llvm.org/D13549 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Re: [PATCH] D13810: Replacements in different files do not overlap.

angelgarcia updated this revision to Diff 37603. angelgarcia added a comment. In both files. http://reviews.llvm.org/D13810 Files: clang-tidy/ClangTidyDiagnosticConsumer.cpp test/clang-tidy/Inputs/overlapping/ test/clang-tidy/Inputs/overlapping/o.h test/clang-tidy/overlapping.cpp Index

[clang-tools-extra] r250523 - Replacements in different files do not overlap.

Author: angelgarcia Date: Fri Oct 16 11:15:27 2015 New Revision: 250523 URL: http://llvm.org/viewvc/llvm-project?rev=250523&view=rev Log: Replacements in different files do not overlap. Summary: Prevent clang-tidy from discarding fixes that are in different files but happen to have the same file

Re: [PATCH] D13810: Replacements in different files do not overlap.

This revision was automatically updated to reflect the committed changes. Closed by commit rL250523: Replacements in different files do not overlap. (authored by angelgarcia). Changed prior to commit: http://reviews.llvm.org/D13810?vs=37603&id=37604#toc Repository: rL LLVM http://reviews.ll

Re: [PATCH] D13810: Replacements in different files do not overlap.

angelgarcia updated this revision to Diff 37602. angelgarcia added a comment. Use "not" instead of "!". http://reviews.llvm.org/D13810 Files: clang-tidy/ClangTidyDiagnosticConsumer.cpp test/clang-tidy/Inputs/overlapping/ test/clang-tidy/Inputs/overlapping/o.h test/clang-tidy/overlapping

Re: [PATCH] D13810: Replacements in different files do not overlap.

bkramer accepted this revision. bkramer added a reviewer: bkramer. bkramer added a comment. test looks good too, thanks! http://reviews.llvm.org/D13810 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/lis

Re: [PATCH] D13810: Replacements in different files do not overlap.

angelgarcia updated this revision to Diff 37600. angelgarcia added a comment. Add a test. http://reviews.llvm.org/D13810 Files: clang-tidy/ClangTidyDiagnosticConsumer.cpp test/clang-tidy/Inputs/overlapping/ test/clang-tidy/Inputs/overlapping/o.h test/clang-tidy/overlapping.cpp Index: t

Re: [PATCH] D13549: Added new options to ClangFormat VSIX package.

curdeius added a comment. > Where is the code in the CL that handles extracting that value from a JSON > string? Because it looks like you're just building an array list of the > trivial non-JSON style names, so why couldn't that be an enum? I don't know > mucha bout clang-format, but looking

Re: [PATCH] D13549: Added new options to ClangFormat VSIX package.

zturner added a comment. In http://reviews.llvm.org/D13549#268701, @curdeius wrote: > Hi Zachary, just to answer your comments. I have done it on purpose not to > use enum, because clang-format style can be actually a JSON string, e.g. > `{BasedOnStyle: "LLVM", IndentWidth: 4}`, so it wouldn't

Re: [PATCH] D10305: [Clang Static Analyzer] Bug identification

zaks.anna added a comment. > Should we require the generation of old hashes once a change is introduced, > or should we expect users > who rely on old hash to maintain the old hash generation as an out of tree > patch? We should maintain the old hashes, at least for a while, if there are peo

[PATCH] D13813: Teach MyriadToolchain how to find its C++ header paths.

jyknight created this revision. jyknight added a reviewer: dougk. jyknight added a subscriber: cfe-commits. Herald added a subscriber: jyknight. Also move the addLibStdCXXIncludePaths helper function from Linux to Generic_GCC. http://reviews.llvm.org/D13813 Files: lib/Driver/ToolChains.cpp l

Re: [PATCH] D13796: [libcxx] Use "-stdlib=libc++" when possible instead of '-nodefaultlibs' in the test suite.

jroelofs added inline comments. Comment at: test/libcxx/test/config.py:364 @@ +363,3 @@ +deduced_use_stdlib_eq_libcxx = (self.cxx.isClang() and +cxx_abi == 'none' and +not use_llvm_unwinder) --

r250514 - PS4: Make sure to add the sanitizer runtime before any linker input

Author: filcab Date: Fri Oct 16 10:07:48 2015 New Revision: 250514 URL: http://llvm.org/viewvc/llvm-project?rev=250514&view=rev Log: PS4: Make sure to add the sanitizer runtime before any linker input Modified: cfe/trunk/lib/Driver/Tools.cpp Modified: cfe/trunk/lib/Driver/Tools.cpp URL: htt

r250515 - PS4: Add tests for rtti/vptr-sanitizer interaction

Author: filcab Date: Fri Oct 16 10:07:56 2015 New Revision: 250515 URL: http://llvm.org/viewvc/llvm-project?rev=250515&view=rev Log: PS4: Add tests for rtti/vptr-sanitizer interaction Modified: cfe/trunk/test/Driver/rtti-options.cpp Modified: cfe/trunk/test/Driver/rtti-options.cpp URL: http

r250516 - [PS4] Add missing tests for -fsanitize=...

Author: filcab Date: Fri Oct 16 10:08:01 2015 New Revision: 250516 URL: http://llvm.org/viewvc/llvm-project?rev=250516&view=rev Log: [PS4] Add missing tests for -fsanitize=... Modified: cfe/trunk/test/Driver/fsanitize.c cfe/trunk/test/Driver/sanitizer-ld.c Modified: cfe/trunk/test/Driver

[PATCH] D13811: [clang-format] AllowShortFunctionsOnASingleLine: true didn't work with BreakBeforeBraces: Linux/Allman.

curdeius created this revision. curdeius added a reviewer: djasper. curdeius added a subscriber: cfe-commits. Herald added a subscriber: klimek. This fixes bug 25192. See https://llvm.org/bugs/show_bug.cgi?id=25192. http://reviews.llvm.org/D13811 Files: lib/Format/UnwrappedLineFormatter.cpp

Re: [PATCH] D12359: New warning -Wnonconst-parameter when a pointer parameter can be const

danielmarjamaki updated this revision to Diff 37584. danielmarjamaki marked 2 inline comments as done. danielmarjamaki added a comment. Minor fixes from previous patch. Added some more testcases. http://reviews.llvm.org/D12359 Files: include/clang/AST/Decl.h include/clang/Basic/DiagnosticGr

Re: [PATCH] D13810: Replacements in different files do not overlap.

klimek accepted this revision. klimek added a comment. This revision is now accepted and ready to land. lg http://reviews.llvm.org/D13810 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-comm

Re: [PATCH] D13810: Replacements in different files do not overlap.

bkramer added a subscriber: bkramer. bkramer added a comment. Is there a way to unittest this? http://reviews.llvm.org/D13810 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D13810: Replacements in different files do not overlap.

angelgarcia created this revision. angelgarcia added a reviewer: klimek. angelgarcia added subscribers: cfe-commits, alexfh. Prevent clang-tidy from discarding fixes that are in different files but happen to have the same file offset. http://reviews.llvm.org/D13810 Files: clang-tidy/ClangTidy

Re: [PATCH] D12359: New warning -Wnonconst-parameter when a pointer parameter can be const

danielmarjamaki updated this revision to Diff 37582. danielmarjamaki marked 5 inline comments as done. danielmarjamaki added a comment. One more work in progress patch. I have moved the NonConstUse to VarDecl. I turned on Wnonconst-parameter by default. This had a very positive effect; I saw FP

Re: [PATCH] D10305: [Clang Static Analyzer] Bug identification

phillip.power added a comment. In http://reviews.llvm.org/D10305#268795, @xazax.hun wrote: > > How close is "the near future"? I would like to start using the hashing > > feature in the next couple of weeks. If your checker identification > > improvements are a long time out, I would like you

[PATCH] D13800: ccc-analyzer: Fix -isystem value passing

Lekensteyn created this revision. Lekensteyn added a reviewer: krememek. Lekensteyn added a subscriber: cfe-commits. The previous and current regex are broken. -[D,I,Usystem] matches "-D", "-,", "-I", "-U", "-s" "-y", etc. Besides that, "-isystem /foo" gets interpreted as "-i" with a non-empty v

Re: [PATCH] D10305: [Clang Static Analyzer] Bug identification

phillip.power added a comment. In http://reviews.llvm.org/D10305#262534, @xazax.hun wrote: > - Should we require the generation of old hashes once a change is introduced, > or should we expect users who rely on old hash to maintain the old hash > generation as an out of tree patch? I will lik

[PATCH] D13803: [OPENMP] Make -fopenmp to turn on OpenMP support by default, clang part

ABataev created this revision. ABataev added a reviewer: chandlerc. ABataev added subscribers: hfinkel, fraggamuffin, ejstotzer, cfe-commits. Patch turns on OpenMP support in clang by default after fixing OpenMP buildbots. http://reviews.llvm.org/D13803 Files: CMakeLists.txt docs/UsersManual

[PATCH] D13802: [OPENMP] Make -fopenmp to turn on OpenMP support by default.

ABataev created this revision. ABataev added a reviewer: chandlerc. ABataev added subscribers: hfinkel, fraggamuffin, ejstotzer, cfe-commits, llvm-commits. Patch turns on OpenMP support in clang by default after fixing OpenMP buildbots. http://reviews.llvm.org/D13802 Files: configure docs/G

Re: [PATCH] D10305: [Clang Static Analyzer] Bug identification

xazax.hun added a comment. In http://reviews.llvm.org/D10305#268777, @phillip.power wrote: > In http://reviews.llvm.org/D10305#262534, @xazax.hun wrote: > > > - Should we require the generation of old hashes once a change is > > introduced, or should we expect users who rely on old hash to maint

Re: [PATCH] D13739: [libcxx] Make libc++.so a linker script by default on most platforms.

vkalintiris added a subscriber: vkalintiris. Comment at: cmake/Modules/HandleOutOfTreeLLVM.cmake:123-133 @@ +122,13 @@ + else(WIN32) +if(UNIX) + set(LLVM_ON_WIN32 0) + set(LLVM_ON_UNIX 1) + if(APPLE) +set(LLVM_HAVE_LINK_VERSION_SCRIPT 0) + else(APP

[clang-tools-extra] r250510 - Empty undefined static variable -> local variable.

Author: d0k Date: Fri Oct 16 07:11:15 2015 New Revision: 250510 URL: http://llvm.org/viewvc/llvm-project?rev=250510&view=rev Log: Empty undefined static variable -> local variable. Resolves a -Wundefined-internal warning from clang. Modified: clang-tools-extra/trunk/clang-tidy/ClangTidyDiagn

[clang-tools-extra] r250509 - Fix overlapping replacements in clang-tidy.

Author: angelgarcia Date: Fri Oct 16 06:43:49 2015 New Revision: 250509 URL: http://llvm.org/viewvc/llvm-project?rev=250509&view=rev Log: Fix overlapping replacements in clang-tidy. Summary: Prevent clang-tidy from applying fixes to errors that overlap with other errors' fixes, with one exceptio

[libcxx] r250508 - Fix an unfortunate yet old typo that never got attention before r250507.

Author: d0k Date: Fri Oct 16 06:26:26 2015 New Revision: 250508 URL: http://llvm.org/viewvc/llvm-project?rev=250508&view=rev Log: Fix an unfortunate yet old typo that never got attention before r250507. Should fix the xcode libc++ build. Modified: libcxx/trunk/src/stdexcept.cpp Modified: li

  1   2   >