Re: r250470 - Fix the subtarget features required by some x86 builtins.

Correct you avx512vl means it support 128 and 256-bit vectors. avx512bw means it supports byte and word elements. So you actually need both. On Thu, Oct 15, 2015 at 11:57 PM, Eric Christopher wrote: > The comma separated list is currently represented as "one of these". I > couldn't parse your fi

Re: r250470 - Fix the subtarget features required by some x86 builtins.

The comma separated list is currently represented as "one of these". I couldn't parse your first sentence, for the avx512 ones are you saying that it requires both and not just one of the options? -eric On Thu, Oct 15, 2015 at 11:55 PM Craig Topper wrote: > So for the AVX512 ones that list 2 fe

Re: r250470 - Fix the subtarget features required by some x86 builtins.

So for the AVX512 ones that list 2 features those features are both required, but for FMA you need either one of the features but not both. What is the comma separated list currently implemented as? On Thu, Oct 15, 2015 at 3:46 PM, Eric Christopher via cfe-commits < cfe-commits@lists.llvm.org> wro

r250498 - [X86] Add fxsr feature name for fxsave/fxrestore builtins.

Author: ctopper Date: Fri Oct 16 01:22:36 2015 New Revision: 250498 URL: http://llvm.org/viewvc/llvm-project?rev=250498&view=rev Log: [X86] Add fxsr feature name for fxsave/fxrestore builtins. Modified: cfe/trunk/include/clang/Basic/BuiltinsX86.def cfe/trunk/include/clang/Driver/Options.t

Re: [PATCH] D13786: [Sema] Implement __make_integer_seq

majnemer updated this revision to Diff 37558. majnemer marked 2 inline comments as done. majnemer added a comment. - Address Richard's review comments. http://reviews.llvm.org/D13786 Files: include/clang/AST/ASTContext.h include/clang/AST/DataRecursiveASTVisitor.h include/clang/AST/DeclTe

r250496 - [X86] Add sse4.2 feature name to CRC32 builtins.

Author: ctopper Date: Fri Oct 16 00:25:15 2015 New Revision: 250496 URL: http://llvm.org/viewvc/llvm-project?rev=250496&view=rev Log: [X86] Add sse4.2 feature name to CRC32 builtins. Modified: cfe/trunk/include/clang/Basic/BuiltinsX86.def Modified: cfe/trunk/include/clang/Basic/BuiltinsX86.d

r250495 - [X86] Add proper feature name to some avx512dq builtins.

Author: ctopper Date: Fri Oct 16 00:25:04 2015 New Revision: 250495 URL: http://llvm.org/viewvc/llvm-project?rev=250495&view=rev Log: [X86] Add proper feature name to some avx512dq builtins. Modified: cfe/trunk/include/clang/Basic/BuiltinsX86.def Modified: cfe/trunk/include/clang/Basic/Built

Re: [PATCH] D13330: Implement __attribute__((unique_instantiation))

loladiro updated this revision to Diff 37555. loladiro added a comment. Address review comments and clang-format. http://reviews.llvm.org/D13330 Files: include/clang/AST/ASTContext.h include/clang/Basic/Attr.td include/clang/Basic/AttrDocs.td include/clang/Basic/DiagnosticSemaKinds.td

Re: [PATCH] D13330: Implement __attribute__((unique_instantiation))

loladiro added inline comments. Comment at: include/clang/Basic/AttrDocs.td:1638 @@ +1637,3 @@ + +Note that to ensure correct execution the user MUST make certain that no +other translation unit has an implicit instantiation of the same entity. In aaron.ballman wr

Re: [libcxx] r250469 - [libcxx] Make libc++.so a linker script by default on most platforms.

On Thu, Oct 15, 2015 at 3:41 PM, Eric Fiselier via cfe-commits < cfe-commits@lists.llvm.org> wrote: > Author: ericwf > Date: Thu Oct 15 17:41:51 2015 > New Revision: 250469 > > URL: http://llvm.org/viewvc/llvm-project?rev=250469&view=rev > Log: > [libcxx] Make libc++.so a linker script by default

Re: [PATCH] D13357: [Concepts] Diagnose when 'concept' is specified on a specialization

faisalv added inline comments. Comment at: include/clang/AST/Decl.h:1577 @@ -1576,2 +1576,3 @@ bool IsConstexpr : 1; + bool IsConcept : 1; My inclination would have been to add this bit to FunctionTemplateDecl, instead of to every FunctionDecl - since not e

Re: [PATCH] D13786: [Sema] Implement __make_integer_seq

EricWF added a subscriber: EricWF. EricWF added a comment. Cool! I imagine that a lot of parts of libc++ could benefit from this. Having something like this that slices parameter packs would probably help libc++ compile times for tuple. Is that something your considering as well? http://review

Re: [PATCH] D12821: Allow for C's "writing off the end" idiom in __builtin_object_size

george.burgess.iv closed this revision. george.burgess.iv marked 3 inline comments as done. george.burgess.iv added a comment. r250488. Thanks for the review! http://reviews.llvm.org/D12821 ___ cfe-commits mailing list cfe-commits@lists.llvm.org htt

r250488 - Make __builtin_object_size more conservative

Author: gbiv Date: Thu Oct 15 20:49:01 2015 New Revision: 250488 URL: http://llvm.org/viewvc/llvm-project?rev=250488&view=rev Log: Make __builtin_object_size more conservative r246877 made __builtin_object_size substantially more aggressive with unknown bases if Type=1 or Type=3, which causes iss

[PATCH] D13796: [libcxx] Use "-stdlib=libc++" when possible instead of '-nodefaultlibs' in the test suite.

EricWF created this revision. EricWF added reviewers: mclow.lists, danalbert, jroelofs. EricWF added a subscriber: cfe-commits. Currently we use '-nodefaultlibs' when building and running the libc++ tests. However we should prefer using '-stdlib=libc++'. This patch automatically detects when the

Re: [libcxx] r249929 - Split out of .

> On Oct 15, 2015, at 1:41 PM, Richard Smith wrote: > > On Thu, Oct 15, 2015 at 12:03 PM, Manman Ren via cfe-commits > mailto:cfe-commits@lists.llvm.org>> wrote: > >> On Oct 15, 2015, at 11:25 AM, Richard Smith > > wrote: >> >> I assume the code in question has a

Re: [PATCH] D13795: Prefer functions with true enable_if conditions when attempting to resolve the address of an overload

This revision was automatically updated to reflect the committed changes. Closed by commit rL250486: [Sema] Fix address-of + enable_if overloading logic (authored by gbiv). Changed prior to commit: http://reviews.llvm.org/D13795?vs=37545&id=37552#toc Repository: rL LLVM http://reviews.llvm.

r250486 - [Sema] Fix address-of + enable_if overloading logic

Author: gbiv Date: Thu Oct 15 20:17:38 2015 New Revision: 250486 URL: http://llvm.org/viewvc/llvm-project?rev=250486&view=rev Log: [Sema] Fix address-of + enable_if overloading logic Previously, our logic when taking the address of an overloaded function would not consider enable_if attributes, s

Re: [PATCH] D13795: Prefer functions with true enable_if conditions when attempting to resolve the address of an overload

rsmith accepted this revision. rsmith added a comment. This revision is now accepted and ready to land. Looks great, thanks! Comment at: lib/Sema/SemaOverload.cpp:8413-8414 @@ +8412,4 @@ +// Cand1's first N enable_if attributes have precisely the same conditions as +// Cand2's f

Re: [PATCH] D13786: [Sema] Implement __make_integer_seq

rsmith added inline comments. Comment at: include/clang/AST/TemplateName.h:93-100 @@ +92,10 @@ + +/// \brief A structure for storing the information associated with an +/// builtin template name. +class BuiltinTemplateStorage : public UncommonTemplateNameStorage { + friend class

[PATCH] D13795: Prefer functions with true enable_if conditions when attempting to resolve the address of an overload

george.burgess.iv created this revision. george.burgess.iv added a reviewer: rsmith. george.burgess.iv added a subscriber: cfe-commits. Our overload resolution logic considers some candidate A better than some candidate B if the set of A's enable_if conditions is a strict superset of the set of

r250477 - Add "-Wc++11-inline-namespace" so that libc++ can use -pedantic in C++03.

Author: ericwf Date: Thu Oct 15 19:31:36 2015 New Revision: 250477 URL: http://llvm.org/viewvc/llvm-project?rev=250477&view=rev Log: Add "-Wc++11-inline-namespace" so that libc++ can use -pedantic in C++03. Summary: The title says it all. Reviewers: rsmith Subscribers: cfe-commits Differential

Re: [PATCH] D12821: Allow for C's "writing off the end" idiom in __builtin_object_size

rsmith accepted this revision. rsmith added a comment. This revision is now accepted and ready to land. Some minor typographical comments. Please add some tests for the union case, then this LGTM. Comment at: lib/AST/ExprConstant.cpp:6333-6336 @@ +6332,6 @@ +if (BaseType->i

r250475 - Mark this test as requiring and x86 registered target.

Author: echristo Date: Thu Oct 15 19:14:36 2015 New Revision: 250475 URL: http://llvm.org/viewvc/llvm-project?rev=250475&view=rev Log: Mark this test as requiring and x86 registered target. Modified: cfe/trunk/test/CodeGen/target-builtin-noerror.c Modified: cfe/trunk/test/CodeGen/target-buil

Re: [PATCH] D13790: Add "-Wc++11-inline-namespace" so that libc++ can use -pedantic in C++03.

rsmith accepted this revision. rsmith added a comment. This revision is now accepted and ready to land. LGTM http://reviews.llvm.org/D13790 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-co

Re: [libcxx] r249738 - Split out of .

On Thu, Oct 15, 2015 at 2:57 PM, Adrian Prantl via cfe-commits < cfe-commits@lists.llvm.org> wrote: > On Oct 15, 2015, at 2:51 PM, Alex Rosenberg wrote: > > On Oct 15, 2015, at 2:20 PM, Adrian Prantl via cfe-commits < > cfe-commits@lists.llvm.org> wrote: > > > On Oct 15, 2015, at 2:09 PM, Adrian

Re: [libcxx] r249738 - Split out of .

On Thu, Oct 15, 2015 at 2:57 PM, Adrian Prantl via cfe-commits < cfe-commits@lists.llvm.org> wrote: > On Oct 15, 2015, at 2:51 PM, Alex Rosenberg wrote: > > On Oct 15, 2015, at 2:20 PM, Adrian Prantl via cfe-commits < > cfe-commits@lists.llvm.org> wrote: > > > On Oct 15, 2015, at 2:09 PM, Adrian

r250473 - Add an error when calling a builtin that requires features that don't

Author: echristo Date: Thu Oct 15 18:47:11 2015 New Revision: 250473 URL: http://llvm.org/viewvc/llvm-project?rev=250473&view=rev Log: Add an error when calling a builtin that requires features that don't match the feature set of the function that they're being called from. This ensures that we c

[libcxx] r250472 - Re-enable linker scripts after fixing bad CMake

Author: ericwf Date: Thu Oct 15 18:04:54 2015 New Revision: 250472 URL: http://llvm.org/viewvc/llvm-project?rev=250472&view=rev Log: Re-enable linker scripts after fixing bad CMake Modified: libcxx/trunk/CMakeLists.txt libcxx/trunk/lib/CMakeLists.txt Modified: libcxx/trunk/CMakeLists.txt

[libcxx] r250471 - Quickly fix bad commit

Author: ericwf Date: Thu Oct 15 17:51:50 2015 New Revision: 250471 URL: http://llvm.org/viewvc/llvm-project?rev=250471&view=rev Log: Quickly fix bad commit Modified: libcxx/trunk/CMakeLists.txt Modified: libcxx/trunk/CMakeLists.txt URL: http://llvm.org/viewvc/llvm-project/libcxx/trunk/CMake

r250470 - Fix the subtarget features required by some x86 builtins.

Author: echristo Date: Thu Oct 15 17:46:02 2015 New Revision: 250470 URL: http://llvm.org/viewvc/llvm-project?rev=250470&view=rev Log: Fix the subtarget features required by some x86 builtins. Update the fma builtins to be fma/fma4 until some we can find some documentation either way. Update a c

[libcxx] r250469 - [libcxx] Make libc++.so a linker script by default on most platforms.

Author: ericwf Date: Thu Oct 15 17:41:51 2015 New Revision: 250469 URL: http://llvm.org/viewvc/llvm-project?rev=250469&view=rev Log: [libcxx] Make libc++.so a linker script by default on most platforms. Summary: This patch turns on `LIBCXX_ENABLE_ABI_LINKER_SCRIPT` by default whenever `LLVM_HAVE

Re: [PATCH] D13785: [clang-tidy] add cert's VariadicFunctionDefCheck as cppcoreguidelines-pro-type-vararg-def

This revision was automatically updated to reflect the committed changes. Closed by commit rL250468: [clang-tidy] add cert's VariadicFunctionDefCheck as cppcoreguidelines-pro… (authored by mgehre). Changed prior to commit: http://reviews.llvm.org/D13785?vs=37516&id=37532#toc Repository: rL L

[clang-tools-extra] r250468 - [clang-tidy] add cert's VariadicFunctionDefCheck as cppcoreguidelines-pro-type-vararg-def

Author: mgehre Date: Thu Oct 15 17:40:45 2015 New Revision: 250468 URL: http://llvm.org/viewvc/llvm-project?rev=250468&view=rev Log: [clang-tidy] add cert's VariadicFunctionDefCheck as cppcoreguidelines-pro-type-vararg-def Summary: Import the cert check for variadic function definitions into cpp

Re: [PATCH] D13357: [Concepts] Diagnose when 'concept' is specified on a specialization

nwilson updated this revision to Diff 37529. nwilson added a comment. Addressing Richard's other comment regarding the FunctionDecl being declared a concept check. Also, remove setting the FunctionDecl being Invalid in the Specialization check since the downstream parts of Clang should look at t

[PATCH] D13790: Add "-Wc++11-inline-namespace" so that libc++ can use -pedantic in C++03.

EricWF created this revision. EricWF added a reviewer: rsmith. EricWF added a subscriber: cfe-commits. The title says it all. http://reviews.llvm.org/D13790 Files: include/clang/Basic/DiagnosticGroups.td include/clang/Basic/DiagnosticParseKinds.td Index: include/clang/Basic/DiagnosticParseK

Re: [PATCH] D13785: [clang-tidy] add cert's VariadicFunctionDefCheck as cppcoreguidelines-pro-type-vararg-def

mgehre added a comment. I have commit privileges :-) http://reviews.llvm.org/D13785 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Re: [PATCH] D13785: [clang-tidy] add cert's VariadicFunctionDefCheck as cppcoreguidelines-pro-type-vararg-def

aaron.ballman accepted this revision. aaron.ballman added a comment. This revision is now accepted and ready to land. LGTM! (If you haven't already gotten commit privileges, now would be a good time to get them -- I will be out of town for two weeks starting Saturday, and alexfh is also currentl

Re: [libcxx] r249738 - Split out of .

> On Oct 15, 2015, at 2:51 PM, Alex Rosenberg wrote: > > On Oct 15, 2015, at 2:20 PM, Adrian Prantl via cfe-commits > mailto:cfe-commits@lists.llvm.org>> wrote: > >>> >>> On Oct 15, 2015, at 2:09 PM, Adrian Prantl via cfe-commits >>> mailto:cfe-commits@lists.llvm.org>> wrote: >>>

Re: [libcxx] r249738 - Split out of .

On Oct 15, 2015, at 2:20 PM, Adrian Prantl via cfe-commits wrote: >> >> On Oct 15, 2015, at 2:09 PM, Adrian Prantl via cfe-commits >> wrote: >> >>> >>> On Oct 15, 2015, at 1:42 PM, Richard Smith wrote: >>> >>> On Thu, Oct 15, 2015 at 11:14 AM, Adrian Prantl wrote: >>> On Oct 14, 20

Re: [PATCH] D13549: Added new options to ClangFormat VSIX package.

zturner added a comment. No obvious problems, mostly just style issues. Feel free to consider them optional. Comment at: tools/clang-format-vs/ClangFormat/ClangFormatPackage.cs:38 @@ +37,3 @@ +private bool sortIncludes = false; +private string style = "file"; +

Re: [libcxx] r249738 - Split out of .

> On Oct 15, 2015, at 2:09 PM, Adrian Prantl via cfe-commits > wrote: > >> >> On Oct 15, 2015, at 1:42 PM, Richard Smith > > wrote: >> >> On Thu, Oct 15, 2015 at 11:14 AM, Adrian Prantl > > wrote: >> >>> On Oct 14, 2015, at 5:07 PM, Ric

[PATCH] D13787: [clang-tidy] add check cppcoreguidelines-pro-type-vararg-use

mgehre created this revision. mgehre added reviewers: alexfh, sbenza, bkramer, aaron.ballman. mgehre added a subscriber: cfe-commits. This check flags all calls to c-style vararg functions. Passing to varargs assumes the correct type will be read. This is fragile because it cannot generally be en

Re: [libcxx] r249738 - Split out of .

> On Oct 15, 2015, at 1:42 PM, Richard Smith wrote: > > On Thu, Oct 15, 2015 at 11:14 AM, Adrian Prantl > wrote: > >> On Oct 14, 2015, at 5:07 PM, Richard Smith > > wrote: >> >> Ack, there are non-modular headers in the Darwin module. =(

r250460 - Add llvm-bcanalyzer to list of clang test dependences

Author: tejohnson Date: Thu Oct 15 16:06:53 2015 New Revision: 250460 URL: http://llvm.org/viewvc/llvm-project?rev=250460&view=rev Log: Add llvm-bcanalyzer to list of clang test dependences This addresses a bot failure from r250455, since new Misc/thinlto.c test uses it. Modified: cfe/trunk/

Re: [PATCH] D10834: Added functions to retrieve information about variable storage in libclang and its python bindings.

rsmith added a comment. Argyrios, I'd appreciate your thoughts here. Comment at: tools/libclang/CIndex.cpp:6670-6694 @@ -6669,1 +6669,27 @@ +bool clang_Cursor_hasLocalStorage(CXCursor C) { + if (C.kind != CXCursor_VarDecl) { +return false; + } + + const Decl *D = getCur

Re: [PATCH] D13786: [Sema] Implement __make_integer_seq

majnemer updated this revision to Diff 37518. majnemer added a comment. - Add an llvm_unreachable to ASTDeclReader::VisitBuiltinTemplateDecl http://reviews.llvm.org/D13786 Files: include/clang/AST/ASTContext.h include/clang/AST/DataRecursiveASTVisitor.h include/clang/AST/DeclTemplate.h

Re: [libcxx] r250256 - Workaround -pedantic flag added by LLVM

Thanks! On Thu, Oct 15, 2015 at 1:30 PM, Eric Fiselier wrote: >> It would probably make sense for libc++ to remove -Wno-pedantic before >> removing -pedantic. > > Good localized fix. Committed as r250452. `remove_flags` hack needs to die > soon :( > > On Thu, Oct 15, 2015 at 2:00 PM, Evgenii Step

Re: [PATCH] D13549: Added new options to ClangFormat VSIX package.

rnk added a comment. In http://reviews.llvm.org/D13549#267790, @klimek wrote: > We're waiting for Reid to find somebody who is good at reviewing this in > detail. > Sorry it takes a while, so far we don't have enough trusted Windows experts > in the community :( Oops, I didn't know that. Zac

[PATCH] D13786: [Sema] Implement __make_integer_seq

majnemer created this revision. majnemer added a reviewer: rsmith. majnemer added a subscriber: cfe-commits. This new builtin template allows for incredibly fast instantiations of templates like std::integer_sequence. Performance numbers follow: My work station has 64 GB of ram + 20 Xeon Cores at

[PATCH] D13785: [clang-tidy] add cert's VariadicFunctionDefCheck as cppcoreguidelines-pro-type-vararg-def

mgehre created this revision. mgehre added reviewers: alexfh, sbenza, bkramer, aaron.ballman. mgehre added a subscriber: cfe-commits. Import the cert check for variadic function definitions into cppcoreguidelines module to check part of https://github.com/isocpp/CppCoreGuidelines/blob/master/CppCo

[PATCH] D13784: [clang-tidy] add check cppcoreguidelines-pro-type-union-access

mgehre created this revision. mgehre added reviewers: alexfh, sbenza, bkramer, aaron.ballman. mgehre added a subscriber: cfe-commits. This check flags all access to members of unions. Passing unions as a whole is not flagged. Reading from a union member assumes that member was the last one writte

Re: [libcxx] r249738 - Split out of .

On Thu, Oct 15, 2015 at 11:14 AM, Adrian Prantl wrote: > > On Oct 14, 2015, at 5:07 PM, Richard Smith wrote: > > Ack, there are non-modular headers in the Darwin module. =( I seem to > recall that they're not version-locked to your compiler, so we've got to > support them as-is? > > If we can't

Re: [libcxx] r249929 - Split out of .

On Thu, Oct 15, 2015 at 12:03 PM, Manman Ren via cfe-commits < cfe-commits@lists.llvm.org> wrote: > > On Oct 15, 2015, at 11:25 AM, Richard Smith wrote: > > I assume the code in question has a "using namespace std;"? > > Yes > > I don't see any way around this other than giving up on trying to fi

r250455 - Recommit "Clang support for -flto=thin."

Author: tejohnson Date: Thu Oct 15 15:35:53 2015 New Revision: 250455 URL: http://llvm.org/viewvc/llvm-project?rev=250455&view=rev Log: Recommit "Clang support for -flto=thin." This recommits r250398 with fixes to the tests for bot failures. Add "-target x86_64-unknown-linux" to the clang invoca

Re: [PATCH] D12761: MPI-Checker patch for Clang Static Analyzer

Alexander_Droste added a comment. Sorry about the delay. Comment at: tools/clang/lib/StaticAnalyzer/Checkers/MPI-Checker/MPITypes.h:67 @@ +66,3 @@ + // Every time a request is 'set' a new 'RequestId' gets created. + // Therefore, the 'UserKind' does not need to be profiled. +

Re: [libcxx] r250256 - Workaround -pedantic flag added by LLVM

> It would probably make sense for libc++ to remove -Wno-pedantic before removing -pedantic. Good localized fix. Committed as r250452. `remove_flags` hack needs to die soon :( On Thu, Oct 15, 2015 at 2:00 PM, Evgenii Stepanov wrote: > It looks like, since libc++ removes -pedantic, we don't need

[libcxx] r250452 - Fix handling of -Wno-pedantic

Author: ericwf Date: Thu Oct 15 15:27:15 2015 New Revision: 250452 URL: http://llvm.org/viewvc/llvm-project?rev=250452&view=rev Log: Fix handling of -Wno-pedantic Modified: libcxx/trunk/CMakeLists.txt Modified: libcxx/trunk/CMakeLists.txt URL: http://llvm.org/viewvc/llvm-project/libcxx/trun

r250448 - Add the minimum target features that these tests depend upon.

Author: echristo Date: Thu Oct 15 15:04:40 2015 New Revision: 250448 URL: http://llvm.org/viewvc/llvm-project?rev=250448&view=rev Log: Add the minimum target features that these tests depend upon. Modified: cfe/trunk/test/CodeGen/adc-builtins.c cfe/trunk/test/CodeGen/builtins-x86.c Modif

r250449 - The target-feature command line option doesn't take a comma delimited

Author: echristo Date: Thu Oct 15 15:04:42 2015 New Revision: 250449 URL: http://llvm.org/viewvc/llvm-project?rev=250449&view=rev Log: The target-feature command line option doesn't take a comma delimited string, so split them into multiple options. Modified: cfe/trunk/test/CodeGen/x86_32-xsa

Re: [libcxx] r250256 - Workaround -pedantic flag added by LLVM

Transforms it to -Wno. On Thu, Oct 15, 2015 at 12:56 PM, Eric Fiselier wrote: > Removes it because "-Wno-pedantic" incorrectly matches -pedantic? If my > guess is correct, whoops :-( > > On Thu, Oct 15, 2015 at 1:51 PM, Evgenii Stepanov > wrote: >> >> Guess what this does to the -Wno-pedantic fl

Re: [libcxx] r250256 - Workaround -pedantic flag added by LLVM

It looks like, since libc++ removes -pedantic, we don't need to add -Wno-pedantic, so I can just fix it in MSan. It would probably make sense for libc++ to remove -Wno-pedantic before removing -pedantic. On Thu, Oct 15, 2015 at 12:57 PM, Evgenii Stepanov wrote: > Transforms it to -Wno. > > On Thu

Re: [libcxx] r250256 - Workaround -pedantic flag added by LLVM

Removes it because "-Wno-pedantic" incorrectly matches -pedantic? If my guess is correct, whoops :-( On Thu, Oct 15, 2015 at 1:51 PM, Evgenii Stepanov wrote: > Guess what this does to the -Wno-pedantic flag added by MSan? :) > > On Tue, Oct 13, 2015 at 4:56 PM, Eric Fiselier via cfe-commits > w

Re: [libcxx] r250256 - Workaround -pedantic flag added by LLVM

Guess what this does to the -Wno-pedantic flag added by MSan? :) On Tue, Oct 13, 2015 at 4:56 PM, Eric Fiselier via cfe-commits wrote: > Author: ericwf > Date: Tue Oct 13 18:56:33 2015 > New Revision: 250256 > > URL: http://llvm.org/viewvc/llvm-project?rev=250256&view=rev > Log: > Workaround -ped

Re: [libcxx] r249929 - Split out of .

> On Oct 15, 2015, at 11:25 AM, Richard Smith wrote: > > I assume the code in question has a "using namespace std;"? > > Yes > I don't see any way around this other than giving up on trying to fix the > function signatures here (or maybe adding a Clang feature to let us fix the > bad signat

Re: r250440 - clang-format: Basic escaping when outputting XML.

test? On Thu, Oct 15, 2015 at 11:39 AM, Daniel Jasper via cfe-commits < cfe-commits@lists.llvm.org> wrote: > Author: djasper > Date: Thu Oct 15 13:39:31 2015 > New Revision: 250440 > > URL: http://llvm.org/viewvc/llvm-project?rev=250440&view=rev > Log: > clang-format: Basic escaping when outputti

Re: [PATCH] D13549: Added new options to ClangFormat VSIX package.

djasper added a comment. While we are waiting, submitted the changes to ClangFormat.cpp in r250440. Thank you! http://reviews.llvm.org/D13549 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe

r250440 - clang-format: Basic escaping when outputting XML.

Author: djasper Date: Thu Oct 15 13:39:31 2015 New Revision: 250440 URL: http://llvm.org/viewvc/llvm-project?rev=250440&view=rev Log: clang-format: Basic escaping when outputting XML. Modified: cfe/trunk/tools/clang-format/ClangFormat.cpp Modified: cfe/trunk/tools/clang-format/ClangFormat.cp

Re: [libcxx] r249929 - Split out of .

I assume the code in question has a "using namespace std;"? I don't see any way around this other than giving up on trying to fix the function signatures here (or maybe adding a Clang feature to let us fix the bad signature). On Oct 15, 2015 11:07 AM, "Manman Ren via cfe-commits" < cfe-commits@lis

Re: [libcxx] r249738 - Split out of .

On Oct 14, 2015, at 5:07 PM, Richard Smith wrote:Ack, there are non-modular headers in the Darwin module. =( I seem to recall that they're not version-locked to your compiler, so we've got to support them as-is?If we can't turn on local submodule visibility, then we need a m

Re: [libcxx] r249929 - Split out of .

Hi Richard, This is causing a failure when building povray on iOS. Compilation error: /Users/buildslave/tmp/test-suite-externals/speccpu2006/benchspec/CPU2006/453.povray/src/fileinputoutput.cpp:364:20: error: call to 'strrchr' is ambiguous const char *p=strrchr(name, '.’); iOS.sdk/usr/incl

Re: r250418 - [CodeGen] Remove dead code. NFC.

On Thu, Oct 15, 2015 at 6:12 PM, Adrian Prantl wrote: > >> On Oct 15, 2015, at 8:29 AM, Benjamin Kramer via cfe-commits >> wrote: >> >> Author: d0k >> Date: Thu Oct 15 10:29:40 2015 >> New Revision: 250418 >> >> URL: http://llvm.org/viewvc/llvm-project?rev=250418&view=rev >> Log: >> [CodeGen] Re

r250428 - Put back doxygen comment accidentally dropped in r250418.

Author: d0k Date: Thu Oct 15 11:46:25 2015 New Revision: 250428 URL: http://llvm.org/viewvc/llvm-project?rev=250428&view=rev Log: Put back doxygen comment accidentally dropped in r250418. Modified: cfe/trunk/lib/CodeGen/CGDebugInfo.h Modified: cfe/trunk/lib/CodeGen/CGDebugInfo.h URL: http:/

Re: r250418 - [CodeGen] Remove dead code. NFC.

> On Oct 15, 2015, at 8:29 AM, Benjamin Kramer via cfe-commits > wrote: > > Author: d0k > Date: Thu Oct 15 10:29:40 2015 > New Revision: 250418 > > URL: http://llvm.org/viewvc/llvm-project?rev=250418&view=rev > Log: > [CodeGen] Remove dead code. NFC. > > Modified: >cfe/trunk/lib/CodeGen/C

r250422 - clang-format/java: Break after annotations on fields in Chromium style.

Author: nico Date: Thu Oct 15 11:03:01 2015 New Revision: 250422 URL: http://llvm.org/viewvc/llvm-project?rev=250422&view=rev Log: clang-format/java: Break after annotations on fields in Chromium style. Chromium follows the Android style guide for Java code, and that doesn't make the distinction

r250418 - [CodeGen] Remove dead code. NFC.

Author: d0k Date: Thu Oct 15 10:29:40 2015 New Revision: 250418 URL: http://llvm.org/viewvc/llvm-project?rev=250418&view=rev Log: [CodeGen] Remove dead code. NFC. Modified: cfe/trunk/lib/CodeGen/CGBuiltin.cpp cfe/trunk/lib/CodeGen/CGCall.cpp cfe/trunk/lib/CodeGen/CGCleanup.cpp cfe

Re: [PATCH] D13731: [RFC][Analyzer] Supporting function attributes in .model files.

pgousseau added a comment. In http://reviews.llvm.org/D13731#267905, @xazax.hun wrote: > Hi! Hi! Thank you for reviewing. > I have some high level questions and notes about this patch. > > I implemented the function modelling as a Google Summer of Code project and > Ted Kremenek was my men

r250416 - Add support for CloudABI/aarch64.

Author: ed Date: Thu Oct 15 10:07:07 2015 New Revision: 250416 URL: http://llvm.org/viewvc/llvm-project?rev=250416&view=rev Log: Add support for CloudABI/aarch64. The core C library has already been ported over to aarch64 successfully, meaning there is no reason to hold this change back. Modifie

Re: [PATCH] D13516: Fix overlapping replacements in clang-tidy.

angelgarcia added a comment. I implemented this, with the following addition: if several errors share the same interval, I can still apply the biggest one that was not discarded during the sweep. This way, the first example would work and in the two other examples it would just apply a random one,

r250403 - Tweak to make clang/test/Driver/ps4-linker-win.c less sinsitive of DLL path.

Author: chapuni Date: Thu Oct 15 08:51:13 2015 New Revision: 250403 URL: http://llvm.org/viewvc/llvm-project?rev=250403&view=rev Log: Tweak to make clang/test/Driver/ps4-linker-win.c less sinsitive of DLL path. - On mingw-w64, libstdc++-6.dll is used for clang.exe. The DLL might not be in Wind

r250402 - Revert "Clang support for -flto=thin." (bot failures)

Author: tejohnson Date: Thu Oct 15 08:41:51 2015 New Revision: 250402 URL: http://llvm.org/viewvc/llvm-project?rev=250402&view=rev Log: Revert "Clang support for -flto=thin." (bot failures) Rolling this back for now since there are a couple of bot failures on the new tests I added, and I won't ha

Re: [PATCH] D13516: Fix overlapping replacements in clang-tidy.

On Thu, Oct 15, 2015 at 6:29 AM, Angel Garcia wrote: > angelgarcia added a comment. > > I cannot find a way to make Daniel's idea work with equal intervals: > > In this case, fix A can be applied because B is completely contained inside > it. > A: [a, b)[c, d) > B: [a, b) > > This time, we should

Re: [PATCH] D11908: Clang support for -fthinlto.

This revision was automatically updated to reflect the committed changes. Closed by commit rL250398: Clang support for -flto=thin. (authored by tejohnson). Changed prior to commit: http://reviews.llvm.org/D11908?vs=36453&id=37478#toc Repository: rL LLVM http://reviews.llvm.org/D11908 Files

Re: [PATCH] D13516: Fix overlapping replacements in clang-tidy.

angelgarcia added a comment. I cannot find a way to make Daniel's idea work with equal intervals: In this case, fix A can be applied because B is completely contained inside it. A: [a, b)[c, d) B: [a, b) This time, we should not apply anyone: A: [a, b) B: [a, b) And here they both have to be di

Re: [PATCH] D13731: [RFC][Analyzer] Supporting function attributes in .model files.

xazax.hun added reviewers: krememek, zaks.anna, dcoughlin. xazax.hun added a comment. Hi! I have some high level questions and notes about this patch. I implemented the function modelling as a Google Summer of Code project and Ted Kremenek was my mentor. I am happy that you found an useful appl

Re: [PATCH] D13482: Revised Initial patch for PS4 toolchain

Hi Katya, On Thu, Oct 15, 2015 at 2:01 AM, Romanova, Katya < katya_roman...@playstation.sony.com> wrote: > Filipe, > > I have one question regarding the change in debug-option.c that you made > to get the builds green again… (r250294). > > > > Basically you changed the generic run line that used

r250398 - Clang support for -flto=thin.

Author: tejohnson Date: Thu Oct 15 08:08:13 2015 New Revision: 250398 URL: http://llvm.org/viewvc/llvm-project?rev=250398&view=rev Log: Clang support for -flto=thin. Summary: Add clang support for -flto=thin option, which is used to set the EmitFunctionSummary code gen option on compiles. Add -f

Re: [PATCH] D13582: [DEBUG INFO] Emit debug info for type used in explicit cast only.

ABataev added reviewers: rjmccall, dblaikie. ABataev updated this revision to Diff 37476. ABataev added a comment. Update after review http://reviews.llvm.org/D13582 Files: lib/CodeGen/CGExpr.cpp lib/CodeGen/CGExprAgg.cpp lib/CodeGen/CGExprCXX.cpp lib/CodeGen/CGExprComplex.cpp lib/Cod

r250388 - Headers: Switch some headers to LF line endings for consistency.

Author: pcc Date: Thu Oct 15 05:33:27 2015 New Revision: 250388 URL: http://llvm.org/viewvc/llvm-project?rev=250388&view=rev Log: Headers: Switch some headers to LF line endings for consistency. Modified: cfe/trunk/lib/Headers/avx512cdintrin.h cfe/trunk/lib/Headers/xsavecintrin.h cfe/

Re: [PATCH] D13731: [RFC][Analyzer] Supporting function attributes in .model files.

pgousseau updated this revision to Diff 37466. pgousseau added a comment. Fix incorrect caching of model files declarations. http://reviews.llvm.org/D13731 Files: include/clang/Analysis/AnalysisContext.h include/clang/Analysis/CodeInjector.h include/clang/StaticAnalyzer/Frontend/FrontendA

Re: [PATCH] D13516: Fix overlapping replacements in clang-tidy.

angelgarcia updated this revision to Diff 37465. angelgarcia added a comment. I did several mutations and the only case were a test didn't break was when I removed the sort, but it turned out that we don't need it. I changed the tests to apply the checks in both orders to ensure that a test will

[PATCH] Add customizable clang-format options variable

Hi. At r249567, '-sort-includes' option is set to clang-format-region command in clang-format.el. This option can be used only with development version clang-format. and users get error if they use old version clang-format. And I suppose clang-format options should not be hard corded and should be

Re: [PATCH] D12358: [Analyzer] Widening loops which do not exit

seaneveson marked 3 inline comments as done. seaneveson added a comment. In http://reviews.llvm.org/D12358#266391, @dcoughlin wrote: > I think this is an acceptable loss of precision because, in general, it is > unlikely that a concrete-bounded loop will be executed *exactly* > maxBlockVisitOnP

Re: [PATCH] D12358: [Analyzer] Widening loops which do not exit

seaneveson updated this revision to Diff 37462. seaneveson added a comment. Set CausedByPointerEscape to true Check if the loop has already been exited before widening Changed tests to use void clang_analyze_eval(int) Added variable bound loop tests Added nested loop tests http://reviews.llvm.or

Re: [PATCH] D13549: Added new options to ClangFormat VSIX package.

klimek added a comment. We're waiting for Reid to find somebody who is good at reviewing this in detail. Sorry it takes a while, so far we don't have enough trusted Windows experts in the community :( http://reviews.llvm.org/D13549 ___ cfe-commits

Re: [PATCH] D13549: Added new options to ClangFormat VSIX package.

curdeius added a comment. Ping? http://reviews.llvm.org/D13549 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Re: [PATCH] D13744: Update clang as per D13683

Done in r250373. Thanks! -eric On Wed, Oct 14, 2015 at 2:18 PM Amaury SECHET < deadalnix+llvmrev...@gmail.com> wrote: > deadalnix created this revision. > deadalnix added reviewers: chandlerc, dexonsmith, echristo. > deadalnix added a subscriber: cfe-commits. > > This diffs remove use of deprec