> It would probably make sense for libc++ to remove -Wno-pedantic before removing -pedantic.
Good localized fix. Committed as r250452. `remove_flags` hack needs to die soon :( On Thu, Oct 15, 2015 at 2:00 PM, Evgenii Stepanov <eugeni.stepa...@gmail.com > wrote: > It looks like, since libc++ removes -pedantic, we don't need to add > -Wno-pedantic, so I can just fix it in MSan. It would probably make > sense for libc++ to remove -Wno-pedantic before removing -pedantic. > > On Thu, Oct 15, 2015 at 12:57 PM, Evgenii Stepanov > <eugeni.stepa...@gmail.com> wrote: > > Transforms it to -Wno. > > > > On Thu, Oct 15, 2015 at 12:56 PM, Eric Fiselier <e...@efcs.ca> wrote: > >> Removes it because "-Wno-pedantic" incorrectly matches -pedantic? If my > >> guess is correct, whoops :-( > >> > >> On Thu, Oct 15, 2015 at 1:51 PM, Evgenii Stepanov > >> <eugeni.stepa...@gmail.com> wrote: > >>> > >>> Guess what this does to the -Wno-pedantic flag added by MSan? :) > >>> > >>> On Tue, Oct 13, 2015 at 4:56 PM, Eric Fiselier via cfe-commits > >>> <cfe-commits@lists.llvm.org> wrote: > >>> > Author: ericwf > >>> > Date: Tue Oct 13 18:56:33 2015 > >>> > New Revision: 250256 > >>> > > >>> > URL: http://llvm.org/viewvc/llvm-project?rev=250256&view=rev > >>> > Log: > >>> > Workaround -pedantic flag added by LLVM > >>> > > >>> > Modified: > >>> > libcxx/trunk/CMakeLists.txt > >>> > > >>> > Modified: libcxx/trunk/CMakeLists.txt > >>> > URL: > >>> > > http://llvm.org/viewvc/llvm-project/libcxx/trunk/CMakeLists.txt?rev=250256&r1=250255&r2=250256&view=diff > >>> > > >>> > > ============================================================================== > >>> > --- libcxx/trunk/CMakeLists.txt (original) > >>> > +++ libcxx/trunk/CMakeLists.txt Tue Oct 13 18:56:33 2015 > >>> > @@ -198,6 +198,10 @@ include(HandleLibcxxFlags) > >>> > remove_flags(-DNDEBUG -UNDEBUG -D_DEBUG > >>> > -stdlib=libc++ -stdlib=libstdc++ -lc++abi -m32) > >>> > > >>> > +# FIXME(EricWF): See the FIXME on LIBCXX_ENABLE_PEDANTIC. > >>> > +# Remove the -pedantic flag provided by LLVM. > >>> > +remove_flags(-pedantic) > >>> > + > >>> > # Required flags > >>> > ============================================================== > >>> > add_compile_flags_if_supported(-std=c++11) > >>> > if (NOT MSVC AND NOT LIBCXX_SUPPORTS_STD_EQ_CXX11_FLAG) > >>> > > >>> > > >>> > _______________________________________________ > >>> > cfe-commits mailing list > >>> > cfe-commits@lists.llvm.org > >>> > http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits > >> > >> >
_______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
