On Thu, Oct 8, 2015 at 6:58 PM, Richard Smith wrote:
> On Thu, Oct 8, 2015 at 6:25 PM, Eric Fiselier wrote:
>
>> Patch #12 needs revision. A bunch of function definitions were moved
>> out of the std namespace and into the global.
>> That change is incorrect.
>
>
> Slightly updated version attac
ABataev updated this revision to Diff 36924.
ABataev marked 2 inline comments as done.
ABataev added a comment.
Update after review
http://reviews.llvm.org/D13546
Files:
include/clang/Basic/Attr.td
lib/AST/DeclPrinter.cpp
test/Misc/ast-print-pragmas.cpp
utils/TableGen/ClangAttrEmitter.c
Attached patch adds a test that all required functions from the C standard
library (and any required overloads) are present with the correct types,
and that the declarations in the and headers declare the
same entity as required by [depr.c.headers]p2.
On Thu, Oct 8, 2015 at 6:58 PM, Richard Smit
hintonda added a comment.
Btw, I don't have commit access, so if you are happy with this change, could
you commit it for me?
http://reviews.llvm.org/D13453
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailma
On Thu, Oct 8, 2015 at 6:25 PM, Eric Fiselier wrote:
> Patch #12 needs revision. A bunch of function definitions were moved
> out of the std namespace and into the global.
> That change is incorrect.
Slightly updated version attached. I should probably explain what's going
on here in more detai
hintonda updated this revision to Diff 36916.
hintonda added a comment.
Add support for cmake version 3, i.e., 3.0.0...
http://reviews.llvm.org/D13453
Files:
CMakeLists.txt
Index: CMakeLists.txt
===
--- CMakeLists.txt
+++ CMakeL
Author: vedantk
Date: Thu Oct 8 20:47:26 2015
New Revision: 249801
URL: http://llvm.org/viewvc/llvm-project?rev=249801&view=rev
Log:
[Sema] Add "Ty" suffix to QualType variables for clarity (NFC)
Modified:
cfe/trunk/lib/Sema/SemaExpr.cpp
Modified: cfe/trunk/lib/Sema/SemaExpr.cpp
URL:
http:
Patch #14 LGTM modulo pragmas.
On Thu, Oct 8, 2015 at 7:39 PM, Eric Fiselier wrote:
> Patch #13 LGTM after revision.
>
> a system header pragma needs to be added to the __need_wint_t path of wchar.h.
> The existing pragma also needs fixing as previously discussed.
>
> On Thu, Oct 8, 2015 at 7:25
Author: rsmith
Date: Thu Oct 8 20:41:45 2015
New Revision: 249800
URL: http://llvm.org/viewvc/llvm-project?rev=249800&view=rev
Log:
Split out of .
Added:
libcxx/trunk/include/stdlib.h
- copied, changed from r249736, libcxx/trunk/include/cstdlib
Modified:
libcxx/trunk/include/cstdl
Patch #13 LGTM after revision.
a system header pragma needs to be added to the __need_wint_t path of wchar.h.
The existing pragma also needs fixing as previously discussed.
On Thu, Oct 8, 2015 at 7:25 PM, Eric Fiselier wrote:
> Patch #12 needs revision. A bunch of function definitions were moved
Author: rsmith
Date: Thu Oct 8 20:29:09 2015
New Revision: 249798
URL: http://llvm.org/viewvc/llvm-project?rev=249798&view=rev
Log:
Split out of .
As with , skip our custom header if __need_FILE or __need___FILE is
defined.
Added:
libcxx/trunk/include/stdio.h
- copied, changed from
Patch #12 needs revision. A bunch of function definitions were moved
out of the std namespace and into the global.
That change is incorrect.
On Thu, Oct 8, 2015 at 7:09 PM, Eric Fiselier wrote:
> Patch #11 LGTM. Any reason you removed the "#pragma diagnostic ignored
> "-Wnonnull"" in test/std/d
Patch #11 LGTM. Any reason you removed the "#pragma diagnostic ignored
"-Wnonnull"" in test/std/depr/depr.c.headers/stdlib_h.pass.cpp?
I would like to leave it in so this test doesn't fail with older clang
versions.
/Eric
On Thu, Oct 8, 2015 at 6:47 PM, Eric Fiselier wrote:
> Patch #10 LGTM.
>
>
Patch #10 LGTM.
On Thu, Oct 8, 2015 at 4:28 PM, Richard Smith wrote:
> On Thu, Oct 8, 2015 at 11:50 AM, Marshall Clow
> wrote:
>>
>> On Tue, Oct 6, 2015 at 3:57 PM, Richard Smith
>> wrote:
>>>
>>> . This one is tricky:
>>>
>>> 1) There's an (undocumented) interface between the C standard librar
Author: echristo
Date: Thu Oct 8 19:35:30 2015
New Revision: 249790
URL: http://llvm.org/viewvc/llvm-project?rev=249790&view=rev
Log:
Fix a few typos in the required feature set for some of the x86
builtins:
avx512vd -> avx512vl
rdrand -> rdrnd
avx512ff -> avx512f
no functional change.
Modifie
Author: rsmith
Date: Thu Oct 8 19:26:50 2015
New Revision: 249788
URL: http://llvm.org/viewvc/llvm-project?rev=249788&view=rev
Log:
PR25118: move system_header pragma before uses of include_next to avoid
extension warnings for people finding libc++ headers via -I paths.
Modified:
libcxx/tru
The patch LGTM. However I would rather see the pragma in
wrap itself in the `#if !defined(_LIBPP_HAS_NO_SYSTEM_HEADER_PRAGMA)`.
I agree that we probably
shouldn't include "<__config>". However people are still free to add
the definition to the command line (line libc++ does when building and
test
Author: ericwf
Date: Thu Oct 8 19:17:57 2015
New Revision: 249787
URL: http://llvm.org/viewvc/llvm-project?rev=249787&view=rev
Log:
Skip NonNull sema checks in unevaluated contexts.
Summary:
Currently when a function annotated with __attribute__((nonnull)) is called in
an unevaluated context wi
EricWF updated the summary for this revision.
EricWF updated this revision to Diff 36910.
http://reviews.llvm.org/D13408
Files:
lib/Sema/SemaChecking.cpp
test/Sema/non-null-warning.c
Index: test/Sema/non-null-warning.c
===
--- t
Author: rsmith
Date: Thu Oct 8 18:44:26 2015
New Revision: 249780
URL: http://llvm.org/viewvc/llvm-project?rev=249780&view=rev
Log:
Fix test failure in C++98 mode due to imperfect static_assert emulation.
Modified:
libcxx/trunk/test/std/depr/depr.c.headers/stddef_h.pass.cpp
Modified: libcxx
Hi,
As noted in PR25118, people who include libc++'s headers via a -I path with
-pedantic_errors will see errors due to the use of #include_next. This
patch moves the #include_next after the #pragma system_header line to
suppress the error.
(For the __need_* case in , I'm not checking whether pra
chapuni accepted this revision.
This revision is now accepted and ready to land.
Comment at: CMakeLists.txt:553
@@ -552,3 +552,3 @@
-if (CLANG_BUILT_STANDALONE)
+if (CLANG_BUILT_STANDALONE OR CMAKE_VERSION VERSION_GREATER 3)
# Generate a list of CMake library targets so that
Author: hans
Date: Thu Oct 8 18:13:28 2015
New Revision: 249775
URL: http://llvm.org/viewvc/llvm-project?rev=249775&view=rev
Log:
Expose -f[no]ms-{compatibility,extensions} in clang-cl (PR25114)
These are enabled by default in clang-cl, because the whole idea is that
it should work like cl.exe,
Moved the test.
Feel free to commit it for me :)
On Oct 8, 2015, at 3:29 PM, Richard Smith
mailto:rich...@metafoo.co.uk>> wrote:
Please add the test to some existing test file for the ownership_takes
attribute, such as test/Sema/attr-ownership.c. Otherwise, LGTM.
On Thu, Oct 8, 2015 at 3:25 P
rsmith added inline comments.
Comment at: include/clang-c/Index.h:3815-3823
@@ -3814,2 +3814,11 @@
/**
+ * \brief Returns true if a variable with function scope is a non-static local
variable.
+ */
+CINDEX_LINKAGE bool clang_Cursor_hasLocalStorage(CXCursor C);
+
+/*
+ * \brief
Please add the test to some existing test file for the ownership_takes
attribute, such as test/Sema/attr-ownership.c. Otherwise, LGTM.
On Thu, Oct 8, 2015 at 3:25 PM, Adrian Zgorzalek wrote:
> Yay! It worked, thank you!
>
>
> On Oct 8, 2015, at 3:10 PM, Richard Smith wrote:
>
> On Thu, Oct 8, 2
On Thu, Oct 8, 2015 at 11:50 AM, Marshall Clow
wrote:
> On Tue, Oct 6, 2015 at 3:57 PM, Richard Smith
> wrote:
>
>> . This one is tricky:
>>
>> 1) There's an (undocumented) interface between the C standard library and
>> this header, where the macros __need_ptrdiff_t, __need_size_t,
>> __need_wc
Author: rsmith
Date: Thu Oct 8 17:25:27 2015
New Revision: 249761
URL: http://llvm.org/viewvc/llvm-project?rev=249761&view=rev
Log:
Split out of .
There are a bunch of macros (__need_size_t etc) that request just one piece of
; if any one of these is defined, we just directly include the
underl
Yay! It worked, thank you!
On Oct 8, 2015, at 3:10 PM, Richard Smith
mailto:rich...@metafoo.co.uk>> wrote:
On Thu, Oct 8, 2015 at 2:59 PM, Adrian Zgorzalek
mailto:a...@fb.com>> wrote:
Same story:
warning: 'ownership_takes' attribute only applies to functions
[-Wignored-attributes]
__attribut
On Thu, Oct 8, 2015 at 2:59 PM, Adrian Zgorzalek wrote:
> Same story:
> warning: 'ownership_takes' attribute only applies to functions
> [-Wignored-attributes]
> __attribute__((ownership_takes(__))) void f();
>^
>
Oh, I see, you're building in C, and the diagnostic here
rsmith added inline comments.
Comment at: lib/AST/ExprConstant.cpp:6311-6314
@@ +6310,6 @@
+ QualType BaseType;
+ if (auto *E = Base.dyn_cast())
+BaseType = E->getType();
+ else
+BaseType = Base.get()->getType();
+ // The outermost BaseType may be a pointer if we got a
Same story:
warning: 'ownership_takes' attribute only applies to functions
[-Wignored-attributes]
__attribute__((ownership_takes(__))) void f();
^
On Oct 8, 2015, at 2:52 PM, Richard Smith
mailto:rich...@metafoo.co.uk>> wrote:
On Thu, Oct 8, 2015 at 2:45 PM, Adrian Zgorza
Yes, these are functionally equivalent. However, the difference between
these two is that the call to f() in 1st is in sub-expression of throw
statement, while the call in 2nd is not.
If the call is in the sub-expression of throw statements, we can guarantee
that the call is only invoked to be thr
beanz updated this revision to Diff 36897.
beanz added a comment.
Updates to fix dependency mapping.
Compiler-rt will be cleaned and rebuilt if clang changes and reconfigured if
llvm-config or clang changes.
http://reviews.llvm.org/D13399
Files:
runtime/CMakeLists.txt
Index: runtime/CMakeL
On Thu, Oct 8, 2015 at 2:45 PM, Adrian Zgorzalek wrote:
>
> On Oct 8, 2015, at 2:17 PM, Richard Smith wrote:
>
> On Thu, Oct 8, 2015 at 2:10 PM, Adrian Zgorzalek via cfe-commits <
> cfe-commits@lists.llvm.org> wrote:
>
>> You are right, my bad, I thought this if covers all the cases, but
>> par
On Oct 8, 2015, at 2:17 PM, Richard Smith
mailto:rich...@metafoo.co.uk>> wrote:
On Thu, Oct 8, 2015 at 2:10 PM, Adrian Zgorzalek via cfe-commits
mailto:cfe-commits@lists.llvm.org>> wrote:
You are right, my bad, I thought this if covers all the cases, but part
could be empty.
Here is the fix
george.burgess.iv added a comment.
Friendly Ping™
http://reviews.llvm.org/D12821
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
There are some other open problems in this area:
- RecursiveASTVisitor on nested InitListExprs is currently worst-case
exponential time because it walks the syntactic and semantic forms
separately
- Tools such as "find all references to this function" need the semantic
form of every initializer, w
zaks.anna added a comment.
Now that we have a way to test symbol reaper, please, add more coverage to the
symbol-reaper.c test, including the test that Jordan mentioned. Even if it is
not fixed, it's good to include it with a FIXME note.
What is the performance impact of this change?
The chang
eugenis closed this revision.
eugenis added a comment.
r249751
Repository:
rL LLVM
http://reviews.llvm.org/D13572
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
Author: eugenis
Date: Thu Oct 8 16:21:44 2015
New Revision: 249751
URL: http://llvm.org/viewvc/llvm-project?rev=249751&view=rev
Log:
Use Triple.isAndroid() where possible.
Modified:
cfe/trunk/lib/Basic/Targets.cpp
cfe/trunk/lib/Driver/SanitizerArgs.cpp
cfe/trunk/lib/Driver/ToolChain.
Author: rsmith
Date: Thu Oct 8 16:17:21 2015
New Revision: 249749
URL: http://llvm.org/viewvc/llvm-project?rev=249749&view=rev
Log:
Fix incorrect file header. This is not .
Modified:
libcxx/trunk/include/cfenv
Modified: libcxx/trunk/include/cfenv
URL:
http://llvm.org/viewvc/llvm-project/l
On Thu, Oct 8, 2015 at 2:10 PM, Adrian Zgorzalek via cfe-commits <
cfe-commits@lists.llvm.org> wrote:
> You are right, my bad, I thought this if covers all the cases, but
> part could be empty.
>
> Here is the fix
>
Please add a testcase ("__attribute__((ownership_takes(__))) void f();"
maybe?).
Author: rnk
Date: Thu Oct 8 16:14:56 2015
New Revision: 249748
URL: http://llvm.org/viewvc/llvm-project?rev=249748&view=rev
Log:
[WinEH] Push cleanupendpad scopes around exceptional cleanups
We were only doing this for SEH as a special case. Generalize it to all
cleanups.
Modified:
cfe/trun
You are right, my bad, I thought this if covers all the cases, but part
could be empty.
Here is the fix:
Adrian
> On Oct 8, 2015, at 1:52 PM, Aaron Ballman wrote:
>
> On Thu, Oct 8, 2015 at 4:49 PM, Richard Smith wrote:
>> On Thu, Oct 8, 2015 at 1:21 PM, Aaron Ballman
>> wrote:
>>>
>>> On
On Thu, Oct 8, 2015 at 9:54 AM, wrote:
> > I think this actually makes it less general. You would presumably perform
> > different inlining for:
> >
> > throw f(x, y);
> >
> > versus
> >
> > auto k = f(x, y);
> > throw k;
>
> We need to differentiate between these two. For the second case,
echristo added a subscriber: echristo.
echristo added a comment.
Pending naming from llvm review, LGTM.
Repository:
rL LLVM
http://reviews.llvm.org/D13572
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailm
Pending naming from llvm review, LGTM.
On Thu, Oct 8, 2015 at 1:55 PM Stephen Hines wrote:
> srhines added a comment.
>
> LGTM
>
>
> Repository:
> rL LLVM
>
> http://reviews.llvm.org/D13572
>
>
>
>
___
cfe-commits mailing list
cfe-commits@lists.llvm.
srhines added a comment.
LGTM
Repository:
rL LLVM
http://reviews.llvm.org/D13572
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
ABataev marked 2 inline comments as done.
Comment at: lib/AST/DeclPrinter.cpp:197
@@ -196,3 +196,3 @@
-void DeclPrinter::prettyPrintAttributes(Decl *D) {
+void DeclPrinter::prettyPrintAttributes(Decl *D, bool PrintPragmas) {
if (Policy.PolishForDeclaration)
a
On Thu, Oct 8, 2015 at 4:49 PM, Richard Smith wrote:
> On Thu, Oct 8, 2015 at 1:21 PM, Aaron Ballman
> wrote:
>>
>> On Thu, Oct 8, 2015 at 4:16 PM, Richard Smith
>> wrote:
>> > On Thu, Oct 8, 2015 at 12:24 PM, Aaron Ballman via cfe-commits
>> > wrote:
>> >>
>> >> Author: aaronballman
>> >> Date
On Thu, Oct 8, 2015 at 1:21 PM, Aaron Ballman
wrote:
> On Thu, Oct 8, 2015 at 4:16 PM, Richard Smith
> wrote:
> > On Thu, Oct 8, 2015 at 12:24 PM, Aaron Ballman via cfe-commits
> > wrote:
> >>
> >> Author: aaronballman
> >> Date: Thu Oct 8 14:24:08 2015
> >> New Revision: 249721
> >>
> >> URL:
Author: rsmith
Date: Thu Oct 8 15:41:26 2015
New Revision: 249743
URL: http://llvm.org/viewvc/llvm-project?rev=249743&view=rev
Log:
Split out of .
Added:
libcxx/trunk/include/setjmp.h
- copied, changed from r249736, libcxx/trunk/include/csetjmp
Modified:
libcxx/trunk/include/csetj
Hey!
I think you are right. This will not regress any of the cases, because previous
behaviour either checked str.size() >= 4 OR didn’t check it at all, but then
called .substr(2, str.size() - 4), which would crash. I think, though, that
explicitly checking str.size() >= 4 makes sense. See comm
eugenis created this revision.
eugenis added a reviewer: echristo.
eugenis added a subscriber: cfe-commits.
eugenis set the repository for this revision to rL LLVM.
Herald added subscribers: srhines, danalbert, tberghammer.
Depends on http://reviews.llvm.org/D13571
Repository:
rL LLVM
http://r
Author: rsmith
Date: Thu Oct 8 15:38:53 2015
New Revision: 249741
URL: http://llvm.org/viewvc/llvm-project?rev=249741&view=rev
Log:
Split out of .
Added:
libcxx/trunk/include/inttypes.h
- copied, changed from r249736, libcxx/trunk/include/cinttypes
Modified:
libcxx/trunk/include/c
Author: rsmith
Date: Thu Oct 8 15:37:11 2015
New Revision: 249739
URL: http://llvm.org/viewvc/llvm-project?rev=249739&view=rev
Log:
Split out of .
Added:
libcxx/trunk/include/errno.h
- copied, changed from r249736, libcxx/trunk/include/cerrno
Modified:
libcxx/trunk/include/cerrno
Author: rsmith
Date: Thu Oct 8 15:37:44 2015
New Revision: 249740
URL: http://llvm.org/viewvc/llvm-project?rev=249740&view=rev
Log:
Split out of .
Added:
libcxx/trunk/include/float.h
- copied, changed from r249736, libcxx/trunk/include/cfloat
Modified:
libcxx/trunk/include/cfloat
Author: rsmith
Date: Thu Oct 8 15:36:30 2015
New Revision: 249738
URL: http://llvm.org/viewvc/llvm-project?rev=249738&view=rev
Log:
Split out of .
Added:
libcxx/trunk/include/ctype.h
- copied, changed from r249736, libcxx/trunk/include/cctype
Modified:
libcxx/trunk/include/cctype
Author: rsmith
Date: Thu Oct 8 15:34:11 2015
New Revision: 249737
URL: http://llvm.org/viewvc/llvm-project?rev=249737&view=rev
Log:
Factor definition of std::nullptr_t out of into a header that can
also be used by .
Added:
libcxx/trunk/include/__nullptr
- copied, changed from r249736
On Thu, Oct 8, 2015 at 7:23 AM, Marshall Clow wrote:
> On Tue, Oct 6, 2015 at 3:36 PM, Richard Smith
> wrote:
>
>> Split out of . This is a big change, but the same pattern
>> as the prior ones.
>>
>> In this patch, you replicate the #ifdef XXX, __libcpp_XXX, #undef XXX
> dance for all the isXX
This revision was automatically updated to reflect the committed changes.
Closed by commit rL249735: [CodeGen] [CodeGen] Attach function attributes to
functions created in (authored by ahatanak).
Changed prior to commit:
http://reviews.llvm.org/D13525?vs=36886&id=36891#toc
Repository:
rL LLV
Author: ahatanak
Date: Thu Oct 8 15:26:34 2015
New Revision: 249735
URL: http://llvm.org/viewvc/llvm-project?rev=249735&view=rev
Log:
[CodeGen] [CodeGen] Attach function attributes to functions created in
CGBlocks.cpp.
This commit fixes a bug in clang's code-gen where it creates the
following fu
On Thu, Oct 8, 2015 at 4:16 PM, Richard Smith wrote:
> On Thu, Oct 8, 2015 at 12:24 PM, Aaron Ballman via cfe-commits
> wrote:
>>
>> Author: aaronballman
>> Date: Thu Oct 8 14:24:08 2015
>> New Revision: 249721
>>
>> URL: http://llvm.org/viewvc/llvm-project?rev=249721&view=rev
>> Log:
>> When ma
On Thu, Oct 8, 2015 at 6:27 AM, Marshall Clow wrote:
> On Wed, Oct 7, 2015 at 2:38 PM, Richard Smith
> wrote:
>
>> Marshall: ping, does the below satisfy your concerns about the direction
>> here?
>>
>
> No, not really, because I'm worried about behavior changes with this
> approach.
>
> #in
On Thu, Oct 8, 2015 at 12:24 PM, Aaron Ballman via cfe-commits <
cfe-commits@lists.llvm.org> wrote:
> Author: aaronballman
> Date: Thu Oct 8 14:24:08 2015
> New Revision: 249721
>
> URL: http://llvm.org/viewvc/llvm-project?rev=249721&view=rev
> Log:
> When mapping no_sanitize_* attributes to no_s
Author: echristo
Date: Thu Oct 8 15:10:14 2015
New Revision: 249732
URL: http://llvm.org/viewvc/llvm-project?rev=249732&view=rev
Log:
Migrate most feature map inclusion to initFeatureMap for the x86 target so
that we can build up an accurate set of features rather than relying on
TargetInfo initi
Author: echristo
Date: Thu Oct 8 15:10:18 2015
New Revision: 249733
URL: http://llvm.org/viewvc/llvm-project?rev=249733&view=rev
Log:
Handle sse turning on mmx, but no -mmx not turning off SSE.
Rationale :
// sse3
__m128d test_mm_addsub_pd(__m128d A, __m128d B) {
return _mm_addsub_pd(A, B);
}
Author: aaronballman
Date: Thu Oct 8 14:54:43 2015
New Revision: 249727
URL: http://llvm.org/viewvc/llvm-project?rev=249727&view=rev
Log:
Adding a checker (cert-err52-cpp) that detects use of setjmp or longjmp in C++
code. Corresponds to the CERT C++ secure coding rule:
https://www.securecoding
aaron.ballman closed this revision.
aaron.ballman added a comment.
Thank you for the fast turn-around! I've commit in r249727.
~Aaron
http://reviews.llvm.org/D13567
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-b
aaron.ballman updated this revision to Diff 36890.
aaron.ballman marked an inline comment as done.
aaron.ballman added a comment.
Corrected a simple copy-paste error.
http://reviews.llvm.org/D13567
Files:
clang-tidy/cert/CERTTidyModule.cpp
clang-tidy/cert/CMakeLists.txt
clang-tidy/cert/Se
On Thu, Oct 8, 2015 at 3:47 PM, Samuel Benzaquen wrote:
> sbenza added inline comments.
>
>
> Comment at: clang-tidy/cert/SetLongJmpCheck.cpp:31
> @@ +30,3 @@
> +public:
> + explicit SetJmpMacroCallbacks(Preprocessor *PP, SetLongJmpCheck &Check)
> + : PP(PP), Check(Check) {}
sbenza added inline comments.
Comment at: clang-tidy/cert/SetLongJmpCheck.cpp:31
@@ +30,3 @@
+public:
+ explicit SetJmpMacroCallbacks(Preprocessor *PP, SetLongJmpCheck &Check)
+ : PP(PP), Check(Check) {}
Why do you pass one as a pointer and one as a referenc
Author: ahatanak
Date: Thu Oct 8 14:30:57 2015
New Revision: 249722
URL: http://llvm.org/viewvc/llvm-project?rev=249722&view=rev
Log:
[CodeGen] Check if the Decl pointer passed is null, and if so, return
early.
This is needed in a patch I plan to commit later, in which a null Decl
pointer is pas
On Thu, Oct 8, 2015 at 2:50 PM, Adrian Zgorzalek wrote:
> Run clang-format, diff is in SVN format.
>
> Please, can you commit on behalf of me unless you are willing to grant me
> write permission to the repo ;-)
Thanks! I've commit in r249721. As for repo permissions, if you are
intending to cont
Author: aaronballman
Date: Thu Oct 8 14:24:08 2015
New Revision: 249721
URL: http://llvm.org/viewvc/llvm-project?rev=249721&view=rev
Log:
When mapping no_sanitize_* attributes to no_sanitize attributes, handle
GNU-style formatting that involves prefix and suffix underscores. Cleans up
other usa
Run clang-format, diff is in SVN format.
Please, can you commit on behalf of me unless you are willing to grant me write
permission to the repo ;-)
Adrian
> On Oct 8, 2015, at 11:40 AM, Aaron Ballman wrote:
>
> On Thu, Oct 8, 2015 at 2:33 PM, Adrian Zgorzalek wrote:
>> I so much like this fa
hintonda updated this revision to Diff 36889.
hintonda added a comment.
- add back check for standalone and add cmake version
http://reviews.llvm.org/D13453
Files:
CMakeLists.txt
Index: CMakeLists.txt
===
--- CMakeLists.txt
+++
ahatanak updated this revision to Diff 36886.
ahatanak added a comment.
Changed CodeGenModule::SetLLVMFunctionAttributesForDefinition to use early
return.
I'll first commit the NFC patch to fix
CodeGenModule::SetLLVMFunctionAttributesForDefinition and commit the rest after
that.
http://revie
On Tue, Oct 6, 2015 at 3:57 PM, Richard Smith wrote:
> . This one is tricky:
>
> 1) There's an (undocumented) interface between the C standard library and
> this header, where the macros __need_ptrdiff_t, __need_size_t,
> __need_wchar_t, __need_NULL, __need_wint_t request just a piece of this
> h
I so much like this fast review cycle :)
Comments applied.
Adrian
> On Oct 8, 2015, at 11:24 AM, Aaron Ballman wrote:
>
> On Thu, Oct 8, 2015 at 12:46 PM, Adrian Zgorzalek wrote:
>> Feedback applied, new patch in the attachment.
>
> Thank you for working on this! A few comments:
>
>> From 13f
On Thu, Oct 8, 2015 at 2:33 PM, Adrian Zgorzalek wrote:
> I so much like this fast review cycle :)
I aim to please. ;-)
>
> Comments applied.
LGTM with one nit:
+static bool normalizeName(StringRef& AttrName) {
Should be (StringRef &AttrName) per style guidelines. A good idea is
to run clang-
On Thu, Oct 8, 2015 at 12:46 PM, Adrian Zgorzalek wrote:
> Feedback applied, new patch in the attachment.
Thank you for working on this! A few comments:
> From 13f4df6def5f26768f9ea048e013f779bb4a7814 Mon Sep 17 00:00:00 2001
> From: =?UTF-8?q?Adrian=20Zgorza=C5=82ek?=
> Date: Wed, 7 Oct 2015 1
sfantao added a comment.
Thanks for the comments!
Comment at: lib/CodeGen/CGOpenMPRuntime.h:323
@@ +322,3 @@
+ /// far.
+ struct OffloadEntriesInfoManagerTy {
+CodeGenModule &CGM;
ABataev wrote:
> Maybe it is better to make it a class if it has some non-pu
sfantao updated this revision to Diff 36880.
sfantao added a comment.
Use class instead of structs if aggregate have private or protected fields.
http://reviews.llvm.org/D12614
Files:
include/clang/Basic/DiagnosticDriverKinds.td
include/clang/Basic/LangOptions.def
include/clang/Basic/Lang
aaron.ballman created this revision.
aaron.ballman added reviewers: alexfh, sbenza.
aaron.ballman added a subscriber: cfe-commits.
setjmp and longjmp facilities in C++ are unsafe due to the likelihood of
triggering undefined behavior with nontrivial type destruction, etc. Instead,
exception hand
beanz added inline comments.
Comment at: runtime/CMakeLists.txt:41
@@ +40,3 @@
+
+ add_custom_target(compiler-rt-clear
+DEPENDS ${CMAKE_CURRENT_BINARY_DIR}/compiler-rt-cleared
samsonov wrote:
> So, that's the target that you can invoke manually to clean compi
rnk added a comment.
I added this conditional check in r221415, with this message:
cmake: Only export targets in the standalone build
Trying to fix bots that didn't like the fact that I exported targets
that depended on LLVM without exporting targets from LLVM.
I assume this has already
zaks.anna added a comment.
> Even if you do not deal with this case I think it would be great to have an
> XFAIL test with a fixme that describes this limitation.
Yes! Every time we have a test case that shows known limitations, we should add
it to the regression tests with a TODO explaining t
Author: rnk
Date: Thu Oct 8 12:29:07 2015
New Revision: 249704
URL: http://llvm.org/viewvc/llvm-project?rev=249704&view=rev
Log:
[clang-cl] Make /EHs turn on C++ EH once again
C++ exceptions are still off by default, which is similar to how C++
cleanups are off by default in MSVC.
If you use cl
rnk added a comment.
Looks like this got committed. Sorry for the delay, I was travelling.
http://reviews.llvm.org/D12832
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
> I think this actually makes it less general. You would presumably perform
> different inlining for:
>
> throw f(x, y);
>
> versus
>
> auto k = f(x, y);
> throw k;
We need to differentiate between these two. For the second case, we should
not add any attribute because its not invoked in th
Author: rengolin
Date: Thu Oct 8 11:43:26 2015
New Revision: 249699
URL: http://llvm.org/viewvc/llvm-project?rev=249699&view=rev
Log:
Simplify DefaultCPU in ARMTargetInfo
Simplifying the convoluted CPU handling in ARMTargetInfo.
The default base CPU on ARM is ARM7TDMI, arch ARMv4T, and
ARMTarge
Feedback applied, new patch in the attachment.
Adrian
> On Oct 8, 2015, at 8:48 AM, Adrian Zgorzalek wrote:
>
> Great! I did not notice, that we already have exactly the same logic in
> SemaDeclAttr.cpp.
> Maybe it would be possible even to refactor it in such a way that this code
> is writte
vkalintiris abandoned this revision.
vkalintiris added a comment.
In http://reviews.llvm.org/D13557#262801, @jroelofs wrote:
> Unfortunately, Musl intentionally doesn't provide that sort of macro [1], so
> to provide support for Musl in libc++, we need to make note of it at
> configure-time via
Author: chapuni
Date: Thu Oct 8 11:41:42 2015
New Revision: 249698
URL: http://llvm.org/viewvc/llvm-project?rev=249698&view=rev
Log:
CGStmtOpenMP.cpp: Prune redundant \param. [-Wdocumentation]
Modified:
cfe/trunk/lib/CodeGen/CGStmtOpenMP.cpp
Modified: cfe/trunk/lib/CodeGen/CGStmtOpenMP.cpp
Great! I did not notice, that we already have exactly the same logic in
SemaDeclAttr.cpp.
Maybe it would be possible even to refactor it in such a way that this code is
written only once.
Adrian
> On Oct 8, 2015, at 6:53 AM, Aaron Ballman wrote:
>
> (Removing llvm-commits, adding cfe-commits)
jroelofs added a subscriber: jroelofs.
jroelofs added a comment.
I don't think it's correct to say that `!defined(__GLIBC__) &&
defined(__linux__) ==> Musl` (nor is the converse true). Unfortunately, Musl
intentionally doesn't provide that sort of macro [1], so to provide support for
Musl in l
vkalintiris added a subscriber: vkalintiris.
Comment at: include/CMakeLists.txt:9
@@ -7,2 +8,3 @@
PATTERN ".svn" EXCLUDE
+ PATTERN "__config_site.in" EXCLUDE
${LIBCXX_SUPPORT_HEADER_PATTERN}
Kind of silly but I believe that the files used for auto-generated
vkalintiris created this revision.
vkalintiris added a reviewer: mclow.lists.
vkalintiris added a subscriber: cfe-commits.
Most of the #ifdefs in the locale code would check for the existence of
GLIBC or for operating systems other than Linux. This patch considers the
case where GLIBC isn't availa
1 - 100 of 132 matches
Mail list logo
