On Mon, 25 Jul 2022 17:21:27 GMT, Harold Seigel wrote:
> Please review this fix for JDK-8285792. The fix removes print statements
> from check_signal_handler() so that it doesn't print all the handlers every
> time it finds one that is modified. Instead, it returns true if the handler
> is m
On Mon, 25 Jul 2022 19:29:52 GMT, Harold Seigel wrote:
> I ran the test for JDK-8279878 after removing both this fix and the fix for
> JDK-8279878 and the test still passed. So I don't think its failure was
> related to this issue. This fix prevents the output from occurring more than
> once.
On Tue, 10 Oct 2023 22:32:54 GMT, Phil Race wrote:
>> Julian Waters has updated the pull request incrementally with five
>> additional commits since the last revision:
>>
>> - Revert sspi.cpp
>> - Revert NativeCreds.c
>> - Revert allocation.cpp
>&g
On Tue, 10 Oct 2023 03:44:27 GMT, Julian Waters wrote:
>> We should set the -permissive- flag for the Microsoft Visual C compiler, as
>> was requested by the now backed out
>> [JDK-8241499](https://bugs.openjdk.org/browse/JDK-8241499). Doing so makes
>> the Visual C compiler much less acceptin
On Wed, 11 Oct 2023 21:05:28 GMT, Mikael Vidstedt wrote:
>> macOS 10.x is no longer receiving updates - the most recent/last release was
>> 10.15.7 back in July of 2022. It's time to bump the target macOS version
>> (min/max) for macosx-x64. macOS 11.x is still receiving updates.
>>
>> This ch
On Wed, 11 Oct 2023 21:50:10 GMT, Phil Race wrote:
>> Mikael Vidstedt has updated the pull request incrementally with two
>> additional commits since the last revision:
>>
>> - Update stale comment (again)
>> - Update stale comment
>
> Marked as revi
On Wed, 11 Oct 2023 21:10:21 GMT, Mikael Vidstedt wrote:
>> macOS 10.x is no longer receiving updates - the most recent/last release was
>> 10.15.7 back in July of 2022. It's time to bump the target macOS version
>> (min/max) for macosx-x64. macOS 11.x is still receiving updates.
>>
>> This ch
On Thu, 12 Oct 2023 19:25:13 GMT, Mikael Vidstedt wrote:
> In GHA, the versions of macOS (note: the version used for build/test, **not**
> the target macOS version we compile for) and Xcode are starting to show age.
> It's time to update to more modern versions.
>
> This change bumps the macOS
On Thu, 12 Oct 2023 19:25:13 GMT, Mikael Vidstedt wrote:
> In GHA, the versions of macOS (note: the version used for build/test, **not**
> the target macOS version we compile for) and Xcode are starting to show age.
> It's time to update to more modern versions.
>
> This change bumps the macOS
On Fri, 13 Oct 2023 18:01:44 GMT, Mikael Vidstedt wrote:
>> macOS 10.x is no longer receiving updates - the most recent/last release was
>> 10.15.7 back in July of 2022. It's time to bump the target macOS version
>> (min/max) for macosx-x64. macOS 11.x is still receiving updates.
>>
>> This ch
On Tue, 31 Oct 2023 21:32:26 GMT, Daniel Jeliński wrote:
> hb-subset and hb-style APIs are not used and not exported by libfontmanger.
> We can cut the compilation time by not compiling the unused files.
>
> The added exclusions reduce the build time by ~1 minute (~8%) on my machine.
> This is
On Wed, 1 Nov 2023 18:51:26 GMT, Phil Race wrote:
>> hb-subset and hb-style APIs are not used and not exported by libfontmanger.
>> We can cut the compilation time by not compiling the unused files.
>>
>> The added exclusions reduce the build time by ~1 minute (~8%) on
On Thu, 2 Nov 2023 14:01:20 GMT, null wrote:
>> Build failure with GCC8.3.1
>>
>> === Output from failing command(s) repeated here ===
>> * For target support_native_java.desktop_libfontmanager_hb-ot-layout.o:
>> /data/codes/bobjdk/src/java.desktop/share/native/libharfbuzz/hb-ot-layout.cc:
>> I
On Tue, 31 Oct 2023 21:32:26 GMT, Daniel Jeliński wrote:
> hb-subset and hb-style APIs are not used and not exported by libfontmanger.
> We can cut the compilation time by not compiling the unused files.
>
> The added exclusions reduce the build time by ~1 minute (~8%) on my machine.
> This is
On Tue, 31 Oct 2023 21:32:26 GMT, Daniel Jeliński wrote:
> hb-subset and hb-style APIs are not used and not exported by libfontmanger.
> We can cut the compilation time by not compiling the unused files.
>
> The added exclusions reduce the build time by ~1 minute (~8%) on my machine.
> This is
On Thu, 11 Jan 2024 08:24:42 GMT, Julian Waters wrote:
>> We should set the -permissive- flag for the Microsoft Visual C compiler, as
>> was requested by the now backed out
>> [JDK-8241499](https://bugs.openjdk.org/browse/JDK-8241499). Doing so makes
>> the Visual C compiler much less acceptin
On Sun, 21 Jan 2024 07:55:16 GMT, Julian Waters wrote:
> Fixed the formatting (at least in the marked cases), but am unsure what you
> mean by set directly?
See my comment
"like in my recoded case above, we no longer need the "pData" var which was
there only because that name
is magically kno
On Sat, 3 Feb 2024 10:07:26 GMT, Sam James wrote:
>> This fixes building with GCC 14:
>> * ~Cherry-pick a fix from Harfbuzz upstream~
>> * Apply other `-Wcalloc-transposed-args` fixes to the JDK sources
>>
>> -Wcalloc-transposed-args errors out with GCC 14 as the OpenJDK build uses
>> -Werror.
>
On Thu, 15 Feb 2024 12:19:31 GMT, Magnus Ihse Bursie wrote:
> Since jcheck only checks file in a commit, there is a possibility of us
> getting files in the repository that would not be accepted by jcheck. This
> can happen when extending the set of files checked by jcheck, or if jcheck
> chan
On Mon, 5 Feb 2024 10:58:17 GMT, Magnus Ihse Bursie wrote:
>> Inspired by (the later backed-out)
>> [JDK-8296115](https://bugs.openjdk.org/browse/JDK-8296115), I propose to
>> enable `-Wpedantic` for clang. This has already found some irregularities in
>> the code, like mistakenly using `#impo
On Sun, 21 Jan 2024 16:55:45 GMT, Sam James wrote:
>> This fixes building with GCC 14:
>> * ~Cherry-pick a fix from Harfbuzz upstream~
>> * Apply other `-Wcalloc-transposed-args` fixes to the JDK sources
>>
>> -Wcalloc-transposed-args errors out with GCC 14 as the OpenJDK build uses
>> -Werror.
On Mon, 11 Mar 2024 13:54:02 GMT, Alexander Scherbatiy
wrote:
> The fix provides ability to print Black & White pages on macOS.
>
> Cocoa API has
> [PMSetColorMode](https://developer.apple.com/documentation/applicationservices/core_printing/1805783-pmsetcolormode)
> function but it is marked
On Mon, 11 Mar 2024 13:54:02 GMT, Alexander Scherbatiy
wrote:
> The fix provides ability to print Black & White pages on macOS.
>
> Cocoa API has
> [PMSetColorMode](https://developer.apple.com/documentation/applicationservices/core_printing/1805783-pmsetcolormode)
> function but it is marked
On Mon, 11 Mar 2024 13:54:02 GMT, Alexander Scherbatiy
wrote:
> The fix provides ability to print Black & White pages on macOS.
>
> Cocoa API has
> [PMSetColorMode](https://developer.apple.com/documentation/applicationservices/core_printing/1805783-pmsetcolormode)
> function but it is marked
On Tue, 12 Mar 2024 17:28:57 GMT, Alexander Scherbatiy
wrote:
> > But I am really surprised to see a PR rather than a discussion first as it
> > is making a lot of policy decisions
> > and implies we need to support something I am not sure we want to support.
>
> There was an email with the is
On Tue, 26 Mar 2024 12:51:38 GMT, Magnus Ihse Bursie wrote:
> This is a follow-up on
> [JDK-8328680](https://bugs.openjdk.org/browse/JDK-8328680), making the same
> kind of cleanup to java.desktop. Some code needed more special treatment
> here, so there is some additional effects outside of t
On Tue, 26 Mar 2024 13:00:41 GMT, Magnus Ihse Bursie wrote:
>> This is a follow-up on
>> [JDK-8328680](https://bugs.openjdk.org/browse/JDK-8328680), making the same
>> kind of cleanup to java.desktop. Some code needed more special treatment
>> here, so there is some additional effects outside
On Wed, 27 Mar 2024 18:20:47 GMT, Magnus Ihse Bursie wrote:
>> This is a follow-up on JDK-8328680, making the same kind of cleanup to
>> jdk.accessibility. The code here needed more work than for the other
>> modules, so I wanted have it in a separate PR to get a more thorough review.
>
> Magnu
On Wed, 27 Mar 2024 19:34:22 GMT, Erik Joelsson wrote:
>> make/modules/jdk.accessibility/Launcher.gmk line 30:
>>
>>> 28: ifeq ($(call isTargetOs, windows), true)
>>> 29: ACCESSIBILITY_SRCDIR := $(TOPDIR)/src/jdk.accessibility/windows/native
>>> 30:
>>
>> It looks like you determined that th
On Wed, 27 Mar 2024 18:20:47 GMT, Magnus Ihse Bursie wrote:
>> This is a follow-up on JDK-8328680, making the same kind of cleanup to
>> jdk.accessibility. The code here needed more work than for the other
>> modules, so I wanted have it in a separate PR to get a more thorough review.
>
> Magnu
On Thu, 28 Mar 2024 07:36:04 GMT, Julian Waters wrote:
>> We should set the -permissive- flag for the Microsoft Visual C compiler, as
>> was requested by the now backed out
>> [JDK-8241499](https://bugs.openjdk.org/browse/JDK-8241499). Doing so makes
>> the Visual C compiler much less acceptin
On Tue, 2 Apr 2024 15:45:59 GMT, Magnus Ihse Bursie wrote:
> This is a retake on https://github.com/openjdk/jdk/pull/15096.
>
> I tried to fix the remaining issues in that PR, but could not push them. In
> the end, it seemed easier to create a new branch in my own personal fork.
>
> The majori
On Mon, 11 Mar 2024 13:54:02 GMT, Alexander Scherbatiy
wrote:
> The fix provides ability to print Black & White pages on macOS.
>
> Cocoa API has
> [PMSetColorMode](https://developer.apple.com/documentation/applicationservices/core_printing/1805783-pmsetcolormode)
> function but it is marked
On Thu, 11 Apr 2024 13:59:30 GMT, Magnus Ihse Bursie wrote:
> @prrace I will need your assistance in confirming that my understanding about
> the AWT vs 2D split is correct. In particular, `libosxui` gave me some
> headache, but after trying to dig into the code my understanding ended up
> bei
On Tue, 16 Apr 2024 10:03:27 GMT, Magnus Ihse Bursie wrote:
>> The file to build most of the java.desktop native libraries,
>> Awt2dLibraries.gmk, is large and unstructured, making it hard to navigate.
>>
>> I want to split it into two parts, one for the AWT libraries, and one for
>> the 2D li
On Tue, 16 Apr 2024 10:03:27 GMT, Magnus Ihse Bursie wrote:
>> The file to build most of the java.desktop native libraries,
>> Awt2dLibraries.gmk, is large and unstructured, making it hard to navigate.
>>
>> I want to split it into two parts, one for the AWT libraries, and one for
>> the 2D li
On Mon, 11 Mar 2024 13:54:02 GMT, Alexander Scherbatiy
wrote:
> The fix provides ability to print Black & White pages on macOS.
>
> Cocoa API has
> [PMSetColorMode](https://developer.apple.com/documentation/applicationservices/core_printing/1805783-pmsetcolormode)
> function but it is marked
On Mon, 8 Apr 2024 23:19:13 GMT, Phil Race wrote:
>> The fix provides ability to print Black & White pages on macOS.
>>
>> Cocoa API has
>> [PMSetColorMode](https://developer.apple.com/documentation/applicationservices/core_printing/1805783-pmsetcolormode)
>
On Fri, 26 Apr 2024 16:04:09 GMT, Jonathan Gibbons wrote:
>> Please review the updates to support a proposed new
>> `-Xlint:dangling-doc-comments` option.
>>
>> The work can be thought of as in 3 parts:
>>
>> 1. An update to the `javac` internal class `DeferredLintHandler` so that it
>> is po
On Mon, 13 May 2024 10:49:30 GMT, Maurizio Cimadamore
wrote:
>> Maurizio Cimadamore has updated the pull request incrementally with one
>> additional commit since the last revision:
>>
>> Address review comments
>
> make/conf/module-loader-map.conf line 105:
>
>> 103: java.smartcardio \
On Fri, 17 May 2024 13:38:25 GMT, Maurizio Cimadamore
wrote:
>> This PR implements [JEP 472](https://openjdk.org/jeps/472), by restricting
>> the use of JNI in the following ways:
>>
>> * `System::load` and `System::loadLibrary` are now restricted methods
>> * `Runtime::load` and `Runtime::loa
On Fri, 17 May 2024 13:38:25 GMT, Maurizio Cimadamore
wrote:
>> This PR implements [JEP 472](https://openjdk.org/jeps/472), by restricting
>> the use of JNI in the following ways:
>>
>> * `System::load` and `System::loadLibrary` are now restricted methods
>> * `Runtime::load` and `Runtime::loa
On Wed, 12 Jun 2024 22:38:37 GMT, Zhao Song wrote:
> @kevinrushforth said in
> [SKARA-2289](https://bugs.openjdk.org/browse/SKARA-2289), 'In general, our
> repositories contain source code and not binary files. There are exceptions
> to this for images and other similar resources, but otherwis
Verified on Ubuntu 24.04
-
Commit messages:
- 8332854
Changes: https://git.openjdk.org/jdk/pull/19739/files
Webrev: https://webrevs.openjdk.org/?repo=jdk&pr=19739&range=00
Issue: https://bugs.openjdk.org/browse/JDK-8332854
Stats: 1 line in 1 file changed: 1 ins; 0 del; 0 mod
On Sun, 16 Jun 2024 21:31:50 GMT, Phil Race wrote:
> Verified on Ubuntu 24.04
This pull request has now been integrated.
Changeset: ba5a4670
Author: Phil Race
URL:
https://git.openjdk.org/jdk/commit/ba5a4670b8ad86fefb41a939752754bf36aac9dc
Stats: 1 line in 1 file changed: 1
On Wed, 12 Jun 2024 22:38:37 GMT, Zhao Song wrote:
> @kevinrushforth said in
> [SKARA-2289](https://bugs.openjdk.org/browse/SKARA-2289), 'In general, our
> repositories contain source code and not binary files. There are exceptions
> to this for images and other similar resources, but otherwis
On Thu, 13 Jun 2024 17:50:21 GMT, Phil Race wrote:
>> @kevinrushforth said in
>> [SKARA-2289](https://bugs.openjdk.org/browse/SKARA-2289), 'In general, our
>> repositories contain source code and not binary files. There are exceptions
>> to this for images and
On Wed, 12 Jun 2024 22:38:37 GMT, Zhao Song wrote:
> @kevinrushforth said in
> [SKARA-2289](https://bugs.openjdk.org/browse/SKARA-2289), 'In general, our
> repositories contain source code and not binary files. There are exceptions
> to this for images and other similar resources, but otherwis
On Sat, 13 Jul 2024 16:48:20 GMT, Aleksey Shipilev wrote:
> Following [JDK-8257913](https://bugs.openjdk.org/browse/JDK-8257913), it
> would be more convenient to search into more paths in sysroot for ALSA as
> well. Currently, this is the only thing that is missing for me to build from
> the
On Sat, 13 Jul 2024 13:43:42 GMT, Aleksey Shipilev wrote:
> In [JDK-8257913](https://bugs.openjdk.org/browse/JDK-8257913), we added the
> search paths for X11 libraries, but they point explicitly to `libX11.so`.
> First, this is not really correct, as `x_libraries` would be added to a
> search
On Tue, 30 Jul 2024 17:51:06 GMT, Alexander Zvegintsev
wrote:
>> GTK2 support for Swing/AWT was deprecated for removal in JDK 21.
>>
>> It's being removed because no platform that supports the JDK needs it.
>>
>> Manual and automated testing is green.
>
> Alexander Zvegintsev has updated the
On Wed, 31 Jul 2024 19:17:05 GMT, Alexander Zvegintsev
wrote:
>> GTK2 support for Swing/AWT was deprecated for removal in JDK 21.
>>
>> It's being removed because no platform that supports the JDK needs it.
>>
>> Manual and automated testing is green.
>
> Alexander Zvegintsev has updated the
On Thu, 11 Aug 2022 09:56:29 GMT, Daniel Jeliński wrote:
> Remove `java.base:include` from `EXTRA_HEADER_DIRS`.
>
> The directory contains base versions of the files present in
> `/support/modules_include/java.base`; the latter is automatically
> [included in every JDK library
> build](https:
On Fri, 30 Sep 2022 14:16:24 GMT, Weijun Wang wrote:
>> src/jdk.accessibility/windows/native/include/bridge/AccessBridgeCalls.h line
>> 34:
>>
>>> 32: * the following link:
>>> 33: *
>>> 34: *
>>> http://hg.openjdk.org/jdk9/jdk9/jdk/raw-file/tip/src/jdk.accessibility/windows/native/bridge/A
On Mon, 3 Oct 2022 17:29:45 GMT, Joe Darcy wrote:
>> With the domain change from openjdk.java.net to openjdk.org, references to
>> URLs in the sources should be updated.
>>
>> Updates were made using a shell script. I"ll run a copyright updater before
>> any push.
>
> Joe Darcy has updated the
On Mon, 3 Oct 2022 20:37:11 GMT, Joe Darcy wrote:
>> With the domain change from openjdk.java.net to openjdk.org, references to
>> URLs in the sources should be updated.
>>
>> Updates were made using a shell script. I"ll run a copyright updater before
>> any push.
>
> Joe Darcy has updated the
On Thu, 20 Oct 2022 04:15:33 GMT, Sergey Bylokhov wrote:
>> The "sizecalc.h" file is moved out from java.desktop/share/native/include,
>> the files in that folder appear in the jdk bundle after installation like
>> the "jawt.h".
>
> make/common/modules/LauncherCommon.gmk line 48:
>
>> 46: LAUN
On Fri, 21 Oct 2022 19:06:13 GMT, Sergey Bylokhov wrote:
> > Can you please refrain from integrating this while I investigate while this
> > was originally moved?
>
> sure.
It was moved because it was designed for use by AWT and SOMEHOW during all the
reshuffle for the modular JDK in JDK 9 it
On Sun, 23 Oct 2022 00:36:11 GMT, Phil Race wrote:
>> make/common/modules/LauncherCommon.gmk line 48:
>>
>>> 46: LAUNCHER_SRC := $(TOPDIR)/src/java.base/share/native/launcher
>>> 47: LAUNCHER_CFLAGS += -I$(TOPDIR)/src/java.base/share/native/launcher \
>>&g
On Thu, 20 Oct 2022 10:36:08 GMT, Magnus Ihse Bursie wrote:
> After JDK-8294281, it is now possible to disable warnings for individual
> files instead for whole libraries. I used this opportunity to go through all
> disabled warnings in java.desktop native libraries.
>
> Any warnings that were
On Thu, 20 Oct 2022 10:24:28 GMT, Magnus Ihse Bursie wrote:
> After JDK-8294281, it is now possible to disable warnings for individual
> files instead for whole libraries. I used this opportunity to go through all
> disabled warnings in the accessibility native code.
>
> Any warnings that were
On Thu, 20 Oct 2022 18:56:56 GMT, Magnus Ihse Bursie wrote:
>> make/modules/jdk.accessibility/Launcher.gmk line 46:
>>
>>> 44: -analyze- -Od -Gd -D_WINDOWS \
>>> 45: -D_UNICODE -DUNICODE -RTC1 -EHsc, \
>>> 46: DISABLED_WARNINGS_microsoft_jabswitch.cpp := 4267 4996, \
>>
On Mon, 24 Oct 2022 03:49:17 GMT, Phil Race wrote:
>> Heh, I did not notice that.
>>
>> I'd still argue that this is a useful change. If some other file were ever
>> to be added, it will not be covered by the blanked disabled warnings, and --
>> perhaps
On Fri, 21 Oct 2022 08:17:46 GMT, Magnus Ihse Bursie wrote:
>> Properties files is essentially source code. It should have the same
>> whitespace checks as all other source code, so we don't get spurious
>> trailing whitespace changes.
>>
>> With the new Skara jcheck, it is possible to increas
On Wed, 19 Oct 2022 08:15:54 GMT, Sergey Bylokhov wrote:
> The "sizecalc.h" file is moved out from java.desktop/share/native/include,
> the files in that folder appear in the jdk bundle after installation like the
> "jawt.h".
Marked as reviewed by prr (Reviewer).
-
PR: https://gi
On Mon, 24 Oct 2022 10:15:53 GMT, Alexey Ivanov wrote:
>> The "sizecalc.h" file is moved out from java.desktop/share/native/include,
>> the files in that folder appear in the jdk bundle after installation like
>> the "jawt.h".
>
> Marked as reviewed by aivanov (Reviewer).
@aivanov-jdk has prep
On Sun, 23 Oct 2022 20:10:35 GMT, Sergey Bylokhov wrote:
> The Java2d do not use "half" float in the image layouts, so we can disable it
> in the LittleCMS library during the build. It is possible to do using
> [this](https://github.com/openjdk/jdk/blob/master/src/java.desktop/share/native/libl
On Thu, 17 Nov 2022 19:05:36 GMT, Alisen Chung wrote:
> Redo of 8295369: Update LCMS to 2.14
> Update LCMS to newest release.
> Updated DISABLED_WARNINGS_gcc for LCMS to include type limits to prevent a
> build error in linux.
> Automatic tests and J2D demo tests were run.
Marked as reviewed by
On Tue, 20 Dec 2022 18:59:18 GMT, Daniel Jeliński wrote:
> Please review this patch that removes unnecessary exports from libawt and
> libfreetype.
>
> Verified that:
> - mach5 client libs tests pass
> - both release and debug builds finish successfully
>
> Did not verify the other issues repo
On Tue, 20 Dec 2022 18:59:18 GMT, Daniel Jeliński wrote:
> Please review this patch that removes unnecessary exports from libawt and
> libfreetype.
>
> Verified that:
> - mach5 client libs tests pass
> - both release and debug builds finish successfully
>
> Did not verify the other issues repo
On Tue, 20 Dec 2022 22:09:42 GMT, Daniel Jeliński wrote:
> These exports were absent even before my changes, so I believe we should be
> fine here.
I can't speak to all of these but we only have a subset of freetype in JDK
sources, since for example we have no interest in the bitmap formats, s
On Tue, 17 Jan 2023 13:35:25 GMT, Kevin Rushforth wrote:
>>> Normally, such changes in third-party libraries need to be done upstream,
>>> and not locally. @prrace can confirm.
>>
>> Thanks @kevinrushforth for your review.
>>
>> Yes, it had been fixed in the upstream and I just follow it.
>> P
On Sat, 14 Jan 2023 14:28:32 GMT, Jie Fu wrote:
> Hi all,
>
> Please review the fix for the build failure with clang-15.
>
> 1. -Wbitwise-instead-of-logical
>
>1) src/hotspot/share/oops/generateOopMap.cpp <--- fixed the
> warning
>2) src/hotspot/share/runtime/notificationThre
On Mon, 6 Feb 2023 12:35:16 GMT, Yasumasa Suenaga wrote:
> This is subtask of https://github.com/openjdk/jdk/pull/12427 .
>
> I have seen C4819 warning in harfbuzz files on Windows (CP932: Japanese
> locale)
>
>
> d:\github-forked\jdk\src\java.desktop\share\native\libharfbuzz\hb.hh(1):
> err
On Mon, 6 Feb 2023 12:34:36 GMT, Yasumasa Suenaga wrote:
> This is subtask of https://github.com/openjdk/jdk/pull/12427 .
>
> I have seen C4819 warning in libfreetype files on Windows (CP932: Japanese
> locale)
>
>
> d:\github-forked\jdk\src\java.desktop\share\native\libfreetype\src\autofit\a
On Tue, 7 Feb 2023 00:01:56 GMT, Yasumasa Suenaga wrote:
> I grep'ed (with `-i`) in `doc` directory with `LANG`, `utf`, `locale`, but I
> could not find out them. I guess locale of build environment is not mentioned
> clearly. Is it correct?
>
> I agree with you to use English locale (e.g. `LA
On Tue, 7 Feb 2023 02:46:10 GMT, Yasumasa Suenaga wrote:
> > but "en_US-iso-8859-1" (eg) definitely should work, because that or some
> > close equivalent (windows cp1252 or maybe 1250) are what we've considered
> > as "must work" (SFAIK)
>
> According to Wikipedia article of
> [CP1250](https
On Mon, 27 Feb 2023 16:16:50 GMT, Jayathirth D V wrote:
>> Under https://bugs.openjdk.org/browse/JDK-8264846 we moved to -O3 level of
>> gcc optimizations from -O1 level for libawt build. This improved our
>> J2DBench performance numbers in some options considerably.
>>
>> Recent changes done
On Tue, 28 Feb 2023 17:03:01 GMT, Dmitry Markov wrote:
>> Added the section devoted to client UI test which use Robot API
>
> Dmitry Markov has updated the pull request incrementally with one additional
> commit since the last revision:
>
> Fix link
Marked as reviewed by prr (Reviewer).
---
On Tue, 28 Feb 2023 13:57:21 GMT, Erik Joelsson wrote:
>> Thanks @prrace for your inputs.
>> I dont think -fPIC is implied by -fpic. @erikj79 please clarify.
>>
>> Difference between -fpic and -fPIC:
>> 1) With -fPIC we have unlimited storage capacity for global offset table and
>> with -fpic
On Thu, 2 Mar 2023 12:03:44 GMT, Pavel Rappo wrote:
> Please review this superficial documentation cleanup that was triggered by
> unrelated analysis of doc comments in JDK API.
>
> The only effect that this multi-area PR has on the JDK API Documentation
> (i.e. the observable effect on the ge
On Fri, 3 Mar 2023 20:25:09 GMT, Harshitha Onkar wrote:
>> HarfBuzz library updated from v4.4.1 to v7.0.1
>>
>> - harfbuzz.md file updated
>> - Added -DHB_NO_VISIBILITY to HARFBUZZ_CFLAGS in Awt2DLibraries.gmk to avoid
>> build issues on linux and macos targets.
>> - GPOS.hh has been moved from
On Fri, 10 Mar 2023 17:07:53 GMT, Justin King wrote:
> FYI HarfBuzz most recent is 7.1.0 as of last week. Might make sense to just
> bite the bullet as it were and to 7.1.0 instead of 7.0.1.
We already switched once from 7.0 to 7.0.1. By the time we've got 7.1 in
review, there might be a 7.2 .
On Thu, 9 Mar 2023 06:12:26 GMT, Harshitha Onkar wrote:
>> HarfBuzz library updated from v4.4.1 to v7.0.1
>>
>> - harfbuzz.md file updated
>> - Added -DHB_NO_VISIBILITY to HARFBUZZ_CFLAGS in Awt2DLibraries.gmk to avoid
>> build issues on linux and macos targets.
>> - GPOS.hh moved to Layout to
On Mon, 13 Mar 2023 21:16:24 GMT, Naoto Sato wrote:
> Proposing accessor methods to Emoji properties defined in [Unicode Technical
> Standard #51](https://unicode.org/reports/tr51/) in `java.lang.Character`
> class. This is per a request from the client group, as well as refining the
> current
On Thu, 9 Mar 2023 06:12:26 GMT, Harshitha Onkar wrote:
>> HarfBuzz library updated from v4.4.1 to v7.0.1
>>
>> - harfbuzz.md file updated
>> - Added -DHB_NO_VISIBILITY to HARFBUZZ_CFLAGS in Awt2DLibraries.gmk to avoid
>> build issues on linux and macos targets.
>> - GPOS.hh moved to Layout to
On Thu, 6 Apr 2023 19:25:19 GMT, Roger Riggs wrote:
>> Define an internal jdk.internal.util.Architecture enumeration and static
>> methods to replace uses of the system property `os.arch`.
>> The enumeration values are defined to match those used in the build.
>> The initial values are: `X64, X8
On Fri, 28 Apr 2023 01:03:28 GMT, Jiangli Zhou wrote:
> Initial implementation for supporting building a fully statically linked
> (with a desired set of JDK native libraries and libjvm) Java launcher
> executable, which is named as 'javastatic'.
>
> In this PR, the support is only added for t
On Thu, 4 May 2023 19:56:21 GMT, Erik Joelsson wrote:
> I would like to understand why we need to add third party headers to our
> source tree. Are these not generally available on Linux systems?
They are not available on anything except very new Linux distros.
Forget RHEL 6.x / 7.x. I'm fairl
On Fri, 5 May 2023 14:35:46 GMT, Alexander Zvegintsev
wrote:
>> Modern Linux systems often come with
>> [Wayland](https://wayland.freedesktop.org/) by default.
>> This comes with some difficulties, and one of them is the inability to get
>> screenshots from the system.
>> This is because we no
On Tue, 9 May 2023 22:09:26 GMT, Alexander Zvegintsev
wrote:
> > I want to work through the scenarios and how much of it is specific to the
> > behaviours of the API you are using and so forth. Since you use the
> > Preferences API for saving the token, if you keyed it off the Robot class
> >
On Wed, 17 May 2023 12:26:22 GMT, xpbob wrote:
> configure --enable-debug
>
> error: infinite recursion detected [-Werror=infinite-recursion]
> 193 | void VMError::reattempt_test_hit_stack_limit(outputStream* st)
>
> configure
>
> java.desktop/share/native/libharfbuzz/graph/../hb-ot-layout-c
On Thu, 25 May 2023 16:29:39 GMT, Alexander Zvegintsev
wrote:
>> Modern Linux systems often come with
>> [Wayland](https://wayland.freedesktop.org/) by default.
>> This comes with some difficulties, and one of them is the inability to get
>> screenshots from the system.
>> This is because we n
On Sat, 27 May 2023 01:25:40 GMT, Alexander Zvegintsev
wrote:
>> Modern Linux systems often come with
>> [Wayland](https://wayland.freedesktop.org/) by default.
>> This comes with some difficulties, and one of them is the inability to get
>> screenshots from the system.
>> This is because we n
On Wed, 31 May 2023 15:03:04 GMT, Alexander Zvegintsev
wrote:
>> Modern Linux systems often come with
>> [Wayland](https://wayland.freedesktop.org/) by default.
>> This comes with some difficulties, and one of them is the inability to get
>> screenshots from the system.
>> This is because we n
On Fri, 26 May 2023 08:31:46 GMT, JoKern65 wrote:
>> When using the new xlc17 compiler (based on a recent clang) to build OpenJDk
>> on AIX , we run into various "warnings as errors".
>> Some of those are in shared codebase and could be addressed by small
>> adjustments.
>> A lot of those chang
On Wed, 31 May 2023 15:03:04 GMT, Alexander Zvegintsev
wrote:
>> Modern Linux systems often come with
>> [Wayland](https://wayland.freedesktop.org/) by default.
>> This comes with some difficulties, and one of them is the inability to get
>> screenshots from the system.
>> This is because we n
On Thu, 1 Jun 2023 12:40:55 GMT, Alexander Zvegintsev
wrote:
>> Modern Linux systems often come with
>> [Wayland](https://wayland.freedesktop.org/) by default.
>> This comes with some difficulties, and one of them is the inability to get
>> screenshots from the system.
>> This is because we no
On Thu, 1 Jun 2023 13:16:49 GMT, JoKern65 wrote:
> This pr is a split off from JDK-8308288: Fix xlc17 clang warnings in shared
> code https://github.com/openjdk/jdk/pull/14146
> It handles the part in java.desktop.
> prrace had already reviewed this part in the original pr.
>
> Here are the han
On Wed, 7 Jun 2023 05:05:38 GMT, Prasanta Sadhukhan
wrote:
>> Alexander Zvegintsev has updated the pull request incrementally with two
>> additional commits since the last revision:
>>
>> - move screencast-tokens.properties to a new location
>> - fix failure of
>> javax/swing/reliability/Ha
1 - 100 of 165 matches
Mail list logo
