On Fri, 3 Mar 2023 20:25:09 GMT, Harshitha Onkar <hon...@openjdk.org> wrote:
>> HarfBuzz library updated from v4.4.1 to v7.0.1 >> >> - harfbuzz.md file updated >> - Added -DHB_NO_VISIBILITY to HARFBUZZ_CFLAGS in Awt2DLibraries.gmk to avoid >> build issues on linux and macos targets. >> - GPOS.hh has been moved from Layout to Layout/GPOS to match upstream >> changes. >> - Total of 270 files changed out of which 46 are newly added. > > Harshitha Onkar has updated the pull request incrementally with one > additional commit since the last revision: > > Updating.txt changes src/java.desktop/share/native/libharfbuzz/hb-icu.h line 1: > 1: /* We don't need/use hb-icu.h and hb-icu.cc, so why are they here ? They were there in harfbuzz source for a long time and we've never needed them before and given what their purpose is, I don't see why we need them now. Are you sure you followed the process of adding in ONLY new files which were needed so that we successfully compiler ? Please double check ALL new files you added are really needed. ------------- PR: https://git.openjdk.org/jdk/pull/12864
