On Wed, 11 Oct 2023 21:05:28 GMT, Mikael Vidstedt <mik...@openjdk.org> wrote:
>> macOS 10.x is no longer receiving updates - the most recent/last release was >> 10.15.7 back in July of 2022. It's time to bump the target macOS version >> (min/max) for macosx-x64. macOS 11.x is still receiving updates. >> >> This change updates the target version for macosx-x64 to 11.00.00, which is >> the same version used for macosx-aarch64. > > Mikael Vidstedt has updated the pull request incrementally with two > additional commits since the last revision: > > - Update stale comment (again) > - Update stale comment make/modules/java.desktop/lib/Awt2dLibraries.gmk line 926: > 924: # pipeline only on macOS >=10.14. For macOS versions <10.14 even if > 925: # we enable Metal pipeline using -Dsun.java2d.metal=true, at > 926: # runtime we force it to use OpenGL pipeline. The comment is obsolete now, since the code that references 10.14 is now gone. it could be a puzzler to anyone reading it later as to how it could be supported on 10.14 when the JDK isn't. It probably should just be "Metal uses the same minimum version as the rest of the JDK" keeping the first sentence though. so in total MACOSX_METAL_VERSION_MIN specifies the lowest version of macOS that should be used to compile Metal shaders. Metal uses the same minimum version as the rest of the JDK ------------- PR Review Comment: https://git.openjdk.org/jdk/pull/16155#discussion_r1355775805
