Re: RFR: 8352064: AIX: now also able to build static-jdk image with a statically linked launcher [v5]

2025-03-24 Thread Matthias Baesken
On Fri, 21 Mar 2025 16:19:38 GMT, Joachim Kern wrote: >> After "JDK-8339480: Build static-jdk image with a statically linked >> launcher" AIX was not able to build the new target. Therefore with >> "JDK-8345590 AIX 'make all' fails after JDK-8339480" the new target was >> disabled again. >> >

Integrated: 8352064: AIX: now also able to build static-jdk image with a statically linked launcher

2025-03-24 Thread Joachim Kern
On Fri, 14 Mar 2025 15:41:56 GMT, Joachim Kern wrote: > After "JDK-8339480: Build static-jdk image with a statically linked launcher" > AIX was not able to build the new target. Therefore with "JDK-8345590 AIX > 'make all' fails after JDK-8339480" the new target was disabled again. > > Now wit

Re: RFR: 8352692: Add support for extra jlink options

2025-03-24 Thread Erik Joelsson
On Mon, 24 Mar 2025 10:37:10 GMT, Severin Gehwolf wrote: > Please review this simple change to allow for extra `jlink` flags to be > passed to the JDK build by `configure`. The bug describes use-cases where > this would be needed. > > Testing: > - [x] GHA > - [x] Manual tests with a fix for >

Re: RFR: 8352692: Add support for extra jlink options

2025-03-24 Thread Severin Gehwolf
On Mon, 24 Mar 2025 10:37:10 GMT, Severin Gehwolf wrote: > Please review this simple change to allow for extra `jlink` flags to be > passed to the JDK build by `configure`. The bug describes use-cases where > this would be needed. > > Testing: > - [x] GHA > - [x] Manual tests with a fix for >

Re: RFR: 8352284: EXTRA_CFLAGS incorrectly applied to BUILD_LIBJVM src/hotspot C++ source files [v2]

2025-03-24 Thread Magnus Ihse Bursie
On Sat, 22 Mar 2025 10:09:46 GMT, Patrick Zhang wrote: >> Building jdk with `--with-extra-cflags='-Wno-incompatible-pointer-types'` >> triggers 1000+ warning messages like `cc1plus: warning: command-line option >> ‘-Wno-incompatible-pointer-types’ is valid for C/ObjC but not for C++`. >> >> T

Re: RFR: 8352284: EXTRA_CFLAGS incorrectly applied to BUILD_LIBJVM src/hotspot C++ source files [v2]

2025-03-24 Thread Patrick Zhang
On Mon, 24 Mar 2025 17:06:11 GMT, Magnus Ihse Bursie wrote: >> Patrick Zhang has updated the pull request incrementally with three >> additional commits since the last revision: >> >> - Fixed a typo >> >>Signed-off-by: Patrick Zhang >> - Added comments to describe why EXTRA_CFLAGS is

Re: RFR: 8352064: AIX: now also able to build static-jdk image with a statically linked launcher [v5]

2025-03-24 Thread Matthias Baesken
On Fri, 21 Mar 2025 16:19:38 GMT, Joachim Kern wrote: >> After "JDK-8339480: Build static-jdk image with a statically linked >> launcher" AIX was not able to build the new target. Therefore with >> "JDK-8345590 AIX 'make all' fails after JDK-8339480" the new target was >> disabled again. >> >

Re: RFR: 8352481: Extra a.out generated after configure with clang [v4]

2025-03-24 Thread SendaoYan
> Hi all, > > There is an extra a.out file generated located in repository root directory > after execute the configure command with llvm/clang compiler sometimes, not > always. The a.out was generate by `$LINKER -Wl,-v 2>&1 | $HEAD -n 1`, shows > as below. This PR add a command to remove the

Re: RFR: 8352481: Extra a.out generated after configure with clang [v3]

2025-03-24 Thread SendaoYan
On Mon, 24 Mar 2025 13:27:19 GMT, Erik Joelsson wrote: >> SendaoYan has updated the pull request incrementally with one additional >> commit since the last revision: >> >> Use "-f" parameter instead of "-rf" > > make/autoconf/toolchain.m4 line 536: > >> 534: >> 535: LINKER_VERSION_STRIN

Re: RFR: 8352064: AIX: now also able to build static-jdk image with a statically linked launcher [v5]

2025-03-24 Thread Magnus Ihse Bursie
On Mon, 24 Mar 2025 14:30:02 GMT, Matthias Baesken wrote: > Regarding BitmapToYXBandedRectangles from splashscreen, couldn't we just > rename it to avoid clashes/issues with the other one from awt with the same > name but other signature? But this can be done in another issue/PR not here. Inde

Re: RFR: 8352064: AIX: now also able to build static-jdk image with a statically linked launcher [v5]

2025-03-24 Thread Matthias Baesken
On Fri, 21 Mar 2025 16:19:38 GMT, Joachim Kern wrote: >> After "JDK-8339480: Build static-jdk image with a statically linked >> launcher" AIX was not able to build the new target. Therefore with >> "JDK-8345590 AIX 'make all' fails after JDK-8339480" the new target was >> disabled again. >> >

Re: RFR: 8352481: Extra a.out generated after configure with clang [v3]

2025-03-24 Thread Erik Joelsson
On Sat, 22 Mar 2025 06:50:48 GMT, SendaoYan wrote: >> Hi all, >> >> There is an extra a.out file generated located in repository root directory >> after execute the configure command with llvm/clang compiler sometimes, not >> always. The a.out was generate by `$LINKER -Wl,-v 2>&1 | $HEAD -n 1`

Re: RFR: 8352064: AIX: now also able to build static-jdk image with a statically linked launcher [v5]

2025-03-24 Thread Magnus Ihse Bursie
On Mon, 24 Mar 2025 15:46:03 GMT, Matthias Baesken wrote: > Seems we use already a bit of functionality from common/awt in the > splashscreen lib Maybe. The client team has traditionally been very conservative about doing clean-up changes like that, so you might be entering an uphill battle if

Re: RFR: 8352284: EXTRA_CFLAGS incorrectly applied to BUILD_LIBJVM src/hotspot C++ source files [v2]

2025-03-24 Thread Magnus Ihse Bursie
On Sat, 22 Mar 2025 10:09:46 GMT, Patrick Zhang wrote: >> Building jdk with `--with-extra-cflags='-Wno-incompatible-pointer-types'` >> triggers 1000+ warning messages like `cc1plus: warning: command-line option >> ‘-Wno-incompatible-pointer-types’ is valid for C/ObjC but not for C++`. >> >> T

Re: RFR: 8352064: AIX: now also able to build static-jdk image with a statically linked launcher [v5]

2025-03-24 Thread Matthias Baesken
On Fri, 21 Mar 2025 16:19:38 GMT, Joachim Kern wrote: >> After "JDK-8339480: Build static-jdk image with a statically linked >> launcher" AIX was not able to build the new target. Therefore with >> "JDK-8345590 AIX 'make all' fails after JDK-8339480" the new target was >> disabled again. >> >

Re: RFR: 8352481: Extra a.out generated after configure with clang [v5]

2025-03-24 Thread SendaoYan
> Hi all, > > There is an extra a.out file generated located in repository root directory > after execute the configure command with llvm/clang compiler sometimes, not > always. The a.out was generate by `$LINKER -Wl,-v 2>&1 | $HEAD -n 1`, shows > as below. This PR add a command to remove the

Re: RFR: 8352481: Extra a.out generated after configure with clang [v4]

2025-03-24 Thread SendaoYan
On Mon, 24 Mar 2025 15:31:41 GMT, Magnus Ihse Bursie wrote: >> SendaoYan has updated the pull request incrementally with one additional >> commit since the last revision: >> >> fix spelling bug > > `RM` is actually defined as `rm -f` so the `-f` is not necessary. > > I'm still not very happy

Re: RFR: 8352284: EXTRA_CFLAGS incorrectly applied to BUILD_LIBJVM src/hotspot C++ source files [v2]

2025-03-24 Thread Patrick Zhang
On Mon, 24 Mar 2025 18:43:42 GMT, Magnus Ihse Bursie wrote: >> Patrick Zhang has updated the pull request incrementally with three >> additional commits since the last revision: >> >> - Fixed a typo >> >>Signed-off-by: Patrick Zhang >> - Added comments to describe why EXTRA_CFLAGS is

Re: RFR: 8351277: Remove pipewire from AIX build [v3]

2025-03-24 Thread Phil Race
On Fri, 21 Mar 2025 08:58:36 GMT, Matthias Baesken wrote: >> Seems Wayland is not supported on AIX, so we most likely do not need to >> build pipewire on AIX and can remove it from the build. >> Reason is that pipewire updates can break the AIX build, so better avoid it >> if possible. >> >> T

Re: RFR: 8351277: Remove pipewire from AIX build [v3]

2025-03-24 Thread Matthias Baesken
On Fri, 21 Mar 2025 08:58:36 GMT, Matthias Baesken wrote: >> Seems Wayland is not supported on AIX, so we most likely do not need to >> build pipewire on AIX and can remove it from the build. >> Reason is that pipewire updates can break the AIX build, so better avoid it >> if possible. >> >> T

RFR: 8352692: Add support for extra jlink options

2025-03-24 Thread Severin Gehwolf
Please review this simple change to allow for extra `jlink` flags to be passed to the JDK build by `configure`. The bug describes use-cases where this would be needed. Testing: - [ ] GHA (currently running) - [x] Manual tests with a fix for [JDK-8352689](https://bugs.openjdk.org/browse/JDK-8352