On Mon, 24 Mar 2025 13:27:19 GMT, Erik Joelsson <er...@openjdk.org> wrote:
>> SendaoYan has updated the pull request incrementally with one additional >> commit since the last revision: >> >> Use "-f" parameter instead of "-rf" > > make/autoconf/toolchain.m4 line 536: > >> 534: >> 535: LINKER_VERSION_STRING=`$LINKER -Wl,-v 2>&1 | $HEAD -n 1` >> 536: # Remove redundant a.out generated by clang, to workaound clang bug >> https://github.com/llvm/llvm-project/issues/132388 > > Spelling and line length, otherwise this looks ok. > Suggestion: > > # Remove redundant a.out generated by clang, to work around clang bug > # https://github.com/llvm/llvm-project/issues/132388 Thanks. PR has been updated. ------------- PR Review Comment: https://git.openjdk.org/jdk/pull/24125#discussion_r2010412509
