Re: RFR: 8352510: Don't reset LCMS_CFLAGS

2025-03-20 Thread Alexander Zvegintsev
On Thu, 20 Mar 2025 13:15:01 GMT, Magnus Ihse Bursie wrote: > In [JDK-8329086](https://bugs.openjdk.org/browse/JDK-8329086), when cleaning > up the native build for java.desktop, what was likely a bug with LCMS_CFLAGS > was found. See the discussion at > https://github.com/openjdk/jdk/pull/184

Re: RFR: 8352506: Simplify make/test/JtregNativeHotspot.gmk

2025-03-20 Thread David Holmes
On Thu, 20 Mar 2025 12:32:53 GMT, Magnus Ihse Bursie wrote: > The file to setup special arguments to native JTReg Hotspot tests is > needlessly complicated. With some generalisation, we can make it much simpler. make/test/JtregNativeHotspot.gmk line 121: > 119: -I$(VM_TESTBASE_DIR)/nsk/str

Re: RFR: 8352506: Simplify make/test/JtregNativeHotspot.gmk

2025-03-20 Thread Erik Joelsson
On Thu, 20 Mar 2025 12:32:53 GMT, Magnus Ihse Bursie wrote: > The file to setup special arguments to native JTReg Hotspot tests is > needlessly complicated. With some generalisation, we can make it much simpler. I think this is ok, but I would like someone with familiarity with these tests to

Re: RFR: 8351842: Windows specific issues in combination of JEP 493 and --with-external-symbols-in-bundles=public

2025-03-20 Thread Severin Gehwolf
On Mon, 17 Mar 2025 08:27:20 GMT, Christoph Langer wrote: >> Alternative approach to #24012 >> >> This keeps the current handling of *.pdb vs *.stripped.pdb which allows >> debugging at the cost of a little hack in jlink. Maybe the code in jlink can >> be improved, e.g. make it more conditiona

RFR: 8352506: Simplify make/test/JtregNativeHotspot.gmk

2025-03-20 Thread Magnus Ihse Bursie
The file to setup special arguments to native JTReg Hotspot tests is needlessly complicated. With some generalisation, we can make it much simpler. - Commit messages: - 8352506: Simplify make/test/JtregNativeHotspot.gmk Changes: https://git.openjdk.org/jdk/pull/24130/files Webrev

Re: RFR: 8352506: Simplify make/test/JtregNativeHotspot.gmk

2025-03-20 Thread Magnus Ihse Bursie
On Thu, 20 Mar 2025 12:32:53 GMT, Magnus Ihse Bursie wrote: > The file to setup special arguments to native JTReg Hotspot tests is > needlessly complicated. With some generalisation, we can make it much simpler. This has passed hotspot testing for tier1-3 in the Oracle CI system. -

Re: RFR: 8329173: LCMS_CFLAGS from configure are lost

2025-03-20 Thread Magnus Ihse Bursie
On Thu, 20 Mar 2025 13:15:01 GMT, Magnus Ihse Bursie wrote: > In [JDK-8329086](https://bugs.openjdk.org/browse/JDK-8329086), when cleaning > up the native build for java.desktop, what was likely a bug with LCMS_CFLAGS > was found. See the discussion at > https://github.com/openjdk/jdk/pull/184

Re: RFR: 8351277: Remove pipewire from AIX build [v2]

2025-03-20 Thread Alexander Zvegintsev
On Thu, 13 Mar 2025 13:06:38 GMT, Matthias Baesken wrote: >> Seems Wayland is not supported on AIX, so we most likely do not need to >> build pipewire on AIX and can remove it from the build. >> Reason is that pipewire updates can break the AIX build, so better avoid it >> if possible. >> >> T

Re: RFR: 8351277: Remove pipewire from AIX build [v2]

2025-03-20 Thread Magnus Ihse Bursie
On Thu, 20 Mar 2025 22:25:49 GMT, Alexander Zvegintsev wrote: >> To me it sounds like defensive programming to include an implementation of >> all native methods, so the JVM will not crash if it mistakenly is called. Do >> you see a problem with that? > > I do not see a problem here, but in th

Re: RFR: 8351322: Parameterize link option for pthreads [v2]

2025-03-20 Thread David Holmes
On Thu, 20 Mar 2025 12:38:37 GMT, Magnus Ihse Bursie wrote: > Is there any gain then in changing away from -lpthread? That is clearly > defined, link with libpthread, with no side effects. "If it ain't broke..." True - what we have works and using `-pthread` might subtly change things. ---

Integrated: 8329173: LCMS_CFLAGS from configure are lost

2025-03-20 Thread Magnus Ihse Bursie
On Thu, 20 Mar 2025 13:15:01 GMT, Magnus Ihse Bursie wrote: > In [JDK-8329086](https://bugs.openjdk.org/browse/JDK-8329086), when cleaning > up the native build for java.desktop, what was likely a bug with LCMS_CFLAGS > was found. See the discussion at > https://github.com/openjdk/jdk/pull/184

Re: RFR: 8352506: Simplify make/test/JtregNativeHotspot.gmk

2025-03-20 Thread David Holmes
On Thu, 20 Mar 2025 22:40:51 GMT, Magnus Ihse Bursie wrote: >> make/test/JtregNativeHotspot.gmk line 121: >> >>> 119: -I$(VM_TESTBASE_DIR)/nsk/stress/jni \ >>> 120: -I$(VM_TESTBASE_DIR)/vm/mlvm/share \ >>> 121: -I$(VM_TESTBASE_DIR)/vm/share \ >> >> Including these directories for ev

Re: RFR: 8352044: Add --with-import-jvms to configure

2025-03-20 Thread Alan Bateman
On Wed, 19 Mar 2025 12:45:23 GMT, Erik Joelsson wrote: > Just to make sure I'm understanding you correctly. Are you proposing that > instead of building a single JDK distribution with multiple JVMs, they would > build a separate JDK for each alternative JVM configuration and publish > java.bas

RFR: 8352481: Extra a.out generated after configure with clang

2025-03-20 Thread SendaoYan
Hi all, There is an extra a.out file generated located in repository root directory after execute the configure command with llvm/clang compiler sometimes, not always. The a.out was generate by `$LINKER -Wl,-v 2>&1 | $HEAD -n 1`, shows as below. This PR add a command to remove the extra a.out

Re: RFR: 8351277: Remove pipewire from AIX build [v2]

2025-03-20 Thread Matthias Baesken
On Thu, 13 Mar 2025 20:00:33 GMT, Phil Race wrote: > Looks right to me, but I will do a test build. Was the test build successful ? - PR Comment: https://git.openjdk.org/jdk/pull/24009#issuecomment-2740436693

Re: RFR: 8352064: AIX: now also able to build static-jdk image with a statically linked launcher [v3]

2025-03-20 Thread Joachim Kern
> After "JDK-8339480: Build static-jdk image with a statically linked launcher" > AIX was not able to build the new target. Therefore with "JDK-8345590 AIX > 'make all' fails after JDK-8339480" the new target was disabled again. > > Now with this change we can enable the statically linked launch

Re: RFR: 8351322: Parameterize link option for pthreads [v2]

2025-03-20 Thread Magnus Ihse Bursie
On Mon, 17 Mar 2025 10:44:30 GMT, snake66 wrote: >>> Another follow-up is if it would hurt to include $LIBPTHREAD for _all_ >>> Hotspot tests, to avoid the huge list. @dholmes-ora Do you have anything >>> coming to mind directly that would make that infeasible, or is it just a >>> matter of te

RFR: 8352510: Don't reset LCMS_CFLAGS

2025-03-20 Thread Magnus Ihse Bursie
In [JDK-8329086](https://bugs.openjdk.org/browse/JDK-8329086), when cleaning up the native build for java.desktop, what was likely a bug with LCMS_CFLAGS was found. See the discussion at https://github.com/openjdk/jdk/pull/18486#discussion_r1539179250. The old behavior was kept to not introduce

Re: RFR: 8352510: Don't reset LCMS_CFLAGS

2025-03-20 Thread Erik Joelsson
On Thu, 20 Mar 2025 13:15:01 GMT, Magnus Ihse Bursie wrote: > In [JDK-8329086](https://bugs.openjdk.org/browse/JDK-8329086), when cleaning > up the native build for java.desktop, what was likely a bug with LCMS_CFLAGS > was found. See the discussion at > https://github.com/openjdk/jdk/pull/184