On Thu, 20 Mar 2025 12:32:53 GMT, Magnus Ihse Bursie <i...@openjdk.org> wrote:
> The file to setup special arguments to native JTReg Hotspot tests is > needlessly complicated. With some generalisation, we can make it much simpler. make/test/JtregNativeHotspot.gmk line 121: > 119: -I$(VM_TESTBASE_DIR)/nsk/stress/jni \ > 120: -I$(VM_TESTBASE_DIR)/vm/mlvm/share \ > 121: -I$(VM_TESTBASE_DIR)/vm/share \ Including these directories for every native test seems a little risky. Are we sure there are no header files with the same name? Can we not still add these only if the test needs them e.g. if it has vmTestBase in its name for the nsk tests? ------------- PR Review Comment: https://git.openjdk.org/jdk/pull/24130#discussion_r2006446472
