On Thu, 20 Mar 2025 22:25:49 GMT, Alexander Zvegintsev <azveg...@openjdk.org> wrote:
>> To me it sounds like defensive programming to include an implementation of >> all native methods, so the JVM will not crash if it mistakenly is called. Do >> you see a problem with that? > > I do not see a problem here, but in this case the > `Java_sun_awt_screencast_ScreencastHelper_getRGBPixelsImpl` is missing, as > the ScreencastHelper has 3 native methods. Ah, I see. I agree, that it makes more sense to either include all native methods, or skip all that are never called. Adding a dummy implementation of one but not all seems ... weird. ------------- PR Review Comment: https://git.openjdk.org/jdk/pull/24009#discussion_r2006566872
