Re: RFR: 8352015: LIBVERIFY_OPTIMIZATION remove special optimization settings

2025-03-14 Thread Matthias Baesken
On Fri, 14 Mar 2025 11:15:26 GMT, Matthias Baesken wrote: > On Linux there are some special settings for LIBVERIFY_OPTIMIZATION that are > most likely not needed any more and could be removed. > The removal (on Linux) brings the lib optimization level de facto from LOW to > HIGH. Example lib s

RFR: 8352064: AIX: now also able to build static-jdk image with a statically linked launcher

2025-03-14 Thread Joachim Kern
After "JDK-8339480: Build static-jdk image with a statically linked launcher" AIX was not able to build the new target. Therefore with "JDK-8345590 AIX 'make all' fails after JDK-8339480" the new target was disabled again. Now with this change we can enable the statically linked launcher target

Re: RFR: 8352015: LIBVERIFY_OPTIMIZATION remove special optimization settings

2025-03-14 Thread Matthias Baesken
On Fri, 14 Mar 2025 11:34:08 GMT, Magnus Ihse Bursie wrote: > What testing have you run? I put it into our testing queue, this runs jtreg tier 1 - 4 and some more stuff over the weekend on all our platforms. - PR Comment: https://git.openjdk.org/jdk/pull/24054#issuecomment-2724577

Re: RFR: 8351842: Test issues on Windows with combination of --enable-linkable-runtime and --with-external-symbols-in-bundles=public

2025-03-14 Thread Magnus Ihse Bursie
On Fri, 14 Mar 2025 13:38:51 GMT, Alan Bateman wrote: >> Alternative approach to #24012 >> >> This keeps the current handling of *.pdb vs *.stripped.pdb which allows >> debugging at the cost of a little hack in jlink. Maybe the code in jlink can >> be improved, e.g. make it more conditional. >

Re: RFR: 8352044: Add --with-import-jvms to configure

2025-03-14 Thread David Holmes
On Fri, 14 Mar 2025 17:58:50 GMT, Magnus Ihse Bursie wrote: >> This change copies `libjvm.so` _and_ sibling `.jsa` files, right? >> >> If so, then one thing is missing: regenerating CDS archives that have >> opinions on `modules` filesizes/dates for fingerprinting their CDS archives. >> My fra

RFR: 8352084: Add more test code in TestSetupAOT.java

2025-03-14 Thread Ioi Lam
I modified TestSetupAOT.java to exercise more functionalities in the JDK so that we can have a more substantial AOT cache when running tests with `AOT_JDK=true`. E.g: make test JTREG=AOT_JDK=true \ TEST=open/test/jdk/java/util/TimeZone/ListTimeZones.java Before: the generated AOT cache wa

Re: RFR: 8351542: LIBMANAGEMENT_OPTIMIZATION remove special optimization settings [v5]

2025-03-14 Thread Matthias Baesken
On Thu, 13 Mar 2025 17:41:28 GMT, Kevin Walls wrote: > Yes seems likely the same history for libverify, so should be good to do the > same update there. I created https://bugs.openjdk.org/browse/JDK-8352015 . - PR Comment: https://git.openjdk.org/jdk/pull/23966#issuecomment-272398

Re: RFR: JDK-8348598 : Update Libpng to 1.6.47 [v3]

2025-03-14 Thread Harshitha Onkar
On Fri, 14 Mar 2025 02:02:58 GMT, Sergey Bylokhov wrote: >> make/modules/java.desktop/lib/ClientLibraries.gmk line 249: >> >>> 247: DISABLED_WARNINGS_clang_dgif_lib.c := sign-compare, \ >>> 248: DISABLED_WARNINGS_clang_gzwrite.c := format-nonliteral, \ >>> 249: DISABLED_WARNING

Re: RFR: 8352084: Add more test code in TestSetupAOT.java

2025-03-14 Thread Vladimir Kozlov
On Fri, 14 Mar 2025 20:13:57 GMT, Ioi Lam wrote: > I modified TestSetupAOT.java to exercise more functionalities in the JDK so > that we can have a more substantial AOT cache when running tests with > `AOT_JDK=true`. E.g: > > > make test JTREG=AOT_JDK=true \ > TEST=open/test/jdk/java/util

Re: RFR: 8352084: Add more test code in TestSetupAOT.java

2025-03-14 Thread Leonid Mesnik
On Fri, 14 Mar 2025 20:13:57 GMT, Ioi Lam wrote: > I modified TestSetupAOT.java to exercise more functionalities in the JDK so > that we can have a more substantial AOT cache when running tests with > `AOT_JDK=true`. E.g: > > > make test JTREG=AOT_JDK=true \ > TEST=open/test/jdk/java/util

Re: RFR: 8352084: Add more test code in TestSetupAOT.java

2025-03-14 Thread Erik Joelsson
On Fri, 14 Mar 2025 20:13:57 GMT, Ioi Lam wrote: > I modified TestSetupAOT.java to exercise more functionalities in the JDK so > that we can have a more substantial AOT cache when running tests with > `AOT_JDK=true`. E.g: > > > make test JTREG=AOT_JDK=true \ > TEST=open/test/jdk/java/util

Re: RFR: 8352064: AIX: now also able to build static-jdk image with a statically linked launcher

2025-03-14 Thread Erik Joelsson
On Fri, 14 Mar 2025 15:41:56 GMT, Joachim Kern wrote: > After "JDK-8339480: Build static-jdk image with a statically linked launcher" > AIX was not able to build the new target. Therefore with "JDK-8345590 AIX > 'make all' fails after JDK-8339480" the new target was disabled again. > > Now wit

Re: RFR: 8351842: Test issues on Windows with combination of --enable-linkable-runtime and --with-external-symbols-in-bundles=public

2025-03-14 Thread Alan Bateman
On Fri, 14 Mar 2025 12:29:22 GMT, Christoph Langer wrote: > Alternative approach to #24012 > > This keeps the current handling of *.pdb vs *.stripped.pdb which allows > debugging at the cost of a little hack in jlink. Maybe the code in jlink can > be improved, e.g. make it more conditional. >

Re: RFR: 8351821: VMManagementImpl.c avoid switching off warnings

2025-03-14 Thread Kevin Walls
On Fri, 14 Mar 2025 10:06:32 GMT, Matthias Baesken wrote: > We switched off unused-variable warnings for the file VMManagementImpl.c, > this should be avoided. > This came up in [JDK-8351542](https://bugs.openjdk.org/browse/JDK-8351542) , We know GetOptionalSupport can't realistically fail, unl

Re: RFR: 8351821: VMManagementImpl.c avoid switching off warnings

2025-03-14 Thread Matthias Baesken
On Fri, 14 Mar 2025 10:06:32 GMT, Matthias Baesken wrote: > We switched off unused-variable warnings for the file VMManagementImpl.c, > this should be avoided. > This came up in [JDK-8351542](https://bugs.openjdk.org/browse/JDK-8351542) , In case someone has a good/better idea what to do with t

Re: RFR: 8351821: VMManagementImpl.c avoid switching off warnings

2025-03-14 Thread Magnus Ihse Bursie
On Fri, 14 Mar 2025 10:06:32 GMT, Matthias Baesken wrote: > We switched off unused-variable warnings for the file VMManagementImpl.c, > this should be avoided. > This came up in [JDK-8351542](https://bugs.openjdk.org/browse/JDK-8351542) , Build changes look good to me. - Marked as

Re: RFR: 8351603: Change to GCC 14.2.0 for building on Linux at Oracle [v2]

2025-03-14 Thread Magnus Ihse Bursie
On Thu, 13 Mar 2025 22:55:33 GMT, Mikael Vidstedt wrote: >> Background: >> >> Oracle is updating the version of GCC for building the JDK on Linux to >> 14.2.0. >> >> This change updates the versions of the components used for the (Linux) >> devkit. Newer versions of ccache use cmake for the b

Re: RFR: 8351603: Change to GCC 14.2.0 for building on Linux at Oracle [v2]

2025-03-14 Thread Magnus Ihse Bursie
On Thu, 13 Mar 2025 22:55:33 GMT, Mikael Vidstedt wrote: >> Background: >> >> Oracle is updating the version of GCC for building the JDK on Linux to >> 14.2.0. >> >> This change updates the versions of the components used for the (Linux) >> devkit. Newer versions of ccache use cmake for the b

Re: RFR: 8351842: Test issues on Windows with combination of --enable-linkable-runtime and --with-external-symbols-in-bundles=public [v2]

2025-03-14 Thread Frederic Thevenet
On Thu, 13 Mar 2025 07:39:20 GMT, Christoph Langer wrote: >> This PR addresses an issue that can be observed when building on Windows >> with configure options `--enable-linkable-runtime` and >> `--with-external-symbols-in-bundles=public`. >> >> The problem is that with this special build conf

Re: RFR: 8351842: Test issues on Windows with combination of --enable-linkable-runtime and --with-external-symbols-in-bundles=public [v2]

2025-03-14 Thread Magnus Ihse Bursie
On Thu, 13 Mar 2025 07:39:20 GMT, Christoph Langer wrote: >> This PR addresses an issue that can be observed when building on Windows >> with configure options `--enable-linkable-runtime` and >> `--with-external-symbols-in-bundles=public`. >> >> The problem is that with this special build conf

Re: RFR: 8352015: LIBVERIFY_OPTIMIZATION remove special optimization settings

2025-03-14 Thread Alan Bateman
On Fri, 14 Mar 2025 11:15:26 GMT, Matthias Baesken wrote: > On Linux there are some special settings for LIBVERIFY_OPTIMIZATION that are > most likely not needed any more and could be removed. > The removal (on Linux) brings the lib optimization level de facto from LOW to > HIGH. In addition t

Re: RFR: 8352015: LIBVERIFY_OPTIMIZATION remove special optimization settings

2025-03-14 Thread Magnus Ihse Bursie
On Fri, 14 Mar 2025 11:53:33 GMT, Alan Bateman wrote: >> On Linux there are some special settings for LIBVERIFY_OPTIMIZATION that are >> most likely not needed any more and could be removed. >> The removal (on Linux) brings the lib optimization level de facto from LOW >> to HIGH. > > In additio

Re: RFR: 8351842: Test issues on Windows with combination of --enable-linkable-runtime and --with-external-symbols-in-bundles=public [v2]

2025-03-14 Thread Severin Gehwolf
On Fri, 14 Mar 2025 12:31:22 GMT, Christoph Langer wrote: > Given all of this, is there any possibility at all for > --enable-linkable-runtime to handle both full and stripped pdb files, or do > we need to accept that this is an inherent limitation for the linkable > runtime? I see a couple o

Re: RFR: 8352044: Add --with-import-jvms to configure

2025-03-14 Thread Aleksey Shipilev
On Fri, 14 Mar 2025 15:49:44 GMT, Magnus Ihse Bursie wrote: > We should allow pre-built JVMs to be included in a build, so they are just > copied into place, and the jvm.cfg file properly updated. This change copies `libjvm.so` _and_ sibling `.jsa` files, right? If so, then one thing is missin

Re: RFR: 8351603: Change to GCC 14.2.0 for building on Linux at Oracle [v2]

2025-03-14 Thread Erik Joelsson
On Thu, 13 Mar 2025 22:55:33 GMT, Mikael Vidstedt wrote: >> Background: >> >> Oracle is updating the version of GCC for building the JDK on Linux to >> 14.2.0. >> >> This change updates the versions of the components used for the (Linux) >> devkit. Newer versions of ccache use cmake for the b

Re: RFR: 8351842: Test issues on Windows with combination of --enable-linkable-runtime and --with-external-symbols-in-bundles=public

2025-03-14 Thread Severin Gehwolf
On Fri, 14 Mar 2025 12:29:22 GMT, Christoph Langer wrote: > Alternative approach to #24012 > > This keeps the current handling of *.pdb vs *.stripped.pdb which allows > debugging at the cost of a little hack in jlink. Maybe the code in jlink can > be improved, e.g. make it more conditional. >

RFR: 8352015: LIBVERIFY_OPTIMIZATION remove special optimization settings

2025-03-14 Thread Matthias Baesken
On Linux there are some special settings for LIBVERIFY_OPTIMIZATION that are most likely not needed any more and could be removed. The removal (on Linux) brings the lib optimization level de facto from LOW to HIGH. - Commit messages: - JDK-8352015 Changes: https://git.openjdk.org/

RFR: 8352044: Add --with-import-jvms to configure

2025-03-14 Thread Magnus Ihse Bursie
We should allow pre-built JVMs to be included in a build, so they are just copied into place, and the jvm.cfg file properly updated. - Commit messages: - 8352044: Add --with-import-jvms to configure Changes: https://git.openjdk.org/jdk/pull/24063/files Webrev: https://webrevs.ope

RFR: 8351821: VMManagementImpl.c avoid switching off warnings

2025-03-14 Thread Matthias Baesken
We switched off unused-variable warnings for the file VMManagementImpl.c, this should be avoided. This came up in [JDK-8351542](https://bugs.openjdk.org/browse/JDK-8351542) , - Commit messages: - JDK-8351821 Changes: https://git.openjdk.org/jdk/pull/24052/files Webrev: https://we

Re: RFR: 8352084: Add more test code in TestSetupAOT.java [v2]

2025-03-14 Thread Ioi Lam
On Fri, 14 Mar 2025 23:21:59 GMT, Leonid Mesnik wrote: >> Ioi Lam has updated the pull request incrementally with one additional >> commit since the last revision: >> >> Review comments from @erikj79 and @lmesnik > > make/RunTests.gmk line 738: > >> 736: $1_AOT_JDK_CACHE := $$($1_TEST_SUPP

Re: RFR: 8351842: Test issues on Windows with combination of --enable-linkable-runtime and --with-external-symbols-in-bundles=public

2025-03-14 Thread Severin Gehwolf
On Fri, 14 Mar 2025 13:55:26 GMT, Magnus Ihse Bursie wrote: >> src/jdk.jlink/share/classes/jdk/tools/jlink/internal/JRTArchive.java line >> 226: >> >>> 224: if (Files.exists(strippedPath)) { >>> 225: path = strippedPath; >>> 226:

Re: RFR: 8352084: Add more test code in TestSetupAOT.java [v2]

2025-03-14 Thread Leonid Mesnik
On Sat, 15 Mar 2025 02:08:33 GMT, Ioi Lam wrote: >> I modified TestSetupAOT.java to exercise more functionalities in the JDK so >> that we can have a more substantial AOT cache when running tests with >> `AOT_JDK=true`. E.g: >> >> >> make test JTREG=AOT_JDK=true \ >> TEST=open/test/jdk/ja

Re: RFR: 8352084: Add more test code in TestSetupAOT.java [v2]

2025-03-14 Thread Ioi Lam
> I modified TestSetupAOT.java to exercise more functionalities in the JDK so > that we can have a more substantial AOT cache when running tests with > `AOT_JDK=true`. E.g: > > > make test JTREG=AOT_JDK=true \ > TEST=open/test/jdk/java/util/TimeZone/ListTimeZones.java > > > Before: the ge