On Fri, 14 Mar 2025 15:49:44 GMT, Magnus Ihse Bursie <i...@openjdk.org> wrote:

> We should allow pre-built JVMs to be included in a build, so they are just 
> copied into place, and the jvm.cfg file properly updated.

This change copies `libjvm.so` _and_ sibling `.jsa` files, right?

If so, then one thing is missing: regenerating CDS archives that have opinions 
on `modules` filesizes/dates for fingerprinting their CDS archives. My 
frankensteining scripts do that by invoking new JVM explicitly with 
`-Xshare:dump`. But build system should already know how to do that, as it does 
it at the end of the build.

-------------

PR Review: https://git.openjdk.org/jdk/pull/24063#pullrequestreview-2686128808

Reply via email to