On Fri, 14 Mar 2025 20:13:57 GMT, Ioi Lam <ik...@openjdk.org> wrote:

> I modified TestSetupAOT.java to exercise more functionalities in the JDK so 
> that we can have a more substantial AOT cache when running tests with 
> `AOT_JDK=true`. E.g:
> 
> 
> make test JTREG=AOT_JDK=true \
>     TEST=open/test/jdk/java/util/TimeZone/ListTimeZones.java
> 
> 
> Before: the generated AOT cache was about 20 MB, with 2245 classes and 125 
> resolved indies
> After:  the generated AOT cache is about 34 MB, with 4703 classes and 912 
> resolved indies
> 
> I verified with Mach5 tiers 4, 5, 6, 10 with all tests tasks that have the 
> label `.*aot.jdkcache.*`

make/test/BuildTestSetupAOT.gmk line 62:

> 60:              JavacBenchApp$$FileManager.class \
> 61:              JavacBenchApp$$SourceFile.class \
> 62:              TestSetupAOT.class, \

Listing all class files like this is cumbersome. Perhaps we should build this 
into a jar file instead now that there are more classes? It should be as easy 
as adding `JAR := <name of jar>` to the SetupJavaCompilation call above and 
then copy that file. Or would that interfere with the classpath requirements 
when using the tool?

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/24067#discussion_r1996434862

Reply via email to