On Thu, 24 Oct 2024 14:55:57 GMT, Alexey Ivanov wrote:
>> Sean Mullan has updated the pull request with a new target base due to a
>> merge or a rebase. The pull request now contains 150 commits:
>>
>> - Merge remote-tracking branch 'jdk-sandbox/jep486' into JDK-8338411
>> - Merge
>> - Updat
> This is the main body of the JEP 450: Compact Object Headers (Experimental).
>
> It is also a follow-up to #20640, which now also includes (and supersedes)
> #20603 and #20605, plus the Tiny Class-Pointers parts that have been
> previously missing.
>
> Main changes:
> - Introduction of the (
On Wed, 23 Oct 2024 11:58:26 GMT, Alan Bateman wrote:
>> test/jdk/java/lang/invoke/RevealDirectTest.java line 33:
>>
>>> 31: * @test
>>> 32: * @summary verify Lookup.revealDirect on a variety of input handles,
>>> with security manager
>>> 33: * @run
>>> main/othervm/policy=jtreg.security.p
On Wed, 23 Oct 2024 02:56:30 GMT, Prasanta Sadhukhan
wrote:
>> Agreed. This is not a "clean up / update tests" task.
>> If it is a change on some lines of code that are updated by the SM changes,
>> then that's fair game, but otherwise only the SM behaviour is part of this
>> task.
>> Anything
On Fri, 25 Oct 2024 14:53:33 GMT, Magnus Ihse Bursie wrote:
> Can we trust the cache that much? I mean, up to now it's only been a
> performance hack, now it will become a necessary part of the pipeline.
Yeah, I guess that's the risk. I can redo this to use the same
upload/download-artifact we
On Thu, 24 Oct 2024 13:19:55 GMT, Sean Mullan wrote:
>> This is the implementation of JEP 486: Permanently Disable the Security
>> Manager. See [JEP 486](https://openjdk.org/jeps/486) for more details. The
>> [CSR](https://bugs.openjdk.org/browse/JDK-8338412) describes in detail the
>> main ch
> Please review this patch which adds a jlink mode to the JDK which doesn't
> need the packaged modules being present. A.k.a run-time image based jlink.
> Fundamentally this patch adds an option to use `jlink` even though your JDK
> install might not come with the packaged modules (directory `jm
> This is the implementation task for `JEP 490: ZGC: Remove the
> Non-Generational Mode`. See the JEP for details.
> [JDK-8335850](https://bugs.openjdk.org/browse/JDK-8335850)
Axel Boldt-Christmas has updated the pull request with a new target base due to
a merge or a rebase. The pull request n
On Tue, 22 Oct 2024 20:23:52 GMT, Roger Riggs wrote:
>> Sean Mullan has updated the pull request with a new target base due to a
>> merge or a rebase. The pull request now contains 97 commits:
>>
>> - Merge remote-tracking branch 'jdk-sandbox/jep486' into JDK-8338411
>> - Change apiNote to de
On Fri, 25 Oct 2024 15:16:30 GMT, Aleksey Shipilev wrote:
> > Can we trust the cache that much? I mean, up to now it's only been a
> > performance hack, now it will become a necessary part of the pipeline.
>
> Yeah, I guess that's the risk. I can redo this to use the same
> upload/download-art
On Thu, 24 Oct 2024 13:19:55 GMT, Sean Mullan wrote:
>> This is the implementation of JEP 486: Permanently Disable the Security
>> Manager. See [JEP 486](https://openjdk.org/jeps/486) for more details. The
>> [CSR](https://bugs.openjdk.org/browse/JDK-8338412) describes in detail the
>> main ch
On Fri, 25 Oct 2024 15:12:00 GMT, Alexey Ivanov wrote:
>> Sean Mullan has updated the pull request with a new target base due to a
>> merge or a rebase. The pull request now contains 150 commits:
>>
>> - Merge remote-tracking branch 'jdk-sandbox/jep486' into JDK-8338411
>> - Merge
>> - Updat
On Fri, 25 Oct 2024 15:29:40 GMT, Alexey Ivanov wrote:
>> test/jdk/javax/swing/UIDefaults/6622002/bug6622002.java line 1:
>>
>>> 1: /*
>>
>> Again, I'm unsure this test has a value after the security manager is
>> removed. All it verifies is that whatever reflection is used in
>> `UIDefaults.
> This is the main body of the JEP 450: Compact Object Headers (Experimental).
>
> It is also a follow-up to #20640, which now also includes (and supersedes)
> #20603 and #20605, plus the Tiny Class-Pointers parts that have been
> previously missing.
>
> Main changes:
> - Introduction of the (
On Thu, 24 Oct 2024 09:28:13 GMT, Amit Kumar wrote:
>>> But then, what exactly is the error? If it's just the test assuming that
>>> cache line size is log 6, then the test should be fixed for ppc, not
>>> hotspot.
>>
>> that is the problem, test assumes log2 of 6 for chacheline size
>
> PPC l
On Thu, 24 Oct 2024 20:23:26 GMT, Alexey Ivanov wrote:
>> @aivanov-jdk
>> It was missed when -Djava.security.manager=allow was removed.
>> Out of curiosity: does it have any impact on the performance of CI testing
>> if tests are run in `/othervm` mode when it is not needed?
>
>> It was missed
On Tue, 22 Oct 2024 14:55:47 GMT, Chen Liang wrote:
>> Context: https://mail.openjdk.org/pipermail/build-dev/2024-July/045586.html
>>
>> People were confused on a few details around fixing windows space names,
>> including:
>> 1. setshortname can report confusing error message when the director
> After 8339120, gcc began catching many different instances of unused code in
> the Windows specific codebase. Some of these seem to be bugs. I've taken the
> effort to mark out all the relevant globals and locals that trigger the
> unused warnings and addressed all of them by commenting out th
On Fri, 25 Oct 2024 04:47:19 GMT, Julian Waters wrote:
>> make/autoconf/flags-cflags.m4 line 589:
>>
>>> 587: # CXXFLAGS C++ language level for all of JDK, including Hotspot.
>>> 588: if test "x$TOOLCHAIN_TYPE" = xgcc || test "x$TOOLCHAIN_TYPE" =
>>> xclang; then
>>> 589: LANGSTD_CXXFLA
On Thu, 24 Oct 2024 13:19:55 GMT, Sean Mullan wrote:
>> This is the implementation of JEP 486: Permanently Disable the Security
>> Manager. See [JEP 486](https://openjdk.org/jeps/486) for more details. The
>> [CSR](https://bugs.openjdk.org/browse/JDK-8338412) describes in detail the
>> main ch
On Thu, 24 Oct 2024 13:19:55 GMT, Sean Mullan wrote:
>> This is the implementation of JEP 486: Permanently Disable the Security
>> Manager. See [JEP 486](https://openjdk.org/jeps/486) for more details. The
>> [CSR](https://bugs.openjdk.org/browse/JDK-8338412) describes in detail the
>> main ch
On Thu, 24 Oct 2024 21:06:23 GMT, Harshitha Onkar wrote:
>>> It was missed when `-Djava.security.manager=allow` was removed.
>>
>> It wasn't intentional then, was it?
>>
>>> Out of curiosity: does it have any impact on the performance of CI testing
>>> if tests are run in /othervm mode when it
On Thu, 24 Oct 2024 18:58:41 GMT, Aleksey Shipilev wrote:
> It is visible in current GHA runs that building jtreg sometimes break on
> dependencies checkout, for example:
>
>
> [build.sh][INFO] CYGWIN_OR_MSYS=0
> [build.sh][INFO] JAVA_HOME: /usr/lib/jvm/temurin-17-jdk-amd64
> [build.sh][INFO]
On Fri, 25 Oct 2024 22:20:00 GMT, Vladimir Ivanov wrote:
>>> Because lowering is a transformation that increases the complexity of the
>>> graph.
>>>
>>> * A `d = ExtractD(z, 4)` expanded into `x = VectorExtract(z, 2); d =
>>> ExtractD(x, 0)` increases the number of nodes by 1.
>>> * A logic
On Fri, 25 Oct 2024 23:30:52 GMT, Vladimir Ivanov wrote:
>> Thanks for looking at the build changes, @magicus! I've pushed a commit that
>> removes the extra newline in the makefiles and adds newlines to the ends of
>> files that were missing them.
>>
>> Thanks for taking a look as well, @mery
On Fri, 25 Oct 2024 17:30:56 GMT, Harshitha Onkar wrote:
>> test/jdk/javax/swing/JPopupMenu/6694823/bug6694823.java line 41:
>>
>>> 39: * @bug 6694823
>>> 40: * @summary Checks that popup menu cannot be partially hidden
>>> 41: * by the task bar.
>>
>> I believe this test is irrelev
On Thu, 24 Oct 2024 13:19:55 GMT, Sean Mullan wrote:
>> This is the implementation of JEP 486: Permanently Disable the Security
>> Manager. See [JEP 486](https://openjdk.org/jeps/486) for more details. The
>> [CSR](https://bugs.openjdk.org/browse/JDK-8338412) describes in detail the
>> main ch
On Fri, 25 Oct 2024 18:08:16 GMT, Alexey Ivanov wrote:
>> Sean Mullan has updated the pull request with a new target base due to a
>> merge or a rebase. The pull request now contains 150 commits:
>>
>> - Merge remote-tracking branch 'jdk-sandbox/jep486' into JDK-8338411
>> - Merge
>> - Updat
On Fri, 25 Oct 2024 19:44:54 GMT, Weijun Wang wrote:
> Comments on `java.security` classes.
>
> Also, I'd like to see some clarifications on what "the installed policy" or
> "the current policy" is. The `ProtectionDomain` mentions this when talking
> about dynamic permissions. On the other han
On Thu, 24 Oct 2024 13:19:55 GMT, Sean Mullan wrote:
>> This is the implementation of JEP 486: Permanently Disable the Security
>> Manager. See [JEP 486](https://openjdk.org/jeps/486) for more details. The
>> [CSR](https://bugs.openjdk.org/browse/JDK-8338412) describes in detail the
>> main ch
On Fri, 25 Oct 2024 16:47:31 GMT, Alexey Ivanov wrote:
>> This doubt applies to all the tests which exercise lazy values or similar
>> logic… without and *with* the security manager.
>>
>> Now, without the security manager, the problematic cases are no longer
>> relevant; the common path *with
On Fri, 25 Oct 2024 21:23:26 GMT, Harshitha Onkar wrote:
>> The tests with “Audit Core Reflection” in their summary fall into this
>> category, we may consider removing them.
>
> @prrace Can you please advice on “Audit Core Reflection” category of tests.
> I'm not 100% sure if these tests need
On Thu, 24 Oct 2024 02:05:58 GMT, Jatin Bhateja wrote:
>> Another reason is that lowering being done late allows us to have more
>> freedom to break some invariants of the nodes, such as looking through
>> `VectorReinterpret`. An example is this (really crafted) case:
>>
>> Int256Vector v;
On Fri, 25 Oct 2024 21:09:19 GMT, Harshitha Onkar wrote:
>> test/jdk/javax/sound/midi/Soundbanks/GetSoundBankSecurityException/GetSoundBankSecurityException.java
>> line 1:
>>
>>> 1: /*
>>
>> I believe this test becomes irrelevant without `SecurityManager`.
>>
>> The summary of the test state
On Fri, 25 Oct 2024 08:25:21 GMT, Axel Boldt-Christmas
wrote:
>> This is the implementation task for `JEP 490: ZGC: Remove the
>> Non-Generational Mode`. See the JEP for details.
>> [JDK-8335850](https://bugs.openjdk.org/browse/JDK-8335850)
>
> Axel Boldt-Christmas has updated the pull request
It is visible in current GHA runs that building jtreg in all worker at once
sometimes break on dependencies checkout, for example:
[build.sh][INFO] CYGWIN_OR_MSYS=0
[build.sh][INFO] JAVA_HOME: /usr/lib/jvm/temurin-17-jdk-amd64
[build.sh][INFO] Downloading
https://archive.apache.org/dist/ant/bin
On Fri, 25 Oct 2024 08:25:21 GMT, Axel Boldt-Christmas
wrote:
>> This is the implementation task for `JEP 490: ZGC: Remove the
>> Non-Generational Mode`. See the JEP for details.
>> [JDK-8335850](https://bugs.openjdk.org/browse/JDK-8335850)
>
> Axel Boldt-Christmas has updated the pull request
On Fri, 25 Oct 2024 10:11:57 GMT, Magnus Ihse Bursie wrote:
>> It's a checkout error from the original gigantic Pull Request, sorry. I
>> don't plan to raise the JDK to C++17 in this one. But I'm not sure what to
>> do with this now, since maybe_unused is C++17. I don't think anyone is going
>
On Fri, 25 Oct 2024 17:52:59 GMT, Alexey Ivanov wrote:
>> This particular test was failing on windows & linux after SM removal. There
>> is a functional issue and for that reason I think it is better to retain
>> this test. Details documented here -
>> [JDK-8342012](https://bugs.openjdk.org/br
On Fri, 25 Oct 2024 14:57:18 GMT, Alexey Ivanov wrote:
>> Sean Mullan has updated the pull request with a new target base due to a
>> merge or a rebase. The pull request now contains 150 commits:
>>
>> - Merge remote-tracking branch 'jdk-sandbox/jep486' into JDK-8338411
>> - Merge
>> - Updat
On Thu, 24 Oct 2024 13:19:55 GMT, Sean Mullan wrote:
>> This is the implementation of JEP 486: Permanently Disable the Security
>> Manager. See [JEP 486](https://openjdk.org/jeps/486) for more details. The
>> [CSR](https://bugs.openjdk.org/browse/JDK-8338412) describes in detail the
>> main ch
> It is visible in current GHA runs that building jtreg sometimes break on
> dependencies checkout, for example:
>
>
> [build.sh][INFO] CYGWIN_OR_MSYS=0
> [build.sh][INFO] JAVA_HOME: /usr/lib/jvm/temurin-17-jdk-amd64
> [build.sh][INFO] Downloading
> https://archive.apache.org/dist/ant/binaries/
On Thu, 24 Oct 2024 18:58:41 GMT, Aleksey Shipilev wrote:
> It is visible in current GHA runs that building jtreg sometimes break on
> dependencies checkout, for example:
>
>
> [build.sh][INFO] CYGWIN_OR_MSYS=0
> [build.sh][INFO] JAVA_HOME: /usr/lib/jvm/temurin-17-jdk-amd64
> [build.sh][INFO]
On Fri, 25 Oct 2024 16:29:52 GMT, Severin Gehwolf wrote:
>> Please review this patch which adds a jlink mode to the JDK which doesn't
>> need the packaged modules being present. A.k.a run-time image based jlink.
>> Fundamentally this patch adds an option to use `jlink` even though your JDK
>>
On Fri, 25 Oct 2024 18:30:23 GMT, Harshitha Onkar wrote:
>> The updated test `bug6694823.java` works correctly on Windows and displays
>> its popup over the Windows taskbar — it is expected.
>>
>> The popup had to be moved if the security manager didn't allow to call
>> `setAlwaysOnTop(true)`.
On Fri, 25 Oct 2024 16:29:52 GMT, Severin Gehwolf wrote:
>> Please review this patch which adds a jlink mode to the JDK which doesn't
>> need the packaged modules being present. A.k.a run-time image based jlink.
>> Fundamentally this patch adds an option to use `jlink` even though your JDK
>>
On Thu, 24 Oct 2024 02:14:46 GMT, Jasmine Karthikeyan
wrote:
>> Build changes look good (but would be slightly better without the extra
>> blank line). I have not reviewed the actual hotspot changes.
>
> Thanks for looking at the build changes, @magicus! I've pushed a commit that
> removes the
On Fri, 25 Oct 2024 21:14:25 GMT, Sean Mullan wrote:
>> src/java.base/share/classes/java/security/SecureClassLoader.java line 1:
>>
>>> 1: /*
>>
>> The class spec still mentions "permissions which are retrieved by the system
>> policy by default". Shall we remove it? Also, `getPermissions` alw
On Fri, 25 Oct 2024 20:53:23 GMT, Sean Mullan wrote:
>> src/java.base/share/classes/java/security/AccessControlContext.java line 141:
>>
>>> 139: throws AccessControlException
>>> 140: {
>>> 141: throw new AccessControlException("");
>>
>> No message for this exception?
>
>
On Fri, 25 Oct 2024 14:36:46 GMT, Alexey Ivanov wrote:
>> Sean Mullan has updated the pull request with a new target base due to a
>> merge or a rebase. The pull request now contains 150 commits:
>>
>> - Merge remote-tracking branch 'jdk-sandbox/jep486' into JDK-8338411
>> - Merge
>> - Updat
On Thu, 24 Oct 2024 13:19:55 GMT, Sean Mullan wrote:
>> This is the implementation of JEP 486: Permanently Disable the Security
>> Manager. See [JEP 486](https://openjdk.org/jeps/486) for more details. The
>> [CSR](https://bugs.openjdk.org/browse/JDK-8338412) describes in detail the
>> main ch
On Fri, 25 Oct 2024 21:06:28 GMT, Harshitha Onkar wrote:
>> test/jdk/javax/imageio/spi/AppletContextTest/IIOPluginTest.java line 42:
>>
>>> 40: } catch (ServiceConfigurationError sce) {
>>> 41: System.out.println("Expected ServiceConfigurationError \n"
>>> + sce);
>>> 42:
52 matches
Mail list logo
