On Fri, 25 Oct 2024 14:36:46 GMT, Alexey Ivanov <aiva...@openjdk.org> wrote:
>> Sean Mullan has updated the pull request with a new target base due to a >> merge or a rebase. The pull request now contains 150 commits: >> >> - Merge remote-tracking branch 'jdk-sandbox/jep486' into JDK-8338411 >> - Merge >> - Update @summary to replace "if the right permission is granted" can be >> replaced with "package java.lang is open to unnamed module". >> - Remove println about Security Manager. >> - Remove unused static variable NEW_PROXY_IN_PKG. >> - Remove static variable `DEFAULT_POLICY` and unused imports. >> - Remove hasSM() method and code that calls it, and remove comment about >> running test manually with SM. >> - clientlibs: import order >> - warning-string >> - java/net/httpclient/websocket/security/WSURLPermissionTest.java: >> integrated review feedback in renamed WSSanityTest.java >> - ... and 140 more: https://git.openjdk.org/jdk/compare/f7a61fce...cb50dfde > > test/jdk/javax/swing/JPopupMenu/6691503/bug6691503.java line 1: > >> 1: /* > > I think we can delete this test. It verifies that popup menus are displayed > in a windows `isAlwaysOnTop() == true` in stand-alone apps whereas for > applets `isAlwaysOnTop() == false`. > > If there's no such distinction, the test tests nothing but the fact that > popup menus are displayed in always-on-top windows. > > The updated test does not test anything for > [JDK-6691503](https://bugs.openjdk.org/browse/JDK-6691503) and its changeset > https://github.com/openjdk/jdk/commit/8dff6c648be296799e4a7e0e1964d339acc0d724. This test was initially deleted but then restored based on the following comment - https://github.com/openjdk/jdk/pull/21498#discussion_r1810297085 Since this test falls under similar category as test/jdk/javax/swing/JPopupMenu/6691503/bug6691503.java and based on your suggestion, I think we can delete it if it doesn't hold value after SM removal. ------------- PR Review Comment: https://git.openjdk.org/jdk/pull/21498#discussion_r1817311600
